aidp 0.17.0 → 0.18.0

data/lib/aidp/watch/repository_client.rb

@@ -11,6 +11,16 @@ module Aidp
     # (works for private repositories) and falls back to public REST endpoints
     # when the CLI is unavailable.
     class RepositoryClient
+      # Binary availability checker for testing
+      class BinaryChecker
+        def gh_cli_available?
+          _stdout, _stderr, status = Open3.capture3("gh", "--version")
+          status.success?
+        rescue Errno::ENOENT
+          false
+        end
+      end
+
       attr_reader :owner, :repo
 
       def self.parse_issues_url(issues_url)
@@ -24,10 +34,11 @@ module Aidp
         end
       end
 
-      def initialize(owner:, repo:, gh_available: nil)
+      def initialize(owner:, repo:, gh_available: nil, binary_checker: BinaryChecker.new)
         @owner = owner
         @repo = repo
-        @gh_available = gh_available.nil? ? gh_cli_available? : gh_available
+        @binary_checker = binary_checker
+        @gh_available = gh_available.nil? ? @binary_checker.gh_cli_available? : gh_available
       end
 
       def gh_available?
@@ -56,13 +67,6 @@ module Aidp
 
       private
 
-      def gh_cli_available?
-        _stdout, _stderr, status = Open3.capture3("gh", "--version")
-        status.success?
-      rescue Errno::ENOENT
-        false
-      end
-
       def list_issues_via_gh(labels:, state:)
         json_fields = %w[number title labels updatedAt state url assignees]
         cmd = ["gh", "issue", "list", "--repo", full_repo, "--state", state, "--json", json_fields.join(",")]
@@ -158,7 +162,7 @@ module Aidp
         response.body
       end
 
-      def create_pull_request_via_gh(title:, body:, head:, base:, issue_number:)
+      def create_pull_request_via_gh(title:, body:, head:, base:, issue_number:, draft: false)
         cmd = [
           "gh", "pr", "create",
           "--repo", full_repo,
@@ -168,6 +172,7 @@ module Aidp
           "--base", base
         ]
         cmd += ["--issue", issue_number.to_s] if issue_number
+        cmd += ["--draft"] if draft
 
         stdout, stderr, status = Open3.capture3(*cmd)
         raise "Failed to create PR via gh: #{stderr.strip}" unless status.success?

data/lib/aidp/workflows/guided_agent.rb

@@ -201,79 +201,10 @@ module Aidp
         goal
       end
 
-      def analyze_user_intent(user_goal)
-        display_message("\n🔍 Analyzing your request...", type: :info)
-
-        # Build the system prompt with AIDP capabilities
-        system_prompt = build_system_prompt
-
-        # Build the user prompt
-        user_prompt = build_analysis_prompt(user_goal)
-
-        # Call provider to analyze intent
-        response = call_provider_for_analysis(system_prompt, user_prompt)
-
-        # Parse the response
-        parse_recommendation(response)
-      end
-
-      def build_system_prompt
-        # Try to load from project dir first, fall back to gem's docs
-        capabilities_path = File.join(@project_dir, "docs", "AIDP_CAPABILITIES.md")
-        unless File.exist?(capabilities_path)
-          # Use the gem's copy
-          gem_root = File.expand_path("../../..", __dir__)
-          capabilities_path = File.join(gem_root, "docs", "AIDP_CAPABILITIES.md")
-        end
-
-        capabilities_doc = File.read(capabilities_path)
-
-        <<~PROMPT
-          You are an expert AI assistant helping users select the right AIDP workflow for their needs.
-
-          Your role:
-          1. Understand what the user wants to accomplish
-          2. Match their intent to AIDP's capabilities
-          3. Recommend the most appropriate workflow
-          4. Explain why this workflow fits their needs
-          5. Identify if custom steps or templates are needed
-
-          AIDP Capabilities Reference:
-          #{capabilities_doc}
-
-          Response Format:
-          Provide a JSON response with:
-          {
-            "mode": "analyze|execute|hybrid",
-            "workflow_key": "specific_workflow_key",
-            "reasoning": "brief explanation of why this fits",
-            "additional_steps": ["any", "custom", "steps", "if", "needed"],
-            "questions": ["any", "clarifying", "questions"],
-            "confidence": "high|medium|low"
-          }
-
-          Be concise to preserve the user's context window.
-        PROMPT
-      end
-
-      def build_analysis_prompt(user_goal)
-        <<~PROMPT
-          User Goal: #{user_goal}
-
-          Analyze this goal and recommend the most appropriate AIDP workflow.
-          Consider:
-          - Is this analysis or development?
-          - What level of rigor is needed?
-          - Are there any gaps in existing workflows?
-
-          Provide your recommendation in JSON format.
-        PROMPT
-      end
-
       def call_provider_for_analysis(system_prompt, user_prompt)
         attempts = 0
         max_attempts = (@provider_manager.respond_to?(:configured_providers) ? @provider_manager.configured_providers.size : 2)
-        max_attempts = 2 if max_attempts < 2 # at least one retry if a fallback exists
+        max_attempts = 2 if max_attempts < 2
 
         begin
           attempts += 1
@@ -283,7 +214,6 @@ module Aidp
             raise ConversationError, "No provider configured for guided workflow"
           end
 
-          # Create provider instance using ProviderFactory
           provider_factory = Aidp::Harness::ProviderFactory.new(@config_manager)
           provider = provider_factory.create_provider(provider_name, prompt: @prompt)
 
@@ -292,7 +222,7 @@ module Aidp
           end
 
           combined_prompt = "#{system_prompt}\n\n#{user_prompt}"
-          result = provider.send(prompt: combined_prompt)
+          result = provider.send_message(prompt: combined_prompt)
 
           if result.nil? || result.empty?
             raise ConversationError, "Provider request failed: empty response"
@@ -319,20 +249,6 @@ module Aidp
         end
       end
 
-      def parse_recommendation(response_text)
-        # Extract JSON from response (might be wrapped in markdown code blocks)
-        json_match = response_text.match(/```json\s*(\{.*?\})\s*```/m) ||
-          response_text.match(/(\{.*\})/m)
-
-        unless json_match
-          raise ConversationError, "Could not parse recommendation from response"
-        end
-
-        JSON.parse(json_match[1], symbolize_names: true)
-      rescue JSON::ParserError => e
-        raise ConversationError, "Invalid JSON in recommendation: #{e.message}"
-      end
-
       def validate_provider_configuration!
         configured = @provider_manager.configured_providers
         if configured.nil? || configured.empty?
@@ -349,232 +265,6 @@ module Aidp
         end
       end
 
-      def present_recommendation(recommendation)
-        display_message("\n✨ Recommendation", type: :highlight)
-        display_message("─" * 60, type: :muted)
-
-        mode = recommendation[:mode].to_sym
-        workflow_key = recommendation[:workflow_key].to_sym
-
-        # Get workflow details
-        workflow = Definitions.get_workflow(mode, workflow_key)
-
-        unless workflow
-          # Handle custom workflow or error
-          return handle_custom_workflow(recommendation)
-        end
-
-        # Display the recommendation
-        display_message("Mode: #{mode.to_s.capitalize}", type: :info)
-        display_message("Workflow: #{workflow[:name]}", type: :info)
-        display_message("\n#{workflow[:description]}", type: :muted)
-        display_message("\nReasoning: #{recommendation[:reasoning]}\n", type: :info)
-
-        # Show what's included
-        display_message("This workflow includes:", type: :highlight)
-        workflow[:details].each do |detail|
-          display_message("  • #{detail}", type: :info)
-        end
-
-        # Handle additional steps if needed
-        steps = workflow[:steps]
-        if recommendation[:additional_steps]&.any?
-          display_message("\nAdditional custom steps recommended:", type: :highlight)
-          recommendation[:additional_steps].each do |step|
-            display_message("  • #{step}", type: :info)
-          end
-          steps = workflow[:steps] + recommendation[:additional_steps]
-        end
-
-        # Ask for confirmation
-        display_message("")
-        confirmed = @prompt.yes?("Does this workflow fit your needs?")
-
-        if confirmed
-          {
-            mode: mode,
-            workflow_key: workflow_key,
-            workflow_type: workflow_key,
-            steps: steps,
-            user_input: @user_input,
-            workflow: workflow
-          }
-        else
-          # Offer alternatives
-          offer_alternatives(mode)
-        end
-      end
-
-      def handle_custom_workflow(recommendation)
-        display_message("\n💡 Custom Workflow Needed", type: :highlight)
-        display_message("The AI recommends creating a custom workflow:\n", type: :info)
-        display_message(recommendation[:reasoning], type: :muted)
-
-        if recommendation[:questions]&.any?
-          display_message("\nLet me gather some more information:\n", type: :highlight)
-          recommendation[:questions].each do |question|
-            answer = @prompt.ask(question)
-            @user_input[question.downcase.gsub(/\s+/, "_").to_sym] = answer
-          end
-        end
-
-        # Let user select from available steps
-        mode = recommendation[:mode].to_sym
-        display_message("\nLet's build a custom workflow by selecting specific steps:", type: :info)
-
-        steps = select_custom_steps(mode, recommendation[:additional_steps])
-
-        {
-          mode: mode,
-          workflow_key: :custom,
-          workflow_type: :custom,
-          steps: steps,
-          user_input: @user_input,
-          workflow: {
-            name: "Custom Workflow",
-            description: recommendation[:reasoning],
-            details: steps
-          }
-        }
-      end
-
-      def select_custom_steps(mode, suggested_steps = [])
-        # Get available steps for the mode
-        spec = case mode
-        when :analyze
-          Aidp::Analyze::Steps::SPEC
-        when :execute
-          Aidp::Execute::Steps::SPEC
-        when :hybrid
-          # Combine both
-          Aidp::Analyze::Steps::SPEC.merge(Aidp::Execute::Steps::SPEC)
-        else
-          {}
-        end
-
-        step_choices = spec.map do |step_key, step_spec|
-          {
-            name: "#{step_key} - #{step_spec["description"]}",
-            value: step_key
-          }
-        end
-
-        # Pre-select suggested steps
-        default_indices = suggested_steps.map do |step|
-          step_choices.index { |choice| choice[:value].to_s == step.to_s }
-        end.compact
-
-        selected_steps = @prompt.multi_select(
-          "Select steps for your custom workflow:",
-          step_choices,
-          default: default_indices,
-          per_page: 20
-        )
-
-        selected_steps.empty? ? suggested_steps : selected_steps
-      end
-
-      def offer_alternatives(current_mode)
-        display_message("\n🔄 Let's find a better fit", type: :highlight)
-
-        choices = [
-          {name: "Try a different #{current_mode} workflow", value: :different_workflow},
-          {name: "Switch to a different mode", value: :different_mode},
-          {name: "Build a custom workflow", value: :custom},
-          {name: "Start over", value: :restart}
-        ]
-
-        choice = @prompt.select("What would you like to do?", choices)
-
-        case choice
-        when :different_workflow
-          select_manual_workflow(current_mode)
-        when :different_mode
-          # Let user pick mode manually then workflow
-          new_mode = @prompt.select(
-            "Select mode:",
-            {
-              "🔬 Analyze Mode" => :analyze,
-              "🏗️  Execute Mode" => :execute,
-              "🔀 Hybrid Mode" => :hybrid
-            }
-          )
-          select_manual_workflow(new_mode)
-        when :custom
-          select_custom_steps(current_mode)
-        when :restart
-          select_workflow # Recursive call to start over
-        end
-      end
-
-      def select_manual_workflow(mode)
-        workflows = Definitions.workflows_for_mode(mode)
-
-        choices = workflows.map do |key, workflow|
-          {
-            name: "#{workflow[:icon]} #{workflow[:name]} - #{workflow[:description]}",
-            value: key
-          }
-        end
-
-        selected_key = @prompt.select("Choose a workflow:", choices, per_page: 15)
-        workflow = workflows[selected_key]
-
-        {
-          mode: mode,
-          workflow_key: selected_key,
-          workflow_type: selected_key,
-          steps: workflow[:steps],
-          user_input: @user_input,
-          workflow: workflow
-        }
-      end
-
-      def collect_workflow_details(workflow_selection)
-        # Collect additional information based on mode
-        case workflow_selection[:mode]
-        when :execute
-          collect_execute_details
-        when :analyze
-          # Analyze mode typically doesn't need much user input
-          @user_input[:analysis_goal] = @user_input[:original_goal]
-        when :hybrid
-          collect_execute_details # Hybrid often needs project details
-        end
-
-        # Update the workflow selection with collected input
-        workflow_selection[:user_input] = @user_input
-      end
-
-      def collect_execute_details
-        return if @user_input[:project_description] # Already collected
-
-        display_message("\n📝 Project Information", type: :highlight)
-        display_message("Let me gather some details for the PRD:\n", type: :info)
-
-        @user_input[:project_description] = @prompt.ask(
-          "Describe what you're building (can reference your original goal):",
-          default: @user_input[:original_goal]
-        )
-
-        @user_input[:tech_stack] = @prompt.ask(
-          "Tech stack (e.g., Ruby/Rails, Node.js, Python)? [optional]",
-          required: false
-        )
-
-        @user_input[:target_users] = @prompt.ask(
-          "Who will use this? [optional]",
-          required: false
-        )
-
-        @user_input[:success_criteria] = @prompt.ask(
-          "How will you measure success? [optional]",
-          required: false
-        )
-      end
-
-      # Plan-then-execute helper methods
-
       def build_planning_system_prompt
         <<~PROMPT
           You are a planning assistant helping gather requirements through clarifying questions.

data/lib/aidp/workstream_executor.rb

@@ -25,11 +25,17 @@ module Aidp
       keyword_init: true
     )
 
-    def initialize(project_dir: Dir.pwd, max_concurrent: 3)
+    # @param project_dir [String] root directory of the project
+    # @param max_concurrent [Integer] maximum number of concurrent workstreams (thread pool size)
+    # @param runner_factory [Proc] factory that builds a harness runner. Signature: (path, mode, options) => object responding to #run
+    def initialize(project_dir: Dir.pwd, max_concurrent: 3, runner_factory: nil)
       @project_dir = project_dir
       @max_concurrent = max_concurrent
       @results = Concurrent::Hash.new
       @start_times = Concurrent::Hash.new
+      @runner_factory = runner_factory || lambda do |path, mode, options|
+        Aidp::Harness::Runner.new(path, mode, options)
+      end
     end
 
     # Execute multiple workstreams in parallel
@@ -120,7 +126,7 @@ module Aidp
         Dir.chdir(workstream[:path])
 
         # Execute harness
-        runner = Aidp::Harness::Runner.new(
+        runner = @runner_factory.call(
           workstream[:path],
           options[:mode] || :execute,
           options

data/lib/aidp.rb

@@ -25,7 +25,6 @@ require_relative "aidp/providers/base"
 require_relative "aidp/providers/cursor"
 require_relative "aidp/providers/anthropic"
 require_relative "aidp/providers/gemini"
-require_relative "aidp/providers/macos_ui"
 # Supervised providers removed - using direct execution model
 require_relative "aidp/provider_manager"
 

data/templates/aidp.yml.example

@@ -123,6 +123,93 @@ harness:
     api_key_rotation: false   # Enable API key rotation
     audit_logging: true       # Enable audit logging
 
+# Thinking Depth Configuration
+# Controls model selection based on task complexity
+thinking:
+  # Default tier for new requests (mini, standard, thinking, pro, max)
+  default_tier: "mini"
+
+  # Maximum tier allowed (prevents excessive costs)
+  max_tier: "max"
+
+  # Enable automatic tier escalation on failures
+  auto_escalate: true
+
+  # Number of failures before escalating to next tier
+  escalation_threshold: 2
+
+  # Per-operation tier overrides (optional)
+  overrides:
+    # Example: Use mini tier for simple decisions
+    # decision.condition_detection: mini
+    # decision.error_classification: mini
+    # decision.completion_detection: mini
+
+# Zero Framework Cognition (ZFC) Configuration
+# Delegates semantic analysis to AI instead of pattern matching
+zfc:
+  # Master toggle for ZFC features
+  enabled: false  # Set to true to enable (experimental)
+
+  # Fallback to legacy pattern matching if AI fails
+  fallback_to_legacy: true
+
+  # Individual decision types (can be toggled separately)
+  decisions:
+    # Condition detection (replaces regex patterns)
+    condition_detection:
+      enabled: false
+      tier: "mini"              # AI tier to use
+      cache_ttl: null           # Cache duration in seconds (null = no cache)
+      confidence_threshold: 0.7 # Minimum confidence to accept result
+
+    # Error classification (determines if retryable)
+    error_classification:
+      enabled: false
+      tier: "mini"
+      cache_ttl: null
+      confidence_threshold: 0.7
+
+    # Completion detection (replaces keyword matching)
+    completion_detection:
+      enabled: false
+      tier: "mini"
+      cache_ttl: null
+      confidence_threshold: 0.8
+
+    # Provider selection (replaces load calculation formula)
+    provider_selection:
+      enabled: false
+      tier: "mini"
+      cache_ttl: 300            # Cache for 5 minutes
+      confidence_threshold: 0.7
+
+    # Tier escalation decision (replaces heuristic thresholds)
+    tier_escalation:
+      enabled: false
+      tier: "mini"
+      cache_ttl: null
+      confidence_threshold: 0.7
+
+    # Workflow routing (replaces pattern matching)
+    workflow_routing:
+      enabled: false
+      tier: "mini"
+      cache_ttl: 60             # Cache for 1 minute
+      confidence_threshold: 0.7
+
+  # Cost controls for ZFC
+  cost_limits:
+    max_daily_cost: 5.00        # Maximum daily ZFC cost in USD
+    max_cost_per_decision: 0.01 # Maximum cost per decision
+    alert_threshold: 0.8        # Alert at 80% of budget
+
+  # A/B testing configuration
+  ab_testing:
+    enabled: false              # Enable A/B testing
+    sample_rate: 0.1            # Test 10% of decisions
+    log_comparisons: true       # Log ZFC vs legacy comparisons
+
 # Provider configurations
 providers:
   # Cursor provider (subscription-based)
@@ -580,6 +667,47 @@ users:
       cursor:
         priority: 2
 
+# Devcontainer configuration (experimental)
+# Controls behavior when running inside a development container
+devcontainer:
+  # Enable automatic detection of devcontainer environment
+  enabled: true
+
+  # Run agents with full permissions when in devcontainer
+  # This allows more dangerous filesystem operations in the sandboxed environment
+  # Only applies when AIDP detects it's running in a container
+  full_permissions_when_in_devcontainer: false
+
+  # Override detection (useful for testing or forcing behavior)
+  # Set to true/false to force detection result, or null for auto-detection
+  force_detection: null
+
+  # Permissions to grant when in devcontainer
+  permissions:
+    # Allow dangerous filesystem operations
+    dangerous_filesystem_ops: false
+
+    # Skip permission checks for specific providers
+    # Provider-specific flags will be added automatically
+    skip_permission_checks:
+      - "claude"  # Adds --dangerously-skip-permissions for Claude Code
+      # - "cursor"
+      # - "gemini"
+
+  # Container-specific settings
+  settings:
+    # Increase timeouts in container (may be slower)
+    timeout_multiplier: 1.5
+
+    # Enable more verbose logging in devcontainer
+    verbose_logging: true
+
+    # Network allowlist (for firewall configuration)
+    # These will be added to init-firewall.sh if using AIDP's devcontainer
+    allowed_domains: []
+      # - "api.example.com"
+      # - "registry.example.com"
+
 # Configuration tips:
 # - Set max_tokens based on your API plan limits
 # - Use default_flags to customize provider behavior

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: aidp
 version: !ruby/object:Gem::Version
-  version: 0.17.0
+  version: 0.18.0
 platform: ruby
 authors:
 - Bart Agapinan
@@ -280,6 +280,8 @@ files:
 - lib/aidp/execute/work_loop_state.rb
 - lib/aidp/execute/work_loop_unit_scheduler.rb
 - lib/aidp/execute/workflow_selector.rb
+- lib/aidp/harness/ai_decision_engine.rb
+- lib/aidp/harness/capability_registry.rb
 - lib/aidp/harness/completion_checker.rb
 - lib/aidp/harness/condition_detector.rb
 - lib/aidp/harness/config_loader.rb
@@ -305,6 +307,7 @@ files:
 - lib/aidp/harness/state_manager.rb
 - lib/aidp/harness/status_display.rb
 - lib/aidp/harness/test_runner.rb
+- lib/aidp/harness/thinking_depth_manager.rb
 - lib/aidp/harness/ui/base.rb
 - lib/aidp/harness/ui/enhanced_tui.rb
 - lib/aidp/harness/ui/enhanced_workflow_selector.rb
@@ -325,13 +328,22 @@ files:
 - lib/aidp/harness/ui/status_widget.rb
 - lib/aidp/harness/ui/workflow_controller.rb
 - lib/aidp/harness/user_interface.rb
+- lib/aidp/harness/zfc_condition_detector.rb
 - lib/aidp/init.rb
+- lib/aidp/init/devcontainer_generator.rb
 - lib/aidp/init/doc_generator.rb
 - lib/aidp/init/project_analyzer.rb
 - lib/aidp/init/runner.rb
 - lib/aidp/jobs/background_runner.rb
 - lib/aidp/logger.rb
 - lib/aidp/message_display.rb
+- lib/aidp/prompt_optimization/context_composer.rb
+- lib/aidp/prompt_optimization/optimizer.rb
+- lib/aidp/prompt_optimization/prompt_builder.rb
+- lib/aidp/prompt_optimization/relevance_scorer.rb
+- lib/aidp/prompt_optimization/source_code_fragmenter.rb
+- lib/aidp/prompt_optimization/style_guide_indexer.rb
+- lib/aidp/prompt_optimization/template_indexer.rb
 - lib/aidp/provider_manager.rb
 - lib/aidp/providers/anthropic.rb
 - lib/aidp/providers/base.rb
@@ -339,7 +351,6 @@ files:
 - lib/aidp/providers/cursor.rb
 - lib/aidp/providers/gemini.rb
 - lib/aidp/providers/github_copilot.rb
-- lib/aidp/providers/macos_ui.rb
 - lib/aidp/providers/opencode.rb
 - lib/aidp/rescue_logging.rb
 - lib/aidp/setup/wizard.rb
@@ -360,6 +371,7 @@ files:
 - lib/aidp/storage/json_storage.rb
 - lib/aidp/tooling_detector.rb
 - lib/aidp/util.rb
+- lib/aidp/utils/devcontainer_detector.rb
 - lib/aidp/version.rb
 - lib/aidp/watch.rb
 - lib/aidp/watch/build_processor.rb