aidp 0.17.0 → 0.17.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 84451cdcc0886f1a70e799ab53d9b8898633f324cdd80c5f07a5f204848a3de2
-  data.tar.gz: e93982382c700564db24fac6ff1de2276e5b0301b91f6cade19aa8dfacd3f7d3
+  metadata.gz: 949670fdea4721406643f4fd8da096e943740effbd836407311b812350919b14
+  data.tar.gz: 8034a3c798571e4626b273c4a9abe9a5da38cef5dd4f25de8794a0ef63bf6022
 SHA512:
-  metadata.gz: 3de783cb25c3eedc9056f77c2b294918a2f5ab46c009280897b6094dd157c45c681fc5c8fe22c6eea401ba74e0c4151c132a85e3c8ceedfef7722e9580f96f43
-  data.tar.gz: de86c77e08a8f9b837d501d8e69786b6f969c0e2a1538f1a9d2062267f01d6e8c855f0885c31d0bdc3f2c9362fa78439fccdcfe5e09a12cd1ab61282365cdc4a
+  metadata.gz: cdabc6ba04d06a89dbc4ad19b27a64862e960daa350029db4fada5a4f6d32d3fba27cb32dda291871a79ad8f319d27e7dd1348ddcb7fdb8b0f0a1390b9493fc1
+  data.tar.gz: 39c384f4c01bf00bef550ac9190d27ddd268437be92fc4cdfcdeac3dff09c79c055b2e5b5582e553af6fa838b3f904cce354e9db62ee3638f658eec05673e4f5

data/lib/aidp/analyze/kb_inspector.rb

@@ -80,7 +80,7 @@ module Aidp
         display_message(box)
       end
 
-      def load_kb_data
+      def load_kb_data(suppress_parse_warnings: false)
         data = {}
 
         %w[symbols imports calls metrics seams hotspots tests cycles].each do |type|
@@ -89,8 +89,7 @@ module Aidp
             begin
               data[type.to_sym] = JSON.parse(File.read(file_path), symbolize_names: true)
             rescue JSON::ParserError => e
-              # Suppress warnings in test mode to avoid CI failures
-              unless ENV["RACK_ENV"] == "test" || defined?(RSpec)
+              unless suppress_parse_warnings
                 display_message("Warning: Could not parse #{file_path}: #{e.message}", type: :warn)
               end
               data[type.to_sym] = []

data/lib/aidp/analyze/progress.rb

@@ -9,9 +9,10 @@ module Aidp
     class Progress
       attr_reader :project_dir, :progress_file
 
-      def initialize(project_dir)
+      def initialize(project_dir, skip_persistence: false)
         @project_dir = project_dir
         @progress_file = File.join(project_dir, ".aidp", "progress", "analyze.yml")
+        @skip_persistence = skip_persistence
         load_progress
       end
 
@@ -60,26 +61,20 @@ module Aidp
       private
 
       def load_progress
-        # In test mode, only skip file operations if no progress file exists
-        if (ENV["RACK_ENV"] == "test" || defined?(RSpec)) && !File.exist?(@progress_file)
+        if @skip_persistence && !File.exist?(@progress_file)
           @progress = {}
           return
         end
-
-        @progress = if File.exist?(@progress_file)
+        @progress = if !@skip_persistence && File.exist?(@progress_file)
           YAML.safe_load_file(@progress_file, permitted_classes: [Date, Time, Symbol], aliases: true) || {}
         else
           {}
         end
-
-        # Ensure @progress is never nil
         @progress = {} if @progress.nil?
       end
 
       def save_progress
-        # In test mode, skip file operations to avoid hanging
-        return if ENV["RACK_ENV"] == "test" || defined?(RSpec)
-
+        return if @skip_persistence
         FileUtils.mkdir_p(File.dirname(@progress_file))
         File.write(@progress_file, @progress.to_yaml)
       end

data/lib/aidp/cli/mcp_dashboard.rb

@@ -102,7 +102,7 @@ module Aidp
 
         providers.each do |provider|
           provider_info = Aidp::Harness::ProviderInfo.new(provider, @root_dir)
-          info = provider_info.get_info
+          info = provider_info.info
 
           next unless info[:mcp_support]
 

data/lib/aidp/cli.rb

@@ -147,6 +147,10 @@ module Aidp
     class << self
       extend Aidp::MessageDisplay::ClassMethods
 
+      def create_prompt
+        ::TTY::Prompt.new
+      end
+
       def run(args = ARGV)
         # Handle subcommands first (status, jobs, kb, harness)
         return run_subcommand(args) if subcommand?(args)
@@ -173,7 +177,7 @@ module Aidp
 
         # Handle configuration setup
         # Create a prompt for the wizard
-        prompt = TTY::Prompt.new
+        prompt = create_prompt
 
         if options[:setup_config]
           # Force setup/reconfigure even if config exists
@@ -398,7 +402,7 @@ module Aidp
 
       def run_jobs_command(args = [])
         require_relative "cli/jobs_command"
-        jobs_cmd = Aidp::CLI::JobsCommand.new(prompt: TTY::Prompt.new)
+        jobs_cmd = Aidp::CLI::JobsCommand.new(prompt: create_prompt)
         subcommand = args.shift
         jobs_cmd.run(subcommand, args)
       end
@@ -504,21 +508,6 @@ module Aidp
         if step
           display_message("Running #{mode} step '#{step}' with enhanced TUI harness", type: :highlight)
           display_message("progress indicators", type: :info)
-          if step.start_with?("00_PRD") && (defined?(RSpec) || ENV["RSPEC_RUNNING"])
-            # Simulate questions & completion similar to TUI test mode
-            root = ENV["AIDP_ROOT"] || Dir.pwd
-            file = Dir.glob(File.join(root, "templates", (mode == :execute) ? "EXECUTE" : "ANALYZE", "00_PRD*.md")).first
-            if file && File.file?(file)
-              content = File.read(file)
-              questions_section = content.split(/## Questions/i)[1]
-              if questions_section
-                questions_section.lines.select { |l| l.strip.start_with?("-") }.each do |line|
-                  display_message(line.strip.sub(/^-\s*/, ""), type: :info)
-                end
-              end
-            end
-            display_message("PRD completed", type: :success)
-          end
           return
         end
         display_message("Starting enhanced TUI harness", type: :highlight)
@@ -601,7 +590,7 @@ module Aidp
         when "clear"
           force = args.include?("--force")
           unless force
-            prompt = TTY::Prompt.new
+            prompt = create_prompt
             confirm = prompt.yes?("Are you sure you want to clear all checkpoint data?")
             return unless confirm
           end
@@ -696,7 +685,7 @@ module Aidp
           end
         end
         config_manager = Aidp::Harness::ConfigManager.new(Dir.pwd)
-        pm = Aidp::Harness::ProviderManager.new(config_manager, prompt: TTY::Prompt.new)
+        pm = Aidp::Harness::ProviderManager.new(config_manager, prompt: create_prompt)
 
         # Use TTY::Spinner for progress indication
         require "tty-spinner"
@@ -738,7 +727,12 @@ module Aidp
           end
           tokens = (r[:total_tokens].to_i > 0) ? r[:total_tokens].to_s : "0"
           reason = r[:unhealthy_reason] || "-"
-          if no_color || !$stdout.tty?
+          is_tty = begin
+            $stdout.respond_to?(:tty?) && $stdout.tty?
+          rescue
+            false
+          end
+          if no_color || !is_tty
             [r[:provider], r[:status], (r[:available] ? "yes" : "no"), cb, rl, tokens, last_used, reason]
           else
             [
@@ -757,7 +751,7 @@ module Aidp
         table = TTY::Table.new header, table_rows
         display_message(table.render(:basic), type: :info)
       rescue => e
-        log_rescue(e, component: "cli", action: "display_provider_health", fallback: "error_message")
+        Aidp.logger.warn("cli", "Failed to display provider health", error_class: e.class.name, error_message: e.message)
         display_message("Failed to display provider health: #{e.message}", type: :error)
       end
 
@@ -777,7 +771,7 @@ module Aidp
         display_message("=" * 60, type: :muted)
 
         provider_info = Aidp::Harness::ProviderInfo.new(provider_name, Dir.pwd)
-        info = provider_info.get_info(force_refresh: force_refresh)
+        info = provider_info.info(force_refresh: force_refresh)
 
         if info.nil?
           display_message("No information available for provider: #{provider_name}", type: :error)
@@ -1044,7 +1038,7 @@ module Aidp
           return
         end
 
-        wizard = Aidp::Setup::Wizard.new(Dir.pwd, prompt: TTY::Prompt.new, dry_run: dry_run)
+        wizard = Aidp::Setup::Wizard.new(Dir.pwd, prompt: create_prompt, dry_run: dry_run)
         wizard.run
       end
 
@@ -1071,7 +1065,7 @@ module Aidp
         end
 
         require_relative "init/runner"
-        runner = Aidp::Init::Runner.new(Dir.pwd, prompt: TTY::Prompt.new, options: options)
+        runner = Aidp::Init::Runner.new(Dir.pwd, prompt: create_prompt, options: options)
         runner.run
       end
 
@@ -1127,7 +1121,7 @@ module Aidp
           project_dir: Dir.pwd,
           once: once,
           use_workstreams: use_workstreams,
-          prompt: TTY::Prompt.new
+          prompt: create_prompt
         )
         runner.start
       rescue ArgumentError => e
@@ -1244,7 +1238,7 @@ module Aidp
 
           # Confirm removal unless --force
           unless force
-            prompt = TTY::Prompt.new
+            prompt = create_prompt
             confirm = prompt.yes?("Remove workstream '#{slug}'?#{" (will also delete branch)" if delete_branch}")
             return unless confirm
           end
@@ -2124,7 +2118,7 @@ module Aidp
 
             # Confirm deletion
             require "tty-prompt"
-            prompt = TTY::Prompt.new
+            prompt = create_prompt
             confirmed = prompt.yes?("Delete skill '#{skill.name}' (#{skill_id})? This cannot be undone.")
 
             unless confirmed

data/lib/aidp/execute/progress.rb

@@ -9,9 +9,10 @@ module Aidp
     class Progress
       attr_reader :project_dir, :progress_file
 
-      def initialize(project_dir)
+      def initialize(project_dir, skip_persistence: false)
         @project_dir = project_dir
         @progress_file = File.join(project_dir, ".aidp", "progress", "execute.yml")
+        @skip_persistence = skip_persistence
         load_progress
       end
 
@@ -61,13 +62,11 @@ module Aidp
       private
 
       def load_progress
-        # In test mode, only skip file operations if no progress file exists
-        if (ENV["RACK_ENV"] == "test" || defined?(RSpec)) && !File.exist?(@progress_file)
+        if @skip_persistence && !File.exist?(@progress_file)
           @progress = {}
           return
         end
-
-        @progress = if File.exist?(@progress_file)
+        @progress = if !@skip_persistence && File.exist?(@progress_file)
           YAML.safe_load_file(@progress_file, permitted_classes: [Date, Time, Symbol], aliases: true) || {}
         else
           {}
@@ -75,9 +74,7 @@ module Aidp
       end
 
       def save_progress
-        # In test mode, skip file operations to avoid hanging
-        return if ENV["RACK_ENV"] == "test" || defined?(RSpec)
-
+        return if @skip_persistence
         FileUtils.mkdir_p(File.dirname(@progress_file))
         File.write(@progress_file, @progress.to_yaml)
       end

data/lib/aidp/harness/config_loader.rb

@@ -9,9 +9,9 @@ module Aidp
   module Harness
     # Enhanced configuration loader for harness
     class ConfigLoader
-      def initialize(project_dir = Dir.pwd)
+      def initialize(project_dir = Dir.pwd, validator: nil)
         @project_dir = project_dir
-        @validator = ConfigValidator.new(project_dir)
+        @validator = validator || ConfigValidator.new(project_dir)
         @config_cache = nil
         @last_loaded = nil
         @last_signature = nil # stores {mtime:, size:, hash:}

data/lib/aidp/harness/enhanced_runner.rb

@@ -22,10 +22,19 @@ module Aidp
         error: "error"
       }.freeze
 
-      def initialize(project_dir, mode = :analyze, options = {})
+      # Simple sleeper abstraction for test control
+      class Sleeper
+        def sleep(duration)
+          Kernel.sleep(duration)
+        end
+      end
+
+      def initialize(project_dir, mode = :analyze, options = {}, prompt: TTY::Prompt.new, sleeper: Sleeper.new)
         @project_dir = project_dir
         @mode = mode.to_sym
         @options = options
+        @prompt = prompt
+        @sleeper = sleeper
         @state = STATES[:idle]
         @start_time = nil
         @current_step = nil
@@ -50,7 +59,7 @@ module Aidp
         @configuration = Configuration.new(project_dir)
         @state_manager = StateManager.new(project_dir, @mode)
         @condition_detector = ConditionDetector.new
-        @provider_manager = ProviderManager.new(@configuration, prompt: TTY::Prompt.new)
+        @provider_manager = ProviderManager.new(@configuration, prompt: @prompt)
         @error_handler = ErrorHandler.new(@provider_manager, @configuration)
         @completion_checker = CompletionChecker.new(@project_dir, @workflow_type)
       end
@@ -240,7 +249,7 @@ module Aidp
         # Remove job after a delay to show completion
         # UI delay to let user see completion status before removal
         Thread.new do
-          sleep 2  # Acceptable for UI timing
+          @sleeper.sleep(2) # UI timing delay
           @tui.remove_job(step_job_id)
         end
 
@@ -349,9 +358,9 @@ module Aidp
       def get_mode_runner
         case @mode
         when :analyze
-          Aidp::Analyze::Runner.new(@project_dir, self, prompt: TTY::Prompt.new)
+          Aidp::Analyze::Runner.new(@project_dir, self, prompt: @prompt)
         when :execute
-          Aidp::Execute::Runner.new(@project_dir, self, prompt: TTY::Prompt.new)
+          Aidp::Execute::Runner.new(@project_dir, self, prompt: @prompt)
         else
           raise ArgumentError, "Unsupported mode: #{@mode}"
         end
@@ -376,7 +385,7 @@ module Aidp
       def handle_pause_condition
         case @state
         when STATES[:paused]
-          sleep(1)
+          @sleeper.sleep(1)
         when STATES[:waiting_for_user]
           # User interface handles this
           nil
@@ -503,7 +512,7 @@ module Aidp
         while Time.now < reset_time && @state == STATES[:waiting_for_rate_limit]
           remaining = reset_time - Time.now
           @tui.show_message("⏳ Rate limit reset in #{remaining.to_i} seconds", :info)
-          sleep(1)
+          @sleeper.sleep(1)
         end
       end
 

data/lib/aidp/harness/error_handler.rb

@@ -10,10 +10,19 @@ module Aidp
     class ErrorHandler
       include Aidp::DebugMixin
 
-      def initialize(provider_manager, configuration, metrics_manager = nil)
+      # Simple wrapper to allow dependency injection of sleep behavior in tests
+      class Sleeper
+        def sleep(seconds)
+          Kernel.sleep(seconds)
+        end
+      end
+
+      # @param sleeper [#sleep] object responding to sleep(seconds); injectable for tests
+      def initialize(provider_manager, configuration, metrics_manager = nil, sleeper: nil)
         @provider_manager = provider_manager
         @configuration = configuration
         @metrics_manager = metrics_manager
+        @sleeper = sleeper || Sleeper.new
         @retry_strategies = {}
         @retry_counts = {}
         @error_history = []
@@ -112,7 +121,7 @@ module Aidp
               if should_retry?(error_info, strategy)
                 delay = @backoff_calculator.calculate_delay(attempt, strategy[:backoff_strategy] || :exponential, 1, 10)
                 debug_log("🔁 Retry attempt #{attempt} for #{current_provider}", level: :info, data: {delay: delay, error_type: error_info[:error_type]})
-                sleep(delay) if delay > 0
+                @sleeper.sleep(delay) if delay > 0
                 retry
               end
             end
@@ -191,9 +200,7 @@ module Aidp
         )
 
         # Wait for backoff delay
-        if delay > 0
-          sleep(delay)
-        end
+        @sleeper.sleep(delay) if delay > 0
 
         # Execute the retry
         retry_result = execute_retry_attempt(error_info, strategy, context)

data/lib/aidp/harness/provider_manager.rb

@@ -12,9 +12,10 @@ module Aidp
       include Aidp::MessageDisplay
       include Aidp::RescueLogging
 
-      def initialize(configuration, prompt: TTY::Prompt.new)
+      def initialize(configuration, prompt: TTY::Prompt.new, binary_checker: Aidp::Util)
         @configuration = configuration
         @prompt = prompt
+        @binary_checker = binary_checker
         @current_provider = nil
         @current_model = nil
         @provider_history = []
@@ -1069,18 +1070,6 @@ module Aidp
       def provider_cli_available?(provider_name)
         normalized = normalize_provider_name(provider_name)
 
-        # Handle test environment overrides
-        if defined?(RSpec) || ENV["RSPEC_RUNNING"]
-          # Force claude to be missing for testing
-          if ENV["AIDP_FORCE_CLAUDE_MISSING"] == "1" && normalized == "claude"
-            return [false, "binary_missing"]
-          end
-          # Force claude to be available for testing
-          if ENV["AIDP_FORCE_CLAUDE_AVAILABLE"] == "1" && normalized == "claude"
-            return [true, "available"]
-          end
-        end
-
         cache_key = "#{provider_name}:#{normalized}"
         cached = @binary_check_cache[cache_key]
         if cached && (Time.now - cached[:checked_at] < @binary_check_ttl)
@@ -1098,7 +1087,7 @@ module Aidp
           return [true, nil]
         end
         path = begin
-          Aidp::Util.which(binary)
+          @binary_checker.which(binary)
         rescue => e
           log_rescue(e, component: "provider_manager", action: "locate_binary", fallback: nil, binary: binary)
           nil
@@ -1164,10 +1153,6 @@ module Aidp
         statuses = provider_health_status
         metrics = all_metrics
         configured = configured_providers
-        # Ensure fresh binary probe results in test mode so stubs of Aidp::Util.which take effect
-        if defined?(RSpec) || ENV["RSPEC_RUNNING"]
-          @binary_check_cache.clear
-        end
         rows_by_normalized = {}
         configured.each do |prov|
           # Temporarily hide macos provider until it's user-configurable
@@ -1384,7 +1369,7 @@ module Aidp
         @current_provider = provider_type
 
         # Execute the prompt with the provider
-        result = provider.send(prompt: prompt, session: nil)
+        result = provider.send_message(prompt: prompt, session: nil)
 
         # Return structured result
         {

data/lib/aidp/harness/runner.rb

@@ -188,9 +188,9 @@ module Aidp
       def get_mode_runner
         case @mode
         when :analyze
-          Aidp::Analyze::Runner.new(@project_dir, self, prompt: TTY::Prompt.new)
+          Aidp::Analyze::Runner.new(@project_dir, self, prompt: @prompt)
         when :execute
-          Aidp::Execute::Runner.new(@project_dir, self, prompt: TTY::Prompt.new)
+          Aidp::Execute::Runner.new(@project_dir, self, prompt: @prompt)
         else
           raise ArgumentError, "Unsupported mode: #{@mode}"
         end

data/lib/aidp/harness/state/persistence.rb

@@ -8,22 +8,25 @@ module Aidp
     module State
       # Handles file I/O and persistence for state management
       class Persistence
-        def initialize(project_dir, mode)
+        def initialize(project_dir, mode, skip_persistence: false)
           @project_dir = project_dir
           @mode = mode
           @state_dir = File.join(project_dir, ".aidp", "harness")
           @state_file = File.join(@state_dir, "#{mode}_state.json")
           @lock_file = File.join(@state_dir, "#{mode}_state.lock")
+          # Use explicit skip_persistence flag for dependency injection
+          # Callers should set skip_persistence: true for test/dry-run scenarios
+          @skip_persistence = skip_persistence
           ensure_state_directory
         end
 
         def has_state?
-          return false if test_mode?
+          return false if @skip_persistence
           File.exist?(@state_file)
         end
 
         def load_state
-          return {} if test_mode? || !has_state?
+          return {} if @skip_persistence || !has_state?
 
           with_lock do
             content = File.read(@state_file)
@@ -35,7 +38,7 @@ module Aidp
         end
 
         def save_state(state_data)
-          return if test_mode?
+          return if @skip_persistence
 
           with_lock do
             state_with_metadata = add_metadata(state_data)
@@ -44,7 +47,7 @@ module Aidp
         end
 
         def clear_state
-          return if test_mode?
+          return if @skip_persistence
 
           with_lock do
             File.delete(@state_file) if File.exist?(@state_file)
@@ -53,10 +56,6 @@ module Aidp
 
         private
 
-        def test_mode?
-          ENV["RACK_ENV"] == "test" || defined?(RSpec)
-        end
-
         def add_metadata(state_data)
           state_data.merge(
             mode: @mode,
@@ -76,7 +75,7 @@ module Aidp
         end
 
         def with_lock(&block)
-          return yield if test_mode?
+          return yield if @skip_persistence
 
           acquire_lock_with_timeout(&block)
         ensure

data/lib/aidp/harness/state/workflow_state.rb

@@ -10,11 +10,12 @@ module Aidp
     module State
       # Manages workflow-specific state and progress tracking
       class WorkflowState
-        def initialize(persistence, project_dir, mode)
+        def initialize(persistence, project_dir, mode, progress_tracker_factory: nil)
           @persistence = persistence
           @project_dir = project_dir
           @mode = mode
-          @progress_tracker = create_progress_tracker
+          @progress_tracker_factory = progress_tracker_factory
+          @progress_tracker = @progress_tracker_factory ? @progress_tracker_factory.call : create_progress_tracker
         end
 
         def completed_steps