aidp 0.14.1 → 0.14.2

data/lib/aidp/storage/json_storage.rb

@@ -2,11 +2,14 @@
 
 require "json"
 require "fileutils"
+require "aidp/rescue_logging"
 
 module Aidp
   module Storage
     # Simple JSON file storage for structured data
     class JsonStorage
+      include Aidp::RescueLogging
+
       def initialize(base_dir = ".aidp")
         @base_dir = base_dir
         ensure_directory_exists
@@ -32,11 +35,13 @@ module Aidp
           success: true
         }
       rescue => error
-        {
+        log_rescue(error,
+          component: "json_storage",
+          action: "store",
+          fallback: {success: false},
           filename: filename,
-          error: error.message,
-          success: false
-        }
+          path: file_path)
+        {filename: filename, error: error.message, success: false}
       end
 
       # Load data from JSON file
@@ -48,7 +53,12 @@ module Aidp
         json_data = JSON.parse(content)
         json_data["data"]
       rescue => error
-        puts "Error loading #{filename}: #{error.message}" if ENV["AIDP_DEBUG"]
+        log_rescue(error,
+          component: "json_storage",
+          action: "load",
+          fallback: nil,
+          filename: filename,
+          path: (defined?(file_path) ? file_path : nil))
         nil
       end
 
@@ -72,11 +82,13 @@ module Aidp
           success: true
         }
       rescue => error
-        {
+        log_rescue(error,
+          component: "json_storage",
+          action: "update",
+          fallback: {success: false},
           filename: filename,
-          error: error.message,
-          success: false
-        }
+          path: (defined?(file_path) ? file_path : nil))
+        {filename: filename, error: error.message, success: false}
       end
 
       # Check if file exists
@@ -92,6 +104,12 @@ module Aidp
         File.delete(file_path)
         {success: true, message: "File deleted"}
       rescue => error
+        log_rescue(error,
+          component: "json_storage",
+          action: "delete",
+          fallback: {success: false},
+          filename: filename,
+          path: file_path)
         {success: false, error: error.message}
       end
 
@@ -120,7 +138,12 @@ module Aidp
           size: File.size(file_path)
         }
       rescue => error
-        puts "Error getting metadata for #{filename}: #{error.message}" if ENV["AIDP_DEBUG"]
+        log_rescue(error,
+          component: "json_storage",
+          action: "metadata",
+          fallback: nil,
+          filename: filename,
+          path: (defined?(file_path) ? file_path : nil))
         nil
       end
 

data/lib/aidp/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Aidp
-  VERSION = "0.14.1"
+  VERSION = "0.14.2"
 end

data/lib/aidp/workflows/guided_agent.rb

@@ -5,6 +5,7 @@ require_relative "../harness/provider_factory"
 require_relative "../harness/config_manager"
 require_relative "definitions"
 require_relative "../message_display"
+require_relative "../debug_mixin"
 require_relative "../cli/enhanced_input"
 
 module Aidp
@@ -13,6 +14,7 @@ module Aidp
     # Acts as a copilot to match user intent to AIDP capabilities
     class GuidedAgent
       include Aidp::MessageDisplay
+      include Aidp::DebugMixin
 
       class ConversationError < StandardError; end
 
@@ -39,6 +41,8 @@ module Aidp
         display_message("\n🤖 Welcome to AIDP Guided Workflow!", type: :highlight)
         display_message("I'll help you plan and execute your project.\n", type: :info)
 
+        validate_provider_configuration!
+
         plan_and_execute_workflow
       rescue => e
         raise ConversationError, "Failed to guide workflow selection: #{e.message}"
@@ -70,10 +74,18 @@ module Aidp
 
         @conversation_history << {role: "user", content: goal}
 
+        iteration = 0
         loop do
+          iteration += 1
           # Ask AI for next question based on current plan
           question_response = get_planning_questions(plan)
 
+          # Debug: show raw provider response and parsed result
+          debug_log("Planning iteration #{iteration} provider response", level: :debug, data: {
+            raw_response: question_response[:raw_response]&.inspect,
+            parsed: question_response.inspect
+          })
+
           # If AI says plan is complete, confirm with user
           if question_response[:complete]
             display_message("\n✅ Plan Summary", type: :highlight)
@@ -96,6 +108,12 @@ module Aidp
             # Update plan with answer
             update_plan_from_answer(plan, question, answer)
           end
+
+          # Guard: break loop after 10 iterations to avoid infinite loop
+          if iteration >= 10
+            display_message("[ERROR] Planning loop exceeded 10 iterations. Provider may be returning generic responses.", type: :error)
+            break
+          end
         end
 
         plan
@@ -105,8 +123,18 @@ module Aidp
         system_prompt = build_planning_system_prompt
         user_prompt = build_planning_prompt(plan)
 
+        # If requirements are already detailed, ask provider to check for completion
+        requirements = plan[:requirements]
+        requirements_detailed = requirements.is_a?(Hash) && requirements.values.flatten.any? { |r| r.length > 50 }
+        if requirements_detailed
+          user_prompt += "\n\nNOTE: Requirements have been provided in detail above. If you have enough information, set 'complete' to true. Do not repeat the same requirements question."
+        end
+
         response = call_provider_for_analysis(system_prompt, user_prompt)
-        parse_planning_response(response)
+        parsed = parse_planning_response(response)
+        # Attach raw response for debug
+        parsed[:raw_response] = response
+        parsed
       end
 
       def identify_steps_from_plan(plan)
@@ -135,6 +163,16 @@ module Aidp
       end
 
       def build_workflow_from_plan(plan, needed_steps)
+        # Filter out any unknown steps to avoid nil dereference if SPEC changed or an AI hallucinated a step key
+        execute_spec = Aidp::Execute::Steps::SPEC
+        unknown_steps = needed_steps.reject { |s| execute_spec.key?(s) }
+        if unknown_steps.any?
+          display_message("⚠️  Ignoring unknown execute steps: #{unknown_steps.join(", ")}", type: :warning)
+          needed_steps -= unknown_steps
+        end
+
+        details = needed_steps.map { |step| execute_spec[step]["description"] }
+
         {
           mode: :execute,
           workflow_key: :plan_and_execute,
@@ -144,7 +182,7 @@ module Aidp
           workflow: {
             name: "Plan & Execute",
             description: "Custom workflow from iterative planning",
-            details: needed_steps.map { |step| Aidp::Execute::Steps::SPEC[step]["description"] }
+            details: details
           },
           completion_criteria: plan[:completion_criteria]
         }
@@ -233,33 +271,52 @@ module Aidp
       end
 
       def call_provider_for_analysis(system_prompt, user_prompt)
-        # Get current provider from provider manager
-        provider_name = @provider_manager.current_provider
+        attempts = 0
+        max_attempts = (@provider_manager.respond_to?(:configured_providers) ? @provider_manager.configured_providers.size : 2)
+        max_attempts = 2 if max_attempts < 2 # at least one retry if a fallback exists
 
-        unless provider_name
-          raise ConversationError, "No provider configured for guided workflow"
-        end
+        begin
+          attempts += 1
 
-        # Create provider instance using ProviderFactory
-        provider_factory = Aidp::Harness::ProviderFactory.new(@config_manager)
-        provider = provider_factory.create_provider(provider_name, prompt: @prompt)
+          provider_name = @provider_manager.current_provider
+          unless provider_name
+            raise ConversationError, "No provider configured for guided workflow"
+          end
 
-        unless provider
-          raise ConversationError, "Failed to create provider instance for #{provider_name}"
-        end
+          # Create provider instance using ProviderFactory
+          provider_factory = Aidp::Harness::ProviderFactory.new(@config_manager)
+          provider = provider_factory.create_provider(provider_name, prompt: @prompt)
 
-        # Make the request - combine system and user prompts
-        combined_prompt = "#{system_prompt}\n\n#{user_prompt}"
+          unless provider
+            raise ConversationError, "Failed to create provider instance for #{provider_name}"
+          end
 
-        result = provider.send(prompt: combined_prompt)
+          combined_prompt = "#{system_prompt}\n\n#{user_prompt}"
+          result = provider.send(prompt: combined_prompt)
 
-        # Provider.send returns a string (the content), not a hash
-        # Check if result is nil or empty which indicates failure
-        if result.nil? || result.empty?
-          raise ConversationError, "Provider request failed: empty response"
-        end
+          if result.nil? || result.empty?
+            raise ConversationError, "Provider request failed: empty response"
+          end
+
+          result
+        rescue => e
+          message = e.message.to_s
+          classified = if message =~ /resource[_ ]exhausted/i || message =~ /\[resource_exhausted\]/i
+            "resource_exhausted"
+          elsif message =~ /quota[_ ]exceeded/i || message =~ /\[quota_exceeded\]/i
+            "quota_exceeded"
+          end
 
-        result
+          if classified && attempts < max_attempts
+            display_message("⚠️  Provider '#{provider_name}' #{classified.tr("_", " ")} – attempting fallback...", type: :warning)
+            switched = @provider_manager.switch_provider_for_error(classified, stderr: message) if @provider_manager.respond_to?(:switch_provider_for_error)
+            if switched && switched != provider_name
+              display_message("↩️  Switched to provider '#{switched}'", type: :info)
+              retry
+            end
+          end
+          raise
+        end
       end
 
       def parse_recommendation(response_text)
@@ -276,6 +333,22 @@ module Aidp
         raise ConversationError, "Invalid JSON in recommendation: #{e.message}"
       end
 
+      def validate_provider_configuration!
+        configured = @provider_manager.configured_providers
+        if configured.nil? || configured.empty?
+          raise ConversationError, <<~MSG.strip
+            No providers are configured. Create an aidp.yml with at least one provider, for example:
+            
+            harness:\n  enabled: true\n  default_provider: claude\nproviders:\n  claude:\n    type: api\n    api_key: "${AIDP_CLAUDE_API_KEY}"\n    models:\n      - claude-3-5-sonnet-20241022
+          MSG
+        end
+
+        default = @provider_manager.current_provider
+        unless default && configured.include?(default)
+          raise ConversationError, "Default provider '#{default || "(nil)"}' not found in configured providers: #{configured.join(", ")}"
+        end
+      end
+
       def present_recommendation(recommendation)
         display_message("\n✨ Recommendation", type: :highlight)
         display_message("─" * 60, type: :muted)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: aidp
 version: !ruby/object:Gem::Version
-  version: 0.14.1
+  version: 0.14.2
 platform: ruby
 authors:
 - Bart Agapinan
@@ -259,7 +259,6 @@ files:
 - lib/aidp/core_ext/class_attribute.rb
 - lib/aidp/daemon/process_manager.rb
 - lib/aidp/daemon/runner.rb
-- lib/aidp/debug_logger.rb
 - lib/aidp/debug_mixin.rb
 - lib/aidp/execute/async_work_loop_runner.rb
 - lib/aidp/execute/checkpoint.rb
@@ -337,6 +336,7 @@ files:
 - lib/aidp/providers/github_copilot.rb
 - lib/aidp/providers/macos_ui.rb
 - lib/aidp/providers/opencode.rb
+- lib/aidp/rescue_logging.rb
 - lib/aidp/setup/wizard.rb
 - lib/aidp/storage/csv_storage.rb
 - lib/aidp/storage/file_manager.rb

data/lib/aidp/debug_logger.rb

@@ -1,195 +0,0 @@
-# frozen_string_literal: true
-
-require "fileutils"
-require "json"
-require "pastel"
-
-module Aidp
-  # Debug logger that outputs to both console and a single log file
-  class DebugLogger
-    LOG_LEVELS = {
-      debug: 0,
-      info: 1,
-      warn: 2,
-      error: 3
-    }.freeze
-
-    def initialize(log_dir: nil)
-      @log_dir = log_dir || default_log_dir
-      @log_file = nil
-      @run_started = false
-      ensure_log_directory
-      log_run_banner
-    end
-
-    def log(message, level: :info, data: nil)
-      timestamp = Time.now.strftime("%Y-%m-%d %H:%M:%S.%3N")
-      level_str = level.to_s.upcase.ljust(5)
-
-      # Format message with timestamp and level
-      formatted_message = "[#{timestamp}] #{level_str} #{message}"
-
-      # Add data if present
-      if data && !data.empty?
-        data_str = format_data(data)
-        formatted_message += "\n#{data_str}" if data_str
-      end
-
-      # Output to console
-      output_to_console(formatted_message, level)
-
-      # Output to log file
-      output_to_file(formatted_message, level, data)
-    end
-
-    def close
-      @log_file&.close
-      @log_file = nil
-    end
-
-    private
-
-    def default_log_dir
-      File.join(Dir.pwd, ".aidp", "debug_logs")
-    end
-
-    def ensure_log_directory
-      FileUtils.mkdir_p(@log_dir) unless Dir.exist?(@log_dir)
-    end
-
-    def log_file_path
-      @log_file_path ||= File.join(@log_dir, "aidp_debug.log")
-    end
-
-    def get_log_file
-      return @log_file if @log_file && !@log_file.closed?
-
-      @log_file = File.open(log_file_path, "a")
-      @log_file
-    end
-
-    def log_run_banner
-      return if @run_started
-      @run_started = true
-
-      timestamp = Time.now.strftime("%Y-%m-%d %H:%M:%S.%3N")
-      command_line = build_command_line
-
-      banner = <<~BANNER
-
-        ================================================================================
-        AIDP DEBUG SESSION STARTED
-        ================================================================================
-        Timestamp: #{timestamp}
-        Command: #{command_line}
-        Working Directory: #{Dir.pwd}
-        Debug Level: #{ENV["DEBUG"] || "0"}
-        ================================================================================
-      BANNER
-
-      # Write banner to log file
-      file = get_log_file
-      file.puts banner
-      file.flush
-
-      # Also output to console if debug is enabled
-      if ENV["DEBUG"] && ENV["DEBUG"].to_i > 0
-        puts "\e[36m#{banner}\e[0m" # Cyan color
-      end
-    end
-
-    def build_command_line
-      # Get the command line arguments
-      cmd_parts = []
-
-      # Add the main command (aidp)
-      cmd_parts << "aidp"
-
-      # Add any arguments from ARGV
-      if defined?(ARGV) && !ARGV.empty?
-        cmd_parts.concat(ARGV)
-      end
-
-      # Add environment variables that affect behavior
-      env_vars = []
-      env_vars << "DEBUG=#{ENV["DEBUG"]}" if ENV["DEBUG"]
-      env_vars << "AIDP_CONFIG=#{ENV["AIDP_CONFIG"]}" if ENV["AIDP_CONFIG"]
-
-      if env_vars.any?
-        cmd_parts << "(" + env_vars.join(" ") + ")"
-      end
-
-      cmd_parts.join(" ")
-    end
-
-    def output_to_console(message, level)
-      case level
-      when :error
-        warn message
-      when :warn
-        puts "\e[33m#{message}\e[0m" # Yellow
-      when :info
-        puts "\e[36m#{message}\e[0m" # Cyan
-      when :debug
-        puts "\e[90m#{message}\e[0m" # Gray
-      else
-        puts message
-      end
-    end
-
-    def output_to_file(message, level, data)
-      file = get_log_file
-      file.puts message
-
-      # Add structured data if present
-      if data && !data.empty?
-        structured_data = {
-          timestamp: Time.now.strftime("%Y-%m-%dT%H:%M:%S.%3N%z"),
-          level: level.to_s,
-          message: message,
-          data: data
-        }
-        file.puts "DATA: #{JSON.generate(structured_data)}"
-      end
-
-      file.flush
-    end
-
-    def format_data(data)
-      return nil if data.nil? || data.empty?
-
-      case data
-      when Hash
-        format_hash_data(data)
-      when Array
-        format_array_data(data)
-      when String
-        (data.length > 200) ? "#{data[0..200]}..." : data
-      else
-        data.to_s
-      end
-    end
-
-    def format_hash_data(hash)
-      lines = []
-      hash.each do |key, value|
-        lines << if value.is_a?(String) && value.length > 100
-          "  #{key}: #{value[0..100]}..."
-        elsif value.is_a?(Hash) || value.is_a?(Array)
-          "  #{key}: #{JSON.pretty_generate(value).gsub("\n", "\n    ")}"
-        else
-          "  #{key}: #{value}"
-        end
-      end
-      lines.join("\n")
-    end
-
-    def format_array_data(array)
-      if array.length > 10
-        "#{array.first(5).join(", ")}... (#{array.length} total items)"
-      else
-        array.join(", ")
-      end
-    end
-  end
-end