aidp 0.12.1 → 0.13.0

data/lib/aidp/harness/status_display.rb

@@ -165,13 +165,13 @@ module Aidp
       end
 
       # Set display mode
-      def set_display_mode(mode)
+      def display_mode(mode)
         @display_mode = mode
         @display_config[:mode] = mode
       end
 
       # Set update interval
-      def set_update_interval(interval)
+      def update_interval(interval)
         @update_interval = interval
         @display_config[:update_interval] = interval
       end
@@ -248,19 +248,19 @@ module Aidp
       end
 
       # Get comprehensive status data
-      def get_status_data
+      def status_data
         {
-          basic_info: get_basic_status,
-          provider_info: get_provider_status,
-          performance_info: get_performance_status,
-          error_info: get_error_status,
-          circuit_breaker_info: get_circuit_breaker_status,
-          token_info: get_token_status,
-          rate_limit_info: get_rate_limit_status,
-          recovery_info: get_recovery_status,
-          user_feedback_info: get_user_feedback_status,
-          work_completion_info: get_work_completion_status,
-          alerts: get_alerts
+          basic_info: basic_status,
+          provider_info: provider_status,
+          performance_info: performance_status,
+          error_info: error_status,
+          circuit_breaker_info: circuit_breaker_status,
+          token_info: token_status,
+          rate_limit_info: rate_limit_status,
+          recovery_info: recovery_status,
+          user_feedback_info: user_feedback_status,
+          work_completion_info: work_completion_status,
+          alerts: alerts
         }
       end
 
@@ -268,9 +268,9 @@ module Aidp
       def export_status_data(format = :json)
         case format
         when :json
-          JSON.pretty_generate(get_status_data)
+          JSON.pretty_generate(status_data)
         when :yaml
-          get_status_data.to_yaml
+          status_data.to_yaml
         when :text
           format_status_as_text
         else
@@ -310,8 +310,8 @@ module Aidp
           @provider_status = {
             current_provider: safe_manager_call(@provider_manager, :current_provider),
             current_model: safe_manager_call(@provider_manager, :current_model),
-            available_providers: safe_manager_call(@provider_manager, :get_available_providers) || [],
-            provider_health: safe_manager_call(@provider_manager, :get_provider_health_status) || {}
+            available_providers: safe_manager_call(@provider_manager, :available_providers) || [],
+            provider_health: safe_manager_call(@provider_manager, :provider_health_status) || {}
           }
         rescue => e
           # Log minimal info without breaking display; keep previous provider_status if available
@@ -330,13 +330,13 @@ module Aidp
       def collect_circuit_breaker_status
         return unless @circuit_breaker_manager
 
-        @circuit_breaker_status = @circuit_breaker_manager.get_all_states
+        @circuit_breaker_status = @circuit_breaker_manager.all_states
       end
 
       def collect_metrics_data
         return unless @metrics_manager
 
-        @performance_metrics = @metrics_manager.get_realtime_metrics
+        @performance_metrics = @metrics_manager.realtime_metrics
       end
 
       def collect_error_data
@@ -616,7 +616,6 @@ module Aidp
       end
 
       def display_alerts
-        alerts = get_alerts
         return unless alerts.any?
 
         display_message("\n🚨 ALERTS", type: :warning)
@@ -672,7 +671,7 @@ module Aidp
         display_message("   Continuing with status updates...", type: :info)
       end
 
-      def get_basic_status
+      def basic_status
         {
           duration: @start_time ? Time.now - @start_time : 0,
           current_step: @current_step,
@@ -684,44 +683,32 @@ module Aidp
         }
       end
 
-      def get_provider_status
-        @provider_status
-      end
+      attr_reader :provider_status
 
-      def get_performance_status
+      def performance_status
         @performance_metrics
       end
 
-      def get_error_status
+      def error_status
         @error_summary
       end
 
-      def get_circuit_breaker_status
-        @circuit_breaker_status
-      end
+      attr_reader :circuit_breaker_status
 
-      def get_token_status
+      def token_status
         @token_usage
       end
 
-      def get_rate_limit_status
-        @rate_limit_status
-      end
+      attr_reader :rate_limit_status
 
-      def get_recovery_status
-        @recovery_status
-      end
+      attr_reader :recovery_status
 
-      def get_user_feedback_status
-        @user_feedback_status
-      end
+      attr_reader :user_feedback_status
 
-      def get_work_completion_status
-        @work_completion_status
-      end
+      attr_reader :work_completion_status
 
-      def get_alerts
-        @alert_manager.get_active_alerts
+      def alerts
+        @alert_manager.active_alerts
       end
 
       def calculate_step_duration
@@ -854,7 +841,7 @@ module Aidp
           end
         end
 
-        def get_active_alerts
+        def active_alerts
           @alerts
         end
 

data/lib/aidp/harness/ui/enhanced_workflow_selector.rb

@@ -250,7 +250,8 @@ module Aidp
 
         def select_guided_workflow
           # Use the guided agent to help user select workflow
-          guided_agent = Aidp::Workflows::GuidedAgent.new(@project_dir, prompt: @tui.instance_variable_get(:@prompt))
+          # Don't pass prompt so it uses EnhancedInput with full readline support
+          guided_agent = Aidp::Workflows::GuidedAgent.new(@project_dir)
           result = guided_agent.select_workflow
 
           # Store user input for later use

data/lib/aidp/harness/ui/job_monitor.rb

@@ -85,7 +85,7 @@ module Aidp
           raise MonitorError, "Failed to update job status: #{e.message}"
         end
 
-        def get_job_status(job_id)
+        def job_status(job_id)
           validate_job_id(job_id)
 
           @monitor_mutex.synchronize do
@@ -100,11 +100,11 @@ module Aidp
           @monitor_mutex.synchronize { @jobs.key?(job_id) }
         end
 
-        def get_all_jobs
+        def all_jobs
           @monitor_mutex.synchronize { @jobs.dup }
         end
 
-        def get_jobs_by_status(status)
+        def jobs_by_status(status)
           validate_job_status(status)
 
           @monitor_mutex.synchronize do
@@ -114,7 +114,7 @@ module Aidp
           raise MonitorError, "Failed to get jobs by status: #{e.message}"
         end
 
-        def get_jobs_by_priority(priority)
+        def jobs_by_priority(priority)
           validate_job_priority(priority)
 
           @monitor_mutex.synchronize do
@@ -162,7 +162,7 @@ module Aidp
           @update_callbacks.delete(callback)
         end
 
-        def get_monitoring_summary
+        def monitoring_summary
           @monitor_mutex.synchronize do
             {
               total_jobs: @jobs.size,
@@ -176,7 +176,7 @@ module Aidp
         end
 
         def display_job_status(job_id)
-          job = get_job_status(job_id)
+          job = job_status(job_id)
           @frame_manager.section("Job Status: #{job_id}") do
             display_job_details(job)
           end
@@ -189,7 +189,7 @@ module Aidp
         end
 
         def display_jobs_by_status(status)
-          jobs = get_jobs_by_status(status)
+          jobs = jobs_by_status(status)
           @frame_manager.section("Jobs with Status: #{status}") do
             display_jobs_table(jobs)
           end

data/lib/aidp/harness/user_interface.rb

@@ -26,7 +26,7 @@ module Aidp
 
       # Helper method to handle input consistently with TTY::Prompt
       # Fixed to avoid keystroke loss issues with TTY::Prompt's required validation
-      def get_input_with_prompt(message, required: false, default: nil)
+      def input_with_prompt(message, required: false, default: nil)
         loop do
           # Always use simple ask without built-in validation to avoid echo issues
           input = if default
@@ -82,7 +82,7 @@ module Aidp
           display_numbered_question(question_data, question_number, index + 1, questions.length)
 
           # Get user response based on question type
-          response = get_question_response(question_data, question_number)
+          response = question_response(question_data, question_number)
 
           # Validate response if required
           if question_data[:required] != false && (response.nil? || response.to_s.strip.empty?)
@@ -468,7 +468,7 @@ module Aidp
       end
 
       # Get response for a specific question with enhanced validation
-      def get_question_response(question_data, _question_number)
+      def question_response(question_data, _question_number)
         question_type = question_data[:type] || "text"
         expected_input = question_data[:expected_input] || "text"
         options = question_data[:options]
@@ -478,21 +478,21 @@ module Aidp
 
         case question_type
         when "text"
-          get_text_response(expected_input, default_value, required, validation_options)
+          text_response(expected_input, default_value, required, validation_options)
         when "choice"
-          get_choice_response(options, default_value, required)
+          choice_response(options, default_value, required)
         when "confirmation"
-          get_confirmation_response(default_value, required)
+          confirmation_response(default_value, required)
         when "file"
-          get_file_response(expected_input, default_value, required, validation_options)
+          file_response(expected_input, default_value, required, validation_options)
         when "number"
-          get_number_response(expected_input, default_value, required, validation_options)
+          number_response(expected_input, default_value, required, validation_options)
         when "email"
-          get_email_response(default_value, required, validation_options)
+          email_response(default_value, required, validation_options)
         when "url"
-          get_url_response(default_value, required, validation_options)
+          url_response(default_value, required, validation_options)
         else
-          get_text_response(expected_input, default_value, required, validation_options)
+          text_response(expected_input, default_value, required, validation_options)
         end
       end
 
@@ -620,13 +620,13 @@ module Aidp
       end
 
       # Get text response with enhanced validation
-      def get_text_response(expected_input, default_value, required, options = {})
+      def text_response(expected_input, default_value, required, options = {})
         prompt = "Your response"
         prompt += " (default: #{default_value})" if default_value
         prompt_text = prompt + (required ? "" : " (optional)")
 
         loop do
-          input = get_input_with_prompt(prompt_text, required: required, default: default_value)
+          input = input_with_prompt(prompt_text, required: required, default: default_value)
 
           # get_input_with_prompt already handles required validation and returns non-empty input
           # Only validate the type/format if we got input
@@ -653,7 +653,7 @@ module Aidp
       end
 
       # Get choice response with enhanced validation
-      def get_choice_response(options, default_value, required)
+      def choice_response(options, default_value, required)
         return nil if options.nil? || options.empty?
 
         display_message("\n   Available options:", type: :info)
@@ -704,7 +704,7 @@ module Aidp
       end
 
       # Get confirmation response with enhanced validation
-      def get_confirmation_response(default_value, required)
+      def confirmation_response(default_value, required)
         default = default_value.nil? || default_value
         default_text = default ? "Y/n" : "y/N"
         prompt = "Your response [#{default_text}]"
@@ -741,7 +741,7 @@ module Aidp
       end
 
       # Get file response with enhanced validation
-      def get_file_response(_expected_input, default_value, required, options = {})
+      def file_response(_expected_input, default_value, required, options = {})
         prompt = "File path"
         prompt += " (default: #{default_value})" if default_value
         prompt += required ? ": " : " (optional): "
@@ -784,7 +784,7 @@ module Aidp
       end
 
       # Get number response with enhanced validation
-      def get_number_response(expected_input, default_value, required, options = {})
+      def number_response(expected_input, default_value, required, options = {})
         prompt = "Number"
         prompt += " (default: #{default_value})" if default_value
         prompt += required ? ": " : " (optional): "
@@ -831,7 +831,7 @@ module Aidp
       end
 
       # Get email response with enhanced validation
-      def get_email_response(default_value, required, options = {})
+      def email_response(default_value, required, options = {})
         prompt = "Email address"
         prompt += " (default: #{default_value})" if default_value
         prompt += required ? ": " : " (optional): "
@@ -868,7 +868,7 @@ module Aidp
       end
 
       # Get URL response with enhanced validation
-      def get_url_response(default_value, required, options = {})
+      def url_response(default_value, required, options = {})
         prompt = "URL"
         prompt += " (default: #{default_value})" if default_value
         prompt += required ? ": " : " (optional): "
@@ -1321,7 +1321,7 @@ module Aidp
       end
 
       # Get user input with support for file selection
-      def get_user_input(prompt)
+      def user_input(prompt)
         loop do
           input = @prompt.ask(prompt)
 
@@ -1364,7 +1364,7 @@ module Aidp
         display_advanced_file_menu(available_files, search_options)
 
         # Get user selection with advanced options
-        selection = get_advanced_file_selection(available_files.size, search_options)
+        selection = advanced_file_selection(available_files.size, search_options)
 
         if selection && selection >= 0 && selection < available_files.size
           selected_file = available_files[selection]
@@ -1602,12 +1602,12 @@ module Aidp
       end
 
       # Get file information for display
-      def get_file_info(file)
+      def file_info(file)
         {
           display_name: file,
           size: format_file_size(File.size(file)),
           modified: File.mtime(file).strftime("%Y-%m-%d %H:%M"),
-          type: get_file_type(file)
+          type: file_type(file)
         }
       end
 
@@ -1623,7 +1623,7 @@ module Aidp
       end
 
       # Get file type for display
-      def get_file_type(file)
+      def file_type(file)
         ext = File.extname(file)
         case ext
         when ".rb"
@@ -1665,7 +1665,7 @@ module Aidp
       end
 
       # Get advanced file selection from user
-      def get_advanced_file_selection(max_files, _search_options)
+      def advanced_file_selection(max_files, _search_options)
         loop do
           input = @prompt.ask("Select file (0-#{max_files}, -1=refine, p=preview, h=help): ")
 
@@ -1743,7 +1743,7 @@ module Aidp
           display_message("  Size: #{format_file_size(File.size(file_path))}", type: :info)
           display_message("  Lines: #{lines.count}", type: :info)
           display_message("  Modified: #{File.mtime(file_path).strftime("%Y-%m-%d %H:%M:%S")}", type: :info)
-          display_message("  Type: #{get_file_type(file_path)}", type: :info)
+          display_message("  Type: #{file_type(file_path)}", type: :info)
 
           display_message("\n📝 Content Preview (first 20 lines):", type: :info)
           display_message("-" * 40, type: :muted)
@@ -1764,12 +1764,12 @@ module Aidp
       end
 
       # Get file selection from user (legacy method for compatibility)
-      def get_file_selection(max_files)
-        get_advanced_file_selection(max_files, {term: "", extensions: [], directories: []})
+      def file_selection(max_files)
+        advanced_file_selection(max_files, {term: "", extensions: [], directories: []})
       end
 
       # Get confirmation from user
-      def get_confirmation(message, default: true)
+      def confirmation(message, default: true)
         default_text = default ? "Y/n" : "y/N"
         prompt = "#{message} [#{default_text}]: "
 
@@ -1793,7 +1793,7 @@ module Aidp
       end
 
       # Get choice from multiple options
-      def get_choice(message, options, default: nil)
+      def choice(message, options, default: nil)
         display_message("\n#{message}", type: :info)
         options.each_with_index do |option, index|
           marker = (default && index == default) ? " (default)" : ""
@@ -1911,32 +1911,32 @@ module Aidp
       end
 
       # Get user preferences for feedback collection
-      def get_user_preferences
+      def user_preferences
         display_message("\n⚙️  User Preferences:", type: :info)
         display_message("-" * 25, type: :muted)
 
         preferences = {}
 
         # Auto-confirm defaults
-        preferences[:auto_confirm_defaults] = get_confirmation(
+        preferences[:auto_confirm_defaults] = confirmation(
           "Auto-confirm default values without prompting?",
           default: false
         )
 
         # Show help automatically
-        preferences[:show_help_automatically] = get_confirmation(
+        preferences[:show_help_automatically] = confirmation(
           "Show help automatically for new question types?",
           default: false
         )
 
         # Verbose mode
-        preferences[:verbose_mode] = get_confirmation(
+        preferences[:verbose_mode] = confirmation(
           "Enable verbose mode with detailed information?",
           default: true
         )
 
         # File browsing enabled
-        preferences[:file_browsing_enabled] = get_confirmation(
+        preferences[:file_browsing_enabled] = confirmation(
           "Enable file browsing with @ character?",
           default: true
         )
@@ -1998,7 +1998,7 @@ module Aidp
       end
 
       # Get quick feedback for simple questions
-      def get_quick_feedback(question, options = {})
+      def quick_feedback(question, options = {})
         question_type = options[:type] || "text"
         default_value = options[:default]
         required = options[:required] != false
@@ -2007,13 +2007,13 @@ module Aidp
 
         case question_type
         when "text"
-          get_text_response("text", default_value, required)
+          text_response("text", default_value, required)
         when "confirmation"
-          get_confirmation_response(default_value, required)
+          confirmation_response(default_value, required)
         when "choice"
-          get_choice_response(options[:options], default_value, required)
+          choice_response(options[:options], default_value, required)
         else
-          get_text_response("text", default_value, required)
+          text_response("text", default_value, required)
         end
       end
 
@@ -2033,7 +2033,7 @@ module Aidp
 
           display_message("\n#{question_number}. #{question_text}", type: :info)
 
-          response = get_quick_feedback(question_text, {
+          response = quick_feedback(question_text, {
             type: question_type,
             default: default_value,
             required: required,
@@ -2299,7 +2299,7 @@ module Aidp
       end
 
       # Get control status
-      def get_control_status
+      def control_status
         @control_mutex.synchronize do
           {
             enabled: !!@control_interface_enabled,
@@ -2313,7 +2313,7 @@ module Aidp
 
       # Display control status
       def display_control_status
-        status = get_control_status
+        status = control_status
 
         display_message("\n🎮 Control Interface Status", type: :info)
         display_message("=" * 40, type: :muted)

data/lib/aidp/providers/anthropic.rb

@@ -21,6 +21,25 @@ module Aidp
         "Anthropic Claude CLI"
       end
 
+      def supports_mcp?
+        true
+      end
+
+      def fetch_mcp_servers
+        return [] unless self.class.available?
+
+        begin
+          # Use claude mcp list command
+          result = debug_execute_command("claude", args: ["mcp", "list"], timeout: 5)
+          return [] unless result.exit_status == 0
+
+          parse_claude_mcp_output(result.out)
+        rescue => e
+          debug_log("Failed to fetch MCP servers via Claude CLI: #{e.message}", level: :debug)
+          []
+        end
+      end
+
       def available?
         self.class.available?
       end
@@ -101,11 +120,9 @@ module Aidp
           return ENV["AIDP_ANTHROPIC_TIMEOUT"].to_i
         end
 
-        # Adaptive timeout based on step type
-        step_timeout = get_adaptive_timeout
-        if step_timeout
-          display_message("🧠 Using adaptive timeout: #{step_timeout} seconds", type: :info)
-          return step_timeout
+        if adaptive_timeout
+          display_message("🧠 Using adaptive timeout: #{adaptive_timeout} seconds", type: :info)
+          return adaptive_timeout
         end
 
         # Default timeout
@@ -113,27 +130,29 @@ module Aidp
         TIMEOUT_DEFAULT
       end
 
-      def get_adaptive_timeout
-        # Timeout recommendations based on step type patterns
-        step_name = ENV["AIDP_CURRENT_STEP"] || ""
-
-        case step_name
-        when /REPOSITORY_ANALYSIS/
-          TIMEOUT_REPOSITORY_ANALYSIS
-        when /ARCHITECTURE_ANALYSIS/
-          TIMEOUT_ARCHITECTURE_ANALYSIS
-        when /TEST_ANALYSIS/
-          TIMEOUT_TEST_ANALYSIS
-        when /FUNCTIONALITY_ANALYSIS/
-          TIMEOUT_FUNCTIONALITY_ANALYSIS
-        when /DOCUMENTATION_ANALYSIS/
-          TIMEOUT_DOCUMENTATION_ANALYSIS
-        when /STATIC_ANALYSIS/
-          TIMEOUT_STATIC_ANALYSIS
-        when /REFACTORING_RECOMMENDATIONS/
-          TIMEOUT_REFACTORING_RECOMMENDATIONS
-        else
-          nil # Use default
+      def adaptive_timeout
+        @adaptive_timeout ||= begin
+          # Timeout recommendations based on step type patterns
+          step_name = ENV["AIDP_CURRENT_STEP"] || ""
+
+          case step_name
+          when /REPOSITORY_ANALYSIS/
+            TIMEOUT_REPOSITORY_ANALYSIS
+          when /ARCHITECTURE_ANALYSIS/
+            TIMEOUT_ARCHITECTURE_ANALYSIS
+          when /TEST_ANALYSIS/
+            TIMEOUT_TEST_ANALYSIS
+          when /FUNCTIONALITY_ANALYSIS/
+            TIMEOUT_FUNCTIONALITY_ANALYSIS
+          when /DOCUMENTATION_ANALYSIS/
+            TIMEOUT_DOCUMENTATION_ANALYSIS
+          when /STATIC_ANALYSIS/
+            TIMEOUT_STATIC_ANALYSIS
+          when /REFACTORING_RECOMMENDATIONS/
+            TIMEOUT_REFACTORING_RECOMMENDATIONS
+          else
+            nil # Use default
+          end
         end
       end
 
@@ -184,6 +203,61 @@ module Aidp
         # Return original output if parsing fails
         output
       end
+
+      # Parse Claude MCP server list output
+      def parse_claude_mcp_output(output)
+        servers = []
+        return servers unless output
+
+        lines = output.lines
+        lines.reject! { |line| /checking mcp server health/i.match?(line) }
+
+        lines.each do |line|
+          line = line.strip
+          next if line.empty?
+
+          # Try to parse Claude format: "name: command - ✓ Connected"
+          if line =~ /^([^:]+):\s*(.+?)\s*-\s*(✓|✗)\s*(.+)$/
+            name = Regexp.last_match(1).strip
+            command = Regexp.last_match(2).strip
+            status_symbol = Regexp.last_match(3)
+            status_text = Regexp.last_match(4).strip
+
+            servers << {
+              name: name,
+              status: (status_symbol == "✓") ? "connected" : "error",
+              description: command,
+              enabled: status_symbol == "✓",
+              error: (status_symbol == "✗") ? status_text : nil,
+              source: "claude_cli"
+            }
+            next
+          end
+
+          # Try to parse legacy table format
+          next if /Name.*Status/i.match?(line)
+          next if /^[-=]+$/.match?(line)
+
+          parts = line.split(/\s{2,}/)
+          next if parts.size < 2
+
+          name = parts[0]&.strip
+          status = parts[1]&.strip
+          description = parts[2..]&.join(" ")&.strip
+
+          next unless name && !name.empty?
+
+          servers << {
+            name: name,
+            status: status || "unknown",
+            description: description,
+            enabled: status&.downcase == "enabled" || status&.downcase == "connected",
+            source: "claude_cli"
+          }
+        end
+
+        servers
+      end
     end
   end
 end