aia 2.0.0.0.pre.alpha → 2.0.0.0.pre.beta2

data/lib/aia/directives/configuration_directives.rb

@@ -5,16 +5,18 @@ module AIA
     state_setting! :model
 
     desc "View or set configuration values"
+    # :reek:TooManyStatements -- view/set dispatch on arg count, coercing booleans and dot-notation keys before writing
     def config(args = [], context_manager = nil)
       args = Array(args)
+      cfg  = AIA.config
 
       if args.empty?
-        ap AIA.config.to_h
+        ap cfg.to_h
       elsif args.length == 1
         config_item = args.first
         local_cfg = {}
-        local_cfg[config_item] = if AIA.config.respond_to?(config_item)
-                                   AIA.config.send(config_item)
+        local_cfg[config_item] = if cfg.respond_to?(config_item)
+                                   cfg.send(config_item)
                                  end
         ap local_cfg
       else
@@ -41,66 +43,22 @@ module AIA
     alias cfg config
 
     desc "View or change the AI model"
-    # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
     def model(args, context_manager = nil)
+      cfg = AIA.config
+
       if args.empty?
         puts
-        models = AIA.config.models
-
-        if models.size == 1
-          puts "Current Model:"
-          puts "=============="
-          model_name = models.first.respond_to?(:name) ? models.first.name : models.first.to_s
-          begin
-            model_info = RubyLLM::Models.find(model_name)
-            puts model_info.to_h.pretty_inspect if model_info
-          rescue StandardError
-            puts "  #{model_name}"
-          end
-        else
-          puts "Multi-Model Configuration:"
-          puts "=========================="
-          puts "Model count: #{models.size}"
-          first_model = models.first.respond_to?(:name) ? models.first.name : models.first.to_s
-          puts "Primary model: #{first_model} (used for consensus when --consensus flag is enabled)"
-          consensus = AIA.config.flags.consensus
-          puts "Consensus mode: #{consensus.nil? ? 'auto-detect (disabled by default)' : consensus}"
-          puts
-          puts "Model Details:"
-          puts "-" * 50
-
-          models.each_with_index do |model_spec, index|
-            model_name = model_spec.respond_to?(:name) ? model_spec.name : model_spec.to_s
-            puts "#{index + 1}. #{model_name}#{' (primary)' if index.zero?}"
-
-            begin
-              model_info = RubyLLM::Models.find(model_name)
-              if model_info
-                puts "   Provider: #{model_info.provider || 'Unknown'}"
-                puts "   Context window: #{model_info.context_window || 'Unknown'}"
-                puts "   Input cost: $#{model_info.input_cost || 'Unknown'}"
-                puts "   Output cost: $#{model_info.output_cost || 'Unknown'}"
-                puts "   Mode: #{model_info.modalities || 'Unknown'}"
-                puts "   Capabilities: #{(model_info.capabilities || []).join(', ')}" if model_info.capabilities&.any?
-              else
-                puts "   Details: Model not found in registry"
-              end
-            rescue StandardError => e
-              puts "   Details: Unable to fetch (#{e.class.name}: #{e.message})"
-            end
-            puts
-          end
-        end
+        models = cfg.models
+        models.size == 1 ? show_single_model(models) : show_multi_model(models)
         puts
       else
         model_names = args.join(' ').split(',').map(&:strip).reject(&:empty?)
-        AIA.config.models = AIA::Config::TO_MODEL_SPECS.call(model_names)
-        AIA.client = RobotFactory.rebuild(AIA.config)
+        cfg.models = AIA::Config::TO_MODEL_SPECS.call(model_names)
+        AIA.client = RobotFactory.rebuild(cfg)
       end
 
       ''
     end
-    # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
 
     desc "Set the temperature parameter for AI responses"
     def temperature(args, context_manager = nil)
@@ -115,7 +73,7 @@ module AIA
     alias topp top_p
 
     desc "Dump session cost/token metrics as CSV"
-    # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
+    # :reek:TooManyStatements -- CSV assembly: guards, header, rows, totals, print, optional file append
     def cost(args = [], context_manager = nil)
       tracker = AIA.session_tracker
       unless tracker
@@ -133,63 +91,115 @@ module AIA
 
       header = %w[model input_tokens output_tokens total_tokens cost elapsed]
       header << 'similarity' if has_similarity
-      lines  = [header.join(',')]
-
-      turns.each do |turn|
-        input_t  = turn[:input_tokens] || 0
-        output_t = turn[:output_tokens] || 0
-        total_t  = input_t + output_t
-        cost_val = turn[:cost] || 0.0
-        elapsed  = turn[:elapsed] || 0
-
-        row = [
-          turn[:model],
-          input_t,
-          output_t,
-          total_t,
-          "$#{'%.5f' % cost_val}",
-          "%.1fs" % elapsed
-        ]
-
-        if has_similarity
-          sim = turn[:similarity]
-          row << (sim.nil? ? 'ref' : "%.1f%%" % (sim * 100))
-        end
+      lines = [header.join(',')]
+      turns.each { |turn| lines << cost_row(turn, has_similarity).join(',') }
+      lines << cost_totals_row(turns, has_similarity).join(',')
+
+      csv = lines.join("\n")
+      puts
+      puts csv
+      puts
+
+      out_file = AIA.config.output&.file
+      File.open(out_file, 'a') { |f| f.puts csv } if out_file
+
+      ''
+    end
 
-        lines << row.join(',')
+    private
+
+    # One CSV row for a single recorded turn.
+    def cost_row(turn, has_similarity)
+      input_t  = turn[:input_tokens] || 0
+      output_t = turn[:output_tokens] || 0
+
+      row = [
+        turn[:model],
+        input_t,
+        output_t,
+        input_t + output_t,
+        "$#{'%.5f' % (turn[:cost] || 0.0)}",
+        "%.1fs" % (turn[:elapsed] || 0)
+      ]
+
+      if has_similarity
+        sim = turn[:similarity]
+        row << (sim.nil? ? 'ref' : "%.1f%%" % (sim * 100))
       end
+      row
+    end
 
-      # Totals
-      total_input   = turns.sum { |t| t[:input_tokens] || 0 }
-      total_output  = turns.sum { |t| t[:output_tokens] || 0 }
-      total_tokens  = total_input + total_output
-      total_cost    = turns.sum { |t| t[:cost] || 0.0 }
-      max_elapsed   = turns.map { |t| t[:elapsed] || 0 }.max
+    # The TOTAL summary row across all turns.
+    # :reek:DuplicateMethodCall -- each turns.sum aggregates a different field; there is no shared value to hoist
+    def cost_totals_row(turns, has_similarity)
+      total_input  = turns.sum { |t| t[:input_tokens] || 0 }
+      total_output = turns.sum { |t| t[:output_tokens] || 0 }
+      total_cost   = turns.sum { |t| t[:cost] || 0.0 }
+      max_elapsed  = turns.map { |t| t[:elapsed] || 0 }.max
 
       totals = [
         'TOTAL',
         total_input,
         total_output,
-        total_tokens,
+        total_input + total_output,
         "$#{'%.5f' % total_cost}",
         "%.1fs" % max_elapsed
       ]
       totals << '' if has_similarity
-      lines << totals.join(',')
+      totals
+    end
 
-      csv = lines.join("\n")
-      puts
-      puts csv
-      puts
+    # Format a model spec's display name whether it is a ModelSpec or a bare string.
+    def model_display_name(spec)
+      spec.respond_to?(:name) ? spec.name : spec.to_s
+    end
 
-      out_file = AIA.config.output&.file
-      File.open(out_file, 'a') { |f| f.puts csv } if out_file
+    def show_single_model(models)
+      puts "Current Model:"
+      puts "=============="
+      model_name = model_display_name(models.first)
+      begin
+        model_info = RubyLLM::Models.find(model_name)
+        puts model_info.to_h.pretty_inspect if model_info
+      rescue StandardError
+        puts "  #{model_name}"
+      end
+    end
 
-      ''
+    # :reek:TooManyStatements -- sequential terminal report: summary lines then a details block per model
+    def show_multi_model(models)
+      puts "Multi-Model Configuration:"
+      puts "=========================="
+      puts "Model count: #{models.size}"
+      puts "Primary model: #{model_display_name(models.first)} (used for consensus when --consensus flag is enabled)"
+      consensus = AIA.config.flags.consensus
+      puts "Consensus mode: #{consensus.nil? ? 'auto-detect (disabled by default)' : consensus}"
+      puts
+      puts "Model Details:"
+      puts "-" * 50
+
+      models.each_with_index do |model_spec, index|
+        puts "#{index + 1}. #{model_display_name(model_spec)}#{' (primary)' if index.zero?}"
+        show_model_details(model_display_name(model_spec))
+        puts
+      end
     end
-    # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
 
-    private
+    def show_model_details(model_name)
+      model_info = RubyLLM::Models.find(model_name)
+      if model_info
+        puts "   Provider: #{model_info.provider || 'Unknown'}"
+        puts "   Context window: #{model_info.context_window || 'Unknown'}"
+        puts "   Input cost: $#{model_info.input_cost || 'Unknown'}"
+        puts "   Output cost: $#{model_info.output_cost || 'Unknown'}"
+        puts "   Mode: #{model_info.modalities || 'Unknown'}"
+        puts "   Capabilities: #{(model_info.capabilities || []).join(', ')}" if model_info.capabilities&.any?
+      else
+        puts "   Details: Model not found in registry"
+      end
+    rescue StandardError => e
+      puts "   Details: Unable to fetch (#{e.class.name}: #{e.message})"
+    end
 
     # Apply a config value by key, supporting three forms:
     #   flat CLI key  — "debug"        → CLI_TO_NESTED_MAP routing
@@ -197,13 +207,15 @@ module AIA
     #   direct setter — "log_level_override" → AIA.config.<key>=
     #
     # Returns true if the value was set, false if the key was unknown.
+    # :reek:TooManyStatements -- three key-addressing forms (dot-notation walk, CLI map, direct setter) tried in order
     def write_config_value(config_item, new_value) # rubocop:disable Naming/PredicateMethod
       key_str = config_item.to_s
+      cfg     = AIA.config
 
       # Dot-notation: walk the config object by path segments
       if key_str.include?('.')
         parts   = key_str.split('.')
-        obj     = AIA.config
+        obj     = cfg
         parents = parts[0..-2]
         leaf    = parts.last
 
@@ -222,15 +234,15 @@ module AIA
 
       # Flat CLI key via CLI_TO_NESTED_MAP (e.g. "debug" → flags.debug)
       if AIA::Config::CLI_TO_NESTED_MAP.key?(key_str.to_sym) &&
-         AIA.config.respond_to?(:apply_overrides)
-        AIA.config.apply_overrides({ key_str.to_sym => new_value })
+         cfg.respond_to?(:apply_overrides)
+        cfg.apply_overrides({ key_str.to_sym => new_value })
         maybe_clear_log_override(key_str, new_value)
         return true
       end
 
       # Direct setter on the config object (e.g. "log_level_override")
-      if AIA.config.respond_to?("#{key_str}=")
-        AIA.config.send("#{key_str}=", new_value)
+      if cfg.respond_to?("#{key_str}=")
+        cfg.send("#{key_str}=", new_value)
         return true
       end
 
@@ -241,9 +253,11 @@ module AIA
     # drops back to its configured level rather than staying at DEBUG.
     def maybe_clear_log_override(key, value)
       return unless key.to_s == 'debug' && value == false
-      return unless AIA.config.respond_to?(:log_level_override=)
 
-      AIA.config.log_level_override = nil if AIA.config.log_level_override.to_s == 'debug'
+      cfg = AIA.config
+      return unless cfg.respond_to?(:log_level_override=)
+
+      cfg.log_level_override = nil if cfg.log_level_override.to_s == 'debug'
     end
   end
 end

data/lib/aia/directives/context_directives.rb

@@ -21,6 +21,7 @@ module AIA
     end
 
     desc "Create a named checkpoint of the current context"
+    # :reek:TooManyStatements -- one snapshot build: name resolution, deep copy of every chat message list, store entry, feedback
     def checkpoint(args, _unused = nil)
       name = args.empty? ? nil : args.join(' ').strip
 
@@ -50,6 +51,7 @@ module AIA
     alias cp checkpoint
 
     desc "Restore context to a previous checkpoint"
+    # :reek:TooManyStatements -- restore flow: name resolution, validation, per-chat message replacement, user feedback
     def restore(args, _unused = nil)
       name = args.empty? ? nil : args.join(' ').strip
 
@@ -107,44 +109,23 @@ module AIA
     end
 
     desc "Display the current conversation context with checkpoint markers"
-    # rubocop:disable Metrics/AbcSize
     def review(args, _unused = nil)
       chats = get_chats
       return "Error: No active chat sessions found." if chats.nil? || chats.empty?
 
-      first_chat = chats.values.first
-      messages = first_chat&.messages || []
-
-      puts "\n=== Chat Context (RubyLLM) ==="
-      puts "Total messages: #{messages.size}"
-      puts "Models: #{chats.keys.join(', ')}"
-      puts "Checkpoints: #{checkpoint_names.join(', ')}" if checkpoint_names.any?
-      puts
+      messages = chats.values.first&.messages || []
+      print_review_header(chats, messages.size)
 
       positions = checkpoint_positions
-
       messages.each_with_index do |msg, index|
-        if positions[index]
-          puts "📍 [Checkpoint: #{positions[index].join(', ')}]"
-          puts "-" * 40
-        end
-
-        role = msg.role.to_s.capitalize
-        content = format_message_content(msg)
-
-        puts "#{index + 1}. [#{role}]: #{content}"
-        puts
-      end
-
-      if positions[messages.size]
-        puts "📍 [Checkpoint: #{positions[messages.size].join(', ')}]"
-        puts "-" * 40
+        print_checkpoint_marker(positions[index])
+        print_review_message(msg, index)
       end
+      print_checkpoint_marker(positions[messages.size])
 
       puts "=== End of Context ==="
       ""
     end
-    # rubocop:enable Metrics/AbcSize
     alias context review
 
     desc "List all available checkpoints"
@@ -157,9 +138,10 @@ module AIA
       puts "\n=== Available Checkpoints ==="
       @checkpoint_store.each do |name, data|
         created = data[:created_at]&.strftime('%H:%M:%S') || 'unknown'
+        preview = data[:topic_preview]
         puts "  #{name}: position #{data[:position]}, created #{created}"
-        if data[:topic_preview] && !data[:topic_preview].empty?
-          puts "    → \"#{data[:topic_preview]}\""
+        if preview && !preview.empty?
+          puts "    → \"#{preview}\""
         end
       end
       puts "=== End of Checkpoints ==="
@@ -173,6 +155,27 @@ module AIA
       @checkpoint_store.keys
     end
 
+    def print_review_header(chats, total)
+      puts "\n=== Chat Context (RubyLLM) ==="
+      puts "Total messages: #{total}"
+      puts "Models: #{chats.keys.join(', ')}"
+      puts "Checkpoints: #{checkpoint_names.join(', ')}" if checkpoint_names.any?
+      puts
+    end
+
+    # Print the marker block when checkpoint names exist at this position.
+    def print_checkpoint_marker(names)
+      return unless names
+
+      puts "📍 [Checkpoint: #{names.join(', ')}]"
+      puts "-" * 40
+    end
+
+    def print_review_message(msg, index)
+      puts "#{index + 1}. [#{msg.role.to_s.capitalize}]: #{format_message_content(msg)}"
+      puts
+    end
+
     def checkpoint_positions
       positions = {}
       @checkpoint_store.each do |name, data|

data/lib/aia/directives/execution_directives.rb

@@ -13,9 +13,10 @@ module AIA
     desc "Execute Ruby code (requires allow_ruby_eval: true in config)"
     def ruby(args, context_manager = nil)
       unless AIA.config.flags.allow_ruby_eval
-        return "ERROR: /ruby is disabled. Set `allow_ruby_eval: true` in " \
-               "~/.aia/config.yml or pass --allow-ruby-eval to enable it. " \
-               "Note: this executes arbitrary Ruby with full process privileges."
+        puts "ERROR: /ruby is disabled. Set `allow_ruby_eval: true` in " \
+             "~/.aia/config.yml or pass --allow-ruby-eval to enable it. " \
+             "Note: this executes arbitrary Ruby with full process privileges."
+        return ""
       end
 
       ruby_code = args.join(' ')
@@ -35,10 +36,11 @@ module AIA
     desc "Use text-to-speech to speak the text"
     def say(args, context_manager = nil)
       audio = AIA.config.audio
+      voice = audio.voice
       env   = {}
       env['SPEECH_MODEL'] = audio.speech_model if audio.speech_model
-      if audio.voice && !audio.voice.strip.empty?
-        system(env, 'say', '-v', audio.voice, *args)
+      if voice && !voice.strip.empty?
+        system(env, 'say', '-v', voice, *args)
       else
         system(env, 'say', *args)
       end
@@ -80,17 +82,19 @@ module AIA
     desc "Spawn a specialist robot for the next prompt. " \
          "Usage: /spawn  |  /spawn <type>  |  /spawn <name> <provider/model> <system prompt>"
     def spawn(args, context_manager = nil)
-      AIA.turn_state.force_spawn = true
+      state = AIA.turn_state
+      state.force_spawn = true
 
       if args.size >= 2
         spec = AIA::SpawnSpecParser.parse(args)
-        AIA.turn_state.spawn_spec = spec
-        AIA.turn_state.spawn_type = nil
+        state.spawn_spec = spec
+        state.spawn_type = nil
         "Spawn mode enabled: '#{spec[:name]}' (#{spawn_model_summary(spec)}) for next prompt."
       else
-        AIA.turn_state.spawn_spec = nil
-        AIA.turn_state.spawn_type = args.first
-        type_msg = args.first ? " (#{args.first})" : " (auto-detect)"
+        type = args.first
+        state.spawn_spec = nil
+        state.spawn_type = type
+        type_msg = type ? " (#{type})" : " (auto-detect)"
         "Spawn mode enabled#{type_msg} for next prompt."
       end
     end
@@ -144,9 +148,10 @@ module AIA
 
     # Human-readable model description for the /spawn confirmation message.
     def spawn_model_summary(spec)
-      return 'inherited model' unless spec[:model]
+      model = spec[:model]
+      return 'inherited model' unless model
 
-      spec[:provider] ? "#{spec[:provider]}/#{spec[:model]}" : spec[:model]
+      spec[:provider] ? "#{spec[:provider]}/#{model}" : model
     end
 
     # Model plus any assigned skills, for the /add_recruit confirmation message.