ahl_scraper 0.3.4 → 0.3.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b20a1f72dc69a61ddd7568c5ef2eeca67f133bbcdd22f0e94d941ada6ee1e479
-  data.tar.gz: f3d310aee075a7cd08f3a8d329c359e974816287c4f768e231c4e50643dabc35
+  metadata.gz: 361ba81452b6f5f3ea306d74730190b602b058636e75c99a803c1873afb3f0d7
+  data.tar.gz: 1fea9a929d692523c9dde5f4bd243a6e9bf7bfff0ff38d7173534c199d0b03fc
 SHA512:
-  metadata.gz: e4b5912e8c6819fd3f45ff7a6f9919fe307ebdf7d554c27d2cebe6bd59452bb5a7f708f86b02bcee4fe1d2be33305264ef39a794d7d7ae5a8f8152b7a6bc4147
-  data.tar.gz: e99c4087b80330d517b2f73027e82a31b32941b1b5d36741c4be0f969fa2ce7bf9d1dbc7bf0beb12d0507a0f7bd3b01138d4df99c8b2186d06b2732d58ee5499
+  metadata.gz: a41ddd6414132e4c5e825854a1a45042dceab56fba3db9d853387de3630514062c5b059f353ae100e8ef738fb1163b61ef20e1ea1555c537998910d5b6d74237
+  data.tar.gz: dc54c30d399a754adfd755a6a83f519dd9ddf602f6281e74411be5c5821f370c137535aea987d9166dc65ddf71148499b00c15a26645dac107ee3db07365cf1a

data/CHANGELOG.md

@@ -1,28 +1,55 @@
 # CHANGELOG
 
+## 0.3.6
+
+### Game
+- Add `suspended` game status
+
+### PlayoffBrackets::Round
+
+- Add `started?` for when round has started (even if it is finished)
+- Add `active?` for when round has active series
+- Add `finished?` for when round has started and has no active series
+
+### PlayoffBrackets::Series
+
+- Fix `active?` to properly assess `active: "1"` meaning has started but not necessarily currently active
+- Added `started?` which now uses `active: "1"` to determine if the series has started
+- Set round one series win count needed to `2` for season `76`
+
+## 0.3.5
+
+### Developer
+
+- Add ability to use `rake console` to access gem in console to do manual testing
+
+### Seasons::Team
+
+- Add Coachella Valley Firebirds to naming hash
+
 ## 0.3.4
 
-## PlayoffBrackets::Series
+### PlayoffBrackets::Series
 
 - Add new series wins required for current playoffs (2022 with id `76`)
 
 ## 0.3.3
 
-## Developer
+### Developer
 
 - Added `.tool-versions` file for `asdf` package manager use
 
-## PlayoffBrackets::Round
+### PlayoffBrackets::Round
 
 - Add `active?` attribute which checks if any series is active, if so it returns truthy, else falsey
 
-## PlayoffBrackets::Series
+### PlayoffBrackets::Series
 
 - Add check for existance of team ids for `active?` attribute to be truthy
 
 ## 0.3.2
 
-## General
+### General
 
 - Changed `.split` to `&.split` and use `.dig` more to not fail when fields don't exist (often on games that have not finished)
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ahl_scraper (0.3.3)
+    ahl_scraper (0.3.6)
       json (~> 2.5.1)
       nokogiri (~> 1.12.4)
       rake (~> 13.0.0)
@@ -118,4 +118,4 @@ DEPENDENCIES
   webmock (>= 3.8.0)
 
 BUNDLED WITH
-   2.3.12
+   2.3.20

data/Rakefile

@@ -6,3 +6,7 @@ require "rspec/core/rake_task"
 RSpec::Core::RakeTask.new(:spec)
 
 task default: :spec
+
+task :console do
+  exec "irb -r ahl_scraper -I ./lib"
+end

data/lib/ahl_scraper/resources/game.rb

@@ -344,7 +344,12 @@ module AhlScraper
       irregular_game_status = IRREGULAR_GAMES.dig(game_id.to_s, :status)
       return irregular_game_status if irregular_game_status
 
-      return "postponed" if @raw_data.dig(:details, :status) == "Postponed"
+      game_status = @raw_data.dig(:details, :status)
+
+      return "suspended" unless game_status.match(/Suspended/).nil?
+
+      return "postponed" if game_status == "Postponed"
+
       # return "forfeited" if game is a forfeit, need to figure this out if it happens
 
       return "finished" if @raw_data.dig(:details, :final) == "1"

data/lib/ahl_scraper/resources/playoff_brackets/round.rb

@@ -23,13 +23,23 @@ module AhlScraper
         @round_type_name ||= @raw_data[:round_type_name]
       end
 
+      def series
+        @series ||= @raw_data[:matchups].map { |series| Series.new(series, { bracket_data: @opts[:bracket_data] }) }
+      end
+
+      def started?
+        @started = active? || finished? if @started.nil?
+        @started
+      end
+
       def active?
-        @active = series.filter(&:active?).any? if @active.nil?
+        @active = series.map(&:active?).any?(true) if @active.nil?
         @active
       end
 
-      def series
-        @series ||= @raw_data[:matchups].map { |series| Series.new(series, { bracket_data: @opts[:bracket_data] }) }
+      def finished?
+        @finished = series.map(&:finished?).none?(false) && !active? if @finished.nil?
+        @finished
       end
     end
   end

data/lib/ahl_scraper/resources/playoff_brackets/series.rb

@@ -13,7 +13,7 @@ module AhlScraper
         "7" => { "1" => 4 },
         "69" => { "1" => 4 },
         "72" => { "1" => 1, "2" => 1, "3" => 2, "4" => 2 },
-        "76" => { "1" => 3, "2" => 3, "3" => 4, "4" => 4, "5" => 4 },
+        "76" => { "1" => 2, "2" => 3, "3" => 4, "4" => 4, "5" => 4 },
       }.freeze
 
       def id
@@ -24,6 +24,10 @@ module AhlScraper
         @name ||= @raw_data[:series_name]
       end
 
+      def season_id
+        @season_id ||= find_season_id
+      end
+
       def logo_url
         @logo_url ||= @raw_data[:series_logo]
       end
@@ -32,8 +36,14 @@ module AhlScraper
         @round ||= @raw_data[:round].to_i
       end
 
+      def started?
+        @started = @raw_data[:active] == "1" if @started.nil?
+        @started
+      end
+
       def active?
-        @active ||= @raw_data[:active] == "1" && team_ids_present? && team1_wins < wins_needed && team2_wins < wins_needed
+        @active ||= team_ids_present? && team1_wins < wins_needed && team2_wins < wins_needed if @active.nil?
+        @active
       end
 
       def home_feeder_series
@@ -75,11 +85,24 @@ module AhlScraper
       end
 
       def wins_needed
-        @wins_needed ||= OVERRIDE_WINS_NEEDED.dig(season_id, round.to_s) || (round == 1 ? 3 : 4)
+        @wins_needed ||= OVERRIDE_WINS_NEEDED.dig(season_id.to_s, round.to_s) || (round == 1 ? 3 : 4)
+      end
+
+      def finished?
+        @finished = winning_team_id.present? if @finished.nil?
+        @finished
       end
 
       private
 
+      def find_season_id
+        dig_season_id = @opts.dig(:bracket_data, :rounds, round - 1, :season_id)
+
+        return if dig_season_id.nil? || dig_season_id.empty?
+
+        dig_season_id.to_i
+      end
+
       def first_game
         @first_game ||= @raw_data.dig(:games, 0)
       end
@@ -92,10 +115,6 @@ module AhlScraper
         nil
       end
 
-      def season_id
-        @opts.dig(:bracket_data, :rounds, round - 1, :season_id)
-      end
-
       def team1
         @team1 ||= @raw_data[:team1].to_i.zero? ? nil : @raw_data[:team1].to_i
       end
@@ -105,7 +124,7 @@ module AhlScraper
       end
 
       def team_ids_present?
-        team1 && team2
+        !team1.nil? && !team2.nil?
       end
 
       def team1_wins

data/lib/ahl_scraper/resources/seasons/team.rb

@@ -26,6 +26,7 @@ module AhlScraper
         "wilkes-barre-scranton-penguins" => { city: "Wilkes-Barre/Scranton", name: "Penguins", game_file_city: "W-B/Scranton" },
         "edmonton-road-runners" => { city: "Edmonton", name: "Road Runners" },
         "henderson-silver-knights" => { city: "Henderson", name: "Silver Knights" },
+        "coachella-valley-firebirds" => { city: "Coachella Valley", name: "Firebirds" },
       }.freeze
 
       def initialize(raw_data, division, opts = {})

data/lib/ahl_scraper/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AhlScraper
-  VERSION = "0.3.4"
+  VERSION = "0.3.6"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ahl_scraper
 version: !ruby/object:Gem::Version
-  version: 0.3.4
+  version: 0.3.6
 platform: ruby
 authors:
 - jefftcraig
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-07-01 00:00:00.000000000 Z
+date: 2022-10-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json