ahl_scraper 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 285012122b98f5d30bb129fb94766a02405f10217340001caea0627be4422075
-  data.tar.gz: f52ca819c0d8c6c7882639aa143695f54cd8d4c8c3f8baac9f1ccf58796e0a6e
+  metadata.gz: 8fc138bb02a9563b2b9a4940a15dd9bd6e56f56d5b7352bddbb09fb2a63a7c0d
+  data.tar.gz: 4292c6ed3cd9c4da7f92aa6b861fa2d40a7cc1c933962c8c55610e34819317f0
 SHA512:
-  metadata.gz: 2daa503ec4b26ce5f50979394ca64de5a8b9be4fdb1c9df792ef5746abfcae38fd58613132bdb8de2336643844d8624e12aec70f1b703b5ad9f1dbb5416d8496
-  data.tar.gz: 8419279fb2c98a65d54b5103052ee54eb9dfc2a7570db1e29decfac10a635af820fbe2ca369664a3bc0585afb221ec8b92dfafd1130892fc066249f228debd5a
+  metadata.gz: cc5998864a75a5a351c2f42eb97066340e681024af5da5d766077dc80d581a5c767340aa9b5125d06da1e40cd615e1c7805d86a831b28f5174d3632dd6d6f14f
+  data.tar.gz: 8cb1e8fa0b79e50bacf1b4755120f3e41382b8f1b0fb542352af6ea744e62719b2c0b9cb821631c3efa3ffdef1491828742a519023b7eb9d300689f947a526ec

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 # CHANGELOG
 
+## 0.3.2
+
+## General
+
+- Changed `.split` to `&.split` and use `.dig` more to not fail when fields don't exist (often on games that have not finished)
+
+### Game::Goalie
+
+- Fix penalty minutes not being copied to the object because of a typo
+
 ## 0.3.1
 
 ### Scoreboards

data/lib/ahl_scraper/helpers/ice_time_helper.rb

@@ -9,7 +9,9 @@ module AhlScraper
     end
 
     def to_seconds
-      ice_time = time.split(":")
+      return unless time
+
+      ice_time = time&.split(":")
       ice_time[0].to_i * 60 + ice_time[1].to_i
     end
 

data/lib/ahl_scraper/helpers/period_time_helper.rb

@@ -10,12 +10,16 @@ module AhlScraper
     end
 
     def to_period_seconds
-      period_time = time.split(":")
+      return unless time
+
+      period_time = time&.split(":")
       period_time[0].to_i * 60 + period_time[1].to_i
     end
 
     def to_time_elapsed
-      period_time = time.split(":")
+      return unless time
+
+      period_time = time&.split(":")
       period_time[0].to_i * 60 + period_time[1].to_i + ((period - 1) * 1200)
     end
 

data/lib/ahl_scraper/resources/game.rb

@@ -344,12 +344,12 @@ module AhlScraper
       irregular_game_status = IRREGULAR_GAMES.dig(game_id.to_s, :status)
       return irregular_game_status if irregular_game_status
 
-      return "postponed" if @raw_data[:details][:status] == "Postponed"
+      return "postponed" if @raw_data.dig(:details, :status) == "Postponed"
       # return "forfeited" if game is a forfeit, need to figure this out if it happens
 
-      return "finished" if @raw_data[:details][:final] == "1"
+      return "finished" if @raw_data.dig(:details, :final) == "1"
 
-      return "in_progress" if @raw_data[:details][:started] == "1"
+      return "in_progress" if @raw_data.dig(:details, :started) == "1"
 
       "not_started"
     end

data/lib/ahl_scraper/resources/games/goalie.rb

@@ -44,7 +44,7 @@ module AhlScraper
           goals: @raw_data[:stats][:goals],
           assists: @raw_data[:stats][:assists],
           points: @raw_data[:stats][:points],
-          penalty_minutes: @raw_data[:stats][:penaltyMinute],
+          penalty_minutes: @raw_data[:stats][:penaltyMinutes],
           toi: @raw_data[:stats][:timeOnIce],
           toi_in_seconds: set_time_on_ice_in_seconds,
           shots_against: @raw_data[:stats][:shotsAgainst],

data/lib/ahl_scraper/resources/games/penalty_shot.rb

@@ -72,11 +72,6 @@ module AhlScraper
       def period_time
         @period_time ||= PeriodTimeHelper.new(time, period)
       end
-
-      def convert_time(game_time)
-        time = game_time.split(":")
-        time[0].to_i * 60 + time[1].to_i
-      end
     end
   end
 end

data/lib/ahl_scraper/resources/seasons/team.rb

@@ -51,11 +51,11 @@ module AhlScraper
       end
 
       def city
-        @city ||= full_name.split.length > 2 ? exception_split_object&.dig(:city) : full_name.split[0]
+        @city ||= full_name&.split.length > 2 ? exception_split_object&.dig(:city) : full_name&.split[0]
       end
 
       def name
-        @name ||= full_name.split.length > 2 ? exception_split_object&.dig(:name) : full_name.split[1]
+        @name ||= full_name&.split.length > 2 ? exception_split_object&.dig(:name) : full_name&.split[1]
       end
 
       def game_file_city

data/lib/ahl_scraper/services/games/penalty_shots_service.rb

@@ -17,14 +17,9 @@ module AhlScraper
 
       def ordered_penalty_shots
         @ordered_penalty_shots ||= penalty_shot_data.sort do |a, b|
-          [a[:period][:id].to_i, convert_time(a[:time])] <=> [b[:period][:id].to_i, convert_time(b[:time])]
+          [a[:period][:id].to_i, IceTimeHelper.new(a[:time]).to_sec] <=> [b[:period][:id].to_i, IceTimeHelper.new(b[:time]).to_sec]
         end
       end
-
-      def convert_time(game_time)
-        time = game_time.split(":")
-        time[0].to_i * 60 + time[1].to_i
-      end
     end
   end
 end

data/lib/ahl_scraper/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AhlScraper
-  VERSION = "0.3.1"
+  VERSION = "0.3.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ahl_scraper
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - jefftcraig
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-11-07 00:00:00.000000000 Z
+date: 2022-03-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json