ahl_scraper 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f6e565f0a3b14eb3c5d568b3012407bbcb3439dc4d1447938e6f4c2618ebf65f
-  data.tar.gz: ff93eaf9c4ae5fd738f2445ab2644162411679a07b00912e5bde5a35a31079e5
+  metadata.gz: 878af541d3e623e6e74955e4edb4fcb713b1ea05b6c536eac092508fce031914
+  data.tar.gz: bf55cecdad52ef86b8a133ae920cbd1c40d0fd95beffe75a804f03e3163091bc
 SHA512:
-  metadata.gz: 34b7c1208b927e5801670427ee12642e86d31ff078463ba188ff5a31e431b5c6e7ea65d9705371c7a87dc77a1b7f2b13e37992a156494e0e2b73372accc00b9d
-  data.tar.gz: 48f9dfc8a50cc7dcf5cf7be3944eb965f14e34d3d991e65163a9f030894a29015bcab485214488178bce2a4bcccf904253d9c2b7132e1c8230cd8bec6974df88
+  metadata.gz: 7d0270faf84de38e464e30aebc1e8db595f2310b3bf2a950573c538acee01cf766b3e06b4293f3aacfe2db1177a4f08164bc610a13a6e4406ca3dac3351f69fa
+  data.tar.gz: e603bcb1f39ff49d68968a325aaa044d8287d9e0b40c1c72d9e61d79033d83d2cc03ca31717e28096516f9b05700922042a3679342a64b59c71ad9cdda5b6e24

data/CHANGELOG.md

@@ -0,0 +1,18 @@
+# CHANGELOG
+
+## 0.2.0
+
+### RosterPlayers
+
+- Changed `shoots` to `handedness` and fixed value so that goalies get a proper handedness
+
+### Players
+
+- Merged `shoots` and `catches` into `handedness` attribute
+
+### Penalties
+
+- Uses AHL id under the `id` attribute
+- Add `penalty_shot` type
+- Add `bench?` for bench related penalties
+- Add `invalid?` for tagging broken penalties that can be skipped

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ahl_scraper (0.1.0)
+    ahl_scraper (0.2.0)
 
 GEM
   remote: https://rubygems.org/
@@ -111,4 +111,4 @@ DEPENDENCIES
   webmock (>= 3.8.0)
 
 BUNDLED WITH
-   2.1.4
+   2.2.17

data/README.md

@@ -136,7 +136,7 @@ Returns a `Player` object which has full details on a player by passing their id
 require "ahl_scraper"
 AhlScraper::Players.retrieve(6845)
 
-#=> #<Player:0x4b8c {:id=>6845, :current_age=>0.2534e2, :position=>"D", :first_name=>"Sebastian", :shoots=>"L", :last_name=>"Aho", :birthplace=>"Umea, Sweden", :height=>"5-11", :birthdate=>"1996-02-17", :draft_year=>2014, :weight=>177, :catches=>"R", :name=>"Sebastian Aho", :jersey_number=>28}>
+#=> #<Player:0x4b8c {:id=>6845, :current_age=>0.2534e2, :position=>"D", :first_name=>"Sebastian", :handedness=>"L", :last_name=>"Aho", :birthplace=>"Umea, Sweden", :height=>"5-11", :birthdate=>"1996-02-17", :draft_year=>2014, :weight=>177, :name=>"Sebastian Aho", :jersey_number=>28}>
 ```
 
 ### Teams
@@ -182,9 +182,9 @@ Returns an array of `RosterPlayer` objects which provide information on all of a
 require "ahl_scraper"
 AhlScraper::RosterPlayers.retrieve_all(335, 68)
 
-#=> [#<RosterPlayer:0x3c3c {:id=>6379, :current_age=>0.2521e2, :season_id=>68, :position=>"C", :shoots=>"L", :birthplace=>"Saskatoon, SK", :birthdate=>"1996-04-03", :height=>"6-0", :draft_year=>2014, :weight=>203, :rookie?=>false, :team_id=>335, :name=>"Rourke Chartier", :jersey_number=>15}>,
- #<RosterPlayer:0x3c50 {:id=>1844, :current_age=>0.3416e2, :season_id=>68, :position=>"LW", :shoots=>"L", :birthplace=>"Toronto, ON", :birthdate=>"1987-04-25", :height=>"5-11", :draft_year=>2005, :weight=>207, :rookie?=>false, :team_id=>335, :name=>"Richard Clune", :jersey_number=>17}>,
- #<RosterPlayer:0x3c64 {:id=>5660, :current_age=>0.2914e2, :season_id=>68, :position=>"LW", :shoots=>"L", :birthplace=>"Morristown, NJ", :birthdate=>"1992-04-30", :height=>"6-0", :draft_year=>2010, :weight=>200, :rookie?=>false, :team_id=>335, :name=>"Kenny Agostino", :jersey_number=>18}>,
+#=> [#<RosterPlayer:0x3c3c {:id=>6379, :current_age=>0.2521e2, :season_id=>68, :position=>"C", :handedness=>"L", :birthplace=>"Saskatoon, SK", :birthdate=>"1996-04-03", :height=>"6-0", :draft_year=>2014, :weight=>203, :rookie?=>false, :team_id=>335, :name=>"Rourke Chartier", :jersey_number=>15}>,
+ #<RosterPlayer:0x3c50 {:id=>1844, :current_age=>0.3416e2, :season_id=>68, :position=>"LW", :handedness=>"L", :birthplace=>"Toronto, ON", :birthdate=>"1987-04-25", :height=>"5-11", :draft_year=>2005, :weight=>207, :rookie?=>false, :team_id=>335, :name=>"Richard Clune", :jersey_number=>17}>,
+ #<RosterPlayer:0x3c64 {:id=>5660, :current_age=>0.2914e2, :season_id=>68, :position=>"LW", :handedness=>"L", :birthplace=>"Morristown, NJ", :birthdate=>"1992-04-30", :height=>"6-0", :draft_year=>2010, :weight=>200, :rookie?=>false, :team_id=>335, :name=>"Kenny Agostino", :jersey_number=>18}>,
  #...
  #]
 ```

data/lib/ahl_scraper/resources/games/penalty.rb

@@ -3,12 +3,16 @@
 module AhlScraper
   module Games
     class Penalty < Resource
+      def id
+        @id ||= @raw_data.dig(:game_penalty_id)&.to_i
+      end
+
       def number
         @number ||= @opts[:number]
       end
 
       def period
-        @period ||= @raw_data.dig(:period, :id).to_i
+        @period ||= @raw_data.dig(:period, :id)&.to_i
       end
 
       def time
@@ -70,12 +74,22 @@ module AhlScraper
       end
 
       def power_play?
-        @power_play ||= @raw_data[:isPowerPlay]
+        @raw_data[:isPowerPlay]
+      end
+
+      def bench?
+        @raw_data[:isPowerPlay]
+      end
+
+      def invalid?
+        [240_773].include? id
       end
 
       def penalty_type
         @penalty_type ||=
           case @raw_data[:description]
+          when /penalty shot/i
+            :penalty_shot
           when /double minor/i
             :double_minor
           when /major/i

data/lib/ahl_scraper/resources/player.rb

@@ -22,12 +22,8 @@ module AhlScraper
       @last_name ||= @raw_data.dig(:info, :lastName)
     end
 
-    def shoots
-      @shoots ||= @raw_data.dig(:info, :shoots)
-    end
-
-    def catches
-      @catches ||= @raw_data.dig(:info, :catches)
+    def handedness
+      @handedness ||= position == "G" ? @raw_data.dig(:info, :catches) : @raw_data.dig(:info, :shoots)
     end
 
     def birthplace

data/lib/ahl_scraper/resources/roster_player.rb

@@ -18,8 +18,8 @@ module AhlScraper
       @name ||= @raw_data.dig(:bio, :row, :name)
     end
 
-    def shoots
-      @shoots ||= @raw_data.dig(:bio, :row, :shoots)
+    def handedness
+      @handedness ||= position == "G" ? @raw_data.dig(:bio, :row, :catches) : @raw_data.dig(:bio, :row, :shoots)
     end
 
     def birthplace

data/lib/ahl_scraper/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AhlScraper
-  VERSION = "0.1.1"
+  VERSION = "0.2.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ahl_scraper
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - jefftcraig
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-06-21 00:00:00.000000000 Z
+date: 2021-07-18 00:00:00.000000000 Z
 dependencies: []
 description: Allows users to gather game, season, and player data from the AHL website
 email:
@@ -24,6 +24,7 @@ files:
 - ".solargraph.yml"
 - ".travis.yml"
 - ".vscode/settings.json"
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
 - Gemfile.lock