aguids-positionable 0.2.1

data/test/rails_root/test/performance/browsing_test.rb

@@ -0,0 +1,9 @@
+require 'test_helper'
+require 'performance_test_help'
+
+# Profiling results for each test method are written to tmp/performance.
+class BrowsingTest < ActionController::PerformanceTest
+  def test_homepage
+    get '/'
+  end
+end

data/test/rails_root/test/scoped_tests.rb

@@ -0,0 +1,53 @@
+module ScopedTests
+  
+  def test_scoped_insert
+    item = create(170)
+    assert item.in_list?
+    assert item.first?
+    assert item.last?
+    assert_equal 1, item.list_position
+  end
+  
+  # Unescoped Tests
+  def test_unescoped_insert
+    item = create(nil)
+    assert item.in_list?
+    assert item.first?
+    assert item.last?
+    assert_equal 1, item.list_position
+    
+    item_2 = create(nil)
+    assert item_2.in_list?
+    assert !item_2.first?
+    assert item_2.last?
+    assert_equal 2, item_2.list_position
+  end
+  
+  # Scope Changed Tests
+  def test_scoped_should_remove_from_previous_list_after_scope_change
+    @items.second.parent_id = 170; @items.second.save
+    assert @items.second.in_list?
+    assert @items.second.first?
+    assert_equal_ids [1,3,4]
+  end
+  
+  def test_scoped_should_add_to_new_list_bottoms_position
+    @items.second.parent_id = 170; @items.second.save
+    @items.second.parent_id = @items.first.parent_id; @items.second.save
+    assert @items.second.last?
+    assert_equal_ids [1,3,4,2]
+  end
+  
+  def test_scoped_changed_to_nil_scope
+    @items.second.parent_id = nil; @items.second.save
+    assert @items.second.in_list?
+    assert @items.second.first?
+  end
+  
+  def test_scoped_changed_from_nil
+    @items.second.parent_id = nil; @items.second.save
+    @items.second.parent_id = @items.first.parent_id; @items.second.save
+    assert @items.second.last?
+    assert_equal_ids [1,3,4,2]
+  end
+end

data/test/rails_root/test/simple_gap_tests.rb

@@ -0,0 +1,17 @@
+module SimpleGapTests
+  # Insert and Remove Tests
+  def test_simple_gap_items_should_have_gaps
+    assert_equal @ids, ordered_ids
+    1.upto(3) do |index|
+      assert @items[index].in_list?
+      assert_not_equal @items[index-1].list_position + 1, @items[index].list_position
+    end
+  end
+  
+  # TODO: test move_up move_down with gaps
+  # => Should move clear gaps?
+  
+  # TODO: test insert_at and gaps
+  # => Should it take the place of the gap?
+  # => or should it shift lower items despite the gap
+end

data/test/rails_root/test/simple_gapless_tests.rb

@@ -0,0 +1,52 @@
+module SimpleGaplessTests
+  # Insert and Remove Tests
+  def test_simple_gapless_insert_on_list_after_create
+    assert_equal @ids, ordered_ids
+    @items.each_with_index do |item, index|
+      assert item.in_list?
+    end
+    assert_equal [1,2,3,4], positions
+  end
+  
+  def test_simple_gapless_insert_at
+    @items.fourth.insert_at(@items.second.list_position)
+    # List: [1,4,2,3]
+    assert_equal [1,3,4,2], positions
+    
+    @items.first.insert_at(@items.third.list_position)
+    # List: [4,2,3,1]
+    assert_equal [4,2,3,1], positions
+    
+    @items.third.insert_at(@items.fourth.list_position)
+    # List: [3,4,2,1]
+    assert_equal [4,3,1,2], positions
+    
+    @items.second.insert_at(@items.fourth.list_position)
+    # List: [3,2,4,1]
+    assert_equal [4,2,1,3], positions
+  end
+
+  def test_simple_gapless_remove_from_list
+    @items.second.remove_from_list
+    # List: [1,3,4]
+    assert_equal [1,nil,2,3], positions
+  end
+
+  def test_simple_gapless_remove_from_list_after_destroy
+    @items.second.destroy
+    # List: [1,3,4]
+    assert_equal [1,2,3], positions(@items.second)
+  end
+  
+  def test_simple_gapless_remove_from_list_shifts_lower_items_up
+    @items.first.remove_from_list
+    # List: [2,3,4]
+    assert_equal [nil,1,2,3], positions
+  end
+  
+  def test_simple_gapless_destroy_shifts_lower_items_up
+    @items.first.destroy
+    # List: [2,3,4]
+    assert_equal [1,2,3], positions(@items.first)
+  end
+end

data/test/rails_root/test/simple_tests.rb

@@ -0,0 +1,185 @@
+module SimpleTests
+  
+  # Insert and Remove Tests
+  def test_simple_insert_at
+    @items.fourth.insert_at(@items.second.list_position)
+    reload_items
+    assert_equal_ids [1,4,2,3]
+    
+    @items.first.insert_at(@items.third.list_position)
+    reload_items
+    assert_equal_ids [4,2,3,1]
+    
+    @items.third.insert_at(@items.fourth.list_position)
+    reload_items
+    assert_equal_ids [3,4,2,1]
+    
+    @items.second.insert_at(@items.fourth.list_position)
+    reload_items
+    assert_equal_ids [3,2,4,1]
+  end
+  
+  def test_simple_insert_at_should_convert_index_higher_than_first_to_first
+    @items.third.insert_at(0)
+    assert @items.third.first?
+    @items.fourth.insert_at(-5)
+    assert @items.fourth.first?
+  end
+  
+  def test_simple_insert_at_should_convert_index_lower_than_last_to_last
+    @items.second.insert_at(@items.last.list_position + 1)
+    assert @items.second.last?
+    @items.first.insert_at(40)
+    assert @items.first.last?
+  end
+
+  def test_simple_insert_at_should_insert_item_as_first_if_empty_list
+    @items.each { |item| item.remove_from_list }
+    item = @items.fourth
+    item.insert_at(2)
+    assert item.first?
+    assert item.last?
+    assert_equal 1, item.list_position
+  end
+  
+  def test_simple_insert_at_should_accept_symbols
+    @items.third.insert_at(:top)
+    assert @items.third.first?
+    
+    @items.third.insert_at(:bottom)
+    assert @items.third.last?
+    
+    @items.fourth.insert_at(:first)
+    assert @items.fourth.first?
+    
+    @items.fourth.insert_at(:last)
+    assert @items.fourth.last?
+  end
+  
+  def test_simple_insert_at_top
+    @items.second.insert_at_top
+    assert @items.second.first?
+  end
+
+  def test_simple_insert_at_bottom
+    @items.second.insert_at_bottom
+    assert @items.second.last?
+  end
+
+  def test_simple_remove_from_list
+    @items.second.remove_from_list
+    assert !@items.second.in_list?
+    assert_nil @items.second.list_position
+    assert_equal_ids [1,3,4]
+  end
+
+  def test_simple_remove_from_list_after_destroy
+    @items.second.destroy
+    assert_equal_ids [1,3,4]
+  end
+
+  def test_simple_remove_before_destroy_does_not_shift_lower_items_twice
+    @items.second.remove_from_list
+    @items.second.destroy
+    assert_equal_ids [1,3,4]
+    third_item_position  = @items.third.list_position
+    fourth_item_position = @items.fourth.list_position
+    reload_items(@items.second)
+    assert_equal third_item_position - 1, @items.third.list_position
+    assert_equal fourth_item_position - 1, @items.fourth.list_position
+  end
+  
+  def test_simple_create_after_destroy_doesnt_introduce_gap
+    @items.fourth.destroy
+    new_item = create(@items.first.respond_to?(:parent_id) ? @items.first.parent_id : nil)
+    assert_equal @items.third.list_position + 1, new_item.list_position
+  end
+  
+  def test_simple_create_after_remove_doesnt_introduce_gap
+    @items.fourth.remove_from_list
+    new_item = create(@items.first.respond_to?(:parent_id) ? @items.first.parent_id : nil)
+    assert_equal @items.third.list_position + 1, new_item.list_position
+  end
+
+  # Move Tests
+  def test_simple_move_down
+    @items.second.move_down
+    assert_equal_ids [1,3,2,4]
+  end
+
+  def test_simple_move_up
+    @items.third.move_up
+    assert_equal_ids [1,3,2,4]
+  end
+
+  def test_simple_move_to_bottom
+    @items.second.move_to_bottom
+    assert_equal_ids [1,3,4,2]
+  end
+  
+  def test_simple_move_to_bottom_should_not_introduce_gap
+    last_position = @items.fourth.list_position
+    @items.second.move_to_bottom
+    reload_items
+    assert_equal last_position, @items.second.list_position
+  end
+
+  def test_simple_move_to_top
+    @items.third.move_to_top
+    assert_equal_ids [3,1,2,4]
+  end
+  
+  # First? Last? Tests
+  def test_simple_first?
+    assert @items.first.first?
+  end
+  
+  def test_simple_last?
+    assert @items.fourth.last?
+  end
+  
+  def test_simple_not_first?
+    assert !@items.second.first?
+  end
+  
+  def test_simple_not_last?
+    assert !@items.third.last?
+  end
+  
+  def test_simple_deleted_first?
+    @items.first.destroy
+    assert @items.second.reload.first?
+  end
+  
+  def test_simple_deleted_last?
+    @items.fourth.destroy
+    assert @items.third.reload.last?
+  end
+  
+  def test_simple_removed_first?
+    @items.first.remove_from_list
+    assert @items.second.reload.first?
+  end
+  
+  def test_simple_removed_last?
+    @items.fourth.remove_from_list
+    assert @items.third.reload.last?
+  end
+  
+  # Previous Next Tests
+  def test_simple_get_next_item
+    assert_equal @items.second, @items.first.next_item
+  end
+
+  def test_simple_should_get_previous_item
+    assert_equal @items.second, @items.third.previous_item
+  end
+  
+  def test_simple_should_not_get_next_item_if_last_item
+    assert_nil @items.fourth.next_item
+  end
+  
+  def test_simple_should_not_get_previous_item_if_first_item
+    assert_nil @items.first.previous_item
+  end
+end

data/test/rails_root/test/test_helper.rb

@@ -0,0 +1,37 @@
+ENV["RAILS_ENV"] = "test"
+require File.expand_path(File.dirname(__FILE__) + "/../config/environment")
+require 'test_help'
+
+require 'simple_tests'
+require 'simple_gapless_tests'
+require 'simple_gap_tests'
+require 'scoped_tests'
+require 'conditional_tests'
+
+class ActiveSupport::TestCase
+  self.use_transactional_fixtures = true
+  self.use_instantiated_fixtures  = false
+  
+  # Asserts expected items ids order matches the actual items ids ordered by position
+  def assert_equal_ids(expected, *args)
+    if args.empty?
+      assert_equal expected.map{ |index| @ids[index-1]}, ordered_ids
+    elsif !@ids.is_a?(Hash)
+      assert_equal expected.map{ |index| @ids[index-1]}, ordered_ids(args.first)
+    else
+      assert_equal expected.map{ |index| @ids[args.first][index-1]}, ordered_ids(args.first)
+    end
+  end
+  
+  def reload_items(except=nil)
+    @items.each { |item| item.reload unless item == except}
+  end
+  
+  def positions(except=nil)
+    reload_items(except)
+    @items.reject do |item|
+      item == except
+    end.map(&:list_position)
+  end
+end
+

data/test/rails_root/test/unit/conditional_item_test.rb

@@ -0,0 +1,36 @@
+require 'test_helper'
+
+class ConditionalItemTest < ActiveSupport::TestCase
+  def setup
+    8.times { |index| (index % 2) > 0 ? ConditionalItem.create(:tag => 'todo') : ConditionalItem.create(:tag => 'bad')}
+    @items = ConditionalItem.find(:all, :conditions => "position IS NOT NULL", :order => 'id')
+    @ids = @items.map(&:id)
+  end
+  
+  include SimpleTests
+  include SimpleGaplessTests
+  include ConditionalTests
+  
+  protected
+    def ordered_ids
+      ConditionalItem.find(:all, :order => 'position', :conditions => "position IS NOT NULL").map(&:id)
+    end
+    
+    def create(tag, *args)
+      ConditionalItem.create(:tag => tag || 'todo')
+    end
+    
+    def create_with_conditions_not_met
+      create('bad_tag')
+    end
+    
+    def fail_conditions(item)
+      item.tag = 'bad_tag'
+      item.save
+    end
+    
+    def pass_conditions(item)
+      item.tag = 'todo'
+      item.save
+    end
+end

data/test/rails_root/test/unit/different_position_column_item_test.rb

@@ -0,0 +1,21 @@
+require 'test_helper'
+
+class DifferentPositionColumnItemTest < ActiveSupport::TestCase
+  def setup
+    4.times { DifferentPositionColumnItem.create }
+    @items = DifferentPositionColumnItem.find(:all, :order => 'id')
+    @ids = @items.map(&:id)
+  end
+ 
+  include SimpleTests
+  include SimpleGaplessTests
+  
+  protected
+    def ordered_ids
+      DifferentPositionColumnItem.find(:all, :order => 'different_position', :conditions => 'different_position IS NOT NULL').map(&:id)
+    end
+    
+    def create(*args)
+      DifferentPositionColumnItem.create
+    end
+end

data/test/rails_root/test/unit/eval_support_test.rb

@@ -0,0 +1,62 @@
+require 'test_helper'
+
+class EvalSupportTest < ActiveSupport::TestCase
+  
+  # Hash Tests
+  def test_hash_string
+    assert_equal "tag == 'todo'", conditions({:tag => 'todo'})
+  end
+  
+  def test_hash_number
+    assert_equal "parent_id == 17", conditions({:parent_id => 17})
+  end
+  
+  def test_hash_true
+    assert_equal "published == true", conditions({:published => true})
+  end
+  
+  def test_hash_false
+    assert_equal "published == false", conditions({:published => false})
+  end
+  
+  def test_nil_value
+    assert_equal "parent_id == nil", conditions({:parent_id => nil})
+  end
+  
+  def test_hash_multiple_conditions
+    assert_include ["tag == 'todo'", "&&", "parent_id == 17"], conditions({:tag => 'todo', :parent_id => 17})
+  end
+  
+  # Array Tests
+  def test_array_equal_string
+    assert_equal "tag == 'todo'", conditions(["tag = ?", 'todo'])
+  end
+  
+  def test_array_greater_number
+    assert_equal "count >= 17", conditions(["count >= ?", 17])
+  end
+  
+  def test_array_multiple_conditions_with_and
+    assert_include ["tag == 'todo'", "&&", "parent_id >= 17"], conditions(["tag = ? AND parent_id >= ?", 'todo', 17])
+  end
+  
+  def test_array_multiple_conditions_with_or
+    assert_include ["tag == 'todo'", "||", "parent_id >= 17"], conditions(["tag = ? OR parent_id >= ?", 'todo', 17])
+  end
+  
+  # String Tests
+  def test_string_multiple_conditions
+    assert_include ["tag == 'todo'", "&&", "parent_id >= 17"], conditions("tag = 'todo' AND parent_id >= 17")
+  end
+  
+  protected
+    def conditions(cond)
+      Positionable::EvalSupport.conditions_to_eval(cond)
+    end
+    
+    def assert_include(arr, string)
+      arr.each do |arr|
+        assert_match arr, string
+      end
+    end
+end

data/test/rails_root/test/unit/hell_on_earth_item_test.rb

@@ -0,0 +1,71 @@
+require 'test_helper'
+
+class HellOnEarthItemTest < ActiveSupport::TestCase
+  def setup
+    @items = {}
+    @ids = {}
+    4.times do
+      HellOnEarthItem.create :parent_id => 1, :session_id => 1, :published => true
+    end
+    4.times do |index|
+      HellOnEarthItem.create :parent_id => 1, :published => false, :tag => index % 2 > 0 ? 'todo' : 'done'
+    end
+
+    @items[:default] = HellOnEarthItem.find(:all, :order => 'id', :conditions => {:parent_id => 1, :session_id => 1})
+    @ids[:default] = @items[:default].map(&:id)
+    
+    @items[:client] = HellOnEarthItem.find(:all, :order => 'id', :conditions => {:parent_id => 1, :published => false})
+    @ids[:client] = @items[:client].map(&:id)
+
+    @items[:developer] = HellOnEarthItem.find(:all, :order => 'id', :conditions => {:parent_id => 1, :published => false, :tag => 'todo'})
+    @ids[:developer] = @items[:developer].map(&:id)
+  end
+
+  def test_complex_creation
+    assert_equal_ids [1,2,3,4], :default
+    assert_equal_ids [1,2,3,4], :client
+    assert_equal_ids [1,2], :developer
+  end
+  
+  def test_complex_conditions
+    assert !@items[:default].first.in_list?(:client)
+    assert !@items[:default].first.in_list?(:developer)
+    
+    assert !@items[:client].first.in_list?(:default)
+    
+    assert @items[:developer].first.in_list?(:client)
+  end
+  
+  def test_complex_removal
+    @items[:developer].first.remove_from_list(:client)
+    assert @items[:developer].first.in_list?(:client)
+    assert @items[:developer].first.in_list?(:developer)
+  end
+  
+  def test_complex_conditions_update
+    @items[:default].first.published = false; @items[:default].first.save
+    assert !@items[:default].first.in_list?(:default)
+    assert @items[:default].first.in_list?(:client)
+    
+    @items[:developer].first.tag = 'done'; @items[:developer].first.save
+    assert !@items[:developer].first.in_list?(:developer)
+    assert @items[:developer].first.in_list?(:client)
+  end
+
+  protected
+    def ordered_ids(list_name)
+      send "#{list_name}_ordered_ids"
+    end
+    
+    def default_ordered_ids
+      HellOnEarthItem.find(:all, :order => 'position', :conditions => "position IS NOT NULL AND parent_id = 1 AND session_id = 1 AND published = 't'").map(&:id)
+    end
+
+    def client_ordered_ids
+      HellOnEarthItem.find(:all, :order => 'client_position', :conditions => "client_position IS NOT NULL AND parent_id = 1 AND published = 'f'").map(&:id)
+    end
+
+    def developer_ordered_ids
+      HellOnEarthItem.find(:all, :order => 'developer_position', :conditions => "developer_position IS NOT NULL AND parent_id = 1 AND published = 'f' AND tag = 'todo'").map(&:id)
+    end
+end

data/test/rails_root/test/unit/helpers/positionable_helper_test.rb

@@ -0,0 +1,69 @@
+require 'test_helper'
+
+class PositionableHelperTest < ActionView::TestCase
+  def protect_against_forgery?
+  end
+   
+  def setup
+    @host = 'http://test.host'
+    @item = MultipleListItem.create
+    @controller = TestController.new
+  end
+  
+  %w( move_lower move_down move_higher move_up move_to_bottom insert_at_bottom
+      move_to_top insert_at_top insert_at remove_from_list).each do |action|
+    test "#{action} path and url" do
+      path = "/multiple_list_item/#{@item.id}/client/position/#{action}"
+      assert_equal path, send("#{action}_path", @item, :client)
+      assert_equal "#{@host}#{path}", send("#{action}_url", @item, :client)
+    end
+  end
+  
+  test "positionable links should have a ul container" do
+    html = positionable_links(@item, :client)
+    assert_match '<ul class="positionable_links">', html
+  end
+  
+  test "positionable links should disable move up and move to top if first?" do
+    html = positionable_links(@item, :client)
+    assert_match '<li class="positionable_disabled">Move to top', html
+    assert_match '<li class="positionable_disabled">Move up', html
+  end
+  
+  test "positionable links should disable move down and move to bottom if last?" do
+    html = positionable_links(@item, :client)
+    assert_match '<li class="positionable_disabled">Move to bottom', html
+    assert_match '<li class="positionable_disabled">Move down', html
+  end
+  
+  test "positionable links should return links for up and top if not first?" do
+    @item = create
+    html = positionable_links(@item, :client)
+    assert_match /<a href="[^"]*".*Move to top/i, html
+    assert_match /<a href="[^"]*".*Move up/i, html
+  end
+  
+  test "positionable links should return links for down and bottom if not last?" do
+    create
+    html = positionable_links(@item, :client)
+    assert_match /<a href="[^"]*".*Move to bottom/i, html
+    assert_match /<a href="[^"]*".*Move down/i, html
+  end
+  
+  test "positionable links should be insert links if resource not in list" do
+    @item.remove_from_list(:client)
+    html = positionable_links(@item, :client)
+    assert_match /Insert at top/i, html
+    assert_match /Insert at bottom/i, html
+  end
+  
+  test "positionable buttons should have a ul container" do
+    html = positionable_buttons(@item, :client)
+    assert_match '<ul class="positionable_buttons">', html
+  end
+  
+  protected
+    def create
+      MultipleListItem.create
+    end
+end

data/test/rails_root/test/unit/multiple_list_item_test.rb

@@ -0,0 +1,60 @@
+require 'test_helper'
+
+class MultipleListItemTest < ActiveSupport::TestCase
+  def setup
+    4.times { MultipleListItem.create }
+    @items = MultipleListItem.find(:all, :order => 'id')
+    @ids = @items.map(&:id)
+  end
+
+  include SimpleTests
+  include SimpleGaplessTests
+  
+  def test_multiple_list_insertion
+    item = create
+    assert item.in_list?(:default)
+    assert item.in_list?(:client)
+    assert item.in_list?(:developer)
+  end
+  
+  def test_multiple_list_removal_should_not_mess_other_lists
+    @items.second.remove_from_list(:client)
+    assert_equal_ids [1,3,4], :client
+    assert_equal_ids [1,2,3,4], :default
+    assert_equal_ids [1,2,3,4], :developer
+  end
+  
+  def test_multiple_list_destroy_should_update_all_lists
+    @items.second.destroy
+    assert_equal_ids [1,3,4], :default
+    assert_equal_ids [1,3,4], :client
+    assert_equal_ids [1,3,4], :developer
+  end
+  
+  def test_multiple_list_move
+    @items.second.move_down(:client)
+    assert_equal_ids [1,2,3,4], :default
+    assert_equal_ids [1,3,2,4], :client
+    assert_equal_ids [1,2,3,4], :developer
+  end
+  
+  def test_multiple_list_insert_at
+    @items.second.insert_at(:bottom, :client)
+    assert_equal_ids [1,2,3,4], :default
+    assert_equal_ids [1,3,4,2], :client
+    assert_equal_ids [1,2,3,4], :developer
+  end
+  
+  protected
+    def ordered_ids(*args)
+      position = 'position'
+      unless args.empty?
+        position = {:default => 'position', :client => 'client_position', :developer => 'developer_position'}[args.first]
+      end
+      MultipleListItem.find(:all, :order => position, :conditions => "#{position} IS NOT NULL").map(&:id)
+    end
+    
+    def create(*args)
+      MultipleListItem.create
+    end
+end