agris 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cbd46cc8f2b9b4bf6ca1af3e2953f2b7ce26aef6
-  data.tar.gz: b6115cd1b162c8e4e0bab1849a85b1bcbcc61c12
+  metadata.gz: 64629354ccada6a381efe8aa942ced5079b6ee4d
+  data.tar.gz: ab9f6e49adf01f310a25d30c2677cd96fb6da522
 SHA512:
-  metadata.gz: e0d6669a41eda7418e5a396766098a0e56e43101f484bb08e527ba4785977ab2a8bdb3e3680e14284b4752ce199e2f3f27a9026e06bbe6971f0001c646c1b7fd
-  data.tar.gz: d13a3daf42827bbc6b4ae50de0c75141519c2796180c3145253c6ba720b79f9e0a9e8a320bb699230e8df38f225e3eef267c9458bd3a7b3ad7bb316d1b131867
+  metadata.gz: 18d1d0e8345d9b2c425a279a3f88e32ada1a3708b10b6d5af134a6699398138b8b7b0e1e23bb176ca8a5b3e824601db4d7a683e8c83d9aec323ee8576275d163
+  data.tar.gz: 6d4b4e8dc43c3b70975fac6e87e829e350f6df6592fc3d7ad4595753bfabd81feac412665a3d47f4d2130bea212081d8fa5d355f3fc0f3080ee275243e770aba

data/.hound-rubocop.yml

@@ -29,7 +29,7 @@ Style/CollectionMethods:
     find: detect
     find_all: select
     reduce: inject
-Style/FileName:
+Naming/FileName:
   Description: Use snake_case for source file names.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#snake-case-files
   Enabled: false
@@ -43,7 +43,6 @@ Style/IfUnlessModifier:
   Description: Favor modifier if/unless usage when you have a single-line body.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#if-as-a-modifier
   Enabled: false
-  MaxLineLength: 80
 Style/OptionHash:
   Description: Don't use option hashes when you can use keyword arguments.
   Enabled: false
@@ -61,7 +60,7 @@ Style/PercentLiteralDelimiters:
     "%w": "()"
     "%W": "()"
     "%x": "()"
-Style/PredicateName:
+Naming/PredicateName:
   Description: Check the names of predicate methods.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#bool-methods-qmark
   Enabled: true
@@ -84,7 +83,7 @@ Style/RaiseArgs:
 Style/SignalException:
   Description: Checks for proper usage of fail and raise.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#fail-method
-  Enabled: false
+  Enabled: true
   EnforcedStyle: semantic
   SupportedStyles:
   - only_raise
@@ -125,12 +124,17 @@ Style/StringLiteralsInInterpolation:
 Style/TrailingCommaInArguments:
   Description: 'Checks for trailing comma in argument lists.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas'
-  Enabled: false
+  Enabled: true
   EnforcedStyleForMultiline: no_comma
-Style/TrailingCommaInLiteral:
-  Description: 'Checks for trailing comma in array and hash literals.'
+Style/TrailingCommaInArrayLiteral:
+  Description: 'Checks for trailing comma in array literals.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas'
-  Enabled: false
+  Enabled: true
+  EnforcedStyleForMultiline: no_comma
+Style/TrailingCommaInHashLiteral:
+  Description: 'Checks for trailing comma in hash literals.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas'
+  Enabled: true
   EnforcedStyleForMultiline: no_comma
 Metrics/AbcSize:
   Description: A calculated magnitude based on number of assignments, branches, and
@@ -177,7 +181,7 @@ Lint/AssignmentInCondition:
 Style/InlineComment:
   Description: Avoid inline comments.
   Enabled: false
-Style/AccessorMethodName:
+Naming/AccessorMethodName:
   Description: Check the naming of accessor methods for get_/set_.
   Enabled: false
 Style/Alias:
@@ -235,7 +239,7 @@ Lint/HandleExceptions:
   Description: Don't suppress exception.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#dont-hide-exceptions
   Enabled: false
-Lint/LiteralInCondition:
+Lint/LiteralAsCondition:
   Description: Checks of literals used in conditions.
   Enabled: false
 Lint/LiteralInInterpolation:

data/.rubocop.yml

@@ -1,8 +1,14 @@
-inherit_from: .hound-rubocop.yml
+inherit_from:
+  - .hound-rubocop.yml
 
+Rails:
+  Enabled: false
 AllCops:
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.4
   Exclude:
+    - "vendor/**/*"
+    - "db/schema.rb"
+    - "node_modules/**/*"
     - bin/*
 Layout/DotPosition:
   Description: Checks the position of the dot in multi-line method calls.
@@ -38,3 +44,6 @@ Style/StringLiterals:
   SupportedStyles:
   - single_quotes
   - double_quotes
+Rails/DynamicFindBy:
+  Exclude:
+    - "spec/features/**/*"

data/agris.gemspec

@@ -1,6 +1,5 @@
-# coding: utf-8
 # frozen_string_literal: true
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'agris/version'
 
@@ -24,10 +23,10 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'savon', '~> 2.11'
 
   spec.add_development_dependency 'bundler', '~> 1.14'
+  spec.add_development_dependency 'pry-byebug'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
-  spec.add_development_dependency 'rubocop', '0.49.0'
+  spec.add_development_dependency 'rubocop', '0.54.0'
   spec.add_development_dependency 'simplecov'
   spec.add_development_dependency 'webmock', '~> 2.3'
-  spec.add_development_dependency 'pry-byebug'
 end

data/lib/agris.rb

@@ -44,7 +44,7 @@ module Agris
     end
 
     def root
-      File.expand_path('../../', __FILE__)
+      File.expand_path('..', __dir__)
     end
   end
 

data/lib/agris/api/document_query_response.rb

@@ -4,12 +4,12 @@ module Agris
     class DocumentQueryResponse
       def initialize(output_hash, resource_type = nil)
         @output_hash = output_hash
-        @objects = nil
+        @documents = nil
         @resource_type = resource_type if resource_type
       end
 
       def last_request_date_time
-        DateTime.parse(
+        Time.parse(
           @output_hash[pluralized_resource_name] \
                       ['system'] \
                       ['lastrequestdatetime']
@@ -17,7 +17,7 @@ module Agris
       end
 
       def documents
-        @objects ||= parse
+        @documents ||= parse
       end
 
       protected
@@ -61,4 +61,3 @@ module Agris
     end
   end
 end
-# rubocop:enable Rails/TimeZone

data/lib/agris/api/inventory/delivery_tickets.rb

@@ -18,9 +18,9 @@ module Agris
           )
         end
 
-        def delivery_tickets_changed_since(datetime)
+        def delivery_tickets_changed_since(datetime, detail = false)
           extract_documents(
-            Messages::QueryChangedDeliveryTickets.new(datetime),
+            Messages::QueryChangedDeliveryTickets.new(datetime, detail),
             DeliveryTicket
           )
         end

data/lib/agris/api/inventory/orders.rb

@@ -28,9 +28,9 @@ module Agris
           )
         end
 
-        def orders_changed_since(datetime)
+        def orders_changed_since(datetime, detail = false)
           extract_documents(
-            Messages::QueryChangedOrders.new(datetime),
+            Messages::QueryChangedOrders.new(datetime, detail),
             Agris::Api::Order
           )
         end

data/lib/agris/api/messages.rb

@@ -2,6 +2,8 @@
 module Agris
   module Api
     module Messages
+      autoload :ChangedQueryBase,
+               'agris/api/messages/changed_query_base'
       autoload :DocumentQueryBase,
                'agris/api/messages/document_query_base'
       autoload :MessageBase,

data/lib/agris/api/messages/changed_query_base.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+module Agris
+  module Api
+    module Messages
+      class ChangedQueryBase < QueryBase
+        def initialize(time, detail)
+          @time = time
+          @detail = detail
+        end
+
+        protected
+
+        def input_hash
+          input_base_hash
+            .merge(
+              :@details => @detail,
+              locid: {
+                :@datetime => @time.strftime('%Y-%m-%dT%H:%M:%S'),
+                :@id => nil,
+                :@loccode => nil
+              }
+            )
+        end
+      end
+    end
+  end
+end

data/lib/agris/api/messages/query_changed_delivery_tickets.rb

@@ -2,28 +2,13 @@
 module Agris
   module Api
     module Messages
-      class QueryChangedDeliveryTickets < QueryBase
-        def initialize(time)
-          @time = time
-        end
-
+      class QueryChangedDeliveryTickets < ChangedQueryBase
         def message_number
           80_600
         end
 
         protected
 
-        def input_hash
-          input_base_hash
-            .merge(
-              locid: {
-                :@datetime => @time.strftime('%Y-%m-%dT%H:%M:%S'),
-                :@id => nil,
-                :@loccode => nil
-              }
-            )
-        end
-
         def xml_hash
           xml_base_hash
             .merge(

data/lib/agris/api/messages/query_changed_invoices.rb

@@ -2,30 +2,13 @@
 module Agris
   module Api
     module Messages
-      class QueryChangedInvoices < QueryBase
-        def initialize(time, detail)
-          @time = time
-          @detail = detail
-        end
-
+      class QueryChangedInvoices < ChangedQueryBase
         def message_number
           80_500
         end
 
         protected
 
-        def input_hash
-          input_base_hash
-            .merge(
-              :@details => @detail,
-              locid: {
-                :@datetime => @time.strftime('%Y-%m-%dT%H:%M:%S'),
-                :@id => nil,
-                :@loccode => nil
-              }
-            )
-        end
-
         def xml_hash
           xml_base_hash
             .merge(

data/lib/agris/api/messages/query_changed_orders.rb

@@ -2,28 +2,13 @@
 module Agris
   module Api
     module Messages
-      class QueryChangedOrders < QueryBase
-        def initialize(time)
-          @time = time
-        end
-
+      class QueryChangedOrders < ChangedQueryBase
         def message_number
           80_900
         end
 
         protected
 
-        def input_hash
-          input_base_hash
-            .merge(
-              locid: {
-                :@datetime => @time.strftime('%Y-%m-%dT%H:%M:%S'),
-                :@id => nil,
-                :@loccode => nil
-              }
-            )
-        end
-
         def xml_hash
           xml_base_hash
             .merge(

data/lib/agris/api/messages/query_changed_purchase_contracts.rb

@@ -2,30 +2,13 @@
 module Agris
   module Api
     module Messages
-      class QueryChangedPurchaseContracts < QueryBase
-        def initialize(time, detail)
-          @time = time
-          @detail = detail
-        end
-
+      class QueryChangedPurchaseContracts < ChangedQueryBase
         def message_number
           80_150
         end
 
         protected
 
-        def input_hash
-          input_base_hash
-            .merge(
-              :@details => @detail,
-              locid: {
-                :@datetime => @time.strftime('%Y-%m-%dT%H:%M:%S'),
-                :@id => nil,
-                :@loccode => nil
-              }
-            )
-        end
-
         def xml_hash
           xml_base_hash
         end

data/lib/agris/process_message_response.rb

@@ -14,7 +14,7 @@ module Agris
     end
 
     def error_info
-      @error ||= error? ? ErrorInfo.new(error_hash) : nil
+      @error_info ||= error? ? ErrorInfo.new(error_hash) : nil
     end
 
     def error_hash

data/lib/agris/savon_request.rb

@@ -17,7 +17,7 @@ module Agris
         message: {
           AgContext_str_p: context,
           AgMessage_int_p: message_number,
-          AgInput_obj_p: input,
+          AgInput_obj_p: input
         }
       )
       message_response = parse_response(response)
@@ -56,17 +56,17 @@ module Agris
     def response_error(error_info)
       Object.const_get(
         format(
-          'Agris::%sError',
-          error_info.type.to_s.split('_').map(&:capitalize).join
+          'Agris::%<error_name>sError',
+          error_name: error_info.type.to_s.split('_').map(&:capitalize).join
         )
       ).new(error_info.payload)
     end
 
     def wsdl
       format(
-        '%s/%s',
-        @base_url,
-        'agris/AGRIS.Env.MessageRouter/AGRIS.Env.MessageRouter.asmx?WSDL'
+        '%<base_url>s/%<path>s',
+        base_url: @base_url,
+        path: 'agris/AGRIS.Env.MessageRouter/AGRIS.Env.MessageRouter.asmx?WSDL'
       )
     end
   end

data/lib/agris/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Agris
-  VERSION = '0.3.0'
+  VERSION = '0.3.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: agris
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - John Gray
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-05-15 00:00:00.000000000 Z
+date: 2018-05-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
@@ -39,6 +39,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.14'
+- !ruby/object:Gem::Dependency
+  name: pry-byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -73,14 +87,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.49.0
+        version: 0.54.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.49.0
+        version: 0.54.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -109,20 +123,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.3'
-- !ruby/object:Gem::Dependency
-  name: pry-byebug
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: 
 email:
 - wopr42@gmail.com
@@ -170,6 +170,7 @@ files:
 - lib/agris/api/inventory/specific_delivery_ticket_extract.rb
 - lib/agris/api/inventory/specific_order_extract.rb
 - lib/agris/api/messages.rb
+- lib/agris/api/messages/changed_query_base.rb
 - lib/agris/api/messages/document_query_base.rb
 - lib/agris/api/messages/import.rb
 - lib/agris/api/messages/message_base.rb