agilibox 1.7.4 → 1.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1260285e63ab21a02407fcc7c4e13f81f5e168fee704a2af4e917612b0d07b67
-  data.tar.gz: a72eddeb10a2a22916aba4dc005eee7183dd3a20f8f63346ea1696c1fa413fb9
+  metadata.gz: 32ae9547194bc24867f080fd2d519d8c5121f0bd29c5f04a77ef3a0cc73ab193
+  data.tar.gz: b3842b9bcaf9a53cabe3ff70e35397f24486848b5b4b63ba718eeac3197149fc
 SHA512:
-  metadata.gz: 5992078d40a5c729a4a15a7068b959dc847ecc7c144eebc13a07210deb89e1b4738a6815cad79be2763b7bb076fea5fdec64a77e719005c71d53d21cceaf45b7
-  data.tar.gz: 898e4d51ff14f1e280ec56b1f8842ccff72174a58925dfa01d39e2507284fe19f73c4a7a9dd8fe5ffc9b0d520c807ea805a330259ddc0a0597b7a175c536fe06
+  metadata.gz: 57219afef63509df9ecef5d62e889f163808acb127634d869b644de4a6510a419880ccbd2bc655e8a892a69cebf29048a0afd2b24efecb72d7cb6f54f2ddf30a
+  data.tar.gz: 74850c8fd415e42e1cd1580ab02f55b5b8b5e2ed557f7b70bb7b036c3b801dfa1c38befe388e78dd8428cf15707ad58591b52ec4b8e698257e1cd83c1d51b671

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## Next version
 
+## 1.8.0
+- SMS improvements
+- Replace TapMethods by Tapenade gem
+- Add nilify_blanks dependency
+
 ## 1.7.4
 - Add `tap_update_columns`and `tap_update_column`
 

data/app/sms/agilibox/sms.rb

@@ -1,6 +1,8 @@
 module Agilibox::SMS
   class << self
-    attr_writer :strategy
+    def strategy=(value)
+      @strategy = parse_strategy(value)
+    end
 
     def strategy
       @strategy ||= default_strategy
@@ -12,6 +14,14 @@ module Agilibox::SMS
       @default_from ||= Rails.application.class.to_s.chomp("::Application")
     end
 
+    def parse_strategy(value)
+      if value.is_a?(Symbol)
+        "Agilibox::SMS::Strategies::#{value.to_s.camelcase}".constantize
+      else
+        value
+      end
+    end
+
     private
 
     def default_strategy

data/app/sms/agilibox/sms/application_sms.rb

@@ -21,7 +21,7 @@ class Agilibox::SMS::ApplicationSMS
   end
 
   def sms(data)
-    Agilibox::SMS.strategy.new(data)
+    Agilibox::SMS::Message.new(data)
   end
 
   class << self

data/app/sms/agilibox/sms/message.rb

@@ -0,0 +1,25 @@
+class Agilibox::SMS::Message
+  attr_reader :data
+
+  def initialize(data)
+    @data = data
+  end
+
+  def strategy=(value)
+    @strategy = Agilibox::SMS.parse_strategy(value)
+  end
+
+  def strategy(value = :no_argument)
+    self.strategy = value unless value == :no_argument
+    @strategy || Agilibox::SMS.strategy
+  end
+
+  def deliver_now
+    strategy.call(data)
+  end
+
+  # TODO : Delay
+  def deliver_later
+    deliver_now
+  end
+end

data/app/sms/agilibox/sms/strategies/amazon_sns.rb

@@ -27,8 +27,6 @@ class Agilibox::SMS::Strategies::AmazonSNS < Agilibox::SMS::Strategies::Base
     )
   end
 
-  private
-
   def call
     from = data[:from] || Agilibox::SMS.default_from
 

data/app/sms/agilibox/sms/strategies/base.rb

@@ -5,18 +5,11 @@ class Agilibox::SMS::Strategies::Base
     @data = data
   end
 
-  def deliver_now
-    call
-  end
-
-  # TODO : Delay
-  def deliver_later
-    deliver_now
-  end
-
-  private
-
   def call
     raise NotImplementedError
   end
+
+  def self.call(*args)
+    new(*args).call
+  end
 end

data/app/sms/agilibox/sms/strategies/test.rb

@@ -3,8 +3,6 @@ class Agilibox::SMS::Strategies::Test < Agilibox::SMS::Strategies::Base
     @deliveries ||= []
   end
 
-  private
-
   def call
     self.class.deliveries << data
     Rails.logger.info "New SMS sent : #{data.inspect}"

data/lib/agilibox/engine.rb

@@ -1,6 +1,8 @@
 require "awesome_print"
 require "pry-rails"
 require "rails-i18n"
+require "nilify_blanks"
+require "tapenade"
 
 module Agilibox
   class Engine < ::Rails::Engine

data/lib/agilibox/version.rb

@@ -1,3 +1,3 @@
 module Agilibox
-  VERSION = "1.7.4"
+  VERSION = "1.8.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: agilibox
 version: !ruby/object:Gem::Version
-  version: 1.7.4
+  version: 1.8.0
 platform: ruby
 authors:
 - agilidée
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-10-01 00:00:00.000000000 Z
+date: 2019-10-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails-i18n
@@ -52,6 +52,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: nilify_blanks
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: tapenade
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Agilibox
 email:
 - contact@agilidee.com
@@ -133,7 +161,6 @@ files:
 - app/models/concerns/agilibox/pluck_to_hash.rb
 - app/models/concerns/agilibox/polymorphic_id.rb
 - app/models/concerns/agilibox/search.rb
-- app/models/concerns/agilibox/tap_methods.rb
 - app/models/concerns/agilibox/timestamp_helpers.rb
 - app/serializers/agilibox/serializers.rb
 - app/serializers/agilibox/serializers/axlsx.rb
@@ -142,6 +169,7 @@ files:
 - app/services/agilibox/service.rb
 - app/sms/agilibox/sms.rb
 - app/sms/agilibox/sms/application_sms.rb
+- app/sms/agilibox/sms/message.rb
 - app/sms/agilibox/sms/strategies/amazon_sns.rb
 - app/sms/agilibox/sms/strategies/base.rb
 - app/sms/agilibox/sms/strategies/test.rb

data/app/models/concerns/agilibox/tap_methods.rb

@@ -1,33 +0,0 @@
-module Agilibox::TapMethods
-  extend ActiveSupport::Concern
-
-  def tap_save!(options = {})
-    save!(options)
-    self
-  end
-
-  def tap_update!(attributes)
-    update!(attributes)
-    self
-  end
-
-  def tap_validate(context = nil)
-    validate(context)
-    self
-  end
-
-  def tap_validate!(context = nil)
-    validate!(context)
-    self
-  end
-
-  def tap_update_columns(attributes)
-    update_columns(attributes) # rubocop:disable Rails/SkipsModelValidations
-    self
-  end
-
-  def tap_update_column(name, value)
-    update_column(name, value) # rubocop:disable Rails/SkipsModelValidations
-    self
-  end
-end