agilibox 1.4.3 → 1.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c86e25a2a64d907710532205286243303ba59dc13be55c7e7b9c598d9fdbb771
-  data.tar.gz: 0750edb2e73c200f92de9d02f32c286eb91a13724d37e41dfdc13c3496c4b629
+  metadata.gz: 73e2e45e1fed7a2e0cec02d337dc0afa3bf0112e4b26ec3168d8b62e0f64c961
+  data.tar.gz: 9a79efe0583a84370cc71d57468e6083b77032053c59ae702c9c557a3cac3dd4
 SHA512:
-  metadata.gz: 3f4ce3e7ca71bd6c8acbfed1f6fdf33f8934b4b5fbf78dc78ef2b1c30459e45bac7e972d20b7ad7fdbe6f54d3f72e6f998cfcfdeb24ec34fe90f7418ff49b268
-  data.tar.gz: 77cd7f7c4590d09d704c72cd2e9c78e892634416669d6779463be1ed958ab72d2efd4294dc8ad3d7df9b69bb71060fd8fa500ca7864758bd97775a91058584a7
+  metadata.gz: 80764451b386701e1e0033ed885589c1e95bff2bd973cc022dc706ce828fc86f1ac8c947c8bbe5b6f394e395fa5c1e9f933b45fb0173fe03d7ef3c088bc2eed2
+  data.tar.gz: 727f23e415b4aa280e2d96bc91d3016636e2e8f76a8a197218b9a8ef93797e638fb9637f880603293476c0ad6960fcd6d1974f74a1669184f20624f4b8169222

data/CHANGELOG.md

@@ -2,74 +2,239 @@
 
 ## Next version
 
-## 1.4.3
+## v1.11.0
+- Add ActionDispatch::Http::MimeNegotiation::InvalidType to errors middleware
+- Fix inverted forbidden/unauthorized
+
+## v1.10.5
+- Fix hidden_inputs_for_get_form again
+
+## v1.10.4
+- Fix hidden_inputs_for_get_form
+
+## v1.10.3
+- Fix search forms to preserve GET params
+
+## v1.10.2
+- Filters improvements
+
+## v1.10.1
+- Fix date filters
+
+## v1.10.0
+- Add date support to XLSX serializer
+- Remove AXLSX serializer
+
+## v1.9.20
+- Add bootstrap 5 search form
+
+## v1.9.19
+- Add bootstrap 4/5 pagination support
+
+## v1.9.18
+- Rails 6.1 compatibility
+
+## v1.9.17
+- Fix capybara selector
+
+## v1.9.16
+- Fix Rails 6.1 warnings
+
+## v1.9.15
+- Add `modal:before-close` event
+
+## v1.9.14
+- Fix syntax error on Ruby < 2.7
+
+## v1.9.13
+- Add apparition capybara driver
+
+## v1.9.12
+- Fix some Ruby 2.7 warnings
+
+## v1.9.11
+- Fix some Ruby 2.7 warnings
+
+## v1.9.10
+- Fix some Ruby 2.7 warnings
+
+## v1.9.9
+- Add error to ErrorsMiddleware
+
+## v1.9.8
+- Fix `tags` helper
+
+## v1.9.7
+- Change XLSX export
+
+## v1.9.6
+- Fix info helper with false
+- Update Rubocop + fix offences
+
+## 1.9.5
+- Fix warnings on Rails 6
+
+## 1.9.4
+- Cucumber : disable Zonebie
+
+## 1.9.3
+- No change
+
+## 1.9.2
+- ErrorsMiddleware improvements
+
+## 1.9.1
+- Add ErrorsMiddleware
+
+## 1.9.0
+- Remove phantomjs/poltergeist support
+- BackUrlConcern transforms absolute URLs to relative
+
+## 1.8.0
+- SMS improvements
+- Replace TapMethods by Tapenade gem
+- Add nilify_blanks dependency
+
+## 1.7.4
+- Add `tap_update_columns`and `tap_update_column`
+
+## 1.7.3
+- Do not require auth in FiltersController
+- Refactor FiltersController Pundit after_actions
+
+## 1.7.2
+- Fix FontAwesome helper
+
+## 1.7.1
+- Cuprite : improve config + increase timeout
+
+## 1.7.0
+- ActiveRecord/ActiveModel type cast : refactor + add date + add boolean
+
+## 1.6.2
+- Fix cucumber/capybara helpers
+
+## 1.6.1
+- Add `SetupJobConcern`
+
+## 1.6.0
+- Remove `GetHTTP`
+- I18n fixes
+- Add `Agilibox::TapMethods`
+- Filters CSS : add flex-wrap
+- Add `bs_card` helper
+- Add `:br` separator to `info` helper
+- TextHelper refactors
+- Update dummy app to Rails 5.2
+- Replace AXLSX by SpreadsheetArchitect
+
+## 1.5.13
+- Fix `info` helper with nested blank value
+
+## 1.5.12
+- Cuprite config improvements
+
+## 1.5.11
+- Add `nbsp` helper
+- Add `PluckDistinct` model concern
+- Add pagination helpers
+
+## 1.5.10
+- Cucumber Helpers : add cuprite support
 
+## 1.5.9
+- I18n fix
+- Add `bs_progress_bar` helper
+
+## 1.5.8
+- Add GetHTTP#response
+
+## 1.5.7
+- `download_button` and `export_button` fixes
+- checkboxes-dropdown CSS improvements
+- Change searchbar CSS
+
+## 1.5.6
+- Various fixes on filters
+
+## 1.5.5
+- Add ModelI18n::raise_on_missing_translations option
+
+## 1.5.4
+- Cucumber "click on" steps improvement
+
+## 1.5.3
+- Fix FontAwesome >=5.6
+
+## 1.5.2
+- GetHTTP service improvements
+- New common steps + improvements
+
+## 1.5.1
+- Add CSS helpers
+- Add Cucumber common steps
+- Add Cucumber select2 helper
+
+## 1.5.0
+- Add `GetHTTP`
+- Add BS4 search form
+
+## 1.4.4
+- Fix i18n error on `info` helper
+
+## 1.4.3
 - `form_buttons` helper fixes and improvements
 
 ## 1.4.2
-
 - Fix FontAwesome helper
 
 ## 1.4.1
-
 - FCM request handle JSON errors
 
 ## 1.4.0
-
 - Add `Agilibox::Email`
 - Add `Agilibox.parent_controller` config
 - Add `Agilibox.parent_mailer` config
 - Filters improvements
 
 ## 1.3.6
-
 - Remove deprecated `Agilibox::SortableUUIDGenerator::generate`
 - `Agilibox::ActiveRecordUUIDConcern` improvements
 - `Agilibox::DefaultValuesConcern` improvements
 - Fix FontAwesome version error
 
 ## 1.3.5
-
 - Add `Agilibox::Monkey`
 
 ## 1.3.4
-
 - Support FontAwesome v4
 
 ## 1.3.3
-
 - Fix error messages
 
 ## 1.3.2
-
 - Add `Agilibox::ActiveModelCustomErrorMessages`
 
 ## 1.3.1
-
 - `ApiControllerConcern` refactor + helpers
 
 ## 1.3.0
-
 - ApiControllerConcern : add `model_errors` in json response
 - `json_response` is now a `HashWithIndifferentAccess`
 
 ## 1.2.3
-
 - Add FCM
 
 ## 1.2.2
-
 - Add CollectionUpdate
 - Rename Agilibox::SortableUUIDGenerator::generate to ::call
 
 ## 1.2.1
-
 - Fix flash partial
 - Filter by date/datetime period now allows custom periods
 - Sorter class improvements
 
 ## 1.2.0
-
 - Add `Agilibox::MiniFormObject`
 - Replace time period filter by date+datetime period filters
 - JS Modal improvements
@@ -80,7 +245,6 @@
   - you now need to add `Agilibox::CucumberConfig.require_poltergeist!` or `Agilibox::CucumberConfig.require_chrome_headless!` to your `env.rb`
 
 ## 1.1.0
-
 - Search concern improvements
 - Date helper improvements
 - Add `boolean_icon` helper
@@ -89,34 +253,28 @@
 - Switch to FontAwesome 5 + `icon` helper improvements
 
 ## 1.0.15
-
 - `ApiControllerConcern#render_json_error` improvements
 - Add Agilibox::Service object
 - Fix SMS AmazonSNS strategy bug
 - Fix time period filter
 
 ## 1.0.14
-
 - Sorting helper improvements
 - FormBackUrl fixes
 - FiltersHelper fixes
 
 ## 1.0.13
-
 - Modal JS fix
 
 ## 1.0.12
-
 - `.checkboxes-dropdown` CSS fix
 - Fix sorting helper
 
 ## 1.0.11
-
 - Add Agilibox::SMS
 - Test helpers improvements
 
 ## 1.0.10
-
 - Add TokenGenerator
 - Add PhoneNumberSanitizer
 - Add engine_file helper to Kernel
@@ -127,21 +285,17 @@
 - Add ApiControllerConcern
 
 ## 1.0.9
-
 - Fix Model#tv
 - Add cucumber helpers
 
 ## 1.0.8
-
 - Serializers improvements
 
 ## 1.0.7
-
 - Search form add reset button
 - Filter form fix default submit button
 
 ## 1.0.6
-
 - Add checkboxes_dropdown helper
 - Add FilterStrategyByKeyValues
 - bs_button improvements
@@ -151,32 +305,26 @@
 - Split i18n files
 
 ## 1.0.5
-
 - Fix `import_button` helper
 - Add mime types
 
 ## 1.0.4
-
 - Search now ignore accents
 - Add Sorter class
 
 ## 1.0.3
-
 - Add `ta` (translate action) helper
 - Add `blank` css class to `info` helper
 - Add autocomplete.coffee
 
 ## 1.0.2
-
 - Button helper changes
 - Modals use event delegation
 
 ## 1.0.1
-
 - Remove AXLSX dependency
 
 ## 1.0.0
-
 - First version imported from agilidee/dorsale
 - `sortable_column_order` now returns symbols
 - modal fixes + allow upload

data/Rakefile

@@ -35,3 +35,7 @@ end
 
 
 task default: :test
+
+task "assets:precompile" do
+  Rake::Task["app:assets:precompile"].invoke
+end

data/app/assets/javascripts/agilibox/modals.coffee

@@ -34,6 +34,7 @@ window.modal =
 
   close: (event) ->
     event.preventDefault() if event
+    $(document).trigger("modal:before-close")
     $("body").removeClass("modal-open")
     $("#modal").remove()
     $(document).trigger("modal:close")

data/app/assets/stylesheets/agilibox/actions.sass

@@ -0,0 +1,2 @@
+.actions.top
+  text-align: right

data/app/assets/stylesheets/agilibox/all.sass

@@ -1,7 +1,10 @@
+@import agilibox/actions
 @import agilibox/buttons
 @import agilibox/filters
 @import agilibox/flash
 @import agilibox/forms
+@import agilibox/icons
 @import agilibox/modals
 @import agilibox/pagination
 @import agilibox/print
+@import agilibox/tables

data/app/assets/stylesheets/agilibox/buttons.sass

@@ -6,3 +6,6 @@
 // .btn-default has been removed in Bootstrap 4
 .btn-default
   @extend .btn-outline-primary !optional
+
+.btn + .btn
+  margin-left: 0.5em

data/app/assets/stylesheets/agilibox/filters.sass

@@ -6,6 +6,7 @@
   padding: 8px
   box-shadow: none
   display: flex
+  flex-wrap: wrap
   flex-direction: initial
   background: #F0F0F0
 

data/app/assets/stylesheets/agilibox/forms.sass

@@ -1,5 +1,7 @@
 .checkboxes-dropdown
   .checkbox
+    display: block
+
     label
       position: static
       margin: 0
@@ -10,6 +12,15 @@
       margin: 0 0.5em 0 0
       width: auto
 
+  .dropdown-menu
+    width: 350px
+    max-height: 400px
+    max-height: calc(100vh - 300px)
+    overflow: auto
+
+    @media (min-height: 700px)
+      max-height: 400px
+
 // Chrome and Safari does not trigger display:none submit buttons on <enter> key press
 .hidden-submit
   position: absolute
@@ -19,3 +30,20 @@
   height: 0
   width: 0
   visibility: hidden
+
+form.search
+  max-width: 25em
+
+.search-middle form.search,
+.search-right form.search,
+  margin-left: auto
+
+.search-left form.search,
+.search-middle form.search,
+  margin-right: auto
+
+.form-actions
+  text-align: center
+  margin-top: 45px
+  padding-top: 15px
+  border-top: 1px solid #ccc

data/app/assets/stylesheets/agilibox/icons.sass

@@ -0,0 +1,5 @@
+.fa,
+.fab,
+.far,
+.fas,
+  @extend .fa-fw

data/app/assets/stylesheets/agilibox/pagination.sass

@@ -4,3 +4,10 @@
 
   li
     display: inline-block
+
+.pagination
+  li
+    @extend .page-item !optional
+
+  a
+    @extend .page-link !optional

data/app/assets/stylesheets/agilibox/tables.sass

@@ -0,0 +1,26 @@
+table.default
+  @extend .table
+  @extend .table-bordered
+  @extend .table-hover
+
+  th.actions,
+  td.actions,
+    width: 5em
+    white-space: nowrap
+    text-align: center
+
+  th
+    text-align: center
+    vertical-align: middle !important
+
+  td[class*="date"]
+    width: 8em
+    text-align: center
+
+  td[class*="count"],
+    width: 1em
+    text-align: center
+
+  td[class*="total"],
+  td[class*="amount"],
+    text-align: right

data/app/controllers/agilibox/small_data/filters_controller.rb

@@ -1,12 +1,10 @@
 class Agilibox::SmallData::FiltersController < ::Agilibox::ApplicationController
+  skip_before_action :verify_authenticity_token, raise: false
+  skip_before_action :authenticate_user!,        raise: false
   skip_after_action  :verify_authorized,         raise: false
   skip_after_action  :verify_policy_scoped,      raise: false
-  skip_before_action :verify_authenticity_token, raise: false
 
   def create
-    skip_authorization if respond_to?(:skip_authorization)
-    skip_policy_scope  if respond_to?(:skip_policy_scope)
-
     filters = ::Agilibox::SmallData::Filter.new(cookies)
     new_filters = params.fetch(:filters, {}).permit!.to_h
     filters.merge new_filters

data/app/controllers/concerns/agilibox/api_controller_concern.rb

@@ -31,13 +31,14 @@ module Agilibox::ApiControllerConcern
 
   def json_errors_hash_for_model(object)
     object.errors
-      .map { |a, m| [a, message: m, full_message: object.errors.full_message(a, m)] }
+      .to_hash
+      .map { |a, m| [a, message: m.first, full_message: object.errors.full_message(a, m.first)] }
       .uniq(&:first)
       .to_h
   end
 
   def json_error_string_for_model(object)
-    json_errors_hash_for_model(object).values.map { |e| e[:full_message] }.join(", ")
+    json_errors_hash_for_model(object).values.pluck(:full_message).join(", ")
   end
 
   def render_not_found
@@ -53,7 +54,7 @@ module Agilibox::ApiControllerConcern
   end
 
   def render_forbidden_or_unauthorized
-    current_user ? render_unauthorized : render_forbidden
+    current_user ? render_forbidden : render_unauthorized
   end
 
   included do |controller|

data/app/controllers/concerns/agilibox/back_url_concern.rb

@@ -7,12 +7,20 @@ module Agilibox::BackUrlConcern
   end
 
   def back_url
-    [
+    url = [
       params[:back_url],
       request.referer,
       default_back_url,
-      main_app.root_path,
+      main_app.try(:root_path),
       "/",
-    ].select(&:present?).first
+    ].find(&:present?)
+
+    uri = URI.parse(url)
+    uri.host = nil
+    uri.port = nil
+    uri.scheme = nil
+    uri.user = nil
+    uri.password = nil
+    uri.to_s
   end
 end

data/app/filters/agilibox/small_data/filter.rb

@@ -1,4 +1,6 @@
 class Agilibox::SmallData::Filter
+  include ActiveModel::Model
+
   STRATEGIES = {}
 
   attr_reader :jar
@@ -43,7 +45,7 @@ class Agilibox::SmallData::Filter
   end
 
   def respond_to_missing?(method, *)
-    strategies.key?(method.to_s) || strategies.key?(method.to_s.chomp("="))
+    super || strategies.key?(method.to_s) || strategies.key?(method.to_s.chomp("="))
   end
 
   def read
@@ -60,8 +62,12 @@ class Agilibox::SmallData::Filter
     write read.merge(new_filters)
   end
 
+  def actives_count
+    read.count { |k, v| strategies.key?(k.to_s) && v.present? }
+  end
+
   def any?
-    read.select { |k, v| strategies.key?(k.to_s) && v.present? }.any?
+    actives_count.positive?
   end
 
   def empty?

data/app/filters/agilibox/small_data/filter_strategy_by_date_begin.rb

@@ -1,6 +1,7 @@
 class Agilibox::SmallData::FilterStrategyByDateBegin < ::Agilibox::SmallData::FilterStrategyByKeyValue
   def apply(query, value)
-    value = Time.zone.parse(value).beginning_of_day
-    query.where("#{key} >= ?", value)
+    value = Date.parse(value)
+    column = column_for(query)
+    query.where("#{column} >= ?", value)
   end
 end

data/app/filters/agilibox/small_data/filter_strategy_by_date_end.rb

@@ -1,6 +1,7 @@
 class Agilibox::SmallData::FilterStrategyByDateEnd < ::Agilibox::SmallData::FilterStrategyByKeyValue
   def apply(query, value)
-    value = Time.zone.parse(value).end_of_day
-    query.where("#{key} <= ?", value)
+    value = Date.parse(value)
+    column = column_for(query)
+    query.where("#{column} <= ?", value)
   end
 end

data/app/filters/agilibox/small_data/filter_strategy_by_date_or_datetime_period.rb

@@ -1,6 +1,6 @@
 class Agilibox::SmallData::FilterStrategyByDateOrDatetimePeriod < ::Agilibox::SmallData::FilterStrategyByKeyValue
   def initialize(*)
-    if self.class == Agilibox::SmallData::FilterStrategyByDateOrDatetimePeriod
+    if instance_of?(Agilibox::SmallData::FilterStrategyByDateOrDatetimePeriod)
       raise "please use FilterStrategyByDatePeriod or FilterStrategyByDatetimePeriod"
     end
 
@@ -46,7 +46,7 @@ class Agilibox::SmallData::FilterStrategyByDateOrDatetimePeriod < ::Agilibox::Sm
       b = b.end_of_day       if b
     end
 
-    column = key.is_a?(Symbol) ? "#{query.model.table_name}.#{key}" : key.to_s
+    column = column_for(query)
 
     query = query.where("#{column} >= ?", a) if a
     query = query.where("#{column} <= ?", b) if b

data/app/filters/agilibox/small_data/filter_strategy_by_key_value.rb

@@ -2,15 +2,26 @@ class Agilibox::SmallData::FilterStrategyByKeyValue < ::Agilibox::SmallData::Fil
   attr_reader :key
 
   def initialize(key = nil)
+    super()
     @key = key
   end
 
   def apply(query, value)
     value = true  if value == "true"
     value = false if value == "false"
-    value = nil   if value == "nil"
-    value = nil   if value == "null"
 
-    query.where("#{key} = ?", value)
+    column = column_for(query)
+
+    if value.to_s.in?(%w(nil null))
+      query.where("#{column} IS NULL")
+    elsif value.to_s.in?(%w(not_nil not_null))
+      query.where("#{column} IS NOT NULL")
+    else
+      query.where("#{column} = ?", value)
+    end
+  end
+
+  def column_for(query)
+    key.is_a?(Symbol) ? "#{query.model.table_name}.#{key}" : key.to_s
   end
 end

data/app/filters/agilibox/small_data/filter_strategy_by_key_values.rb

@@ -1,16 +1,11 @@
-class Agilibox::SmallData::FilterStrategyByKeyValues < ::Agilibox::SmallData::FilterStrategy
-  attr_reader :key
-
-  def initialize(key = nil)
-    @key = key
-  end
-
+class Agilibox::SmallData::FilterStrategyByKeyValues < ::Agilibox::SmallData::FilterStrategyByKeyValue
   def apply(query, value)
-    value = value.split(" ") if value.is_a?(String)
+    value = value.split if value.is_a?(String)
     value = value.select(&:present?)
+    column = column_for(query)
 
     if value.any?
-      query.where("#{key} IN (?)", value)
+      query.where("#{column} IN (?)", value)
     else
       query
     end