agilibox 1.10.0 → 1.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b79eff8bab58fe3ca456bb0f4ed5eb18de97fd7a82dc247751a094a4fb91a961
-  data.tar.gz: b13ee9bd49da7ceccee0f20737706ab1a9a3d4762688902bc773be94950af6cd
+  metadata.gz: 73e2e45e1fed7a2e0cec02d337dc0afa3bf0112e4b26ec3168d8b62e0f64c961
+  data.tar.gz: 9a79efe0583a84370cc71d57468e6083b77032053c59ae702c9c557a3cac3dd4
 SHA512:
-  metadata.gz: 599316ad810f15843e060a9cc5034cc76b505cde1bda4066deccd8bad1470986ad5bf3fecaa1e4712ede494904a06851a5df1a8852beeb0a087e5677bf118bb8
-  data.tar.gz: 92a2e1834215bfd50c322163cb59dfa22ea025aa4e52ee345815b5cebadb4cc3f45f376d8205e934e8aba4c8cf7cfe71813e367d4dd06e53cbbe1cf6cf329c3f
+  metadata.gz: 80764451b386701e1e0033ed885589c1e95bff2bd973cc022dc706ce828fc86f1ac8c947c8bbe5b6f394e395fa5c1e9f933b45fb0173fe03d7ef3c088bc2eed2
+  data.tar.gz: 727f23e415b4aa280e2d96bc91d3016636e2e8f76a8a197218b9a8ef93797e638fb9637f880603293476c0ad6960fcd6d1974f74a1669184f20624f4b8169222

data/CHANGELOG.md

@@ -2,6 +2,25 @@
 
 ## Next version
 
+## v1.11.0
+- Add ActionDispatch::Http::MimeNegotiation::InvalidType to errors middleware
+- Fix inverted forbidden/unauthorized
+
+## v1.10.5
+- Fix hidden_inputs_for_get_form again
+
+## v1.10.4
+- Fix hidden_inputs_for_get_form
+
+## v1.10.3
+- Fix search forms to preserve GET params
+
+## v1.10.2
+- Filters improvements
+
+## v1.10.1
+- Fix date filters
+
 ## v1.10.0
 - Add date support to XLSX serializer
 - Remove AXLSX serializer

data/app/controllers/concerns/agilibox/api_controller_concern.rb

@@ -54,7 +54,7 @@ module Agilibox::ApiControllerConcern
   end
 
   def render_forbidden_or_unauthorized
-    current_user ? render_unauthorized : render_forbidden
+    current_user ? render_forbidden : render_unauthorized
   end
 
   included do |controller|

data/app/filters/agilibox/small_data/filter.rb

@@ -1,4 +1,6 @@
 class Agilibox::SmallData::Filter
+  include ActiveModel::Model
+
   STRATEGIES = {}
 
   attr_reader :jar
@@ -60,8 +62,12 @@ class Agilibox::SmallData::Filter
     write read.merge(new_filters)
   end
 
+  def actives_count
+    read.count { |k, v| strategies.key?(k.to_s) && v.present? }
+  end
+
   def any?
-    read.select { |k, v| strategies.key?(k.to_s) && v.present? }.any?
+    actives_count.positive?
   end
 
   def empty?

data/app/filters/agilibox/small_data/filter_strategy_by_date_begin.rb

@@ -1,6 +1,6 @@
 class Agilibox::SmallData::FilterStrategyByDateBegin < ::Agilibox::SmallData::FilterStrategyByKeyValue
   def apply(query, value)
-    value = Time.zone.parse(value).beginning_of_day
+    value = Date.parse(value)
     column = column_for(query)
     query.where("#{column} >= ?", value)
   end

data/app/filters/agilibox/small_data/filter_strategy_by_date_end.rb

@@ -1,6 +1,6 @@
 class Agilibox::SmallData::FilterStrategyByDateEnd < ::Agilibox::SmallData::FilterStrategyByKeyValue
   def apply(query, value)
-    value = Time.zone.parse(value).end_of_day
+    value = Date.parse(value)
     column = column_for(query)
     query.where("#{column} <= ?", value)
   end

data/app/helpers/agilibox/form_helper.rb

@@ -59,4 +59,14 @@ module Agilibox::FormHelper
       :label      => label,
     )
   end
+
+  def hidden_inputs_for_get_form(url, except: [])
+    query_values = Addressable::URI.parse(url).query_values.to_h
+      .with_indifferent_access
+      .except(*except)
+
+    return if query_values.empty?
+
+    query_values.sum { |k, v| tag.input(type: "hidden", name: k, value: v) }
+  end
 end

data/app/views/agilibox/search/_form_bs3.html.slim

@@ -1,4 +1,5 @@
 form.search.bs3 method="get" action=action
+  = hidden_inputs_for_get_form(action, except: [:q])
   = form_hidden_submit
 
   p.input-group.search

data/app/views/agilibox/search/_form_bs4.html.slim

@@ -1,4 +1,5 @@
 form.search.bs4 method="get" action=action
+  = hidden_inputs_for_get_form(action, except: [:q])
   = form_hidden_submit
 
   .input-group.search

data/app/views/agilibox/search/_form_bs5.html.slim

@@ -1,4 +1,5 @@
 form.search.bs5.mb-3 method="get" action=action
+  = hidden_inputs_for_get_form(action, except: [:q])
   = form_hidden_submit
 
   .input-group.search

data/lib/agilibox/cucumber_helpers/capybara.rb

@@ -1,5 +1,6 @@
 Capybara.register_driver :agilibox_no_driver do |_app|
-  raise "You need to add Agilibox::CucumberConfig.require_cuprite! or "\
+  raise \
+    "You need to add Agilibox::CucumberConfig.require_cuprite! or " \
     "Agilibox::CucumberConfig.require_chrome_headless! " \
     "to your features/support/env.rb"
 end

data/lib/agilibox/errors_middleware.rb

@@ -9,6 +9,8 @@ class Agilibox::ErrorsMiddleware
     "ActionController::BadRequest",
     "ActionController::UnknownFormat",
     "ActionController::UnknownHttpMethod",
+    "ActionDispatch::Cookies::CookieOverflow",
+    "ActionDispatch::Http::MimeNegotiation::InvalidType",
     "ActionView::MissingTemplate",
     "Mime::Type::InvalidMimeType",
   ]

data/lib/agilibox/version.rb

@@ -1,3 +1,3 @@
 module Agilibox
-  VERSION = "1.10.0"
+  VERSION = "1.11.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: agilibox
 version: !ruby/object:Gem::Version
-  version: 1.10.0
+  version: 1.11.0
 platform: ruby
 authors:
 - agilidée
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-08-24 00:00:00.000000000 Z
+date: 2021-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails-i18n
@@ -80,6 +80,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: addressable
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Agilibox
 email:
 - contact@agilidee.com
@@ -125,7 +139,6 @@ files:
 - app/filters/agilibox/small_data/filter_strategy_by_key_value.rb
 - app/filters/agilibox/small_data/filter_strategy_by_key_values.rb
 - app/filters/agilibox/small_data/filter_strategy_by_tags.rb
-- app/filters/agilibox/small_data/filter_strategy_by_time_period.rb
 - app/forms/agilibox/mini_form_object.rb
 - app/helpers/agilibox/all_helpers.rb
 - app/helpers/agilibox/bootstrap_helper.rb

data/app/filters/agilibox/small_data/filter_strategy_by_time_period.rb

@@ -1,6 +0,0 @@
-class Agilibox::SmallData::FilterStrategyByTimePeriod
-  def initialize(*)
-    raise "FilterStrategyByTimePeriod is deprecated, please use " \
-      "FilterStrategyByDatePeriod or FilterStrategyByDatetimePeriod"
-  end
-end