aggregate_root 2.18.0 → 2.19.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 56864e85e76ea281fe3dbcf40ab87785c95307aa71097b3dc91e4609c181749f
-  data.tar.gz: 5574046f25ff2e665576c952b7611b10c2c709da90782498f6d434a3548423f4
+  metadata.gz: cea5ad2176ba3e7cb7bf1b4c7b02e0b3b0fd9ed6c77b1316b3d793a8ce9f3a5b
+  data.tar.gz: 5a3d5ff57b4da8e5fe2798beb18d975b41ebeea2ffa59b6665ca8dae46a255d3
 SHA512:
-  metadata.gz: 9755d680ac7e7c242022fa80e6986cb14b51f50a0e8d807716749eaace9c82fc39b1268c9405fb258b81cc1df672aaf8a70ed680d3a021690daef8983a7f4000
-  data.tar.gz: 595e79c6455e3af191991e7830fae076f4e80523dc661d8fc7e7ab8624338296f56c98be13f9ea597b750e134da28e0c06d0b9ce874240471304eda21c28416b
+  metadata.gz: 3dcac31c42eb2620a1cb0fabb173e1ea8f79e1b024154076cf08a341b0393bedf87852dfedd933471c50da1526e7c1bfcd2ca6928bc9d2dfa1a1f7b732bba9e5
+  data.tar.gz: bdca6260756887094170d161132593cc0ce5996954049070b04f4c9b8a7c80ae19cb0dfc22f1a0eb1c33a39e1201b7c86c6a2c3ad3734f732f91d53c46e1dfbd

data/lib/aggregate_root/configuration.rb

@@ -6,6 +6,10 @@ module AggregateRoot
   end
 
   def self.configure
+    warn <<~EOW
+      DEPRECATION WARNING: `AggregateRoot.configure` and `AggregateRoot::Configuration` are deprecated and will be removed in the next major release.
+      Use `AggregateRoot::Repository.new(event_store)` with explicit event store injection instead.
+    EOW
     self.configuration ||= Configuration.new
     yield(configuration)
   end

data/lib/aggregate_root/default_apply_strategy.rb

@@ -4,6 +4,17 @@ module AggregateRoot
   MissingHandler = Class.new(StandardError)
 
   class DefaultApplyStrategy
+    DEPRECATION_MESSAGE = <<~EOW
+      Handling events via apply_* method naming convention is deprecated and will be removed in the next major release.
+
+      Use the on DSL instead:
+
+        on %s do |event|
+          # your code
+        end
+    EOW
+    private_constant :DEPRECATION_MESSAGE
+
     def initialize(strict: true)
       @strict = strict
     end
@@ -20,15 +31,19 @@ module AggregateRoot
     private
 
     def handler_name(aggregate, event)
-      on_dsl_handler_name(aggregate, event.event_type) || apply_handler_name(event.event_type)
+      on_dsl_handler_name(aggregate, event.event_type) || apply_handler_name(aggregate, event.event_type)
     end
 
     def on_dsl_handler_name(aggregate, event_type)
       aggregate.class.on_methods[event_type] if aggregate.class.respond_to?(:on_methods)
     end
 
-    def apply_handler_name(event_type)
-      "apply_#{Transform.to_snake_case(event_type(event_type))}"
+    def apply_handler_name(aggregate, event_type)
+      name = "apply_#{Transform.to_snake_case(event_type(event_type))}"
+      if aggregate.respond_to?(name, true)
+        warn DEPRECATION_MESSAGE % event_type
+      end
+      name
     end
 
     def event_type(event_type)

data/lib/aggregate_root/repository.rb

@@ -8,7 +8,8 @@ module AggregateRoot
 
     def load(aggregate, stream_name)
       event_store.read.stream(stream_name).reduce { |_, ev| aggregate.apply(ev) }
-      aggregate.version = aggregate.unpublished_events.count - 1
+      event_count = aggregate.unpublished_events.size # mutant:disable
+      aggregate.version = event_count - 1
       aggregate
     end
 
@@ -18,7 +19,8 @@ module AggregateRoot
         stream_name: stream_name,
         expected_version: aggregate.version,
       )
-      aggregate.version = aggregate.version + aggregate.unpublished_events.count
+      event_count = aggregate.unpublished_events.size # mutant:disable
+      aggregate.version = aggregate.version + event_count
     end
 
     def with_aggregate(aggregate, stream_name, &block)
@@ -31,6 +33,10 @@ module AggregateRoot
     attr_reader :event_store
 
     def default_event_store
+      warn <<~EOW
+        DEPRECATION WARNING: Calling `AggregateRoot::Repository.new` without an event store argument relies on `AggregateRoot::Configuration` which is deprecated and will be removed in the next major release.
+        Use `AggregateRoot::Repository.new(event_store)` with explicit event store injection instead.
+      EOW
       AggregateRoot.configuration.default_event_store
     end
   end

data/lib/aggregate_root/snapshot_repository.rb

@@ -35,15 +35,16 @@ module AggregateRoot
         end
       end
       query.reduce { |_, ev| aggregate.apply(ev) }
-      aggregate.version = aggregate.version + aggregate.unpublished_events.count
+      event_count = aggregate.unpublished_events.size # mutant:disable
+      aggregate.version = aggregate.version + event_count
       aggregate
     end
 
     def store(aggregate, stream_name)
       events = aggregate.unpublished_events.to_a
       event_store.publish(events, stream_name: stream_name, expected_version: aggregate.version)
-
-      aggregate.version = aggregate.version + events.count
+      published_count = events.size # mutant:disable
+      aggregate.version = aggregate.version + published_count
 
       if time_for_snapshot?(aggregate.version, events.size)
         begin

data/lib/aggregate_root/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AggregateRoot
-  VERSION = "2.18.0"
+  VERSION = "2.19.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: aggregate_root
 version: !ruby/object:Gem::Version
-  version: 2.18.0
+  version: 2.19.0
 platform: ruby
 authors:
 - Arkency
@@ -15,14 +15,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.18.0
+        version: 2.19.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.18.0
+        version: 2.19.0
 email: dev@arkency.com
 executables: []
 extensions: []
@@ -62,7 +62,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.7.2
+rubygems_version: 4.0.6
 specification_version: 4
 summary: Event sourced aggregate root implementation for RubyEventStore
 test_files: []