aggcat 0.2.5 → 0.2.6

data/lib/aggcat/client.rb

@@ -26,10 +26,10 @@ module Aggcat
       post("/institutions/#{institution_id}/logins", body)
     end
 
-    def account_confirmation(institution_id, challenge_session_id, challenge_node_id, answer)
-      validate(institution_id: institution_id, challenge_node_id: challenge_session_id, challenge_node_id: challenge_node_id, answer: answer)
+    def account_confirmation(institution_id, challenge_session_id, challenge_node_id, answers)
+      validate(institution_id: institution_id, challenge_node_id: challenge_session_id, challenge_node_id: challenge_node_id, answers: answers)
       headers = {'challengeSessionId' => challenge_session_id, 'challengeNodeId' => challenge_node_id}
-      post("/institutions/#{institution_id}/logins", challenge_answer(answer), headers)
+      post("/institutions/#{institution_id}/logins", challenge_answers(answers), headers)
     end
 
     def accounts
@@ -56,10 +56,10 @@ module Aggcat
       put("/logins/#{login_id}?refresh=true", body)
     end
 
-    def update_login_confirmation(login_id, challenge_session_id, challenge_node_id, answer)
-      validate(login_id: login_id, challenge_node_id: challenge_session_id, challenge_node_id: challenge_node_id, answer: answer)
-      headers = {challengeSessionId: challenge_session_id, challengeNodeId: challenge_node_id}
-      put("/logins/#{login_id}?refresh=true", challenge_answer(answer), headers)
+    def update_login_confirmation(login_id, challenge_session_id, challenge_node_id, answers)
+      validate(login_id: login_id, challenge_node_id: challenge_session_id, challenge_node_id: challenge_node_id, answers: answers)
+      headers = {'challengeSessionId' => challenge_session_id, 'challengeNodeId' => challenge_node_id}
+      put("/logins/#{login_id}?refresh=true", challenge_answers(answers), headers)
     end
 
     def delete_account(account_id)
@@ -143,14 +143,17 @@ module Aggcat
       end
     end
 
-    def challenge_answer(answer)
+    def challenge_answers(answers)
       xml = Builder::XmlMarkup.new
       xml.InstitutionLogin('xmlns' => LOGIN_NAMESPACE) do |login|
         login.challengeResponses do |challenge|
-          challenge.response(answer, 'xmlns' => CHALLENGE_NAMESPACE)
+          [answers].flatten.each do |answer|
+            challenge.response(answer, 'xmlns' => CHALLENGE_NAMESPACE)
+          end
         end
       end
     end
+
   end
 end
 

data/lib/aggcat/version.rb

@@ -1,3 +1,3 @@
 module Aggcat
-  VERSION = '0.2.5'
+  VERSION = '0.2.6'
 end

data/test/aggcat/client_test.rb

@@ -189,6 +189,17 @@ class ClientTest < Test::Unit::TestCase
     @client.account_confirmation(institution_id, challenge_session_id, challenge_node_id, answer)
   end
 
+  def test_account_confirmation_multi_answer
+    institution_id = '100000'
+    challenge_session_id = '1234'
+    challenge_node_id = '4321'
+    answers = ['answer1', 'answer2']
+    parser = XmlHasher::Parser.new(snakecase: true, ignore_namespaces: true)
+    stub_get("/institutions/#{institution_id}").to_return(:body => fixture('institution.xml'), :headers => {:content_type => 'application/xml; charset=utf-8'})
+    stub_post("/institutions/#{institution_id}/logins").to_return(:body => lambda { |request| assert_equal(parser.parse(fixture('challenges.xml')), parser.parse(request.body)) })
+    @client.account_confirmation(institution_id, challenge_session_id, challenge_node_id, answers)
+  end
+
   def test_update_login_confirmation
     login_id = '1234567890'
     challenge_session_id = '1234'
@@ -204,6 +215,21 @@ class ClientTest < Test::Unit::TestCase
     @client.update_login_confirmation(login_id, challenge_session_id, challenge_node_id, answer)
   end
 
+  def test_update_login_confirmation_multi_answers
+    login_id = '1234567890'
+    challenge_session_id = '1234'
+    challenge_node_id = '4321'
+    answers = ['answer1', 'answer2']
+    validator = lambda do |request|
+      parser = XmlHasher::Parser.new(snakecase: true, ignore_namespaces: true)
+      assert_equal(parser.parse(fixture('challenges.xml')), parser.parse(request.body))
+      assert_equal(challenge_session_id, request.headers['Challengesessionid'])
+      assert_equal(challenge_node_id, request.headers['Challengenodeid'])
+    end
+    stub_put("/logins/#{login_id}?refresh=true").to_return(:body => validator)
+    @client.update_login_confirmation(login_id, challenge_session_id, challenge_node_id, answers)
+  end
+
   def test_retry_success
     institution_id = '100000'
     stub_get("/institutions/#{institution_id}").to_timeout.times(1).then.to_return(:body => fixture('institution.xml'), :headers => {:content_type => 'application/xml; charset=utf-8'})

data/test/fixtures/challenges.xml

@@ -0,0 +1,6 @@
+<InstitutionLogin xmlns:v1="http://schema.intuit.com/platform/fdatafeed/institutionlogin/v1">
+  <challengeResponses>
+    <response xmlns:v11="http://schema.intuit.com/platform/fdatafeed/challenge/v1">answer1</response>
+    <response xmlns:v11="http://schema.intuit.com/platform/fdatafeed/challenge/v1">answer2</response>
+  </challengeResponses>
+</InstitutionLogin>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: aggcat
 version: !ruby/object:Gem::Version
-  version: 0.2.5
+  version: 0.2.6
   prerelease: 
 platform: ruby
 authors:
@@ -148,6 +148,7 @@ files:
 - test/fixtures/accounts.xml
 - test/fixtures/cert.key
 - test/fixtures/challenge.xml
+- test/fixtures/challenges.xml
 - test/fixtures/institution.xml
 - test/fixtures/institutions.xml
 - test/fixtures/login.xml
@@ -186,6 +187,7 @@ test_files:
 - test/fixtures/accounts.xml
 - test/fixtures/cert.key
 - test/fixtures/challenge.xml
+- test/fixtures/challenges.xml
 - test/fixtures/institution.xml
 - test/fixtures/institutions.xml
 - test/fixtures/login.xml