agent_cooper 0.0.6 → 0.0.7.pre

data/lib/agent_cooper/response.rb

@@ -1,35 +1,34 @@
-require 'nokogiri'
-
 module AgentCooper
   class Response
 
-    def initialize(response)
-      @response = response
-    end
+    include Virtus
+
+    attribute :response, Object, :accessor => :protected
 
+    # @api public
     def body
       response.body
     end
 
+    # @api public
     def to_hash
-      xml.to_hash
+      AgentCooper::Builder.from_xml(xml)
     end
 
+    # @api public
     def code
       response.code
     end
 
+    # @api public
     def valid?
       code == 200
     end
 
+    # @api public
     def xml
       @xml ||= Nokogiri::XML(body)
     end
 
-    protected
-
-    attr_reader :response
-
   end
 end

data/lib/agent_cooper/synchrony.rb

@@ -1,31 +1,44 @@
-require 'agent_cooper'
 require 'em-synchrony'
 require 'em-synchrony/em-http'
 
 module AgentCooper
 
   class Request
-    def adapter
-      @adapter ||= EM::HttpRequest
-    end
 
+    # request attributes
+    attribute :request_adapter, Object,
+      :default  => Proc.new { EM::HttpRequest },
+      :accessor => :protected
+
+    # @api public
     def aget(&block)
-      http = adapter.new(url).aget
-      http.callback { block.call(Response.new(http)) }
-      http.errback  { block.call(Response.new(http)) }
+      http = new_adapter.aget
+      http.callback { block.call(Response.new(:response => http)) }
+      http.errback  { block.call(Response.new(:respose  => http)) }
     end
 
+    # @api public
     def get
-      http = adapter.new(url).get
-      Response.new(http)
+      http = new_adapter.get
+      Response.new(:response => http)
+    end
+
+    private
+
+    # @api private
+    def new_adapter
+      request_adapter.new(url)
     end
+
   end
 
   class Response
+    # @api public
     def body
       response.response
     end
 
+    # @api public
     def code
       response.response_header.status
     end

data/lib/agent_cooper/version.rb

@@ -1,3 +1,3 @@
 module AgentCooper
-  VERSION = "0.0.6"
+  VERSION = "0.0.7.pre"
 end

data/spec/agent_cooper/config_spec.rb

@@ -0,0 +1,36 @@
+require "spec_helper"
+
+describe AgentCooper::Config do
+
+  subject { described_class }
+
+  let(:app_id) { "123456ABCD" }
+
+  describe  ".app_id" do
+    before do
+      subject.instance_variable_set(:@app_id, app_id)
+    end
+
+    its(:app_id) { should eql(app_id) }
+  end
+
+  describe ".app_id=" do
+    it "sets app_id" do
+      subject.app_id = app_id
+      subject.instance_variable_get(:@app_id).should eql(app_id)
+    end
+  end
+
+  describe ".configure" do
+    it "yields an AgentCooper::Config" do
+      subject.configure do |obj|
+        obj.should eql(described_class)
+      end
+    end
+
+    context "when no block is given" do
+      it { should raise_error }
+    end
+  end
+
+end

data/spec/agent_cooper/request_spec.rb

@@ -1,117 +1,28 @@
 require 'spec_helper'
 
-module AgentCooper
-
-  describe Request do
-
-    let(:adapter) { mock(HTTPClient) }
-    let(:url)     { 'http://foo.com' }
-
-    let(:response) { 'bar' }
-
-    let(:host)  { 'foo.com' }
-    let(:path)  { '/bar' }
-    let(:query) { 'foo=bar&bar=foo' }
-
-    let(:default_parameters) { {:foo => 'bar'} }
-    let(:parameters)    { {:bar => 'foo'} }
-
-    let(:config) { mock(Config) }
-
-    subject { Request }
-
-    before(:each) do
-      @request = subject.new
-    end
-
-    describe "#app_id" do
-      before(:each) do
-        @request.instance_variable_set(:@config, config)
-      end
-
-      it "calls @config.app_id" do
-        config.should_receive(:app_id)
-        @request.app_id
-      end
-    end
-
-    describe "#adapter" do
-      it "defaults to HTTPClient" do
-        @request.adapter.should be_a(HTTPClient)
-      end
+describe AgentCooper::Request do
+  describe "#parameters" do
+    let(:query_parameters) do
+      { "SECURITY-APPNAME" => "123456",
+        "SECURITY-VERSION" => 781 }
     end
 
-    describe "#get" do
-      before(:each) do
-        adapter.stub(:get).and_return(response)
-
-        @request.stub(:adapter).and_return(adapter)
-        @request.stub(:url).and_return(url)
-      end
-
-      it "calls adapter#get" do
-        adapter.should_receive(:get).with(url)
-        @request.get
-      end
-
-      it "initializes a new AgentCooper::Response" do
-        Response.should_receive(:new).with(response)
-        @request.get
-      end
-
-      it "returns an AgentCooper::Response" do
-        @request.get.should be_a(Response)
-      end
+    let(:default_parameters) do
+      { "REST-PAYLOAD"     => "",
+        "SECURITY-VERSION" => 582 }
     end
 
-    describe "#url" do
-      before(:each) do
-        @request.stub(:host).and_return(host)
-        @request.stub(:path).and_return(path)
-        @request.stub(:query).and_return(query)
-      end
-
-      it "builds the correct url" do
-        URI::HTTP.should_receive(:build).with(:host => host, :path => path, :query => query)
-        @request.url
-      end
-
-      it "returns an instance of URI::HTTP" do
-        @request.url.should be_a(URI::HTTP)
-      end
+    let(:expected_parameters) do
+      { "SECURITY-APPNAME" => "123456",
+        "SECURITY-VERSION" => 781,
+        "REST-PAYLOAD"     => "" }
     end
 
-    describe "#query" do
-      before(:each) do
-        @request.stub(:default_parameters).and_return(default_parameters)
-        @request.stub(:parameters).and_return(parameters)
-      end
-
-      it "returns the query" do
-        @request.query.should == "foo=bar&bar=foo"
-      end
+    before do
+      subject.stub(:default_parameters).and_return(default_parameters)
+      subject.stub(:query_parameters).and_return(query_parameters)
     end
 
-    describe "#parameters" do
-      it "returns a hash" do
-        @request.parameters.should be_a(Hash)
-      end
-    end
-
-    describe "#<<" do
-      it "merges a hash into the existing parameters" do
-        @request << {:foo => "bar"}
-        @request.parameters[:foo].should == "bar"
-      end
-    end
-
-    describe "#reset!" do
-      it "resets the parameters to a blank hash" do
-        @request << {:foo => 'bar'}
-        @request.reset!
-        @request.parameters.should_not have_key(:foo)
-      end
-    end
+    its(:parameters) { should eql(expected_parameters) }
   end
-
-end
+end

data/spec/agent_cooper/requests/finder_spec.rb

@@ -1,13 +1,16 @@
 require 'spec_helper'
 
-module AgentCooper
-  describe Finder do
-
-    subject { Finder.new }
-
-    it "inherits from AgentCooper::Request" do
-      subject.should be_a(Request)
+describe AgentCooper::Finder do
+  it_behaves_like "Request" do
+    let(:expected_default_parameters) do
+      {
+        "SECURITY-APPNAME"     => app_id,
+        "SECURITY-VERSION"     => version,
+        "RESPONSE-DATA-FORMAT" => encoding,
+        "REST-PAYLOAD"         => ""
+      }
     end
 
+    its(:default_parameters) { should eql(expected_default_parameters) }
   end
-end
+end

data/spec/agent_cooper/requests/merchandiser_spec.rb

@@ -1,13 +1,19 @@
 require 'spec_helper'
 
-module AgentCooper
-  describe Merchandiser do
+describe AgentCooper::Merchandiser do
+  it_behaves_like "Request" do
+    let(:service_name) { described_class::SERVICE_NAME }
 
-    subject { Merchandiser.new }
-
-    it "inherits from AgentCooper::Request" do
-      subject.should be_a(Request)
+    let(:expected_default_parameters) do
+      {
+        "CONSUMER-ID"          => app_id,
+        "SERVICE-NAME"         => service_name,
+        "SERVICE-VERSION"      => version,
+        "RESPONSE-DATA-FORMAT" => encoding,
+        "REST-PAYLOAD"         => ""
+      }
     end
 
+    its(:default_parameters) { should eql(expected_default_parameters) }
   end
-end
+end

data/spec/agent_cooper/requests/shopper_spec.rb

@@ -1,13 +1,18 @@
 require 'spec_helper'
 
-module AgentCooper
-  describe Shopper do
+describe AgentCooper::Shopper do
+  it_behaves_like "Request" do
+    let(:site_id) { described_class::SITE_ID }
 
-    subject { Shopper.new }
-
-    it "inherits from AgentCooper::Request" do
-      subject.should be_a(Request)
+    let(:expected_default_parameters) do
+      {
+        "APPID"            => app_id,
+        "RESPONSEENCODING" => encoding,
+        "VERSION"          => version,
+        "SITEID"           => site_id
+      }
     end
 
+    its(:default_parameters) { should eql(expected_default_parameters) }
   end
-end
+end

data/spec/agent_cooper/response_spec.rb

@@ -1,57 +1,25 @@
 require 'spec_helper'
 
-module AgentCooper
-  describe Response do
-
-    let(:response) { '<root><item></item></root>' }
-
-    subject { Response.new(response) }
-
-    before(:each) do
-      response.stub(:body).and_return(response)
-    end
-
-    describe "#body" do
-      it "delegates to response#code" do
-        response.should_receive(:body)
-        subject.body
-      end
-    end
-
-    describe "#to_hash" do
-      it "converts the xml to a hash" do
-        subject.to_hash.should == { "item"=> {} }
-      end
-    end
-
-    describe "#code" do
-      it "delegate to response#code" do
-        response.should_receive(:code)
-        subject.code
-      end
-    end
-
-    describe "#valid?" do
-      context "#code returns '200'" do
-        before(:each) do
-          subject.stub(:code).and_return(200)
-        end
-
-        it "returns true" do
-          subject.valid?.should be_true
-        end
-      end
-
-      context "#code does not return '200'" do
-        before(:each) do
-          subject.stub(:code).and_return(500)
-        end
-
-        it "returns false" do
-          subject.valid?.should be_false
-        end
-      end
-    end
+describe AgentCooper::Response do
 
+  subject { described_class.new(:response => response) }
+
+  let(:body) { "<root><foo>bar</foo></root>" }
+  let(:code) { 200 }
+
+  let(:response) { mock(:response, :body => body, :code => code) }
+
+  its(:body)    { should eql(body) }
+  its(:code)    { should eql(code) }
+
+  its(:to_hash) { should eql({"foo" => "bar"}) }
+
+  its(:xml)     { should be_a(Nokogiri::XML::Document) }
+  its(:valid?)  { should be_true }
+
+  context "when code != 200" do
+    let(:code) { 400 }
+    its(:valid?) { should be_false }
   end
-end
+
+end

data/spec/agent_cooper_spec.rb

@@ -2,11 +2,14 @@ require 'spec_helper'
 
 describe AgentCooper do
 
-  subject { AgentCooper }
+  subject { described_class }
 
   describe ".configure" do
     it "yields a Config object" do
-      subject.configure {|c| c.should == AgentCooper::Config }
+      subject.configure do |c|
+        c.should == AgentCooper::Config
+      end
     end
   end
+
 end