agen 0.2.1 → 0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 567b4d1df4a054da853eb05a9476bcf9579758cac435e562842c74655e773198
-  data.tar.gz: 86e7947aac95a1fc80822158509b1d2e762a11727eca8abda0001b7de87d2115
+  metadata.gz: edd821d0314f78d537a2228181e4f1dfd0ecaceddc8d8a67bb783499911e7ccb
+  data.tar.gz: 721e0d0871630027ac23c0e08d7dd54e3e20ef26fda674fe755ebb02e0e4be48
 SHA512:
-  metadata.gz: cbaead32095bc304c5bf657426fa66f5b7196c90715a8b8466b597fc578d2c49414f25533bc815946b6bdf20c51af877299bdc3bcba886b4d575864fca04f324
-  data.tar.gz: 1c2b2388b097b4f7a95036be7395569d81b3de1e33630a2ffa1b5c262898dbda59742a62a6d88e9d0eb615dcba2375cbf7430472aeb99a77efe03fefa61e60c5
+  metadata.gz: f2c802aa56ab03338dbe58638a5ab5cf525c13ffef6b0a6b11e5aff39b430d4645f3116d6d49e37425df1704029148ca8df3d8d5dc4af84d0b3dff8ff8263d1c
+  data.tar.gz: d02a95bbee062a61ebe93160c03f773706e45264b09cd4cae9a2aab2c1a45c97078192b399466854e22e87d80266c6aa29e61167ce3f8b726b4a07180311a450

data/.github/workflows/main.yml

@@ -12,5 +12,7 @@ jobs:
       with:
         ruby-version: 3.0.1
         bundler-cache: true
-    - name: Run the default task
+    - name: Lint
+      run: bundle exec rake standard
+    - name: Test
       run: bundle exec rake

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## [Released]
 
+## [0.3] - 2021-06-17
+- Adds support for bash shell.
+- Adds ability to pass custom rcfile and histfile options.
+
 ## [0.2.1] - 2021-05-01
 - Adds ability to modify aliases before writing them in interactive mode.
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    agen (0.2.1)
+    agen (0.3)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -4,6 +4,9 @@
 
 Generate shell aliases based on your most commonly entered commands.
 
+https://user-images.githubusercontent.com/22665228/116796045-5e5a8280-aa8e-11eb-8b4c-4408a252c143.mov
+
+
 ## Installation & Usage
 
 Install with `gem install agen` and then run `agen` to build your aliases. Then
@@ -14,10 +17,11 @@ available options.
 Usage: agen [options]
     -n, --number=NUMBER              Number of aliases to generate
     -a, --auto                       Aliases will be generated and applied automatically
+    -r, --rcfile=RCFILE              Path to shell rc file
+    -h, --histfile=HISTFILE          Path to shell history file
 ```
 
-Right now, this will only work with `zsh`, but support for other shells is on
-the very lengthy todo list. By default, agen reads from `.zsh_history` and
+Right now, this will only work with `zsh` or `bash`, but you can specify unique shell config files using the `-r` and `-h` options (though there is no guarantee that your history file will be read properly). By default, agen reads from `.zsh_history` and
 writes to `.zshrc`.
 
 ## Development
@@ -32,14 +36,10 @@ Bug reports and pull requests are welcome on GitHub at https://github.com/Jonath
 
 ## Roadmap
 
-* CLI will support any (or most common) shells, and will find history and rc
-   file dynamically.
-* CLI will let you specific which history file to read from, and which file to output aliases to.
-* CLI will let you interactively modify proposed aliases.
 * CLI will let you "ignore" commands you don't want to alias, forever.
+* CLI will raise user friendly errors if you specify shell configuration files that don't exist.
 * CLI will let you specify "meta" vs "full" commands.
-  - Full command would be `git checkout branch-name`, meta command would be
-      `git checkout`.
+  - Full command would be `git checkout branch-name`, meta command would be `git checkout`.
 
 ## License
 

data/lib/agen.rb

@@ -1,6 +1,10 @@
 # frozen_string_literal: true
 
 require_relative "agen/version"
+require_relative "agen/base_options"
+require_relative "agen/bash_options"
+require_relative "agen/zsh_options"
+require_relative "agen/shell"
 require_relative "agen/cli"
 require_relative "agen/builder"
 require_relative "agen/finder"

data/lib/agen/base_options.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+module Agen
+  class BaseOptions
+    def initialize(options)
+      @options = options
+    end
+
+    def set_histfile
+      # handle not set here
+      if !defined?(self.class::HISTFILE)
+        puts "Please specify shell history file with -h option. See agen --help."
+        return false
+      end
+
+      options.tap do |opts|
+        opts[:histfile] = self.class::HISTFILE
+      end
+    end
+
+    def set_rcfile
+      if !defined?(self.class::RCFILE)
+        puts "Please specify shell rc file with -r option. See agen --help."
+        return false
+      end
+
+      options.tap do |opts|
+        opts[:rcfile] = self.class::RCFILE
+      end
+    end
+
+    private
+
+    attr_reader :options
+  end
+end

data/lib/agen/bash_options.rb

@@ -0,0 +1,8 @@
+# frozen_string_literal: true
+
+module Agen
+  class BashOptions < BaseOptions
+    HISTFILE = "#{Dir.home}/.bash_history"
+    RCFILE = "#{Dir.home}/.bashrc"
+  end
+end

data/lib/agen/cli.rb

@@ -21,8 +21,19 @@ module Agen
         opts.on("-a", "--auto", "Aliases will be generated and applied automatically") do |a|
           options[:auto] = a
         end
+
+        opts.on("-rRCFILE", "--rcfile=RCFILE", String, "Path to shell rc file") do |r|
+          options[:rcfile] = r
+        end
+
+        opts.on("-hHISTFILE", "--histfile=HISTFILE", String, "Path to shell history file") do |h|
+          options[:histfile] = h
+        end
       end.parse!
 
+      options = Shell.new(options).add_options
+      return unless options
+
       Runner.new(**options).run
     end
   end

data/lib/agen/finder.rb

@@ -14,7 +14,8 @@ module Agen
         .each_with_object(Hash.new(0)) do |line, commands|
         cmd = line.split(";").last.delete("\n")
         commands[cmd] += 1 if cmd != ""
-      rescue
+      rescue => e
+        puts e
       end
         .sort_by { |k, v| -v }
         .to_h

data/lib/agen/runner.rb

@@ -2,8 +2,8 @@
 
 module Agen
   class Runner
-    DEFAULT_HISTFILE = "#{Dir.home}/.zsh_history"
-    DEFAULT_RCFILE = "#{Dir.home}/.zshrc"
+    DEFAULT_HISTFILE = ZshOptions::HISTFILE
+    DEFAULT_RCFILE = ZshOptions::RCFILE
     DEFAULT_NUMBER = 5
 
     attr_reader :histfile, :rcfile

data/lib/agen/shell.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+module Agen
+  class Shell
+    def initialize(options)
+      @options = options
+    end
+
+    def add_options
+      if !@options[:histfile]
+        @options = opts_klass.set_histfile
+      end
+
+      if @options && !@options[:rcfile]
+        @options = opts_klass.set_rcfile
+      end
+
+      @options
+    end
+
+    private
+
+    def bash?
+      @_bash ||= shell.match?(/bash/)
+    end
+
+    def opts_klass
+      @_opts_klass ||= if bash?
+        BashOptions
+      elsif zsh?
+        ZshOptions
+      else
+        BaseOptions
+      end.new(@options)
+    end
+
+    def shell
+      @_shell ||= ENV["SHELL"]
+    end
+
+    def zsh?
+      @_zsh ||= shell.match?(/zsh/)
+    end
+  end
+end

data/lib/agen/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Agen
-  VERSION = "0.2.1"
+  VERSION = "0.3"
 end

data/lib/agen/zsh_options.rb

@@ -0,0 +1,8 @@
+# frozen_string_literal: true
+
+module Agen
+  class ZshOptions < BaseOptions
+    HISTFILE = "#{Dir.home}/.zsh_history"
+    RCFILE = "#{Dir.home}/.zshrc"
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: agen
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: '0.3'
 platform: ruby
 authors:
 - Jonathan Thom
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-05-01 00:00:00.000000000 Z
+date: 2021-06-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -75,11 +75,15 @@ files:
 - bin/setup
 - exe/agen
 - lib/agen.rb
+- lib/agen/base_options.rb
+- lib/agen/bash_options.rb
 - lib/agen/builder.rb
 - lib/agen/cli.rb
 - lib/agen/finder.rb
 - lib/agen/runner.rb
+- lib/agen/shell.rb
 - lib/agen/version.rb
+- lib/agen/zsh_options.rb
 homepage: https://github.com/JonathanWThom/agen
 licenses:
 - MIT