afterbanks-psd2-api-ruby 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 74a77be49119cc3b5c78ebcdb319db8f2fb0dc240d9c7374c5a65bfeee4086ca
-  data.tar.gz: 75d2475c8af58adfb6cf21954057a7076f8367da1b31f9dc0315fa0e05e79d72
+  metadata.gz: b231b2ae3d5d4a5dcc4da8e04c765b9ff797e65e63b3175e4c40e08aac7aee9c
+  data.tar.gz: 19a60b950a91ffa7960c29038ac4dd93d9e8ba1d069ff69155f02ddcecf2ff85
 SHA512:
-  metadata.gz: f8978cabe120ef0cdfc65618af4515587f2120c6c0272e0deeffee291f1c0f87a3b25e78079bdc8075594205cc408c83485372361895178596a94f2d6c058cd1
-  data.tar.gz: 6b01263e08c321231c7e93111e1752ab9dc4e20b36d45018f35238a59c9bd0cfb90a04ee59160abbd3b531b12b3857010c2dd807d9bf1d103c58c1b162fb56de
+  metadata.gz: ae3cb367d060dd1993b83ca1a38a8bc4759460e1ba80e7c0af2c553b2132605431fe28ffa6dec8a8246ced047b472a7a37acff1e04116dd2094ac93bd7dfceb9
+  data.tar.gz: 361d21c49d77cae9c3011fe8dd6a0131432273a03f74a290b244dbf0baf86ef4179e9989ff6f4e559405caa0fcd7052da91ab701ec5e0b511ad1fe09106d3cf8

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    afterbanks-psd2-api-ruby (0.1.0)
+    afterbanks-psd2-api-ruby (0.1.2)
       rest-client (~> 2.0.2)
 
 GEM
@@ -13,14 +13,15 @@ GEM
     crack (0.4.3)
       safe_yaml (~> 1.0.0)
     diff-lcs (1.3)
-    domain_name (0.5.20190701)
-      unf (>= 0.0.5, < 1.0.0)
+    domain_name (0.6.20240107)
     hashdiff (1.0.1)
-    http-cookie (1.0.3)
+    http-cookie (1.0.8)
       domain_name (~> 0.5)
-    mime-types (3.3.1)
+    logger (1.6.2)
+    mime-types (3.6.0)
+      logger
       mime-types-data (~> 3.2015)
-    mime-types-data (3.2020.1104)
+    mime-types-data (3.2024.1203)
     netrc (0.11.0)
     parallel (1.19.1)
     parser (3.0.0.0)
@@ -64,9 +65,6 @@ GEM
     ruby-progressbar (1.10.1)
     safe_yaml (1.0.5)
     timecop (0.9.2)
-    unf (0.1.4)
-      unf_ext
-    unf_ext (0.0.7.7)
     unicode-display_width (1.6.0)
     webmock (3.8.3)
       addressable (>= 2.3.6)

data/README.md

@@ -33,6 +33,8 @@ You can set a `logger` as well.
 Changelog
 ---------
 
+* 0.1.2 Add AccountNotFoundError (need for Revolut rules changes) 
+* 0.1.1 Fix options parameters to ensure not null and check other parameters on Transaction.list
 * 0.1.0 First full version, including resource wrapping (banks, user, accounts, transactions), error coverage and support for logging
 
 TODO
@@ -54,6 +56,7 @@ List of Error
  * `C005` -> MaximumNumberOfCallsReachedConsentError
  * `T000` -> GenericTransactionError
  * `T001` -> InvalidConsentForProductError
+ * `P000` -> AccountNotFoundError
 
 
 

data/lib/afterbanks_psd2/base.rb

@@ -12,6 +12,8 @@ module AfterbanksPSD2
     end
 
     def api_call(method:, path:, params: {}, options: {})
+      options = {} if options.nil?
+
       api_url = ENV['AFTERBANKS_API_URL'] || 'https://apipsd2.afterbanks.com'
       url = api_url + path
 
@@ -125,6 +127,8 @@ module AfterbanksPSD2
         raise GenericTransactionError.new(**error_info)
       when 'T001'
         raise InvalidConsentForProductError.new(**error_info)
+      when 'P000'
+        raise AccountNotFoundError.new(**error_info)
       end
 
       nil

data/lib/afterbanks_psd2/error.rb

@@ -73,4 +73,10 @@ module AfterbanksPSD2
       'T001'
     end
   end
+
+  class AccountNotFoundError < Error
+    def code
+      'P000'
+    end
+  end
 end

data/lib/afterbanks_psd2/resources/transaction.rb

@@ -10,6 +10,12 @@ module AfterbanksPSD2
                account:        { type: :afterbankspsd2_account }
 
     def self.list(token:, products:, start_date:)
+      raise ArgumentError, "Token is missing" if token.nil? || token.empty?
+      raise ArgumentError, "Products must be a string" unless products.is_a?(String)
+      raise ArgumentError, "Products is missing" if products.nil? || products.empty?
+      raise ArgumentError, "Start date is missing" if start_date.nil? || products.empty?
+      raise ArgumentError, "Start date must be a Date" unless start_date.is_a?(Date)
+
       params = {
         servicekey: AfterbanksPSD2.configuration.servicekey,
         token:      token,
@@ -17,6 +23,8 @@ module AfterbanksPSD2
         startDate:  start_date.strftime("%d-%m-%Y")
       }
 
+      options = {}
+
       # if the start_date is older than 90 days, we need to increase timeout to 2 hours
       if start_date < Date.today << 3
         options = {
@@ -46,7 +54,7 @@ module AfterbanksPSD2
 
     def self.transactions_information_for(response:, products:)
       transactions_information = []
-      products_array = products.split(",")
+      products_array = products.to_s.split(",").map(&:strip)
 
       response.each do |account_information|
         product = account_information['product']

data/lib/afterbanks_psd2/version.rb

@@ -1,3 +1,3 @@
 module AfterbanksPSD2
-  VERSION = "0.1.0"
+  VERSION = "0.1.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: afterbanks-psd2-api-ruby
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - Florent Lemaitre
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-10-14 00:00:00.000000000 Z
+date: 2024-12-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client