afterbanks-api-ruby 0.3.4 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 47ce0303d43a61ed4dbb9995e830c150b9ce17381680d6d60c0ca4fb3c57c18a
-  data.tar.gz: 0b3809056462a943e2aef44c2046686a244c282714f12f8f2fbbcfaf98610260
+  metadata.gz: c495dddbe9aaa82bc1c801dfd0a1c52c40913369cb20a47e1cd3dc997b300d26
+  data.tar.gz: 49a481b3a5c3c1057f8c03ec0fd5fd1b3c1b7a06605abf2d4994a695b1733b64
 SHA512:
-  metadata.gz: 58b5066534be42b43d178b48f2b601f11cee1f7ebf57d481a68536c904f88db7ecf735200f33bcafea85e280c9b165adbbe5881c7a71030584666dfb2ec073ac
-  data.tar.gz: 7a17bfa456463b898ceace9a0fae98b2fd4d885a339b4924116128d2b8a8c57884a11d8a230dd6c7765bef6f52d7b72ea453d68be111ac430ebe506c4ab721bb
+  metadata.gz: 9e26fb7e10161b345708ebcdd4516622cb6bd1971586801022678ba1ebc3837287b68d1d932dc23c91ab5c98e28f554d59f5af2ccf8b99d295103842dd408642
+  data.tar.gz: cd28df51ed0cd1e41be1ef057a746ac4e918632e299551a20c3b2615d5828ce380adce0e87dfdf4eeee07b3b35146d5d29ba95cb0ef12712af2f0e2715f29626

data/.circleci/config.yml

@@ -4,7 +4,7 @@ executors:
   gem-executor:
     working_directory: ~/tmp/gem
     docker:
-      - image: circleci/ruby:2.4.1
+      - image: circleci/ruby:2.7.5
     environment:
       TZ: "Europe/Madrid"
 
@@ -16,7 +16,7 @@ jobs:
 
       - run:
           name: Update bundler
-          command: gem install bundler -v 1.17.3
+          command: gem install bundler -v 2.2.25
 
       - restore_cache:
           keys:
@@ -34,6 +34,10 @@ jobs:
           name: Run rspec
           command: bundle exec rspec spec/
 
+      - run:
+          name: Run Rubocop
+          command: bundle exec rubocop
+
 workflows:
   build-test-gem:
     jobs:

data/.rubocop.yml

@@ -0,0 +1,45 @@
+inherit_from: .rubocop_exclusions.yml
+
+# General configuration
+AllCops:
+  DisabledByDefault: true
+  Include:
+    - 'lib/**/*.rb'
+    - 'spec/**/*.rb'
+  NewCops: enable
+  SuggestExtensions: false
+  TargetRubyVersion: 2.7.5
+
+# Explicit configuration
+Bundler:
+  Enabled: true
+
+Lint:
+  Enabled: true
+
+Layout:
+  Enabled: true
+
+Layout/BlockAlignment:
+  EnforcedStyleAlignWith: start_of_block
+
+Layout/HashAlignment:
+  AllowMultipleStyles: true
+  EnforcedHashRocketStyle: table
+  EnforcedColonStyle: table
+
+Layout/MultilineMethodCallIndentation:
+  Enabled: true
+  EnforcedStyle: indented_relative_to_receiver
+
+Security:
+  Enabled: true
+
+Style/CollectionMethods:
+  Enabled: true
+  PreferredMethods:
+    inject: "inject"
+    collect: "map"
+
+Style/Documentation:
+  Enabled: false

data/.rubocop_exclusions.yml

@@ -0,0 +1,28 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2022-09-30 09:45:27 UTC using RuboCop version 1.36.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 4
+Security/MarshalLoad:
+  Exclude:
+    - 'spec/afterbanks/resources/account_spec.rb'
+    - 'spec/afterbanks/resources/bank_spec.rb'
+    - 'spec/afterbanks/resources/transaction_spec.rb'
+    - 'spec/afterbanks/resources/user_spec.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 149
+
+# Offense count: 2
+Lint/MissingSuper:
+  Exclude:
+    - 'lib/afterbanks/collection.rb'
+    - 'lib/afterbanks/error.rb'

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    afterbanks-api-ruby (0.3.4)
+    afterbanks-api-ruby (0.4.1)
       rest-client (~> 2.0.2)
 
 GEM
@@ -9,6 +9,7 @@ GEM
   specs:
     addressable (2.8.0)
       public_suffix (>= 2.0.2, < 5.0)
+    ast (2.4.2)
     crack (0.4.3)
       safe_yaml (~> 1.0.0)
     diff-lcs (1.3)
@@ -17,16 +18,23 @@ GEM
     hashdiff (1.0.0)
     http-cookie (1.0.4)
       domain_name (~> 0.5)
+    json (2.6.2)
     mime-types (3.3.1)
       mime-types-data (~> 3.2015)
     mime-types-data (3.2021.0704)
     netrc (0.11.0)
+    parallel (1.22.1)
+    parser (3.1.2.1)
+      ast (~> 2.4.1)
     public_suffix (4.0.6)
+    rainbow (3.1.1)
     rake (13.0.1)
+    regexp_parser (2.6.0)
     rest-client (2.0.2)
       http-cookie (>= 1.0.2, < 2.0)
       mime-types (>= 1.16, < 4.0)
       netrc (~> 0.8)
+    rexml (3.2.5)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
       rspec-expectations (~> 3.9.0)
@@ -40,11 +48,27 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
     rspec-support (3.9.0)
+    rubocop (1.36.0)
+      json (~> 2.3)
+      parallel (~> 1.10)
+      parser (>= 3.1.2.1)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.20.1, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 3.0)
+    rubocop-ast (1.21.0)
+      parser (>= 3.1.1.0)
+    rubocop-rspec (2.13.2)
+      rubocop (~> 1.33)
+    ruby-progressbar (1.11.0)
     safe_yaml (1.0.5)
     timecop (0.9.1)
     unf (0.1.4)
       unf_ext
     unf_ext (0.0.7.7)
+    unicode-display_width (2.3.0)
     webmock (3.7.6)
       addressable (>= 2.3.6)
       crack (>= 0.3.2)
@@ -58,8 +82,10 @@ DEPENDENCIES
   bundler
   rake
   rspec
+  rubocop
+  rubocop-rspec
   timecop
   webmock
 
 BUNDLED WITH
-   1.17.3
+   2.2.25

data/README.md

@@ -33,6 +33,8 @@ You can set a `logger` as well.
 Changelog
 ---------
 
+* v.0.4.1 Increased timeout from 5min to 15min
+* v.0.4.0 Add new, opt-in error for missing product, and several internal improvements
 * v.0.3.4 Security: upgrade addressable from 2.7.0 to 2.8.0
 * v.0.3.3 Transaction and Account are compatible with account ID
 * v.0.3.2 Properly handle account ID needed errors

data/afterbanks.gemspec

@@ -24,6 +24,8 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
+  spec.add_development_dependency "rubocop"
+  spec.add_development_dependency 'rubocop-rspec'
   spec.add_development_dependency "timecop"
   spec.add_development_dependency "webmock"
 end

data/lib/afterbanks/base.rb

@@ -3,8 +3,6 @@ require 'json'
 
 module Afterbanks
   class << self
-    attr_accessor :configuration
-
     def configuration
       @configuration ||= Configuration.new
     end
@@ -16,8 +14,9 @@ module Afterbanks
     def api_call(method:, path:, params: {})
       url = 'https://api.afterbanks.com' + path
 
-      # Timeout is set to 5min: some banks take a lot to respond (e.g. ING Direct)
-      request_params = { method: method, url: url, timeout: 60*5 }
+      # Timeout is set to 15min: some banks take a lot to respond
+      # (e.g. ING Direct or CaixaBank in some cases)
+      request_params = { method: method, url: url, timeout: 60 * 15 }
 
       if method == :post
         request_params.merge!(payload: params)
@@ -34,9 +33,9 @@ module Afterbanks
       debug_id = response.headers[:debug_id]
 
       log_request(
-        method: method,
-        url: url,
-        params: params,
+        method:   method,
+        url:      url,
+        params:   params,
         debug_id: debug_id
       )
 
@@ -44,7 +43,7 @@ module Afterbanks
 
       treat_errors_if_any(
         response_body: response_body,
-        debug_id: debug_id
+        debug_id:      debug_id
       )
 
       [response_body, debug_id]
@@ -70,13 +69,13 @@ module Afterbanks
       end
 
       logger.info(
-        message: 'Afterbanks request',
-        method: method.upcase.to_s,
-        url: url,
-        time: now.to_s,
+        message:   'Afterbanks request',
+        method:    method.upcase.to_s,
+        url:       url,
+        time:      now.to_s,
         timestamp: now.to_i,
-        debug_id: debug_id || 'none',
-        params: safe_params
+        debug_id:  debug_id || 'none',
+        params:    safe_params
       )
     end
 
@@ -93,28 +92,28 @@ module Afterbanks
 
       case code
       when 1
-        raise GenericError.new(error_info)
+        raise GenericError.new(**error_info)
       when 2
-        raise ServiceUnavailableTemporarilyError.new(error_info)
+        raise ServiceUnavailableTemporarilyError.new(**error_info)
       when 3
-        raise ConnectionDataError.new(error_info)
+        raise ConnectionDataError.new(**error_info)
       when 4
-        raise AccountIdDoesNotExistError.new(error_info)
+        raise AccountIdDoesNotExistError.new(**error_info)
       when 5
-        raise CutConnectionError.new(error_info)
+        raise CutConnectionError.new(**error_info)
       when 6
-        raise HumanActionNeededError.new(error_info)
+        raise HumanActionNeededError.new(**error_info)
       when 50
         unless additional_info
-          raise MissingParameterError.new(error_info)
+          raise MissingParameterError.new(**error_info)
         end
 
         error_info.merge!(additional_info: additional_info)
 
         if additional_info.is_a?(Hash) && additional_info['session_id']
-          raise TwoStepAuthenticationError.new(error_info)
+          raise TwoStepAuthenticationError.new(**error_info)
         else
-          raise AccountIdNeededError.new(error_info)
+          raise AccountIdNeededError.new(**error_info)
         end
       end
 

data/lib/afterbanks/error.rb

@@ -66,4 +66,12 @@ module Afterbanks
       50
     end
   end
+
+  class MissingProductError < Error
+    def code
+      # This is not provided by Afterbanks itself, but an invented unique ID
+      # without overlap from other error codes
+      -1
+    end
+  end
 end

data/lib/afterbanks/resources/account.rb

@@ -1,67 +1,69 @@
 module Afterbanks
   class Account < Resource
-    has_fields service: :string,
-               product: :string,
-               type: :string,
-               balance: :decimal,
-               currency: :string,
+    has_fields service:     :string,
+               product:     :string,
+               type:        :string,
+               balance:     :decimal,
+               currency:    :string,
                description: :string,
-               iban: :string,
-               is_owner: :boolean,
-               holders: :hash
+               iban:        :string,
+               is_owner:    :boolean,
+               holders:     :hash
 
-    def self.list(service:, username:, password:, password2: nil,
-                  document_type: nil, account_id: nil,
-                  session_id: nil, otp: nil, counter_id: nil,
-                  avoid_caching: false)
+    class << self
+      def list(service:, username:, password:, password2: nil,
+               document_type: nil, account_id: nil,
+               session_id: nil, otp: nil, counter_id: nil,
+               avoid_caching: false)
 
-      params = {
-        servicekey: Afterbanks.configuration.servicekey,
-        service: service,
-        user: username,
-        pass: password,
-        products: 'GLOBAL'
-      }
+        params = {
+          servicekey: Afterbanks.configuration.servicekey,
+          service:    service,
+          user:       username,
+          pass:       password,
+          products:   'GLOBAL'
+        }
 
-      params.merge!(pass2: password2) unless password2.nil?
-      params.merge!(documentType: document_type) unless document_type.nil?
-      params.merge!(account_id: account_id) unless account_id.nil?
+        params.merge!(pass2: password2) unless password2.nil?
+        params.merge!(documentType: document_type) unless document_type.nil?
+        params.merge!(account_id: account_id) unless account_id.nil?
 
-      params.merge!(session_id: session_id) unless session_id.nil?
-      params.merge!(OTP: otp) unless otp.nil?
-      params.merge!(counterId: counter_id) unless counter_id.nil?
+        params.merge!(session_id: session_id) unless session_id.nil?
+        params.merge!(OTP: otp) unless otp.nil?
+        params.merge!(counterId: counter_id) unless counter_id.nil?
 
-      params.merge!(randomizer: Time.now.to_i) if avoid_caching
+        params.merge!(randomizer: Time.now.to_i) if avoid_caching
 
-      response, debug_id = Afterbanks.api_call(
-        method: :post,
-        path: '/V3/',
-        params: params
-      )
+        response, debug_id = Afterbanks.api_call(
+          method: :post,
+          path:   '/V3/',
+          params: params
+        )
 
-      Response.new(
-        result: Collection.new(
-          accounts_information_for(
-            response: response,
-            service: service
+        Response.new(
+          result:   Collection.new(
+            accounts_information_for(
+              response: response,
+              service:  service
+            ),
+            self
           ),
-          self
-        ),
-        debug_id: debug_id
-      )
-    end
+          debug_id: debug_id
+        )
+      end
 
     private
 
-    def self.accounts_information_for(response:, service:)
-      accounts_information = []
+      def accounts_information_for(response:, service:)
+        accounts_information = []
 
-      response.each do |account_information|
-        account_information['service'] = service
-        accounts_information << account_information
-      end
+        response.each do |account_information|
+          account_information['service'] = service
+          accounts_information << account_information
+        end
 
-      accounts_information
-    end
+        accounts_information
+      end
+  end
   end
 end

data/lib/afterbanks/resources/bank.rb

@@ -1,111 +1,113 @@
 module Afterbanks
   class Bank < Resource
     has_fields country_code: :string,
-               service: :string,
-               swift: :string,
-               fullname: :string,
-               business: :boolean,
+               service:      :string,
+               swift:        :string,
+               fullname:     :string,
+               business:     :boolean,
                documenttype: :string,
-               user: :string,
-               pass: :string,
-               pass2: :string,
-               userdesc: :string,
-               passdesc: :string,
-               pass2desc: :string,
-               usertype: :string,
-               passtype: :string,
-               pass2type: :string,
-               image: :string,
-               color: :string
-
-    def self.list(ordered: false)
-      response, debug_id = Afterbanks.api_call(
-        method: :get,
-        path: '/forms/'
-      )
-
-      Response.new(
-        result: Collection.new(
-          banks_information_for(
-            response: response,
-            ordered: ordered
+               user:         :string,
+               pass:         :string,
+               pass2:        :string,
+               userdesc:     :string,
+               passdesc:     :string,
+               pass2desc:    :string,
+               usertype:     :string,
+               passtype:     :string,
+               pass2type:    :string,
+               image:        :string,
+               color:        :string
+
+    class << self
+      def list(ordered: false)
+        response, debug_id = Afterbanks.api_call(
+          method: :get,
+          path:   '/forms/'
+        )
+
+        Response.new(
+          result:   Collection.new(
+            banks_information_for(
+              response: response,
+              ordered:  ordered
+            ),
+            self
           ),
-          self
-        ),
-        debug_id: debug_id
-      )
-    end
+          debug_id: debug_id
+        )
+      end
 
     private
 
-    def self.banks_information_for(response:, ordered:)
-      banks_information = []
+      def banks_information_for(response:, ordered:)
+        banks_information = []
 
-      services_number_by_bank_id = {}
-      response.each { |bank_information|
-        bank_id = bank_id_for(bank_information: bank_information)
-        services_number_by_bank_id[bank_id] ||= 0
-        services_number_by_bank_id[bank_id] += 1
-      }
-
-      response.each do |bank_information|
-        bank_information['fullname'] = bank_name_for(
-          bank_information: bank_information,
-          services_number_by_bank_id: services_number_by_bank_id
-        )
+        services_number_by_bank_id = {}
+        response.each { |bank_information|
+          bank_id = bank_id_for(bank_information: bank_information)
+          services_number_by_bank_id[bank_id] ||= 0
+          services_number_by_bank_id[bank_id] += 1
+        }
 
-        banks_information << bank_information
-      end
+        response.each do |bank_information|
+          bank_information['fullname'] = bank_name_for(
+            bank_information:           bank_information,
+            services_number_by_bank_id: services_number_by_bank_id
+          )
+
+          banks_information << bank_information
+        end
 
-      if ordered
-        banks_information.sort! do |bank_information1, bank_information2|
-          bank_information1['fullname'].downcase <=> bank_information2['fullname'].downcase
+        if ordered
+          banks_information.sort! do |bank_information1, bank_information2|
+            bank_information1['fullname'].downcase <=> bank_information2['fullname'].downcase
+          end
         end
+
+        banks_information
       end
 
-      banks_information
-    end
+      def bank_name_for(bank_information:, services_number_by_bank_id:)
+        # Name changes:
+        # 1. Add Particulares if there are different personal/company endpoints
+        # 2. Add Empresas following the same reason
+        # 3. Rename Caja Ingenieros into Caixa d'Enginyers (most known name)
+        # 4. Rename Caixa Guisona into Caixa Guissona (fix typo)
+        # 5. Rename Caixa burriana into Caixa Burriana (fix typo)
+        # 6. Rename Bancho Pichincha into Banco Pichincha (fix typo)
+
+        if bank_information['service'] == 'cajaingenieros'
+          return "Caixa d'Enginyers"
+        end
 
-    def self.bank_name_for(bank_information:, services_number_by_bank_id:)
-      # Name changes:
-      # 1. Add Particulares if there are different personal/company endpoints
-      # 2. Add Empresas following the same reason
-      # 3. Rename Caja Ingenieros into Caixa d'Enginyers (most known name)
-      # 4. Rename Caixa Guisona into Caixa Guissona (fix typo)
-      # 5. Rename Caixa burriana into Caixa Burriana (fix typo)
-      # 6. Rename Bancho Pichincha into Banco Pichincha (fix typo)
+        if bank_information['service'] == 'caixaguissona'
+          return "Caixa Guissona"
+        end
 
-      if bank_information['service'] == 'cajaingenieros'
-        return "Caixa d'Enginyers"
-      end
+        if bank_information['service'] == 'caixaruralburriana'
+          return "Caixa Burriana"
+        end
 
-      if bank_information['service'] == 'caixaguissona'
-        return "Caixa Guissona"
-      end
+        if bank_information['service'] == 'pichincha'
+          return "Banco Pichincha"
+        end
 
-      if bank_information['service'] == 'caixaruralburriana'
-        return "Caixa Burriana"
-      end
+        fullname = bank_information['fullname']
+        if bank_information['business'] == "1"
+          return "#{fullname} Empresas"
+        end
 
-      if bank_information['service'] == 'pichincha'
-        return "Banco Pichincha"
-      end
+        bank_id = bank_id_for(bank_information: bank_information)
+        if services_number_by_bank_id[bank_id] > 1
+          return "#{fullname} Particulares"
+        end
 
-      fullname = bank_information['fullname']
-      if bank_information['business'] == "1"
-        return "#{fullname} Empresas"
+        fullname
       end
 
-      bank_id = bank_id_for(bank_information: bank_information)
-      if services_number_by_bank_id[bank_id] > 1
-        return "#{fullname} Particulares"
+      def bank_id_for(bank_information:)
+        bank_information['service'].split("_").first
       end
-
-      fullname
-    end
-
-    def self.bank_id_for(bank_information:)
-      bank_information['service'].split("_").first
-    end
+  end
   end
 end

data/lib/afterbanks/resources/transaction.rb

@@ -1,79 +1,102 @@
 module Afterbanks
   class Transaction < Resource
-    has_fields service: :string,
-               product: :string,
-               date: :date,
-               date2: :date,
-               amount: :decimal,
-               description: :string,
-               balance: :decimal,
+    has_fields service:       :string,
+               product:       :string,
+               date:          :date,
+               date2:         :date,
+               amount:        :decimal,
+               description:   :string,
+               balance:       :decimal,
                transactionId: :string,
-               categoryId: :integer
-
-    def self.list(service:, username:, password:, password2: nil,
-                  document_type: nil, account_id: nil,
-                  products:, startdate:,
-                  session_id: nil, otp: nil, counter_id: nil)
-
-      params = {
-        servicekey: Afterbanks.configuration.servicekey,
-        service: service,
-        user: username,
-        pass: password,
-        products: products,
-        startdate: startdate.strftime("%d-%m-%Y")
-      }
-
-      params.merge!(pass2: password2) unless password2.nil?
-      params.merge!(documentType: document_type) unless document_type.nil?
-      params.merge!(account_id: account_id) unless account_id.nil?
-
-      params.merge!(session_id: session_id) unless session_id.nil?
-      params.merge!(OTP: otp) unless otp.nil?
-      params.merge!(counterId: counter_id) unless counter_id.nil?
-
-      response, debug_id = Afterbanks.api_call(
-        method: :post,
-        path: '/V3/',
-        params: params
-      )
-
-      Response.new(
-        result: Collection.new(
-          transactions_information_for(
-            service: service,
+               categoryId:    :integer
+
+    class << self
+      def list(service:, username:, password:, password2: nil,
+               document_type: nil, account_id: nil,
+               products:, check_products_presence: false, startdate:,
+               session_id: nil, otp: nil, counter_id: nil)
+
+        params = {
+          servicekey: Afterbanks.configuration.servicekey,
+          service:    service,
+          user:       username,
+          pass:       password,
+          products:   products,
+          startdate:  startdate.strftime("%d-%m-%Y")
+        }
+
+        params.merge!(pass2: password2) unless password2.nil?
+        params.merge!(documentType: document_type) unless document_type.nil?
+        params.merge!(account_id: account_id) unless account_id.nil?
+
+        params.merge!(session_id: session_id) unless session_id.nil?
+        params.merge!(OTP: otp) unless otp.nil?
+        params.merge!(counterId: counter_id) unless counter_id.nil?
+
+        response, debug_id = Afterbanks.api_call(
+          method: :post,
+          path:   '/V3/',
+          params: params
+        )
+
+        if check_products_presence
+          ensure_no_product_is_missing(
             response: response,
+            debug_id: debug_id,
             products: products
+          )
+        end
+
+        Response.new(
+          result:   Collection.new(
+            transactions_information_for(
+              service:  service,
+              response: response,
+              products: products
+            ),
+            self
           ),
-          self
-        ),
-        debug_id: debug_id
-      )
-    end
+          debug_id: debug_id
+        )
+      end
 
     private
 
-    def self.transactions_information_for(response:, service:, products:)
-      transactions_information = []
-      products_array = products.split(",")
+      def ensure_no_product_is_missing(response:, debug_id:, products:)
+        products_array = products.split(",")
+        found_products_array = response.map { |account_information| account_information['product'] }
 
-      response.each do |account_information|
-        product = account_information['product']
+        missing_products_array = products_array - found_products_array
+        return unless missing_products_array.any?
 
-        if products_array.include?(product)
-          transactions = account_information['transactions']
-          next if transactions.nil?
+        raise MissingProductError.new(
+          message:  'Producto no encontrado',
+          debug_id: debug_id
+        )
+      end
 
-          transactions.each do |transaction|
-            transaction['service'] = service
-            transaction['product'] = product
-          end
+      def transactions_information_for(response:, service:, products:)
+        transactions_information = []
+        products_array = products.split(",")
+
+        response.each do |account_information|
+          product = account_information['product']
+
+          if products_array.include?(product)
+            transactions = account_information['transactions']
+            next if transactions.nil?
+
+            transactions.each do |transaction|
+              transaction['service'] = service
+              transaction['product'] = product
+            end
 
-          transactions_information += transactions
+            transactions_information += transactions
+          end
         end
-      end
 
-      transactions_information
-    end
+        transactions_information
+      end
+  end
   end
 end

data/lib/afterbanks/resources/user.rb

@@ -1,24 +1,26 @@
 module Afterbanks
   class User < Resource
-    has_fields limit: :integer,
-               counter: :integer,
+    has_fields limit:           :integer,
+               counter:         :integer,
                remaining_calls: :integer,
-               date_renewal: :date,
-               detail: :string
+               date_renewal:    :date,
+               detail:          :string
 
-    def self.get
-      response, debug_id = Afterbanks.api_call(
-        method: :post,
-        path: '/me/',
-        params: {
-          servicekey: Afterbanks.configuration.servicekey
-        }
-      )
+    class << self
+      def get
+        response, debug_id = Afterbanks.api_call(
+          method: :post,
+          path:   '/me/',
+          params: {
+            servicekey: Afterbanks.configuration.servicekey
+          }
+        )
 
-      Response.new(
-        result: new(response),
-        debug_id: debug_id
-      )
+        Response.new(
+          result:   new(response),
+          debug_id: debug_id
+        )
+      end
     end
   end
 end

data/lib/afterbanks/version.rb

@@ -1,3 +1,3 @@
 module Afterbanks
-  VERSION = "0.3.4"
+  VERSION = "0.4.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: afterbanks-api-ruby
 version: !ruby/object:Gem::Version
-  version: 0.3.4
+  version: 0.4.1
 platform: ruby
 authors:
 - Albert Bellonch
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-07-13 00:00:00.000000000 Z
+date: 2023-06-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -66,6 +66,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: timecop
   requirement: !ruby/object:Gem::Requirement
@@ -104,6 +132,8 @@ files:
 - ".circleci/config.yml"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
+- ".rubocop_exclusions.yml"
 - Gemfile
 - Gemfile.lock
 - README.md
@@ -139,7 +169,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: Ruby client for the Afterbanks' API