afterbanks-api-ruby 0.2.2 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4007a9c95869ee3649a7222d04de852394644756b5b8c282824440f3314e32cf
-  data.tar.gz: 174843f2e47ead8e49ff7e9150d9a6f9359d15707999c9cf767f3985384e5777
+  metadata.gz: 7e8930f102e85517209fcce5b5b135df8a2c2ef8f006b34373d2f3f8fb506c6c
+  data.tar.gz: c0dc2f9f696a0c7deb911c8c97540c58c24ae279889fcbf1e817523c9d004379
 SHA512:
-  metadata.gz: a667e7d1d24a1cf81b6ca7374f27af2a0331275f66554fbdabc79e51f020e353ad20d95db50cbf1495f06d1b23f611f6250a66747a5846e46a3918c51005b9b2
-  data.tar.gz: 8480e58506498fec7709a7447d023bdfabc6c255ce6738c5266d3c1af250007f3c6c3309e39bf473d115708215d433717543dfded9ff21de67110fe2539032b1
+  metadata.gz: '0399b89536f56a7a7a005b1de08a39467e904f334d93e71785417e7484dc52c33a5ddcbbe45c071ccb2f33b6d6b95277bf948db36b21f05f0f4d917c22c08985'
+  data.tar.gz: 8470ba253a635d0fe30f37ae3734ce9d71bef65d95065e0ec53c45a8f6792f9bad155ba69437e73e32d1e1beb5d9f60638510a54d896f89e6e2fc9d8681307cb

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    afterbanks-api-ruby (0.2.2)
+    afterbanks-api-ruby (0.3.0)
       rest-client (~> 2.0.2)
 
 GEM

data/README.md

@@ -33,6 +33,8 @@ You can set a `logger` as well.
 Changelog
 ---------
 
+* v.0.3.0 Set a higher timeout so it works properly with ING Direct
+* v.0.2.3 Better logging
 * v.0.2.2 Better naming (fix Caixa Guissona, Caixa Burriana and Banco Pichincha)
 * v.0.2.1 Better naming for banks (add Particulares for the proper ones, and use Caixa Enginyers)
 * v.0.2.0 Allow adding an (opt-in) random parameter to Afterbanks::Account.list to avoid caching

data/lib/afterbanks/base.rb

@@ -16,7 +16,8 @@ module Afterbanks
     def api_call(method:, path:, params: {})
       url = 'https://api.afterbanks.com' + path
 
-      request_params = { method: method, url: url }
+      # Timeout is set to 5min: some banks take a lot to respond (e.g. ING Direct)
+      request_params = { method: method, url: url, timeout: 60*5 }
 
       if method == :post
         request_params.merge!(payload: params)
@@ -50,38 +51,33 @@ module Afterbanks
     end
 
     def log_request(method:, url:, params: {}, debug_id: nil)
-      now = Time.now
+      logger = Afterbanks.configuration.logger
+      return if logger.nil?
 
-      log_message(message: "")
-      log_message(message: "=> #{method.upcase} #{url}")
+      now = Time.now
 
-      log_message(message: "* Time: #{now}")
-      log_message(message: "* Timestamp: #{now.to_i}")
-      log_message(message: "* Debug ID: #{debug_id || 'none'}")
+      safe_params = {}
+      params.each do |key, value|
+        safe_value = if %w{servicekey user pass pass2}.include?(key.to_s)
+                       "<masked>"
+                     else
+                       value
+                     end
 
-      if params.any?
-        log_message(message: "* Params")
-        params.each do |key, value|
-          safe_value = if %w{servicekey user pass pass2}.include?(key.to_s)
-                         "<masked>"
-                       else
-                         value
-                       end
+        safe_value = safe_value.to_s if safe_value.is_a?(Symbol)
 
-          log_message(message: "#{key}: #{safe_value}")
-        end
-      else
-        log_message(message: "* No params")
+        safe_params[key] = safe_value
       end
-    end
 
-    def log_message(message: nil)
-      return if message.nil?
-
-      logger = Afterbanks.configuration.logger
-      return if logger.nil?
-
-      logger.info(message)
+      logger.info(
+        message: 'Afterbanks request',
+        method: method.upcase.to_s,
+        url: url,
+        time: now.to_s,
+        timestamp: now.to_i,
+        debug_id: debug_id || 'none',
+        params: safe_params
+      )
     end
 
     private

data/lib/afterbanks/version.rb

@@ -1,3 +1,3 @@
 module Afterbanks
-  VERSION = "0.2.2"
+  VERSION = "0.3.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: afterbanks-api-ruby
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.3.0
 platform: ruby
 authors:
 - Albert Bellonch
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-04-30 00:00:00.000000000 Z
+date: 2020-05-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client