afterbanks-api-ruby 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b950e0c205ccad340e3151cf3b30e059ede78eaa2537decdf34df8f5069ca00d
-  data.tar.gz: 297d4e9482c49b6c3513d5d33a005456490411b2337e9f4c287e23dddbe3807e
+  metadata.gz: 19bc05050d36cdf980cc1d2ab883c6b82f4ed4622fa959cebaa80099b5a40716
+  data.tar.gz: a5ffd80b0e31ee743d903564909ba692839c34a390eab12bcec6948719b56b6b
 SHA512:
-  metadata.gz: c8b8e439e5c5d28925050f97f0bff83d8358b492c13f3b9ba7f4f437b6819a821c1515d291d08d3152e05d7e455cb5a2b9315d11f78a87eaf2da9e7cb06b1d1a
-  data.tar.gz: d59b18b57fb1a0f7acad963cce8faf2b50fbe4ae5f5c7c27dd6940b240ea5284d9dff83c0430aafdcc21ed86faba26ecb8a6447c325a9b5e74b4dc6ded90f2c8
+  metadata.gz: 89335c1312001084d537c486f800d3d46fc252b80a634d970b68120210888cbc2e9ba66ee80f331da86cd813c8362081c25f4c91da8501bf6e0157970a4aea51
+  data.tar.gz: e97843bdfd06e003e5ba6136e8e237084e5b0d43c0ad347c221f42586936772c099bf2a2cf59ec57a8363db0b6b600304e21ad0f36d629f83fba70de44f5719c

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    afterbanks-api-ruby (0.2.0)
+    afterbanks-api-ruby (0.2.1)
       rest-client (~> 2.0.2)
 
 GEM

data/README.md

@@ -33,7 +33,8 @@ You can set a `logger` as well.
 Changelog
 ---------
 
-* v.0.1.2 Allow adding an (opt-in) random parameter to Afterbanks::Account.list to avoid caching
+* v.0.2.1 Better naming for banks
+* v.0.2.0 Allow adding an (opt-in) random parameter to Afterbanks::Account.list to avoid caching
 * v.0.1.1 Fix rake security issue and remove specific Ruby version dependency.
 * v.0.1.0 First vull version, including resource wrapping (for banks, accounts, transactions and the user) and separate exceptions for each different code.
 

data/lib/afterbanks/resources/bank.rb

@@ -24,16 +24,11 @@ module Afterbanks
         path: '/forms/'
       )
 
-      if ordered
-        response.sort! do |bank1, bank2|
-          bank1['fullname'].downcase <=> bank2['fullname'].downcase
-        end
-      end
-
       Response.new(
         result: Collection.new(
           banks_information_for(
-            response: response
+            response: response,
+            ordered: ordered
           ),
           self
         ),
@@ -43,18 +38,54 @@ module Afterbanks
 
     private
 
-    def self.banks_information_for(response:)
+    def self.banks_information_for(response:, ordered:)
       banks_information = []
 
+      services_number_by_bank_id = {}
+      response.each { |bank_information|
+        bank_id = bank_id_for(bank_information: bank_information)
+        services_number_by_bank_id[bank_id] ||= 0
+        services_number_by_bank_id[bank_id] += 1
+      }
+
       response.each do |bank_information|
-        if bank_information['business'] == "1"
-          bank_information['fullname'] += " Empresas"
-        end
+        bank_information['fullname'] = bank_name_for(
+          bank_information: bank_information,
+          services_number_by_bank_id: services_number_by_bank_id
+        )
 
         banks_information << bank_information
       end
 
+      if ordered
+        banks_information.sort! do |bank_information1, bank_information2|
+          bank_information1['fullname'].downcase <=> bank_information2['fullname'].downcase
+        end
+      end
+
       banks_information
     end
+
+    def self.bank_name_for(bank_information:, services_number_by_bank_id:)
+      if bank_information['service'] == 'cajaingenieros'
+        return "Caixa d'Enginyers"
+      end
+
+      fullname = bank_information['fullname']
+      if bank_information['business'] == "1"
+        return "#{fullname} Empresas"
+      end
+
+      bank_id = bank_id_for(bank_information: bank_information)
+      if services_number_by_bank_id[bank_id] > 1
+        return "#{fullname} Particulares"
+      end
+
+      fullname
+    end
+
+    def self.bank_id_for(bank_information:)
+      bank_information['service'].split("_").first
+    end
   end
 end

data/lib/afterbanks/version.rb

@@ -1,3 +1,3 @@
 module Afterbanks
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: afterbanks-api-ruby
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Albert Bellonch
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-04-29 00:00:00.000000000 Z
+date: 2020-04-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client