after_commit_everywhere 1.3.1 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6b63aab224d26cf40ba71632ebc055bd458bd3c72c87234715d1d8020f661247
-  data.tar.gz: b558770a87644ee346a8361419ea9d0e616062da4873427d260dc8e428d545b4
+  metadata.gz: c801e905947621b60d9409be76cfb81d5d8b33f9c875cb120b143a91b4f87736
+  data.tar.gz: 90b6d70641c070a3866ab70929c41b9729b8693878a3bdba203a690eef6312a5
 SHA512:
-  metadata.gz: 99d19cdc3ba272ad5a7c6a47b232d2cd6d5fa012889cd270763d154cf559d2b504b34ba650917a8618f073897a46e4e4fec79293092d05e66aa435d21179037a
-  data.tar.gz: 7169e814084435d36a231cc5b2a3c7b11268a3e24913826b00fefe87ceaddea2c2299208616938d51ee245eca60136a654f8ec02664e30c3466f59b43f82f62d
+  metadata.gz: 3ce2d472754e15c17b4c52795c1a9f7a98b0021ab2ffc0c7d5120fd7ff0a2f24c83d0e1177c35ff30c517a6501219716b5ef1c49c1ff386b947561a092ab674c
+  data.tar.gz: a4e4ee45d289bba022eef8f3da4b08fa2da1f23f4643197a1338bfd734da9f7d3b1e55f8ec87d8183ba448022af957238f848baef5d66383ace9d55fa739dd76

data/CHANGELOG.md

@@ -4,6 +4,27 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## 1.5.0 (2024-12-09)
+
+### Added
+
+- Ability to propagate exception for multiple `after_commit` callbacks within transaction. Should handle exception inside callback to avoid stopping other callbacks.
+
+  [Pull request #35](https://github.com/Envek/after_commit_everywhere/pull/35) by [@kevink1103](). Also see discussion at [#34](https://github.com/Envek/after_commit_everywhere/issues/34).
+
+## 1.4.0 (2024-02-07)
+
+### Added
+
+- Ability to prepend callbacks to the head of callback queue using `prepend: true` option.
+
+  ```ruby
+  AfterCommitEverywhere.after_commit { puts "I'm second!" }
+  AfterCommitEverywhere.after_commit(prepend: true) { puts "I'm first!" }
+  ```
+
+  See [Pull request #30](https://github.com/Envek/after_commit_everywhere/pull/30) by [@quentindemetz][] and [@A1090][].
+
 ## 1.3.1 (2023-06-21)
 
 ### Fixed
@@ -132,3 +153,6 @@ See [#11](https://github.com/Envek/after_commit_everywhere/issues/11) for discus
 [@stokarenko]: https://github.com/stokarenko "Sergey Tokarenko"
 [@lolripgg]: https://github.com/lolripgg "James Brewer"
 [@jpcamara]: https://github.com/jpcamara "JP Camara"
+[@quentindemetz]: https://github.com/quentindemetz "Quentin de Metz"
+[@A1090]: https://github.com/A1090 "Tabac Andreina"
+[@kevink1103]: https://github.com/kevink1103 "Kevin (bum)"

data/README.md

@@ -111,7 +111,7 @@ Will be executed right after transaction in which it have been declared was roll
 
 If called outside transaction will raise an exception!
 
-Please keep in mind ActiveRecord's [limitations for rolling back nested transactions](http://api.rubyonrails.org/classes/ActiveRecord/Transactions/ClassMethods.html#module-ActiveRecord::Transactions::ClassMethods-label-Nested+transactions). See [`in_transaction`](#in_transaction) for a workaround to this limitation. 
+Please keep in mind ActiveRecord's [limitations for rolling back nested transactions](http://api.rubyonrails.org/classes/ActiveRecord/Transactions/ClassMethods.html#module-ActiveRecord::Transactions::ClassMethods-label-Nested+transactions). See [`in_transaction`](#in_transaction) for a workaround to this limitation.
 
 ### Available helper methods
 
@@ -139,7 +139,7 @@ class ServiceObjectBtw
 end
 ```
 
-Our service object can run its database operations safely when run in isolation. 
+Our service object can run its database operations safely when run in isolation.
 
 ```rb
 ServiceObjectBtw.new.call # This opens a new #transaction block
@@ -195,6 +195,8 @@ end
     - `:warn_and_execute` to print warning and execute immediately
     - `:raise` to raise an exception instead of executing
 
+- `prepend` puts the callback at the head of the callback chain, instead of at the end.
+
 ### FAQ
 
 #### Does it works with transactional_test or DatabaseCleaner

data/after_commit_everywhere.gemspec

@@ -28,6 +28,11 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
+  spec.metadata["homepage_uri"] = spec.homepage
+  spec.metadata["source_code_uri"] = spec.homepage
+  spec.metadata["changelog_uri"] = "https://github.com/Envek/after_commit_everywhere/blob/master/CHANGELOG.md"
+  spec.metadata["bug_tracker_uri"] = "https://github.com/Envek/after_commit_everywhere/issues"
+
   spec.add_dependency "activerecord", ">= 4.2"
   spec.add_dependency "activesupport"
   spec.add_development_dependency "appraisal"

data/lib/after_commit_everywhere/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AfterCommitEverywhere
-  VERSION = "1.3.1"
+  VERSION = "1.5.0"
 end

data/lib/after_commit_everywhere/wrap.rb

@@ -23,8 +23,10 @@ module AfterCommitEverywhere
       true
     end
 
-    def committed!(*)
-      @handlers[:after_commit]&.call
+    def committed!(should_run_callbacks: true)
+      if should_run_callbacks
+        @handlers[:after_commit]&.call
+      end
     end
 
     def rolledback!(*)

data/lib/after_commit_everywhere.rb

@@ -39,11 +39,13 @@ module AfterCommitEverywhere
     # @param callback   [#call] Callback to be executed
     # @return           void
     def after_commit(
+      prepend: false,
       connection: nil,
       without_tx: EXECUTE,
       &callback
     )
       register_callback(
+        prepend: prepend,
         connection: connection,
         name: __method__,
         callback: callback,
@@ -64,6 +66,7 @@ module AfterCommitEverywhere
     # @param callback   [#call] Callback to be executed
     # @return           void
     def before_commit(
+      prepend: false,
       connection: nil,
       without_tx: WARN_AND_EXECUTE,
       &callback
@@ -73,6 +76,7 @@ module AfterCommitEverywhere
       end
 
       register_callback(
+        prepend: prepend,
         connection: connection,
         name: __method__,
         callback: callback,
@@ -90,8 +94,9 @@ module AfterCommitEverywhere
     # @param callback   [#call] Callback to be executed
     # @return           void
     # @raise            [NotInTransaction] if called outside transaction.
-    def after_rollback(connection: nil, &callback)
+    def after_rollback(prepend: false, connection: nil, &callback)
       register_callback(
+        prepend: prepend,
         connection: connection,
         name: __method__,
         callback: callback,
@@ -100,7 +105,7 @@ module AfterCommitEverywhere
     end
 
     # @api private
-    def register_callback(connection: nil, name:, without_tx:, callback:)
+    def register_callback(prepend:, connection: nil, name:, without_tx:, callback:)
       raise ArgumentError, "Provide callback to #{name}" unless callback
 
       unless in_transaction?(connection)
@@ -119,7 +124,16 @@ module AfterCommitEverywhere
 
       connection ||= default_connection
       wrap = Wrap.new(connection: connection, "#{name}": callback)
-      connection.add_transaction_record(wrap)
+
+      if prepend
+        # Hacking ActiveRecord's transaction internals to prepend our callback
+        # See https://github.com/rails/rails/blob/f0d433bb46ac233ec7fd7fae48f458978908d905/activerecord/lib/active_record/connection_adapters/abstract/transaction.rb#L148-L156
+        records = connection.current_transaction.instance_variable_get(:@records)
+        records = connection.current_transaction.instance_variable_set(:@records, []) if records.nil?
+        records.unshift(wrap)
+      else
+        connection.add_transaction_record(wrap)
+      end
     end
 
     # Helper method to determine whether we're currently in transaction or not

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: after_commit_everywhere
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.5.0
 platform: ruby
 authors:
 - Andrey Novikov
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-06-21 00:00:00.000000000 Z
+date: 2024-12-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -230,7 +230,11 @@ files:
 homepage: https://github.com/Envek/after_commit_everywhere
 licenses:
 - MIT
-metadata: {}
+metadata:
+  homepage_uri: https://github.com/Envek/after_commit_everywhere
+  source_code_uri: https://github.com/Envek/after_commit_everywhere
+  changelog_uri: https://github.com/Envek/after_commit_everywhere/blob/master/CHANGELOG.md
+  bug_tracker_uri: https://github.com/Envek/after_commit_everywhere/issues
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -246,7 +250,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.5.22
 signing_key: 
 specification_version: 4
 summary: Executes code after database commit wherever you want in your application