after_commit_everywhere 1.2.1 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c67c4fd8f55095680c0519cef506d1b7296059b2dd4ce3c94c2a8787cc82c32e
-  data.tar.gz: e6feb83c65aa88072e56872105cf9511fccd9d4f5410afb9b9fc7060c768b79a
+  metadata.gz: e4a45b526cda61ade274b1e038628a0718417047d553c2784242487eca91ad78
+  data.tar.gz: ff7c001043feee2cd69d746b0c0fbe9350ebfb608ba94470135280eca878aed1
 SHA512:
-  metadata.gz: f1679f32b243651bacc0d2966b4d72b67c1fe190f5a9165702ca11c9edd872b9bec0bd63fd0136b179a4255c5e98f9c957ce3fd67c7ce3454dbd1e201bcf0e01
-  data.tar.gz: c779815fd32f8e90f1ec01df87eab0a90a2425ad7e738d285d636b6e4762a0d7cb380f423a44087458dd2fdf533df57b8b78bc803ecb9858bf0eac70722cdb34
+  metadata.gz: 524ecaf8c3598f724d9c02c0faa6c3f2a0fc6ab89d45fa9bc326a5b4a269d479e450120b75c4585ea9b7ce7a0ce8ec005c248838ca84ba6a7003b48cd0c1d76f
+  data.tar.gz: 49f603aca07b79763e21a52cb2495a63ea13be07ce646e5e2883e4448c12a9e06079011f50f674db1abc61cc8e93e08fa13bfa2c8b4877cf5940d757931fbde9

data/CHANGELOG.md

@@ -4,6 +4,16 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## 1.2.2 (2022-06-20)
+
+### Fixed
+
+- Connection leak from the connection pool when `after_commit` called outside Rails executor without connection checked out *and* some connections were already checked out from another threads.
+
+  See discussion at [issue #20](https://github.com/Envek/after_commit_everywhere/issues/20) for details.
+
+  [Pull request #22](https://github.com/Envek/after_commit_everywhere/pull/22) by [@Envek][].
+
 ## 1.2.1 (2022-06-10)
 
 ### Fixed

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    after_commit_everywhere (1.2.0)
+    after_commit_everywhere (1.2.2)
       activerecord (>= 4.2)
       activesupport
 
@@ -225,4 +225,4 @@ DEPENDENCIES
   sqlite3 (~> 1.3, >= 1.3.6)
 
 BUNDLED WITH
-   2.3.10
+   2.3.16

data/lib/after_commit_everywhere/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AfterCommitEverywhere
-  VERSION = "1.2.1"
+  VERSION = "1.2.2"
 end

data/lib/after_commit_everywhere.rb

@@ -125,7 +125,7 @@ module AfterCommitEverywhere
     # Helper method to determine whether we're currently in transaction or not
     def in_transaction?(connection = nil)
       # Don't establish new connection if not connected: we apparently not in transaction
-      return false unless connection || ActiveRecord::Base.connection_pool.connected?
+      return false unless connection || ActiveRecord::Base.connection_pool.active_connection?
 
       connection ||= default_connection
       # service transactions (tests and database_cleaner) are not joinable

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: after_commit_everywhere
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.2
 platform: ruby
 authors:
 - Andrey Novikov
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-06-10 00:00:00.000000000 Z
+date: 2022-06-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord