after_commit_everywhere 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 7d629817cd7a0bcb81c8d59d09356e9f1ca30552
-  data.tar.gz: a918de48d7fe61eeb40493cd5f9cfe9e8f38e135
+SHA256:
+  metadata.gz: d959365a048625cd9a944d475f20a3621bcaba1666399f558269eee56ba6d238
+  data.tar.gz: 17b9c71cb73cb8c86a3d45928476537169183dca86bdfd896eb7c66c83d32b7f
 SHA512:
-  metadata.gz: a0dcd0079e0d01bd55442a45b633f3ffbe628555c3cad8e8f6a8c06323150d0ffb8fa291f49510776ad406b8d1f6dc7254a19c2ba9ba5b10686ff3b3e9fc9467
-  data.tar.gz: e0b2bd78ade3dc2b0f280fbbd15f4230d8748f03347e2b022c63fa472edb0ca849edf3c7735b4662f5a7171e59789f2445107787243b19c801cf28f1e343020d
+  metadata.gz: e453a9b961a9c5d18c77a0bb1d69fe899604b8970316459e008930ad0264c5a9077cf2adf7bf9ce6ecde856a1b5c8a1cf3a8f733e25a7e65d6641be8fc63aa8d
+  data.tar.gz: 915d3541eaf4c43f0eb195cb94ea0debd86d3fa0372ad2eb081fa2471c2f80586fc96c9691bf77af15390522b8cf06e5aa2f82410cde6ef1f9bff5ed898fff1a

data/.rubocop.yml

@@ -34,8 +34,17 @@ Style/TrailingCommaInArguments:
   Enabled: true
   EnforcedStyleForMultiline: consistent_comma
 
-Style/TrailingCommaInLiteral:
-  Description: 'Checks for trailing comma in array and hash literals.'
+Style/TrailingCommaInArrayLiteral:
+  Description: 'Checks for trailing comma in array literals.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas'
   Enabled: true
   EnforcedStyleForMultiline: consistent_comma
+
+Style/TrailingCommaInHashLiteral:
+  Description: 'Checks for trailing comma in hash literals.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas'
+  Enabled: true
+  EnforcedStyleForMultiline: consistent_comma
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes

data/.travis.yml

@@ -11,22 +11,24 @@ addons:
 
 matrix:
   include:
-    - rvm: 2.5.1
+    - rvm: 2.5.3
       gemfile: gemfiles/activerecord_4_2.gemfile
-    - rvm: 2.5.1
+    - rvm: 2.5.3
       gemfile: gemfiles/activerecord_5_0.gemfile
-    - rvm: 2.5.1
+    - rvm: 2.5.3
       gemfile: gemfiles/activerecord_5_1.gemfile
-    - rvm: 2.5.1
+    - rvm: 2.4.5
       gemfile: gemfiles/activerecord_5_2.gemfile
-    - rvm: 2.5.1
-      gemfile: gemfiles/activerecord_master.gemfile
-    - rvm: 2.4.4
+    - rvm: 2.3.8
+      gemfile: gemfiles/activerecord_5_2.gemfile
+    - rvm: 2.5.3
       gemfile: gemfiles/activerecord_5_2.gemfile
-    - rvm: 2.3.7
+    - rvm: 2.6.1
       gemfile: gemfiles/activerecord_5_2.gemfile
+    - rvm: 2.6.1
+      gemfile: gemfiles/activerecord_master.gemfile
 
 # https://github.com/travis-ci/travis-ci/issues/8969#issuecomment-380028168
 before_install:
   - gem update --system
-  - gem install bundler
+  - gem install bundler -v "~> 1.17.2"

data/Appraisals

@@ -1,22 +1,22 @@
 # frozen_string_literal: true
-#
-appraise 'activerecord-4-2' do
-  gem 'activerecord', '~> 4.2.0'
+
+appraise "activerecord-4-2" do
+  gem "activerecord", "~> 4.2.0"
 end
 
-appraise 'activerecord-5-0' do
-  gem 'activerecord', '~> 5.0.0'
+appraise "activerecord-5-0" do
+  gem "activerecord", "~> 5.0.0"
 end
 
-appraise 'activerecord-5-1' do
-  gem 'activerecord', '~> 5.1.0'
+appraise "activerecord-5-1" do
+  gem "activerecord", "~> 5.1.0"
 end
 
-appraise 'activerecord-5-2' do
-  gem 'activerecord', '~> 5.2.0'
+appraise "activerecord-5-2" do
+  gem "activerecord", "~> 5.2.0"
 end
 
-appraise 'activerecord-master' do
-  gem 'rails', git: 'https://github.com/rails/rails.git'
-  gem 'activerecord', git: 'https://github.com/rails/rails.git'
+appraise "activerecord-master" do
+  gem "rails", git: "https://github.com/rails/rails.git"
+  gem "activerecord", git: "https://github.com/rails/rails.git"
 end

data/CHANGELOG.md

@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+## 0.1.3 (2019-02-18)
+
+- Make `in_transaction?` helper method public. ([@Envek])
+
 ## 0.1.2 (2018-05-01)
 
 - [PR [#1](https://github.com/Envek/after_commit_everywhere/pull/1)] Enable ActiveRecord 4.2 support. ([@arjun810], [@Envek])

data/Gemfile

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 

data/Rakefile

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-require 'bundler/gem_tasks'
-require 'rspec/core/rake_task'
+require "bundler/gem_tasks"
+require "rspec/core/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)
 

data/after_commit_everywhere.gemspec

@@ -1,14 +1,14 @@
 # frozen_string_literal: true
 
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path("lib", __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'after_commit_everywhere/version'
+require "after_commit_everywhere/version"
 
 Gem::Specification.new do |spec|
-  spec.name          = 'after_commit_everywhere'
+  spec.name          = "after_commit_everywhere"
   spec.version       = AfterCommitEverywhere::VERSION
-  spec.authors       = ['Andrey Novikov']
-  spec.email         = ['envek@envek.name']
+  spec.authors       = ["Andrey Novikov"]
+  spec.email         = ["envek@envek.name"]
 
   spec.summary       = <<~MSG.strip
     Executes code after database commit wherever you want in your application
@@ -18,25 +18,25 @@ Gem::Specification.new do |spec|
     Brings before_commit, after_commit, and after_rollback transactional \
     callbacks outside of your ActiveRecord models.
   MSG
-  spec.homepage      = 'https://github.com/Envek/after_commit_everywhere'
-  spec.license       = 'MIT'
+  spec.homepage      = "https://github.com/Envek/after_commit_everywhere"
+  spec.license       = "MIT"
 
   spec.files         = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
   end
-  spec.bindir        = 'exe'
+  spec.bindir        = "exe"
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ['lib']
+  spec.require_paths = ["lib"]
 
-  spec.add_dependency 'activerecord', '>= 4.2'
-  spec.add_development_dependency 'appraisal'
-  spec.add_development_dependency 'bundler', '~> 1.16'
-  spec.add_development_dependency 'pry'
-  spec.add_development_dependency 'rake', '~> 10.0'
-  spec.add_development_dependency 'rspec', '~> 3.0'
-  spec.add_development_dependency 'rubocop'
-  spec.add_development_dependency 'sqlite3'
-  spec.add_development_dependency 'isolator'
-  spec.add_development_dependency 'rails'
-  spec.add_development_dependency 'rspec-rails'
+  spec.add_dependency "activerecord", ">= 4.2"
+  spec.add_development_dependency "appraisal"
+  spec.add_development_dependency "bundler", "~> 1.16"
+  spec.add_development_dependency "isolator"
+  spec.add_development_dependency "pry"
+  spec.add_development_dependency "rails"
+  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "rspec", "~> 3.0"
+  spec.add_development_dependency "rspec-rails"
+  spec.add_development_dependency "rubocop", "~> 0.64"
+  spec.add_development_dependency "sqlite3", "~> 1.3.6"
 end

data/bin/console

@@ -1,11 +1,11 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
 
-require 'bundler/setup'
-require 'after_commit_everywhere'
+require "bundler/setup"
+require "after_commit_everywhere"
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
 
-require 'pry'
+require "pry"
 Pry.start

data/gemfiles/activerecord_4_2.gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # This file was generated by Appraisal
 
 source "https://rubygems.org"

data/gemfiles/activerecord_5_0.gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # This file was generated by Appraisal
 
 source "https://rubygems.org"

data/gemfiles/activerecord_5_1.gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # This file was generated by Appraisal
 
 source "https://rubygems.org"

data/gemfiles/activerecord_5_2.gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # This file was generated by Appraisal
 
 source "https://rubygems.org"

data/gemfiles/activerecord_master.gemfile

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 # This file was generated by Appraisal
 
 source "https://rubygems.org"
 
-gem "rails", git: "https://github.com/rails/rails.git"
 gem "activerecord", git: "https://github.com/rails/rails.git"
+gem "rails", git: "https://github.com/rails/rails.git"
 
 gemspec path: "../"

data/lib/after_commit_everywhere.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
-require 'active_record'
+require "active_record"
 
-require 'after_commit_everywhere/version'
-require 'after_commit_everywhere/wrap'
+require "after_commit_everywhere/version"
+require "after_commit_everywhere/wrap"
 
 # Module allowing to use ActiveRecord transactional callbacks outside of
 # ActiveRecord models, literally everywhere in your application.
@@ -42,6 +42,7 @@ module AfterCommitEverywhere
     if ActiveRecord::VERSION::MAJOR < 5
       raise NotImplementedError, "#{__callee__} works only with Rails 5.0+"
     end
+
     AfterCommitEverywhere.register_callback(
       connection: connection,
       name: __callee__,
@@ -72,6 +73,7 @@ module AfterCommitEverywhere
   class << self
     def register_callback(connection:, name:, no_tx_action:, callback:)
       raise ArgumentError, "Provide callback to #{name}" unless callback
+
       unless in_transaction?(connection)
         case no_tx_action
         when :warn_and_execute
@@ -87,9 +89,8 @@ module AfterCommitEverywhere
       connection.add_transaction_record(wrap)
     end
 
-    private
-
-    def in_transaction?(connection)
+    # Helper method to determine whether we're currently in transaction or not
+    def in_transaction?(connection = ActiveRecord::Base.connection)
       # service transactions (tests and database_cleaner) are not joinable
       connection.transaction_open? && connection.current_transaction.joinable?
     end

data/lib/after_commit_everywhere/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AfterCommitEverywhere
-  VERSION = '0.1.2'
+  VERSION = "0.1.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: after_commit_everywhere
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Andrey Novikov
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-05-01 00:00:00.000000000 Z
+date: 2019-02-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -53,7 +53,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.16'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: isolator
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -67,63 +67,63 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.0'
 - !ruby/object:Gem::Dependency
-  name: sqlite3
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: isolator
+  name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -137,35 +137,35 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rails
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.64'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.64'
 - !ruby/object:Gem::Dependency
-  name: rspec-rails
+  name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.3.6
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
-description: Brings before_commit, after_commit, and after_rollback transactional     callbacks
-  outside of your ActiveRecord models.
+        version: 1.3.6
+description: Brings before_commit, after_commit, and after_rollback transactional
+  callbacks outside of your ActiveRecord models.
 email:
 - envek@envek.name
 executables: []
@@ -214,8 +214,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14.1
+rubygems_version: 3.0.1
 signing_key: 
 specification_version: 4
 summary: Executes code after database commit wherever you want in your application