after_commit_everywhere 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 208fab154c7355e827669ffb9943b8dd9d320ec8096284f4a35bfff45b5d6301
-  data.tar.gz: 95989a3e5c164f21371ccd8102e2d51ba99c4b303a956c83fde73b733fce700a
+SHA1:
+  metadata.gz: 7d629817cd7a0bcb81c8d59d09356e9f1ca30552
+  data.tar.gz: a918de48d7fe61eeb40493cd5f9cfe9e8f38e135
 SHA512:
-  metadata.gz: 7bdad3cb3d1e23a2ee124e06a43340c0fe6af8737d1e59e276aec40277ffb3cc662b4ec2de7856154dfb914ae69b97ca3aa977c87bf888f60367a5cf86a169a3
-  data.tar.gz: 7be979c08769da19778405d59d4808b0e402ff5d943c6ed541026056d8eea005fc6df98b41730b04de2f2f188256ade720726dbd09f5c75306faaa875bdd4b8b
+  metadata.gz: a0dcd0079e0d01bd55442a45b633f3ffbe628555c3cad8e8f6a8c06323150d0ffb8fa291f49510776ad406b8d1f6dc7254a19c2ba9ba5b10686ff3b3e9fc9467
+  data.tar.gz: e0b2bd78ade3dc2b0f280fbbd15f4230d8748f03347e2b022c63fa472edb0ca849edf3c7735b4662f5a7171e59789f2445107787243b19c801cf28f1e343020d

data/.travis.yml

@@ -11,15 +11,22 @@ addons:
 
 matrix:
   include:
-    - rvm: 2.5.0
+    - rvm: 2.5.1
+      gemfile: gemfiles/activerecord_4_2.gemfile
+    - rvm: 2.5.1
       gemfile: gemfiles/activerecord_5_0.gemfile
-    - rvm: 2.5.0
+    - rvm: 2.5.1
       gemfile: gemfiles/activerecord_5_1.gemfile
-    - rvm: 2.5.0
+    - rvm: 2.5.1
       gemfile: gemfiles/activerecord_5_2.gemfile
-    - rvm: 2.5.0
+    - rvm: 2.5.1
       gemfile: gemfiles/activerecord_master.gemfile
-    - rvm: 2.4.3
+    - rvm: 2.4.4
       gemfile: gemfiles/activerecord_5_2.gemfile
-    - rvm: 2.3.6
+    - rvm: 2.3.7
       gemfile: gemfiles/activerecord_5_2.gemfile
+
+# https://github.com/travis-ci/travis-ci/issues/8969#issuecomment-380028168
+before_install:
+  - gem update --system
+  - gem install bundler

data/Appraisals

@@ -1,4 +1,8 @@
 # frozen_string_literal: true
+#
+appraise 'activerecord-4-2' do
+  gem 'activerecord', '~> 4.2.0'
+end
 
 appraise 'activerecord-5-0' do
   gem 'activerecord', '~> 5.0.0'
@@ -9,9 +13,10 @@ appraise 'activerecord-5-1' do
 end
 
 appraise 'activerecord-5-2' do
-  gem 'activerecord', '~> 5.2.0.rc1'
+  gem 'activerecord', '~> 5.2.0'
 end
 
 appraise 'activerecord-master' do
+  gem 'rails', git: 'https://github.com/rails/rails.git'
   gem 'activerecord', git: 'https://github.com/rails/rails.git'
 end

data/CHANGELOG.md

@@ -0,0 +1,22 @@
+# Changelog
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
+and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
+
+## [Unreleased]
+
+## 0.1.2 (2018-05-01)
+
+- [PR [#1](https://github.com/Envek/after_commit_everywhere/pull/1)] Enable ActiveRecord 4.2 support. ([@arjun810], [@Envek])
+
+## 0.1.1 (2018-03-29)
+
+- Do not issue warning on `after_commit` invocation outside of transaction as it is expected behaviour. ([@Envek])
+
+## 0.1.0 (2018-03-18)
+
+- Initial version with `after_commit`, `before_commit`. and `after_rollback` callbacks. ([@Envek])
+
+[@Envek]: https://github.com/Envek "Andrey Novikov"
+[@arjun810]: https://github.com/arjun810 "Arjun Singh" 

data/README.md

@@ -98,6 +98,8 @@ Will be executed right before outermost transaction will be commited _(I can't i
 
 If called outside transaction will execute callback immediately.
 
+Supported only starting from ActiveRecord 5.0.
+
 #### `after_rollback`
 
 Will be executed right after transaction in which it have been declared was rolled back (this might be nested savepoint transaction block with `requires_new: true`).
@@ -110,7 +112,7 @@ Please keep in mind ActiveRecord's [limitations for rolling back nested transact
 
 #### Does it works with transactional_test or DatabaseCleaner
 
-*Yes* but currently it is not tested (help wanted).
+**Yes**.
 
 
 ## Development

data/after_commit_everywhere.gemspec

@@ -28,7 +28,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'activerecord', '>= 5.0'
+  spec.add_dependency 'activerecord', '>= 4.2'
   spec.add_development_dependency 'appraisal'
   spec.add_development_dependency 'bundler', '~> 1.16'
   spec.add_development_dependency 'pry'
@@ -36,4 +36,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rubocop'
   spec.add_development_dependency 'sqlite3'
+  spec.add_development_dependency 'isolator'
+  spec.add_development_dependency 'rails'
+  spec.add_development_dependency 'rspec-rails'
 end

data/gemfiles/activerecord_4_2.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activerecord", "~> 4.2.0"
+
+gemspec path: "../"

data/gemfiles/activerecord_5_2.gemfile

@@ -2,6 +2,6 @@
 
 source "https://rubygems.org"
 
-gem "activerecord", "~> 5.2.0.rc1"
+gem "activerecord", "~> 5.2.0"
 
 gemspec path: "../"

data/gemfiles/activerecord_master.gemfile

@@ -2,6 +2,7 @@
 
 source "https://rubygems.org"
 
+gem "rails", git: "https://github.com/rails/rails.git"
 gem "activerecord", git: "https://github.com/rails/rails.git"
 
 gemspec path: "../"

data/lib/after_commit_everywhere.rb

@@ -33,10 +33,15 @@ module AfterCommitEverywhere
   #
   # If called outside transaction it will execute callback immediately.
   #
+  # Available only since Ruby on Rails 5.0. See https://github.com/rails/rails/pull/18936
+  #
   # @param connection [ActiveRecord::ConnectionAdapters::AbstractAdapter]
   # @param callback   [#call] Callback to be executed
   # @return           void
   def before_commit(connection: ActiveRecord::Base.connection, &callback)
+    if ActiveRecord::VERSION::MAJOR < 5
+      raise NotImplementedError, "#{__callee__} works only with Rails 5.0+"
+    end
     AfterCommitEverywhere.register_callback(
       connection: connection,
       name: __callee__,

data/lib/after_commit_everywhere/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AfterCommitEverywhere
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: after_commit_everywhere
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Andrey Novikov
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-03-29 00:00:00.000000000 Z
+date: 2018-05-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '4.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '4.2'
 - !ruby/object:Gem::Dependency
   name: appraisal
   requirement: !ruby/object:Gem::Requirement
@@ -122,6 +122,48 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: isolator
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Brings before_commit, after_commit, and after_rollback transactional     callbacks
   outside of your ActiveRecord models.
 email:
@@ -135,6 +177,7 @@ files:
 - ".rubocop.yml"
 - ".travis.yml"
 - Appraisals
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -143,6 +186,7 @@ files:
 - bin/console
 - bin/setup
 - gemfiles/.bundle/config
+- gemfiles/activerecord_4_2.gemfile
 - gemfiles/activerecord_5_0.gemfile
 - gemfiles/activerecord_5_1.gemfile
 - gemfiles/activerecord_5_2.gemfile
@@ -171,7 +215,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.6.14.1
 signing_key: 
 specification_version: 4
 summary: Executes code after database commit wherever you want in your application