afipws 2.1.0 → 2.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c62722b5dadabc183a975922b0177b63d8bce82c24fafdd35e74240856b25d8e
-  data.tar.gz: b1a0f1ce2a252d730fee01a0830fc3d2142b50df33c13864b95854bdffa856ca
+  metadata.gz: 06c593e69f4ee8e1d8a9ebb1737eab6fbbc67000cd7cd1c765452b9cbb0d163b
+  data.tar.gz: 3ca8cb1302e496bcc60911cf13ef84b1c89b70b8a7abf56b0e658e49d4457a4e
 SHA512:
-  metadata.gz: 969630cf2f9cb2b9ae629a61f0c0cdfe79832825ea6a6fe43745d341b5b29b1117ce230567ed0e9fd27ff22f73936135bf1c4cfc6aed856fb5090ec1eeadd9eb
-  data.tar.gz: 4601ea842fcd9d84ed968fd6e8a0d11e7304353b92782dfe79ad18d6894d8c8eada013b893d8ea0f424ac004722cee6edd9e879513204d7cb354321dfb16ad75
+  metadata.gz: c708d15931cd8d67df57d8228e21d86e2eac85ca46439d3357856c779109293907105ff47a9e274dc38b6957f64daf4266bfd102f18da7a487bb08e49fbf79d4
+  data.tar.gz: 5199b2e3d64d98f56b6e71c487b6677feb5332a81f9f5181f3a54e20b95e91270f6ce5a172ae9421d43ab9c82494d1386f76daa88a86f736dbc2b959ff2668d7

data/.envrc

@@ -1,2 +1 @@
-layout ruby
-use nix
+use ruby-version

data/.github/workflows/ci.yml

@@ -0,0 +1,13 @@
+name: CI
+on: push
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+      - name: Install dependencies
+        run: bundle install
+      - name: Run tests
+        run: bundle exec rake

data/.gitignore

@@ -5,4 +5,5 @@ spec/manual/*.key
 spec/manual/*.crt
 .DS_Store
 tmp
-/.direnv
+/.direnv
+/keys

data/.ruby-version

@@ -1 +1 @@
-2.7.5
+3.3.4

data/CHANGELOG.md

@@ -4,13 +4,17 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
 
-## [2.0.0] - 2020-10-28
+## [2.3.0] - 2024-07-13
 
-### Added
+- Upgrade Ruby to 3.3.4
+- Upgrade Savon to 2.15.1
 
-- Long overdue CHANGELOG file.
-- Include `httpclient` dependency so we can wrap network errors.
+## [2.2.0] - 2023-03-19
 
-### Changed
+- Handle Savon::HTTPError
 
+## [2.0.0] - 2020-10-28
+
+- Long overdue CHANGELOG file.
+- Include `httpclient` dependency so we can wrap network errors.
 - Rename `Afipws::WSError` to `Afipws::Error`, and create subclasses to distinguish between different types of errors.

data/Gemfile

@@ -1,3 +1,5 @@
+ruby File.read(".ruby-version").strip
+
 source "http://rubygems.org"
 
 # Specify your gem's dependencies in afipws.gemspec

data/Gemfile.lock

@@ -1,34 +1,50 @@
 PATH
   remote: .
   specs:
-    afipws (2.1.0)
+    afipws (2.3.0)
       activesupport
       builder
       httpclient
       nokogiri
-      savon (~> 2.12.0)
+      savon (~> 2.15.0)
 
 GEM
   remote: http://rubygems.org/
   specs:
-    activesupport (7.0.2.2)
+    activesupport (7.1.3.4)
+      base64
+      bigdecimal
       concurrent-ruby (~> 1.0, >= 1.0.2)
+      connection_pool (>= 2.2.5)
+      drb
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
+      mutex_m
       tzinfo (~> 2.0)
-    addressable (2.8.0)
-      public_suffix (>= 2.0.2, < 5.0)
-    akami (1.3.1)
+    addressable (2.8.7)
+      public_suffix (>= 2.0.2, < 7.0)
+    akami (1.3.3)
+      base64
       gyoku (>= 0.4.0)
       nokogiri
-    ast (2.4.2)
-    builder (3.2.4)
+    base64 (0.2.0)
+    bigdecimal (3.1.8)
+    builder (3.3.0)
     coderay (1.1.3)
-    concurrent-ruby (1.1.9)
-    diff-lcs (1.3)
-    ffi (1.15.5)
+    concurrent-ruby (1.3.3)
+    connection_pool (2.4.1)
+    date (3.3.4)
+    diff-lcs (1.5.1)
+    drb (2.2.1)
+    faraday (2.10.0)
+      faraday-net_http (>= 2.0, < 3.2)
+      logger
+    faraday-net_http (3.1.0)
+      net-http
+    ffi (1.17.0)
+    ffi (1.17.0-x86_64-linux-gnu)
     formatador (1.1.0)
-    guard (2.18.0)
+    guard (2.18.1)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
       lumberjack (>= 1.0.12, < 2.0)
@@ -42,88 +58,106 @@ GEM
       guard (~> 2.1)
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
-    gyoku (1.3.1)
+    gyoku (1.4.0)
       builder (>= 2.1.2)
+      rexml (~> 3.0)
     httpclient (2.8.3)
-    httpi (2.5.0)
-      rack
-      socksify
-    i18n (1.10.0)
+    httpi (4.0.3)
+      base64
+      mutex_m
+      nkf
+      rack (>= 2.0, < 4)
+    i18n (1.14.5)
       concurrent-ruby (~> 1.0)
-    jaro_winkler (1.5.4)
-    listen (3.7.1)
+    listen (3.9.0)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
-    lumberjack (1.2.8)
-    method_source (1.0.0)
-    minitest (5.15.0)
+    logger (1.6.0)
+    lumberjack (1.2.10)
+    mail (2.8.1)
+      mini_mime (>= 0.1.1)
+      net-imap
+      net-pop
+      net-smtp
+    method_source (1.1.0)
+    mini_mime (1.1.5)
+    mini_portile2 (2.8.7)
+    minitest (5.24.1)
     mocha (0.9.10)
       rake
+    mutex_m (0.2.0)
     nenv (0.3.0)
-    nokogiri (1.13.1-arm64-darwin)
+    net-http (0.4.1)
+      uri
+    net-imap (0.4.14)
+      date
+      net-protocol
+    net-pop (0.1.2)
+      net-protocol
+    net-protocol (0.2.2)
+      timeout
+    net-smtp (0.5.0)
+      net-protocol
+    nkf (0.2.0)
+    nokogiri (1.16.6)
+      mini_portile2 (~> 2.8.2)
       racc (~> 1.4)
-    nori (2.6.0)
+    nokogiri (1.16.6-x86_64-linux)
+      racc (~> 1.4)
+    nori (2.7.0)
+      bigdecimal
     notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    parallel (1.21.0)
-    parser (3.1.0.0)
-      ast (~> 2.4.1)
-    pry (0.14.1)
+    pry (0.14.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    public_suffix (4.0.6)
-    racc (1.6.0)
-    rack (2.2.3)
-    rainbow (3.1.1)
+    public_suffix (6.0.0)
+    racc (1.8.0)
+    rack (3.1.7)
     rake (13.0.1)
-    rb-fsevent (0.11.1)
-    rb-inotify (0.10.1)
+    rb-fsevent (0.11.2)
+    rb-inotify (0.11.1)
       ffi (~> 1.0)
-    rexml (3.2.5)
-    rspec (3.7.0)
-      rspec-core (~> 3.7.0)
-      rspec-expectations (~> 3.7.0)
-      rspec-mocks (~> 3.7.0)
-    rspec-core (3.7.1)
-      rspec-support (~> 3.7.0)
-    rspec-expectations (3.7.0)
+    rexml (3.3.1)
+      strscan
+    rspec (3.13.0)
+      rspec-core (~> 3.13.0)
+      rspec-expectations (~> 3.13.0)
+      rspec-mocks (~> 3.13.0)
+    rspec-core (3.13.0)
+      rspec-support (~> 3.13.0)
+    rspec-expectations (3.13.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.7.0)
-    rspec-mocks (3.7.0)
+      rspec-support (~> 3.13.0)
+    rspec-mocks (3.13.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.7.0)
-    rspec-support (3.7.1)
-    rubocop (0.80.1)
-      jaro_winkler (~> 1.5.1)
-      parallel (~> 1.10)
-      parser (>= 2.7.0.1)
-      rainbow (>= 2.2.2, < 4.0)
-      rexml
-      ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 1.7)
-    ruby-progressbar (1.11.0)
-    savon (2.12.1)
+      rspec-support (~> 3.13.0)
+    rspec-support (3.13.1)
+    savon (2.15.1)
       akami (~> 1.2)
       builder (>= 2.1.2)
       gyoku (~> 1.2)
-      httpi (~> 2.3)
+      httpi (>= 4, < 5)
+      mail (~> 2.5)
       nokogiri (>= 1.8.1)
       nori (~> 2.4)
-      wasabi (~> 3.4)
+      wasabi (>= 3.7, < 6)
     shellany (0.0.1)
-    socksify (1.7.1)
-    thor (1.2.1)
-    tzinfo (2.0.4)
+    strscan (3.1.0)
+    thor (1.3.1)
+    timeout (0.4.1)
+    tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (1.6.1)
-    wasabi (3.7.0)
+    uri (0.13.0)
+    wasabi (5.0.2)
       addressable
-      httpi (~> 2.0)
-      nokogiri (>= 1.4.2)
+      faraday (~> 2.8)
+      nokogiri (>= 1.13.9)
 
 PLATFORMS
   ruby
+  x86_64-linux
 
 DEPENDENCIES
   afipws!
@@ -131,7 +165,9 @@ DEPENDENCIES
   mocha
   pry
   rspec
-  rubocop (~> 0.80.0)
+
+RUBY VERSION
+   ruby 3.3.4p94
 
 BUNDLED WITH
-   2.1.4
+   2.5.15

data/README.md

@@ -2,17 +2,17 @@
 
 Ruby client para los web services de la AFIP.
 
-[![Build Status](https://app.travis-ci.com/eeng/afipws.svg?branch=master)](https://app.travis-ci.com/eeng/afipws)
+[![Build Status](https://github.com/eeng/afipws/actions/workflows/ci.yml/badge.svg)](https://github.com/eeng/afipws/actions/workflows/ci.yml)
 
 ## Servicios Disponibles
 
-* wsaa (WSAA)
-* wsfe (WSFE)
-* ws_sr_constancia_inscripcion (WSConstanciaInscripcion)
-* ws_sr_padron_a100 (PersonaServiceA100)
-* ws_sr_padron_a4 (PersonaServiceA4)
-* ws_sr_padron_a5 (PersonaServiceA5)
-* wconsdeclaracion (WConsDeclaracion)
+- wsaa (WSAA)
+- wsfe (WSFE)
+- ws_sr_constancia_inscripcion (WSConstanciaInscripcion)
+- ws_sr_padron_a100 (PersonaServiceA100)
+- ws_sr_padron_a4 (PersonaServiceA4)
+- ws_sr_padron_a5 (PersonaServiceA5)
+- wconsdeclaracion (WConsDeclaracion)
 
 ## Uso
 

data/afipws.gemspec

@@ -21,10 +21,9 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rspec'
   s.add_development_dependency 'mocha'
   s.add_development_dependency 'guard-rspec'
-  s.add_development_dependency 'rubocop', '~> 0.80.0'
   s.add_development_dependency 'pry'
   s.add_dependency "builder"
-  s.add_dependency "savon", '~> 2.12.0'
+  s.add_dependency "savon", '~> 2.15.0'
   s.add_dependency "httpclient"
   s.add_dependency "nokogiri"
   s.add_dependency "activesupport"

data/lib/afipws/client.rb

@@ -6,8 +6,10 @@ module Afipws
 
     def request action, body = nil
       @savon.call action, message: body
-    rescue Savon::SOAPFault => e
+    rescue Savon::SOAPFault, Savon::HTTPError => e
       raise ServerError, e
+    rescue HTTPClient::ConnectTimeoutError => e
+      raise NetworkError.new(e, retriable: true)
     rescue HTTPClient::TimeoutError => e
       raise NetworkError, e
     end

data/lib/afipws/errors/error.rb

@@ -3,5 +3,9 @@ module Afipws
     def code? _code
       false
     end
+
+    def retriable?
+      false
+    end
   end
 end

data/lib/afipws/errors/network_error.rb

@@ -1,4 +1,13 @@
 module Afipws
   class NetworkError < Error
+    def initialize e, retriable: false
+      super e
+
+      @retriable = retriable
+    end
+
+    def retriable?
+      @retriable
+    end
   end
 end

data/lib/afipws/version.rb

@@ -1,3 +1,3 @@
 module Afipws
-  VERSION = '2.1.0'
+  VERSION = '2.3.0'
 end

data/spec/afipws/client_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 module Afipws
   describe Client do
-    context 'manejo de errores' do
+    context 'errores' do
       subject { Client.new(wsdl: Afipws::WSFE::WSDL[:test]) }
 
       it 'Savon::SOAPFault se encapsulan en ServerError' do
@@ -10,10 +10,32 @@ module Afipws
         -> { subject.request :fe_dummy }.should raise_error ServerError, /CMS no es valido/
       end
 
-      it 'HTTPClient::TimeoutError se encapsulan en NetworkError' do
+      it 'Savon::HTTPError se encapsulan en ServerError' do
+        expect_savon_to_raise Savon::HTTPError, stub(code: 503, body: 'Service Unavailable')
+        -> { subject.request :fe_dummy }.should raise_error ServerError, /Service Unavailable/
+      end
+
+      it 'HTTPClient::TimeoutError se encapsulan en NetworkError y no es retriable' do
+        expect_savon_to_raise HTTPClient::ReceiveTimeoutError, 'execution expired'
+        -> { subject.request :fe_dummy }.should raise_error { |error|
+          error.should be_a NetworkError
+          error.message.should match /execution expired/
+          error.retriable?.should be false
+        }
+      end
+
+      it 'HTTPClient::ConnectTimeoutError se encapsulan en NetworkError y es retriable' do
+        expect_savon_to_raise HTTPClient::ConnectTimeoutError, 'execution expired'
+        -> { subject.request :fe_dummy }.should raise_error { |error|
+          error.should be_a NetworkError
+          error.message.should match /execution expired/
+          error.retriable?.should be true
+        }
+      end
+
+      def expect_savon_to_raise error_class, message
         # Hack to mock exceptions on Savon
-        subject.instance_eval('@savon').expects(:call).raises(HTTPClient::ReceiveTimeoutError, 'execution expired')
-        -> { subject.request :fe_dummy }.should raise_error NetworkError, /execution expired/
+        subject.instance_eval('@savon', __FILE__, __LINE__).expects(:call).raises(error_class, message)
       end
     end
   end

data/spec/afipws/wsaa_spec.rb

@@ -22,12 +22,6 @@ module Afipws
       end
     end
 
-    context 'codificación del tra' do
-      it 'debería quitarle el header y footer' do
-        subject.codificar_tra(OpenSSL::PKCS7.new).should_not include 'BEGIN', 'END'
-      end
-    end
-
     context 'login' do
       it 'debería mandar el TRA al WS y obtener el TA' do
         ws = WSAA.new key: 'key', cert: 'cert'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: afipws
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.3.0
 platform: ruby
 authors:
 - Emmanuel Nicolau
 autorequire:
 bindir: bin
 cert_chain: []
-date: 1980-01-01 00:00:00.000000000 Z
+date: 2024-07-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -52,20 +52,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.80.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.80.0
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -100,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.12.0
+        version: 2.15.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.12.0
+        version: 2.15.0
 - !ruby/object:Gem::Dependency
   name: httpclient
   requirement: !ruby/object:Gem::Requirement
@@ -159,11 +145,11 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".envrc"
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
 - ".ruby-version"
-- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - Gemfile.lock
@@ -189,7 +175,6 @@ files:
 - lib/afipws/ws_constancia_inscripcion.rb
 - lib/afipws/wsaa.rb
 - lib/afipws/wsfe.rb
-- shell.nix
 - spec/afipws/client_spec.rb
 - spec/afipws/core_ext/hash_spec.rb
 - spec/afipws/persona_service_a100_spec.rb
@@ -279,7 +264,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.26
+rubygems_version: 3.5.11
 signing_key:
 specification_version: 4
 summary: Ruby client para los web services de la AFIP

data/.travis.yml

@@ -1,5 +0,0 @@
----
-sudo: false
-language: ruby
-cache: bundler
-before_install: gem install bundler -v 2.1.4

data/shell.nix

@@ -1,6 +0,0 @@
-with import <nixpkgs> {};
-mkShell {
-  nativeBuildInputs = [
-    ruby
-  ];
-}