afipws 2.1.0 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c62722b5dadabc183a975922b0177b63d8bce82c24fafdd35e74240856b25d8e
-  data.tar.gz: b1a0f1ce2a252d730fee01a0830fc3d2142b50df33c13864b95854bdffa856ca
+  metadata.gz: 35d82abb92bacac0765fa6ff1165144285d88b6de45ffb84ae70fa99a8c5bd34
+  data.tar.gz: 5dfb329baf6446010559789d0afbcf24b1de9dbe8a5c7121f5b3dec932ef1d4e
 SHA512:
-  metadata.gz: 969630cf2f9cb2b9ae629a61f0c0cdfe79832825ea6a6fe43745d341b5b29b1117ce230567ed0e9fd27ff22f73936135bf1c4cfc6aed856fb5090ec1eeadd9eb
-  data.tar.gz: 4601ea842fcd9d84ed968fd6e8a0d11e7304353b92782dfe79ad18d6894d8c8eada013b893d8ea0f424ac004722cee6edd9e879513204d7cb354321dfb16ad75
+  metadata.gz: 9c3a00c50955d67e1a4c5bf53965a5b5d2b5ec305c0d4fff28beb8f54339d7d0bd2e9d17145dccdf101f1608f4a0c0420da2e75e2ab8ef8fdfaae7163d142547
+  data.tar.gz: e3cfc5f3648b0ab30686f6a7848557b42f332eb12e38216a7b2ee9da69cc3a2d0dfc437477b80d35e2f9b003f699ea3fdd988cbdf9dfd23f85f7c980df3fca17

data/.github/workflows/ci.yml

@@ -0,0 +1,13 @@
+name: CI
+on: push
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+      - name: Install dependencies
+        run: bundle install
+      - name: Run tests
+        run: bundle exec rake

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    afipws (2.1.0)
+    afipws (2.2.0)
       activesupport
       builder
       httpclient
@@ -11,7 +11,7 @@ PATH
 GEM
   remote: http://rubygems.org/
   specs:
-    activesupport (7.0.2.2)
+    activesupport (7.0.4.3)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
@@ -24,7 +24,7 @@ GEM
     ast (2.4.2)
     builder (3.2.4)
     coderay (1.1.3)
-    concurrent-ruby (1.1.9)
+    concurrent-ruby (1.2.2)
     diff-lcs (1.3)
     ffi (1.15.5)
     formatador (1.1.0)
@@ -48,7 +48,7 @@ GEM
     httpi (2.5.0)
       rack
       socksify
-    i18n (1.10.0)
+    i18n (1.12.0)
       concurrent-ruby (~> 1.0)
     jaro_winkler (1.5.4)
     listen (3.7.1)
@@ -56,11 +56,11 @@ GEM
       rb-inotify (~> 0.9, >= 0.9.10)
     lumberjack (1.2.8)
     method_source (1.0.0)
-    minitest (5.15.0)
+    minitest (5.18.0)
     mocha (0.9.10)
       rake
     nenv (0.3.0)
-    nokogiri (1.13.1-arm64-darwin)
+    nokogiri (1.13.10-arm64-darwin)
       racc (~> 1.4)
     nori (2.6.0)
     notiffany (0.1.3)
@@ -73,8 +73,8 @@ GEM
       coderay (~> 1.1)
       method_source (~> 1.0)
     public_suffix (4.0.6)
-    racc (1.6.0)
-    rack (2.2.3)
+    racc (1.6.1)
+    rack (3.0.7)
     rainbow (3.1.1)
     rake (13.0.1)
     rb-fsevent (0.11.1)
@@ -114,7 +114,7 @@ GEM
     shellany (0.0.1)
     socksify (1.7.1)
     thor (1.2.1)
-    tzinfo (2.0.4)
+    tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
     unicode-display_width (1.6.1)
     wasabi (3.7.0)

data/README.md

@@ -2,17 +2,17 @@
 
 Ruby client para los web services de la AFIP.
 
-[![Build Status](https://app.travis-ci.com/eeng/afipws.svg?branch=master)](https://app.travis-ci.com/eeng/afipws)
+[![Build Status](https://github.com/eeng/afipws/actions/workflows/ci.yml/badge.svg)](https://github.com/eeng/afipws/actions/workflows/ci.yml)
 
 ## Servicios Disponibles
 
-* wsaa (WSAA)
-* wsfe (WSFE)
-* ws_sr_constancia_inscripcion (WSConstanciaInscripcion)
-* ws_sr_padron_a100 (PersonaServiceA100)
-* ws_sr_padron_a4 (PersonaServiceA4)
-* ws_sr_padron_a5 (PersonaServiceA5)
-* wconsdeclaracion (WConsDeclaracion)
+- wsaa (WSAA)
+- wsfe (WSFE)
+- ws_sr_constancia_inscripcion (WSConstanciaInscripcion)
+- ws_sr_padron_a100 (PersonaServiceA100)
+- ws_sr_padron_a4 (PersonaServiceA4)
+- ws_sr_padron_a5 (PersonaServiceA5)
+- wconsdeclaracion (WConsDeclaracion)
 
 ## Uso
 

data/lib/afipws/client.rb

@@ -6,8 +6,10 @@ module Afipws
 
     def request action, body = nil
       @savon.call action, message: body
-    rescue Savon::SOAPFault => e
+    rescue Savon::SOAPFault, Savon::HTTPError => e
       raise ServerError, e
+    rescue HTTPClient::ConnectTimeoutError => e
+      raise NetworkError.new(e, retriable: true)
     rescue HTTPClient::TimeoutError => e
       raise NetworkError, e
     end

data/lib/afipws/errors/error.rb

@@ -3,5 +3,9 @@ module Afipws
     def code? _code
       false
     end
+
+    def retriable?
+      false
+    end
   end
 end

data/lib/afipws/errors/network_error.rb

@@ -1,4 +1,13 @@
 module Afipws
   class NetworkError < Error
+    def initialize e, retriable: false
+      super e
+
+      @retriable = retriable
+    end
+
+    def retriable?
+      @retriable
+    end
   end
 end

data/lib/afipws/version.rb

@@ -1,3 +1,3 @@
 module Afipws
-  VERSION = '2.1.0'
+  VERSION = '2.2.0'
 end

data/spec/afipws/client_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 module Afipws
   describe Client do
-    context 'manejo de errores' do
+    context 'errores' do
       subject { Client.new(wsdl: Afipws::WSFE::WSDL[:test]) }
 
       it 'Savon::SOAPFault se encapsulan en ServerError' do
@@ -10,10 +10,32 @@ module Afipws
         -> { subject.request :fe_dummy }.should raise_error ServerError, /CMS no es valido/
       end
 
-      it 'HTTPClient::TimeoutError se encapsulan en NetworkError' do
+      it 'Savon::HTTPError se encapsulan en ServerError' do
+        expect_savon_to_raise Savon::HTTPError, stub(code: 503, body: 'Service Unavailable')
+        -> { subject.request :fe_dummy }.should raise_error ServerError, /Service Unavailable/
+      end
+
+      it 'HTTPClient::TimeoutError se encapsulan en NetworkError y no es retriable' do
+        expect_savon_to_raise HTTPClient::ReceiveTimeoutError, 'execution expired'
+        -> { subject.request :fe_dummy }.should raise_error { |error|
+          error.should be_a NetworkError
+          error.message.should match /execution expired/
+          error.retriable?.should be false
+        }
+      end
+
+      it 'HTTPClient::ConnectTimeoutError se encapsulan en NetworkError y es retriable' do
+        expect_savon_to_raise HTTPClient::ConnectTimeoutError, 'execution expired'
+        -> { subject.request :fe_dummy }.should raise_error { |error|
+          error.should be_a NetworkError
+          error.message.should match /execution expired/
+          error.retriable?.should be true
+        }
+      end
+
+      def expect_savon_to_raise error_class, message
         # Hack to mock exceptions on Savon
-        subject.instance_eval('@savon').expects(:call).raises(HTTPClient::ReceiveTimeoutError, 'execution expired')
-        -> { subject.request :fe_dummy }.should raise_error NetworkError, /execution expired/
+        subject.instance_eval('@savon', __FILE__, __LINE__).expects(:call).raises(error_class, message)
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: afipws
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.2.0
 platform: ruby
 authors:
 - Emmanuel Nicolau
@@ -159,11 +159,11 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".envrc"
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
 - ".ruby-version"
-- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - Gemfile.lock

data/.travis.yml

@@ -1,5 +0,0 @@
----
-sudo: false
-language: ruby
-cache: bundler
-before_install: gem install bundler -v 2.1.4