afipws 2.0.0 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a50ec977b4eb2da94edd06703a11d9ee46b6cfd847de01160a1527871712158e
-  data.tar.gz: 3c0aa5ab031957e66b2afea67af73ea1cd91026f67cfea9353877c1b43186dc2
+  metadata.gz: 35d82abb92bacac0765fa6ff1165144285d88b6de45ffb84ae70fa99a8c5bd34
+  data.tar.gz: 5dfb329baf6446010559789d0afbcf24b1de9dbe8a5c7121f5b3dec932ef1d4e
 SHA512:
-  metadata.gz: 471e56e9c6ceab26acc42b4c2997c2ab9f611ad89bee70400ce5a5d68bc83dc3e89e348af5ce98e727bc6c2363af8936fbcd238f8d1f00942cae3a8a754dae02
-  data.tar.gz: d503f3f2df71fc503ddb10bf80985014da6cb03cabc77c5a8a98b4203269e5225c011f66fb125d248e785cb5c3b5b133b32ae8bd2b8c471b1946c8fc1f7dc1ad
+  metadata.gz: 9c3a00c50955d67e1a4c5bf53965a5b5d2b5ec305c0d4fff28beb8f54339d7d0bd2e9d17145dccdf101f1608f4a0c0420da2e75e2ab8ef8fdfaae7163d142547
+  data.tar.gz: e3cfc5f3648b0ab30686f6a7848557b42f332eb12e38216a7b2ee9da69cc3a2d0dfc437477b80d35e2f9b003f699ea3fdd988cbdf9dfd23f85f7c980df3fca17

data/.envrc

@@ -0,0 +1,2 @@
+layout ruby
+use nix

data/.github/workflows/ci.yml

@@ -0,0 +1,13 @@
+name: CI
+on: push
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+      - name: Install dependencies
+        run: bundle install
+      - name: Run tests
+        run: bundle exec rake

data/.gitignore

@@ -5,3 +5,4 @@ spec/manual/*.key
 spec/manual/*.crt
 .DS_Store
 tmp
+/.direnv

data/.rubocop.yml

@@ -46,9 +46,6 @@ Style/Next:
 Style/NumericPredicate:
   Enabled: false
 
-Style/NumericLiterals:
-  Enabled: false
-
 Style/SymbolArray:
   Enabled: false
 
@@ -58,19 +55,31 @@ Style/MutableConstant:
 Style/RescueModifier:
   Enabled: false
 
+Style/HashEachMethods:
+  Enabled: false
+
+Style/HashTransformKeys:
+  Enabled: false
+
+Style/HashTransformValues:
+  Enabled: false
+
+Layout/LineLength:
+  Max: 120
+
 Layout/SpaceInsideHashLiteralBraces:
   Enabled: false
 
 Layout/MultilineMethodCallIndentation:
   Enabled: false
 
-Layout/TrailingBlankLines:
+Layout/TrailingEmptyLines:
   Enabled: false
 
-Layout/IndentArray:
+Layout/FirstArrayElementIndentation:
   EnforcedStyle: consistent
 
-Layout/AlignParameters:
+Layout/ParameterAlignment:
   EnforcedStyle: with_fixed_indentation
 
 Layout/SpaceInLambdaLiteral:
@@ -82,10 +91,6 @@ Metrics:
 Bundler:
   Enabled: false
 
-Lint/Void:
-  Exclude:
-    - spec/**/*.rb
-
 Lint/AssignmentInCondition:
   Enabled: false
 
@@ -101,5 +106,5 @@ Lint/AmbiguousOperator:
 Lint/AmbiguousBlockAssociation:
   Enabled: false
 
-Naming/UncommunicativeMethodParamName:
+Naming/MethodParameterName:
   Enabled: false

data/.ruby-version

@@ -1 +1 @@
-2.5.0
+2.7.5

data/{lib/CHANGELOG.md → CHANGELOG.md}

@@ -13,4 +13,4 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
 
 ### Changed
 
-- Rename Afipws::WSError to Afipws::Error, and create subclasses to distinguish between different types of errors.
+- Rename `Afipws::WSError` to `Afipws::Error`, and create subclasses to distinguish between different types of errors.

data/Gemfile.lock

@@ -1,42 +1,40 @@
 PATH
   remote: .
   specs:
-    afipws (2.0.0)
+    afipws (2.2.0)
       activesupport
       builder
       httpclient
       nokogiri
-      savon (~> 2.11.0)
+      savon (~> 2.12.0)
 
 GEM
   remote: http://rubygems.org/
   specs:
-    activesupport (6.0.3.2)
+    activesupport (7.0.4.3)
       concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 0.7, < 2)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-      zeitwerk (~> 2.2, >= 2.2.2)
-    addressable (2.7.0)
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      tzinfo (~> 2.0)
+    addressable (2.8.0)
       public_suffix (>= 2.0.2, < 5.0)
     akami (1.3.1)
       gyoku (>= 0.4.0)
       nokogiri
-    ast (2.4.0)
+    ast (2.4.2)
     builder (3.2.4)
-    byebug (11.0.1)
-    coderay (1.1.2)
-    concurrent-ruby (1.1.7)
+    coderay (1.1.3)
+    concurrent-ruby (1.2.2)
     diff-lcs (1.3)
-    ffi (1.9.25)
-    formatador (0.2.5)
-    guard (2.14.2)
+    ffi (1.15.5)
+    formatador (1.1.0)
+    guard (2.18.0)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
       lumberjack (>= 1.0.12, < 2.0)
       nenv (~> 0.1)
       notiffany (~> 0.0)
-      pry (>= 0.9.12)
+      pry (>= 0.13.0)
       shellany (~> 0.0)
       thor (>= 0.18.1)
     guard-compat (1.2.1)
@@ -47,46 +45,42 @@ GEM
     gyoku (1.3.1)
       builder (>= 2.1.2)
     httpclient (2.8.3)
-    httpi (2.4.5)
+    httpi (2.5.0)
       rack
       socksify
-    i18n (1.8.5)
+    i18n (1.12.0)
       concurrent-ruby (~> 1.0)
-    jaro_winkler (1.5.1)
-    listen (3.1.5)
-      rb-fsevent (~> 0.9, >= 0.9.4)
-      rb-inotify (~> 0.9, >= 0.9.7)
-      ruby_dep (~> 1.2)
-    lumberjack (1.0.13)
-    method_source (0.9.0)
-    mini_portile2 (2.4.0)
-    minitest (5.14.2)
+    jaro_winkler (1.5.4)
+    listen (3.7.1)
+      rb-fsevent (~> 0.10, >= 0.10.3)
+      rb-inotify (~> 0.9, >= 0.9.10)
+    lumberjack (1.2.8)
+    method_source (1.0.0)
+    minitest (5.18.0)
     mocha (0.9.10)
       rake
     nenv (0.3.0)
-    nokogiri (1.10.10)
-      mini_portile2 (~> 2.4.0)
+    nokogiri (1.13.10-arm64-darwin)
+      racc (~> 1.4)
     nori (2.6.0)
-    notiffany (0.1.1)
+    notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    parallel (1.12.1)
-    parser (2.5.3.0)
-      ast (~> 2.4.0)
-    powerpack (0.1.2)
-    pry (0.11.3)
-      coderay (~> 1.1.0)
-      method_source (~> 0.9.0)
-    pry-byebug (3.7.0)
-      byebug (~> 11.0)
-      pry (~> 0.10)
-    public_suffix (4.0.5)
-    rack (2.2.3)
-    rainbow (3.0.0)
+    parallel (1.21.0)
+    parser (3.1.0.0)
+      ast (~> 2.4.1)
+    pry (0.14.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    public_suffix (4.0.6)
+    racc (1.6.1)
+    rack (3.0.7)
+    rainbow (3.1.1)
     rake (13.0.1)
-    rb-fsevent (0.10.3)
-    rb-inotify (0.9.10)
-      ffi (>= 0.5.0, < 2)
+    rb-fsevent (0.11.1)
+    rb-inotify (0.10.1)
+      ffi (~> 1.0)
+    rexml (3.2.5)
     rspec (3.7.0)
       rspec-core (~> 3.7.0)
       rspec-expectations (~> 3.7.0)
@@ -100,36 +94,33 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.7.0)
     rspec-support (3.7.1)
-    rubocop (0.61.1)
+    rubocop (0.80.1)
       jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
-      parser (>= 2.5, != 2.5.1.1)
-      powerpack (~> 0.1)
+      parser (>= 2.7.0.1)
       rainbow (>= 2.2.2, < 4.0)
+      rexml
       ruby-progressbar (~> 1.7)
-      unicode-display_width (~> 1.4.0)
-    ruby-progressbar (1.10.0)
-    ruby_dep (1.5.0)
-    savon (2.11.2)
+      unicode-display_width (>= 1.4.0, < 1.7)
+    ruby-progressbar (1.11.0)
+    savon (2.12.1)
       akami (~> 1.2)
       builder (>= 2.1.2)
       gyoku (~> 1.2)
       httpi (~> 2.3)
-      nokogiri (>= 1.4.0)
+      nokogiri (>= 1.8.1)
       nori (~> 2.4)
       wasabi (~> 3.4)
     shellany (0.0.1)
     socksify (1.7.1)
-    thor (0.20.0)
-    thread_safe (0.3.6)
-    tzinfo (1.2.7)
-      thread_safe (~> 0.1)
-    unicode-display_width (1.4.0)
-    wasabi (3.6.1)
+    thor (1.2.1)
+    tzinfo (2.0.6)
+      concurrent-ruby (~> 1.0)
+    unicode-display_width (1.6.1)
+    wasabi (3.7.0)
       addressable
       httpi (~> 2.0)
       nokogiri (>= 1.4.2)
-    zeitwerk (2.4.0)
 
 PLATFORMS
   ruby
@@ -139,9 +130,8 @@ DEPENDENCIES
   guard-rspec
   mocha
   pry
-  pry-byebug
   rspec
-  rubocop
+  rubocop (~> 0.80.0)
 
 BUNDLED WITH
    2.1.4

data/README.md

@@ -2,17 +2,17 @@
 
 Ruby client para los web services de la AFIP.
 
-[![Build Status](https://travis-ci.org/eeng/afipws.svg?branch=master)](https://travis-ci.org/eeng/afipws)
+[![Build Status](https://github.com/eeng/afipws/actions/workflows/ci.yml/badge.svg)](https://github.com/eeng/afipws/actions/workflows/ci.yml)
 
 ## Servicios Disponibles
 
-* wsaa (WSAA)
-* wsfe (WSFE)
-* ws_sr_constancia_inscripcion (WSConstanciaInscripcion)
-* ws_sr_padron_a100 (PersonaServiceA100)
-* ws_sr_padron_a4 (PersonaServiceA4)
-* ws_sr_padron_a5 (PersonaServiceA5)
-* wconsdeclaracion (WConsDeclaracion)
+- wsaa (WSAA)
+- wsfe (WSFE)
+- ws_sr_constancia_inscripcion (WSConstanciaInscripcion)
+- ws_sr_padron_a100 (PersonaServiceA100)
+- ws_sr_padron_a4 (PersonaServiceA4)
+- ws_sr_padron_a5 (PersonaServiceA5)
+- wconsdeclaracion (WConsDeclaracion)
 
 ## Uso
 

data/afipws.gemspec

@@ -21,11 +21,10 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rspec'
   s.add_development_dependency 'mocha'
   s.add_development_dependency 'guard-rspec'
-  s.add_development_dependency 'rubocop'
+  s.add_development_dependency 'rubocop', '~> 0.80.0'
   s.add_development_dependency 'pry'
-  s.add_development_dependency 'pry-byebug'
   s.add_dependency "builder"
-  s.add_dependency "savon", '~> 2.11.0'
+  s.add_dependency "savon", '~> 2.12.0'
   s.add_dependency "httpclient"
   s.add_dependency "nokogiri"
   s.add_dependency "activesupport"

data/lib/afipws/client.rb

@@ -6,8 +6,10 @@ module Afipws
 
     def request action, body = nil
       @savon.call action, message: body
-    rescue Savon::SOAPFault => e
+    rescue Savon::SOAPFault, Savon::HTTPError => e
       raise ServerError, e
+    rescue HTTPClient::ConnectTimeoutError => e
+      raise NetworkError.new(e, retriable: true)
     rescue HTTPClient::TimeoutError => e
       raise NetworkError, e
     end

data/lib/afipws/errors/error.rb

@@ -3,5 +3,9 @@ module Afipws
     def code? _code
       false
     end
+
+    def retriable?
+      false
+    end
   end
 end

data/lib/afipws/errors/network_error.rb

@@ -1,4 +1,13 @@
 module Afipws
   class NetworkError < Error
+    def initialize e, retriable: false
+      super e
+
+      @retriable = retriable
+    end
+
+    def retriable?
+      @retriable
+    end
   end
 end

data/lib/afipws/version.rb

@@ -1,3 +1,3 @@
 module Afipws
-  VERSION = '2.0.0'
+  VERSION = '2.2.0'
 end

data/shell.nix

@@ -0,0 +1,6 @@
+with import <nixpkgs> {};
+mkShell {
+  nativeBuildInputs = [
+    ruby
+  ];
+}

data/spec/afipws/client_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 module Afipws
   describe Client do
-    context 'manejo de errores' do
+    context 'errores' do
       subject { Client.new(wsdl: Afipws::WSFE::WSDL[:test]) }
 
       it 'Savon::SOAPFault se encapsulan en ServerError' do
@@ -10,10 +10,32 @@ module Afipws
         -> { subject.request :fe_dummy }.should raise_error ServerError, /CMS no es valido/
       end
 
-      it 'HTTPClient::TimeoutError se encapsulan en NetworkError' do
+      it 'Savon::HTTPError se encapsulan en ServerError' do
+        expect_savon_to_raise Savon::HTTPError, stub(code: 503, body: 'Service Unavailable')
+        -> { subject.request :fe_dummy }.should raise_error ServerError, /Service Unavailable/
+      end
+
+      it 'HTTPClient::TimeoutError se encapsulan en NetworkError y no es retriable' do
+        expect_savon_to_raise HTTPClient::ReceiveTimeoutError, 'execution expired'
+        -> { subject.request :fe_dummy }.should raise_error { |error|
+          error.should be_a NetworkError
+          error.message.should match /execution expired/
+          error.retriable?.should be false
+        }
+      end
+
+      it 'HTTPClient::ConnectTimeoutError se encapsulan en NetworkError y es retriable' do
+        expect_savon_to_raise HTTPClient::ConnectTimeoutError, 'execution expired'
+        -> { subject.request :fe_dummy }.should raise_error { |error|
+          error.should be_a NetworkError
+          error.message.should match /execution expired/
+          error.retriable?.should be true
+        }
+      end
+
+      def expect_savon_to_raise error_class, message
         # Hack to mock exceptions on Savon
-        subject.instance_eval('@savon').expects(:call).raises(HTTPClient::ReceiveTimeoutError, 'execution expired')
-        -> { subject.request :fe_dummy }.should raise_error NetworkError, /execution expired/
+        subject.instance_eval('@savon', __FILE__, __LINE__).expects(:call).raises(error_class, message)
       end
     end
   end

data/spec/spec_helper.rb

@@ -2,7 +2,6 @@ require 'rspec'
 require 'afipws'
 require 'savon/mock/spec_helper'
 require 'mocha'
-require 'pry-byebug'
 
 Dir[File.dirname(__FILE__) + '/support/**/*.rb'].each { |f| require f }
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: afipws
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.2.0
 platform: ruby
 authors:
 - Emmanuel Nicolau
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-10-28 00:00:00.000000000 Z
+date: 1980-01-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -56,16 +56,16 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.80.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.80.0
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -80,20 +80,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: pry-byebug
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: builder
   requirement: !ruby/object:Gem::Requirement
@@ -114,14 +100,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.11.0
+        version: 2.12.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.11.0
+        version: 2.12.0
 - !ruby/object:Gem::Dependency
   name: httpclient
   requirement: !ruby/object:Gem::Requirement
@@ -172,11 +158,13 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- ".envrc"
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
 - ".ruby-version"
-- ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - Gemfile.lock
 - Guardfile
@@ -185,7 +173,6 @@ files:
 - Rakefile
 - afipws.gemspec
 - bin/console
-- lib/CHANGELOG.md
 - lib/afipws.rb
 - lib/afipws/client.rb
 - lib/afipws/core_ext/hash.rb
@@ -202,6 +189,7 @@ files:
 - lib/afipws/ws_constancia_inscripcion.rb
 - lib/afipws/wsaa.rb
 - lib/afipws/wsfe.rb
+- shell.nix
 - spec/afipws/client_spec.rb
 - spec/afipws/core_ext/hash_spec.rb
 - spec/afipws/persona_service_a100_spec.rb
@@ -291,8 +279,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: afipws
-rubygems_version: 2.7.3
+rubygems_version: 3.2.26
 signing_key:
 specification_version: 4
 summary: Ruby client para los web services de la AFIP

data/.travis.yml

@@ -1,5 +0,0 @@
----
-sudo: false
-language: ruby
-cache: bundler
-before_install: gem install bundler -v 1.16.2