afipws 1.3.0 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: e083e48130414df572623a49024d5d68fc169d57
-  data.tar.gz: c87895059bef97f564ecd82e59771a6569c6b011
+SHA256:
+  metadata.gz: c62722b5dadabc183a975922b0177b63d8bce82c24fafdd35e74240856b25d8e
+  data.tar.gz: b1a0f1ce2a252d730fee01a0830fc3d2142b50df33c13864b95854bdffa856ca
 SHA512:
-  metadata.gz: 9beb54c5fd1c0a08c829735cd8fb05edac37a50333eccdbab3517103eb453a9804324e2293936d2af43e42d868a198c1606c4de84bb81e0e35d52cf099a689ab
-  data.tar.gz: 91069cf8b299dfb59c6e1eac27d7ac3fbe4748f89682e6a4bca049f0fc8669d949292c8a384e9aa7578723928c3ad564d29eb270a4f6f1fc6665c0439e8d7cee
+  metadata.gz: 969630cf2f9cb2b9ae629a61f0c0cdfe79832825ea6a6fe43745d341b5b29b1117ce230567ed0e9fd27ff22f73936135bf1c4cfc6aed856fb5090ec1eeadd9eb
+  data.tar.gz: 4601ea842fcd9d84ed968fd6e8a0d11e7304353b92782dfe79ad18d6894d8c8eada013b893d8ea0f424ac004722cee6edd9e879513204d7cb354321dfb16ad75

data/.envrc

@@ -0,0 +1,2 @@
+layout ruby
+use nix

data/.gitignore

@@ -5,3 +5,4 @@ spec/manual/*.key
 spec/manual/*.crt
 .DS_Store
 tmp
+/.direnv

data/.rubocop.yml

@@ -55,19 +55,31 @@ Style/MutableConstant:
 Style/RescueModifier:
   Enabled: false
 
+Style/HashEachMethods:
+  Enabled: false
+
+Style/HashTransformKeys:
+  Enabled: false
+
+Style/HashTransformValues:
+  Enabled: false
+
+Layout/LineLength:
+  Max: 120
+
 Layout/SpaceInsideHashLiteralBraces:
   Enabled: false
 
 Layout/MultilineMethodCallIndentation:
   Enabled: false
 
-Layout/TrailingBlankLines:
+Layout/TrailingEmptyLines:
   Enabled: false
 
-Layout/IndentArray:
+Layout/FirstArrayElementIndentation:
   EnforcedStyle: consistent
 
-Layout/AlignParameters:
+Layout/ParameterAlignment:
   EnforcedStyle: with_fixed_indentation
 
 Layout/SpaceInLambdaLiteral:
@@ -79,10 +91,6 @@ Metrics:
 Bundler:
   Enabled: false
 
-Lint/Void:
-  Exclude:
-    - spec/**/*.rb
-
 Lint/AssignmentInCondition:
   Enabled: false
 
@@ -98,5 +106,5 @@ Lint/AmbiguousOperator:
 Lint/AmbiguousBlockAssociation:
   Enabled: false
 
-Naming/UncommunicativeMethodParamName:
+Naming/MethodParameterName:
   Enabled: false

data/.ruby-version

@@ -1 +1 @@
-2.3.1
+2.7.5

data/.travis.yml

@@ -2,4 +2,4 @@
 sudo: false
 language: ruby
 cache: bundler
-before_install: gem install bundler -v 1.16.2
+before_install: gem install bundler -v 2.1.4

data/CHANGELOG.md

@@ -0,0 +1,16 @@
+# Change Log
+
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
+
+## [2.0.0] - 2020-10-28
+
+### Added
+
+- Long overdue CHANGELOG file.
+- Include `httpclient` dependency so we can wrap network errors.
+
+### Changed
+
+- Rename `Afipws::WSError` to `Afipws::Error`, and create subclasses to distinguish between different types of errors.

data/Gemfile.lock

@@ -1,38 +1,40 @@
 PATH
   remote: .
   specs:
-    afipws (1.3.0)
+    afipws (2.1.0)
       activesupport
       builder
+      httpclient
       nokogiri
-      savon (~> 2.11.0)
+      savon (~> 2.12.0)
 
 GEM
   remote: http://rubygems.org/
   specs:
-    activesupport (5.2.3)
+    activesupport (7.0.2.2)
       concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 0.7, < 2)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      tzinfo (~> 2.0)
+    addressable (2.8.0)
+      public_suffix (>= 2.0.2, < 5.0)
     akami (1.3.1)
       gyoku (>= 0.4.0)
       nokogiri
-    ast (2.4.0)
-    builder (3.2.3)
-    byebug (11.0.1)
-    coderay (1.1.2)
-    concurrent-ruby (1.1.5)
+    ast (2.4.2)
+    builder (3.2.4)
+    coderay (1.1.3)
+    concurrent-ruby (1.1.9)
     diff-lcs (1.3)
-    ffi (1.9.25)
-    formatador (0.2.5)
-    guard (2.14.2)
+    ffi (1.15.5)
+    formatador (1.1.0)
+    guard (2.18.0)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
       lumberjack (>= 1.0.12, < 2.0)
       nenv (~> 0.1)
       notiffany (~> 0.0)
-      pry (>= 0.9.12)
+      pry (>= 0.13.0)
       shellany (~> 0.0)
       thor (>= 0.18.1)
     guard-compat (1.2.1)
@@ -42,45 +44,43 @@ GEM
       rspec (>= 2.99.0, < 4.0)
     gyoku (1.3.1)
       builder (>= 2.1.2)
-    httpi (2.4.4)
+    httpclient (2.8.3)
+    httpi (2.5.0)
       rack
       socksify
-    i18n (1.6.0)
+    i18n (1.10.0)
       concurrent-ruby (~> 1.0)
-    jaro_winkler (1.5.1)
-    listen (3.1.5)
-      rb-fsevent (~> 0.9, >= 0.9.4)
-      rb-inotify (~> 0.9, >= 0.9.7)
-      ruby_dep (~> 1.2)
-    lumberjack (1.0.13)
-    method_source (0.9.0)
-    mini_portile2 (2.4.0)
-    minitest (5.11.3)
+    jaro_winkler (1.5.4)
+    listen (3.7.1)
+      rb-fsevent (~> 0.10, >= 0.10.3)
+      rb-inotify (~> 0.9, >= 0.9.10)
+    lumberjack (1.2.8)
+    method_source (1.0.0)
+    minitest (5.15.0)
     mocha (0.9.10)
       rake
     nenv (0.3.0)
-    nokogiri (1.10.4)
-      mini_portile2 (~> 2.4.0)
+    nokogiri (1.13.1-arm64-darwin)
+      racc (~> 1.4)
     nori (2.6.0)
-    notiffany (0.1.1)
+    notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    parallel (1.12.1)
-    parser (2.5.3.0)
-      ast (~> 2.4.0)
-    powerpack (0.1.2)
-    pry (0.11.3)
-      coderay (~> 1.1.0)
-      method_source (~> 0.9.0)
-    pry-byebug (3.7.0)
-      byebug (~> 11.0)
-      pry (~> 0.10)
-    rack (2.0.8)
-    rainbow (3.0.0)
-    rake (10.4.2)
-    rb-fsevent (0.10.3)
-    rb-inotify (0.9.10)
-      ffi (>= 0.5.0, < 2)
+    parallel (1.21.0)
+    parser (3.1.0.0)
+      ast (~> 2.4.1)
+    pry (0.14.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    public_suffix (4.0.6)
+    racc (1.6.0)
+    rack (2.2.3)
+    rainbow (3.1.1)
+    rake (13.0.1)
+    rb-fsevent (0.11.1)
+    rb-inotify (0.10.1)
+      ffi (~> 1.0)
+    rexml (3.2.5)
     rspec (3.7.0)
       rspec-core (~> 3.7.0)
       rspec-expectations (~> 3.7.0)
@@ -94,32 +94,31 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.7.0)
     rspec-support (3.7.1)
-    rubocop (0.61.1)
+    rubocop (0.80.1)
       jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
-      parser (>= 2.5, != 2.5.1.1)
-      powerpack (~> 0.1)
+      parser (>= 2.7.0.1)
       rainbow (>= 2.2.2, < 4.0)
+      rexml
       ruby-progressbar (~> 1.7)
-      unicode-display_width (~> 1.4.0)
-    ruby-progressbar (1.10.0)
-    ruby_dep (1.5.0)
-    savon (2.11.2)
+      unicode-display_width (>= 1.4.0, < 1.7)
+    ruby-progressbar (1.11.0)
+    savon (2.12.1)
       akami (~> 1.2)
       builder (>= 2.1.2)
       gyoku (~> 1.2)
       httpi (~> 2.3)
-      nokogiri (>= 1.4.0)
+      nokogiri (>= 1.8.1)
       nori (~> 2.4)
       wasabi (~> 3.4)
     shellany (0.0.1)
     socksify (1.7.1)
-    thor (0.20.0)
-    thread_safe (0.3.6)
-    tzinfo (1.2.5)
-      thread_safe (~> 0.1)
-    unicode-display_width (1.4.0)
-    wasabi (3.5.0)
+    thor (1.2.1)
+    tzinfo (2.0.4)
+      concurrent-ruby (~> 1.0)
+    unicode-display_width (1.6.1)
+    wasabi (3.7.0)
+      addressable
       httpi (~> 2.0)
       nokogiri (>= 1.4.2)
 
@@ -131,9 +130,8 @@ DEPENDENCIES
   guard-rspec
   mocha
   pry
-  pry-byebug
   rspec
-  rubocop
+  rubocop (~> 0.80.0)
 
 BUNDLED WITH
-   1.16.2
+   2.1.4

data/README.md

@@ -2,7 +2,7 @@
 
 Ruby client para los web services de la AFIP.
 
-[![Build Status](https://travis-ci.org/eeng/afipws.svg?branch=master)](https://travis-ci.org/eeng/afipws)
+[![Build Status](https://app.travis-ci.com/eeng/afipws.svg?branch=master)](https://app.travis-ci.com/eeng/afipws)
 
 ## Servicios Disponibles
 

data/afipws.gemspec

@@ -21,11 +21,11 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rspec'
   s.add_development_dependency 'mocha'
   s.add_development_dependency 'guard-rspec'
-  s.add_development_dependency 'rubocop'
+  s.add_development_dependency 'rubocop', '~> 0.80.0'
   s.add_development_dependency 'pry'
-  s.add_development_dependency 'pry-byebug'
   s.add_dependency "builder"
-  s.add_dependency "savon", '~> 2.11.0'
+  s.add_dependency "savon", '~> 2.12.0'
+  s.add_dependency "httpclient"
   s.add_dependency "nokogiri"
   s.add_dependency "activesupport"
 end

data/bin/console

@@ -0,0 +1,7 @@
+#!/usr/bin/env ruby
+
+require 'bundler/setup'
+require 'afipws'
+
+require 'pry'
+Pry.start

data/lib/afipws/client.rb

@@ -1,15 +1,19 @@
 module Afipws
   class Client
     def initialize savon_options
-      @client = Savon.client savon_options.reverse_merge(soap_version: 2, ssl_version: :TLSv1)
+      @savon = Savon.client savon_options.reverse_merge(soap_version: 2, ssl_version: :TLSv1_2)
     end
 
     def request action, body = nil
-      @client.call action, message: body
+      @savon.call action, message: body
+    rescue Savon::SOAPFault => e
+      raise ServerError, e
+    rescue HTTPClient::TimeoutError => e
+      raise NetworkError, e
     end
 
     def operations
-      @client.operations
+      @savon.operations
     end
   end
 end

data/lib/afipws/core_ext/hash.rb

@@ -4,10 +4,6 @@ module Afipws
       def select_keys *keys
         select { |k, _| keys.include? k }
       end
-
-      def has_entries? entries
-        entries.each_pair.all? { |k, v| self[k] == v }
-      end
     end
   end
 end

data/lib/afipws/errors/error.rb

@@ -0,0 +1,7 @@
+module Afipws
+  class Error < StandardError
+    def code? _code
+      false
+    end
+  end
+end

data/lib/afipws/errors/network_error.rb

@@ -0,0 +1,4 @@
+module Afipws
+  class NetworkError < Error
+  end
+end

data/lib/afipws/errors/response_error.rb

@@ -0,0 +1,16 @@
+module Afipws
+  class ResponseError < Error
+    attr_reader :errors
+
+    def initialize errors
+      raise ArgumentError, '`errors` must be an array of maps, each with :code and :msg keys' unless errors.is_a? Array
+
+      super errors.map { |e| "#{e[:code]}: #{e[:msg]}" }.join '; '
+      @errors = errors
+    end
+
+    def code? code
+      @errors.any? { |e| e[:code].to_s == code.to_s }
+    end
+  end
+end

data/lib/afipws/errors/server_error.rb

@@ -0,0 +1,4 @@
+module Afipws
+  class ServerError < Error
+  end
+end

data/lib/afipws/persona_service_a100.rb

@@ -44,8 +44,6 @@ module Afipws
 
     def request action, body = nil
       @client.request(action, body).to_hash[:"#{action}_response"]
-    rescue Savon::SOAPFault => f
-      raise WSError, f.message
     end
   end
 end

data/lib/afipws/persona_service_a4.rb

@@ -27,8 +27,6 @@ module Afipws
 
     def request action, body = nil
       @client.request(action, body).to_hash[:"#{action}_response"]
-    rescue Savon::SOAPFault => f
-      raise WSError, f.message
     end
   end
 end

data/lib/afipws/persona_service_a5.rb

@@ -21,15 +21,13 @@ module Afipws
 
     def get_persona id
       message = @wsaa.auth.merge(cuitRepresentada: @cuit, idPersona: id)
-      request(:get_persona, message)[:persona_return][:datos_generales]
+      request(:get_persona, message)[:persona_return]
     end
 
     private
 
     def request action, body = nil
       @client.request(action, body).to_hash[:"#{action}_response"]
-    rescue Savon::SOAPFault => f
-      raise WSError, f.message
     end
   end
 end

data/lib/afipws/version.rb

@@ -1,3 +1,3 @@
 module Afipws
-  VERSION = '1.3.0'
+  VERSION = '2.1.0'
 end

data/lib/afipws/w_cons_declaracion.rb

@@ -40,12 +40,10 @@ module Afipws
     def request action, body = nil
       response = @client.request(action, body).to_hash[:"#{action}_response"][:"#{action}_result"]
       if response[:lista_errores] && response[:lista_errores][:detalle_error][:codigo] != '0'
-        raise WSError, Array.wrap(response[:lista_errores][:detalle_error]).map { |e| {code: e[:codigo], msg: e[:descripcion]} }
+        raise ResponseError, Array.wrap(response[:lista_errores][:detalle_error]).map { |e| {code: e[:codigo], msg: e[:descripcion]} }
       else
         response
       end
-    rescue Savon::SOAPFault => f
-      raise WSError, f.message
     end
 
     def auth

data/lib/afipws/ws_constancia_inscripcion.rb

@@ -27,8 +27,6 @@ module Afipws
 
     def request action, body = nil
       @client.request(action, body).to_hash[:"#{action}_response"]
-    rescue Savon::SOAPFault => f
-      raise WSError, f.message
     end
   end
 end

data/lib/afipws/wsaa.rb

@@ -55,8 +55,6 @@ module Afipws
         generation_time: from_xsd_datetime(ta.css('generationTime').text),
         expiration_time: from_xsd_datetime(ta.css('expirationTime').text)
       }
-    rescue Savon::SOAPFault => f
-      raise WSError, f.message
     end
 
     def auth

data/lib/afipws/wsfe.rb

@@ -92,8 +92,8 @@ module Afipws
 
     def solicitar_caea
       convertir_rta_caea request(:fecaea_solicitar, auth.merge(periodo_para_solicitud_caea))
-    rescue Afipws::WSError => e
-      if e.errors.any? { |e| e[:code] == '15008' }
+    rescue Afipws::ResponseError => e
+      if e.code? 15008
         consultar_caea fecha_inicio_quincena_siguiente
       else
         raise
@@ -163,7 +163,7 @@ module Afipws
     def request action, body = nil
       response = @client.request(action, body).to_hash[:"#{action}_response"][:"#{action}_result"]
       if response[:errors]
-        raise WSError, Array.wrap(response[:errors][:err])
+        raise ResponseError, Array.wrap(response[:errors][:err])
       else
         response
       end

data/lib/afipws.rb

@@ -5,12 +5,16 @@ end
 require 'forwardable'
 require 'builder'
 require 'base64'
+require 'httpclient'
 require 'savon'
 require 'nokogiri'
 require 'active_support'
 require 'active_support/core_ext'
 require 'afipws/core_ext/hash'
-require 'afipws/wserror'
+require 'afipws/errors/error'
+require 'afipws/errors/response_error'
+require 'afipws/errors/server_error'
+require 'afipws/errors/network_error'
 require 'afipws/type_conversions'
 require 'afipws/client'
 require 'afipws/wsaa'

data/shell.nix

@@ -0,0 +1,6 @@
+with import <nixpkgs> {};
+mkShell {
+  nativeBuildInputs = [
+    ruby
+  ];
+}

data/spec/afipws/client_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+module Afipws
+  describe Client do
+    context 'manejo de errores' do
+      subject { Client.new(wsdl: Afipws::WSFE::WSDL[:test]) }
+
+      it 'Savon::SOAPFault se encapsulan en ServerError' do
+        savon.expects(:fe_dummy).returns(fixture('wsaa/login_cms/fault'))
+        -> { subject.request :fe_dummy }.should raise_error ServerError, /CMS no es valido/
+      end
+
+      it 'HTTPClient::TimeoutError se encapsulan en NetworkError' do
+        # Hack to mock exceptions on Savon
+        subject.instance_eval('@savon').expects(:call).raises(HTTPClient::ReceiveTimeoutError, 'execution expired')
+        -> { subject.request :fe_dummy }.should raise_error NetworkError, /execution expired/
+      end
+    end
+  end
+end

data/spec/afipws/core_ext/hash_spec.rb

@@ -10,14 +10,4 @@ describe Hash do
       hash.select_keys(5, 3).should == {3 => 4}
     end
   end
-
-  context 'has_entries?' do
-    subject { Hash[1, 2, 3, 4] }
-
-    it 'debería devolver true cuando self incluye todas las entries del hash parametro' do
-      should include 1 => 2
-      should include 3 => 4, 1 => 2
-      should_not include 1 => 3
-    end
-  end
 end

data/spec/afipws/persona_service_a5_spec.rb

@@ -16,7 +16,7 @@ module Afipws
         savon.expects(:get_persona)
           .with(message: message.merge(idPersona: '98765432198'))
           .returns(fixture('ws_sr_padron_a5/get_persona/success'))
-        ws.get_persona('98765432198').should include apellido: 'ALEXA'
+        ws.get_persona('98765432198').should have_key :datos_generales
       end
     end
   end

data/spec/afipws/w_cons_declaracion_spec.rb

@@ -55,7 +55,7 @@ module Afipws
           savon.expects(:detallada_lista_declaraciones).with(message: :any)
             .returns(fixture('wconsdeclaracion/detallada_lista_declaraciones/por_id_inexistente'))
           -> { ws.detallada_lista_declaraciones identificador_declaracion: '...' }
-            .should raise_error WSError, '21248: Declaracion 19093SIMI000434. inexistente o invalida'
+            .should raise_error ResponseError, '21248: Declaracion 19093SIMI000434. inexistente o invalida'
         end
       end
 

data/spec/afipws/ws_constancia_inscripcion_spec.rb

@@ -51,7 +51,7 @@ module Afipws
         savon.expects(:get_persona)
           .with(message: message.merge(id_persona: '123'))
           .returns(fixture('ws_sr_constancia_inscripcion/get_persona/fault'))
-        -> { ws.get_persona '123' }.should raise_error WSError, /No existe persona con ese Id/
+        -> { ws.get_persona '123' }.should raise_error ServerError, /No existe persona con ese Id/
       end
     end
 

data/spec/afipws/wsaa_spec.rb

@@ -39,12 +39,6 @@ module Afipws
         ta[:generation_time].should == Time.new(2011, 1, 12, 18, 57, 4, '-03:00')
         ta[:expiration_time].should == Time.new(2011, 1, 13, 6, 57, 4, '-03:00')
       end
-
-      it 'debería encapsular SOAP Faults' do
-        subject.stubs(:tra).returns('')
-        savon.expects(:login_cms).with(message: :any).returns(fixture('wsaa/login_cms/fault'))
-        -> { subject.login }.should raise_error WSError, /CMS no es valido/
-      end
     end
 
     context 'auth' do

data/spec/afipws/wsfe_spec.rb

@@ -70,7 +70,7 @@ module Afipws
         it 'cuando la moneda no existe' do
           savon.expects(:fe_param_get_cotizacion).with(message: auth.merge(mon_id: 'PES')).returns(fixture('wsfe/fe_param_get_cotizacion/inexistente'))
           -> { ws.cotizacion('PES') }.should raise_error { |error|
-            error.should be_a WSError
+            error.should be_a ResponseError
             error.message.should match /602: Sin Resultados/
             error.code?(602).should be true
             error.code?(603).should be false
@@ -195,9 +195,9 @@ module Afipws
           ws.solicitar_caea.should include caea: '21043476341977', fch_vig_desde: Date.new(2011, 0o2, 0o1)
         end
 
-        it 'cuando hay otro error debería burbujearlo' do
+        it 'cuando encapsular errores' do
           savon.expects(:fecaea_solicitar).with(message: :any).returns(fixture('wsfe/fecaea_solicitar/error_distinto'))
-          -> { ws.solicitar_caea }.should raise_error WSError, /15007/
+          -> { ws.solicitar_caea }.should raise_error ResponseError, /15007/
         end
       end
 
@@ -287,7 +287,7 @@ module Afipws
       it 'cuando hay un error' do
         savon.expects(:fe_param_get_tipos_cbte).with(message: :any).returns(fixture('wsfe/fe_param_get_tipos_cbte/failure_1_error'))
         -> { ws.tipos_comprobantes }.should raise_error { |e|
-          e.should be_a WSError
+          e.should be_a ResponseError
           e.errors.should == [{ code: '600', msg: 'No se corresponden token con firma' }]
           e.message.should == '600: No se corresponden token con firma'
         }
@@ -296,8 +296,11 @@ module Afipws
       it 'cuando hay varios errores' do
         savon.expects(:fe_param_get_tipos_cbte).with(message: :any).returns(fixture('wsfe/fe_param_get_tipos_cbte/failure_2_errors'))
         -> { ws.tipos_comprobantes }.should raise_error { |e|
-          e.should be_a WSError
-          e.errors.should == [{ code: '600', msg: 'No se corresponden token con firma' }, { code: '601', msg: 'CUIT representada no incluida en token' }]
+          e.should be_a ResponseError
+          e.errors.should == [
+            { code: '600', msg: 'No se corresponden token con firma' },
+            { code: '601', msg: 'CUIT representada no incluida en token' }
+          ]
           e.message.should == '600: No se corresponden token con firma; 601: CUIT representada no incluida en token'
         }
       end

data/spec/spec_helper.rb

@@ -2,7 +2,6 @@ require 'rspec'
 require 'afipws'
 require 'savon/mock/spec_helper'
 require 'mocha'
-require 'pry-byebug'
 
 Dir[File.dirname(__FILE__) + '/support/**/*.rb'].each { |f| require f }
 

data/spec/support/savon_extensions.rb

@@ -24,14 +24,14 @@ end
 
 class HasXPath
   include RSpec::Matchers
-  
+
   def initialize(paths)
     @paths = paths
   end
-  
+
   def verify! xml
     @actual_xml = xml
-    @paths.each do |(path, value)| 
+    @paths.each do |(path, value)|
       @expected_xpath, @expected_value = path, value
       @actual_xml.should match_xpath @expected_xpath, @expected_value
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: afipws
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 2.1.0
 platform: ruby
 authors:
 - Emmanuel Nicolau
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-02-13 00:00:00.000000000 Z
+date: 1980-01-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -56,16 +56,16 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.80.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.80.0
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -81,13 +81,13 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry-byebug
+  name: builder
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -95,33 +95,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: builder
+  name: savon
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.12.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.12.0
 - !ruby/object:Gem::Dependency
-  name: savon
+  name: httpclient
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.11.0
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.11.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -153,15 +153,18 @@ dependencies:
 description: ''
 email:
 - emmanicolau@gmail.com
-executables: []
+executables:
+- console
 extensions: []
 extra_rdoc_files: []
 files:
+- ".envrc"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
 - ".ruby-version"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - Gemfile.lock
 - Guardfile
@@ -169,9 +172,14 @@ files:
 - README.md
 - Rakefile
 - afipws.gemspec
+- bin/console
 - lib/afipws.rb
 - lib/afipws/client.rb
 - lib/afipws/core_ext/hash.rb
+- lib/afipws/errors/error.rb
+- lib/afipws/errors/network_error.rb
+- lib/afipws/errors/response_error.rb
+- lib/afipws/errors/server_error.rb
 - lib/afipws/persona_service_a100.rb
 - lib/afipws/persona_service_a4.rb
 - lib/afipws/persona_service_a5.rb
@@ -180,8 +188,9 @@ files:
 - lib/afipws/w_cons_declaracion.rb
 - lib/afipws/ws_constancia_inscripcion.rb
 - lib/afipws/wsaa.rb
-- lib/afipws/wserror.rb
 - lib/afipws/wsfe.rb
+- shell.nix
+- spec/afipws/client_spec.rb
 - spec/afipws/core_ext/hash_spec.rb
 - spec/afipws/persona_service_a100_spec.rb
 - spec/afipws/persona_service_a4_spec.rb
@@ -255,7 +264,7 @@ files:
 homepage: https://github.com/eeng/afipws
 licenses: []
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -270,12 +279,12 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: afipws
-rubygems_version: 2.5.1
-signing_key: 
+rubygems_version: 3.2.26
+signing_key:
 specification_version: 4
 summary: Ruby client para los web services de la AFIP
 test_files:
+- spec/afipws/client_spec.rb
 - spec/afipws/core_ext/hash_spec.rb
 - spec/afipws/persona_service_a100_spec.rb
 - spec/afipws/persona_service_a4_spec.rb

data/lib/afipws/wserror.rb

@@ -1,19 +0,0 @@
-module Afipws
-  class WSError < StandardError
-    attr_reader :errors
-
-    def initialize errors
-      if errors.is_a? Array
-        super errors.map { |e| "#{e[:code]}: #{e[:msg]}" }.join '; '
-        @errors = errors
-      else
-        super
-        @errors = []
-      end
-    end
-
-    def code? code
-      @errors.any? { |e| e[:code].to_s == code.to_s }
-    end
-  end
-end