afipws 1.0.3 → 1.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3bb1054b4ad45099d4b950edb154f0961e2a8100
-  data.tar.gz: 3768c0065771f1b021e136a30ce4d56fbdcf0204
+  metadata.gz: 9efcd1dff92381947ee6cb51d967b29be89807e7
+  data.tar.gz: a2d8e8b7887810180b2a1519acf28ccf9b03fc43
 SHA512:
-  metadata.gz: beea7ebef5946e80acfd6ae40277000e9433964b38f669a0a0d6a4cb789b52e6e0856f35b5d804de7754b150501d8e68fa5d557ac1f2b4d0eb7cb7d30bdc75c8
-  data.tar.gz: bdcc106d8fdbeb4fee5000795ecba43d5483ede917a578874d52b2c66df60c930254c3da54ae9bcc54d5d8eca47956ed3aa5b507f8443f65e12e8f4e572f0d40
+  metadata.gz: a27824e48e8e96b4f9924d6a106500da58e1d334a464e9dbd09c324c99c590b42f9d60a4fc596537cf6d75b2642ea9777a17f328a212d2f8e5aecb9162ae5301
+  data.tar.gz: b338ff05f6648220a3afbe577aad62b4fae07207d1ab941785774b730e3e3a58d59fab4e17f11f005877e6b452ae1a8545d5ac19e5a36af0597fdd10b995a94e

data/.rubocop.yml

@@ -0,0 +1,102 @@
+Style/Documentation:
+  Enabled: false
+
+Style/MethodDefParentheses:
+  Enabled: false
+
+Style/ParallelAssignment:
+  Enabled: false
+
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+Style/FormatStringToken:
+  Enabled: false
+
+Style/EmptyMethod:
+  Enabled: false
+
+Style/GuardClause:
+  Enabled: false
+
+Style/CommentAnnotation:
+  Enabled: false
+
+Style/AsciiComments:
+  Enabled: false
+
+Style/StabbyLambdaParentheses:
+  EnforcedStyle: require_no_parentheses
+
+Style/MultilineIfModifier:
+  Enabled: false
+
+Style/SafeNavigation:
+  Enabled: false
+
+Style/FormatString:
+  Enabled: false
+
+Style/AndOr:
+  Enabled: false
+
+Style/Next:
+  Enabled: false
+
+Style/NumericPredicate:
+  Enabled: false
+
+Style/SymbolArray:
+  Enabled: false
+
+Style/MutableConstant:
+  Enabled: false
+
+Style/RescueModifier:
+  Enabled: false
+
+Layout/SpaceInsideHashLiteralBraces:
+  Enabled: false
+
+Layout/MultilineMethodCallIndentation:
+  Enabled: false
+
+Layout/TrailingBlankLines:
+  Enabled: false
+
+Layout/IndentArray:
+  EnforcedStyle: consistent
+
+Layout/AlignParameters:
+  EnforcedStyle: with_fixed_indentation
+
+Layout/SpaceInLambdaLiteral:
+  Enabled: false
+
+Metrics:
+  Enabled: false
+
+Bundler:
+  Enabled: false
+
+Lint/Void:
+  Exclude:
+    - spec/**/*.rb
+
+Lint/AssignmentInCondition:
+  Enabled: false
+
+Lint/ShadowingOuterLocalVariable:
+  Enabled: false
+
+Lint/AmbiguousRegexpLiteral:
+  Enabled: false
+
+Lint/AmbiguousOperator:
+  Enabled: false
+
+Lint/AmbiguousBlockAssociation:
+  Enabled: false
+
+Naming/UncommunicativeMethodParamName:
+  Enabled: false

data/.travis.yml

@@ -1 +1,2 @@
 language: ruby
+cache: bundler

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    afipws (1.0.3)
+    afipws (1.0.4)
       activesupport
       builder
       nokogiri
@@ -18,6 +18,7 @@ GEM
     akami (1.3.1)
       gyoku (>= 0.4.0)
       nokogiri
+    ast (2.4.0)
     builder (3.2.3)
     coderay (1.1.2)
     concurrent-ruby (1.0.5)
@@ -45,6 +46,7 @@ GEM
       socksify
     i18n (1.0.1)
       concurrent-ruby (~> 1.0)
+    jaro_winkler (1.5.1)
     listen (3.1.5)
       rb-fsevent (~> 0.9, >= 0.9.4)
       rb-inotify (~> 0.9, >= 0.9.7)
@@ -62,11 +64,16 @@ GEM
     notiffany (0.1.1)
       nenv (~> 0.1)
       shellany (~> 0.0)
+    parallel (1.12.1)
+    parser (2.5.3.0)
+      ast (~> 2.4.0)
+    powerpack (0.1.2)
     pry (0.11.3)
       coderay (~> 1.1.0)
       method_source (~> 0.9.0)
-    rack (2.0.5)
-    rake (10.4.2)
+    rack (2.0.6)
+    rainbow (3.0.0)
+    rake (12.3.2)
     rb-fsevent (0.10.3)
     rb-inotify (0.9.10)
       ffi (>= 0.5.0, < 2)
@@ -83,6 +90,15 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.7.0)
     rspec-support (3.7.1)
+    rubocop (0.61.1)
+      jaro_winkler (~> 1.5.1)
+      parallel (~> 1.10)
+      parser (>= 2.5, != 2.5.1.1)
+      powerpack (~> 0.1)
+      rainbow (>= 2.2.2, < 4.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.4.0)
+    ruby-progressbar (1.10.0)
     ruby_dep (1.5.0)
     savon (2.11.2)
       akami (~> 1.2)
@@ -98,6 +114,7 @@ GEM
     thread_safe (0.3.6)
     tzinfo (1.2.5)
       thread_safe (~> 0.1)
+    unicode-display_width (1.4.0)
     wasabi (3.5.0)
       httpi (~> 2.0)
       nokogiri (>= 1.4.2)
@@ -111,6 +128,7 @@ DEPENDENCIES
   mocha
   rake
   rspec
+  rubocop
 
 BUNDLED WITH
-   1.16.1
+   1.16.2

data/LICENSE.txt

@@ -0,0 +1,22 @@
+Copyright (c) 2011 Emmanuel Nicolau
+
+MIT License
+
+Permission is hereby granted, free of charge, to any person obtaining
+a copy of this software and associated documentation files (the
+"Software"), to deal in the Software without restriction, including
+without limitation the rights to use, copy, modify, merge, publish,
+distribute, sublicense, and/or sell copies of the Software, and to
+permit persons to whom the Software is furnished to do so, subject to
+the following conditions:
+
+The above copyright notice and this permission notice shall be
+included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/README.md

@@ -4,13 +4,19 @@ Ruby client para los web services de la AFIP.
 
 [![Build Status](https://travis-ci.org/eeng/afipws.svg?branch=master)](https://travis-ci.org/eeng/afipws)
 
+## Servicios Disponibles
+
+* WSAA
+* WSFE
+* WSConstanciaInscripcion (ws_sr_constancia_inscripcion)
+
 ## Uso
 
 Primero hay que crear la clave privada y obtener el certificado correspondiente según los pasos indicados [aquí](http://www.afip.gov.ar/ws/WSAA/cert-req-howto.txt).
 
 Luego hay que instalar la librería:
 
-```ruby
+```
 gem install afipws
 ```
 
@@ -22,13 +28,13 @@ ws = Afipws::WSFE.new env: :development, cuit: '...', key: File.read('test.key')
 puts ws.cotizacion 'DOL'
 ```
 
-De momento sólo están soportados los servicios WSAA y WSFEv1.
 Ver specs para más ejemplos.
 
 ## Contributing
 
 1. Fork it
 2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Commit your changes (`git commit -am 'Add some feature'`)
-4. Push to the branch (`git push origin my-new-feature`)
-5. Create new Pull Request
+3. Test, test, test (`guard`)
+4. Commit your changes (`git commit -am 'Add some feature'`)
+5. Push to the branch (`git push origin my-new-feature`)
+6. Create new Pull Request

data/afipws.gemspec

@@ -22,6 +22,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rake'
   s.add_development_dependency 'mocha'
   s.add_development_dependency 'guard-rspec'
+  s.add_development_dependency 'rubocop'
   s.add_dependency "builder"
   s.add_dependency "savon", '~> 2.11.0'
   s.add_dependency "nokogiri"

data/lib/afipws.rb

@@ -13,5 +13,7 @@ require 'afipws/core_ext/hash'
 require 'afipws/excepciones'
 require 'afipws/type_conversions'
 require 'afipws/client'
+require 'afipws/ws_base'
 require 'afipws/wsaa'
 require 'afipws/wsfe'
+require 'afipws/ws_constancia_inscripcion'

data/lib/afipws/client.rb

@@ -1,28 +1,15 @@
 module Afipws
   class Client
     def initialize savon_options
-      @client = Savon.client savon_options.reverse_merge(soap_version: 2)
+      @client = Savon.client savon_options.reverse_merge(soap_version: 2, ssl_version: :TLSv1)
     end
-    
+
     def request action, body = nil
-      response = raw_request(action, body).to_hash[:"#{action}_response"][:"#{action}_result"]
-      if response[:errors]
-        raise WSError, Array.wrap(response[:errors][:err])
-      else
-        response
-      end
-    end
-    
-    def raw_request action, body = nil
       @client.call action, message: body
     end
-    
+
     def operations
       @client.operations
     end
-    
-    def method_missing method_sym, *args
-      request method_sym, *args
-    end
   end
-end
+end

data/lib/afipws/core_ext/hash.rb

@@ -4,7 +4,7 @@ module Afipws
       def select_keys *keys
         select { |k, _| keys.include? k }
       end
-  
+
       def has_entries? entries
         entries.each_pair.all? { |k, v| self[k] == v }
       end
@@ -14,4 +14,4 @@ end
 
 class Hash
   include Afipws::CoreExt::Hash
-end
+end

data/lib/afipws/excepciones.rb

@@ -9,5 +9,5 @@ module Afipws
         super
       end
     end
-  end  
+  end
 end

data/lib/afipws/type_conversions.rb

@@ -7,33 +7,36 @@ module Afipws
     def x2r x, types
       convert x, types, parsing_fn
     end
-    
+
     private
+
     # Hace una conversión recursiva de tipo de todos los values según los tipos de las keys indicados en types
     def convert object, types, convert_fn
       case object
-      when Array then 
+      when Array then
         object.map { |e| convert e, types, convert_fn }
-      when Hash then 
-        Hash[object.map { |k, v| [k, v.is_a?(Hash) || v.is_a?(Array) ? convert(v, types, convert_fn) : convert_fn[types[k]].call(v)] }]
-      else 
+      when Hash then
+        Hash[object.map do |k, v|
+          [k, v.is_a?(Hash) || v.is_a?(Array) ? convert(v, types, convert_fn) : convert_fn[types[k]].call(v)]
+        end]
+      else
         object
       end
     end
-    
+
     def parsing_fn
-      @parsing ||= Hash.new(Proc.new { |v| v }).tap { |p|
-        p[:date] = Proc.new { |v| ::Date.parse(v) rescue nil }
-        p[:integer] = Proc.new { |v| v.to_i }
-        p[:float] = Proc.new { |v| v.to_f }
-        p[:boolean] = Proc.new { |v| v == "S" }
+      @parsing_fn ||= Hash.new(proc { |v| v }).tap { |p|
+        p[:date] = proc { |v| ::Date.parse(v) rescue nil }
+        p[:integer] = proc { |v| v.to_i }
+        p[:float] = proc { |v| v.to_f }
+        p[:boolean] = proc { |v| v == 'S' }
       }
     end
 
     def marshall_fn
-      @marshall ||= Hash.new(Proc.new { |other| other }).tap { |p|
-        p[:date] = Proc.new { |date| date.strftime('%Y%m%d') }
-      }
-    end    
+      @marshall_fn ||= Hash.new(proc { |other| other }).tap do |p|
+        p[:date] = proc { |date| date.strftime('%Y%m%d') }
+      end
+    end
   end
-end
+end

data/lib/afipws/version.rb

@@ -1,3 +1,3 @@
 module Afipws
-  VERSION = "1.0.3"
+  VERSION = '1.0.4'
 end

data/lib/afipws/ws_base.rb

@@ -0,0 +1,12 @@
+module Afipws
+  class WSBase
+    extend Forwardable
+
+    attr_reader :wsaa, :client, :env
+    def_delegators :wsaa, :cuit
+
+    def initialize options = {}
+      @env = (options[:env] || :test).to_sym
+    end
+  end
+end

data/lib/afipws/ws_constancia_inscripcion.rb

@@ -0,0 +1,33 @@
+module Afipws
+  class WSConstanciaInscripcion < WSBase
+    WSDL = {
+      development: 'https://awshomo.afip.gov.ar/sr-padron/webservices/personaServiceA5?WSDL',
+      production: 'https://aws.afip.gov.ar/sr-padron/webservices/personaServiceA5?WSDL',
+      test: Root + '/spec/fixtures/ws_constancia_inscripcion.wsdl'
+    }.freeze
+
+    def initialize options = {}
+      super
+      @wsaa = WSAA.new options.merge(service: 'ws_sr_constancia_inscripcion')
+      @client = Client.new Hash(options[:savon]).reverse_merge(wsdl: WSDL[env], soap_version: 1)
+    end
+
+    def dummy
+      request(:dummy)[:return]
+    end
+
+    def get_persona id
+      request(:get_persona, auth.merge(id_persona: id))[:persona_return]
+    end
+
+    def auth
+      wsaa.auth.merge(cuit_representada: cuit)
+    end
+
+    private
+
+    def request action, body = nil
+      @client.request(action, body).to_hash[:"#{action}_response"]
+    end
+  end
+end

data/lib/afipws/wsaa.rb

@@ -3,9 +3,9 @@ module Afipws
     attr_reader :key, :cert, :service, :ta, :cuit, :client
 
     WSDL = {
-      development: "https://wsaahomo.afip.gov.ar/ws/services/LoginCms?wsdl",
-      production: "https://wsaa.afip.gov.ar/ws/services/LoginCms?wsdl",
-      test: Root + "/spec/fixtures/wsaa.wsdl"
+      development: 'https://wsaahomo.afip.gov.ar/ws/services/LoginCms?wsdl',
+      production: 'https://wsaa.afip.gov.ar/ws/services/LoginCms?wsdl',
+      test: Root + '/spec/fixtures/wsaa.wsdl'
     }
 
     def initialize options = {}
@@ -35,7 +35,7 @@ module Afipws
     def firmar_tra tra, key, crt
       key = OpenSSL::PKey::RSA.new key
       crt = OpenSSL::X509::Certificate.new crt
-      OpenSSL::PKCS7::sign crt, key, tra
+      OpenSSL::PKCS7.sign crt, key, tra
     end
 
     def codificar_tra pkcs7
@@ -47,7 +47,7 @@ module Afipws
     end
 
     def login
-      response = @client.raw_request :login_cms, in0: tra(@key, @cert, @service, @ttl)
+      response = @client.request :login_cms, in0: tra(@key, @cert, @service, @ttl)
       ta = Nokogiri::XML(Nokogiri::XML(response.to_xml).text)
       {
         token: ta.css('token').text,
@@ -59,10 +59,9 @@ module Afipws
       raise WSError, f.message
     end
 
-    # Obtiene un TA, lo cachea hasta que expire, y devuelve el hash Auth listo para pasarle al Client en los otros WS
     def auth
       ta = obtener_y_cachear_ta
-      {auth: {token: ta[:token], sign: ta[:sign], cuit: @cuit}}
+      {token: ta[:token], sign: ta[:sign]}
     end
 
     private
@@ -90,15 +89,12 @@ module Afipws
     end
 
     def restore_ta
-      Marshal.load(File.read(@ta_path)) if File.exists?(@ta_path)
+      Marshal.load(File.read(@ta_path)) if File.exist?(@ta_path)
     end
 
     def persist_ta ta
-      dirname = File.dirname(@ta_path)
-      unless File.directory?(dirname)
-        FileUtils.mkdir_p(dirname)
-      end
-      File.open(@ta_path, "wb") { |f| f.write(Marshal.dump(ta)) }
+      FileUtils.mkdir_p(File.dirname(@ta_path))
+      File.open(@ta_path, 'wb') { |f| f.write(Marshal.dump(ta)) }
     end
   end
 end