ae_page_objects 5.0.0 → 6.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9ac141566f7fa0ef821de7597f5ca1c52d8e20a2a73a772c186631ea9340b3ba
-  data.tar.gz: e43b377ece706710f77792e4e7a4540160bd94ee4d81f0f5e6e8b360df452a49
+  metadata.gz: 821e62b026f7ce8c826470730f1e4f582ca4f2e5a253730204288b282c4dec7b
+  data.tar.gz: fd777245e7db9fb50691bfbd0a4ccf2ae153bf055178615afbe77cf5896c66cd
 SHA512:
-  metadata.gz: 67411eea6351ede5cf53ba6944b5ab15ee1066208df1afb7d493dbe6a99de623881d8742fbb764ef04a92103f6432af9dbc597ffb6e0d0fad02b0ad3842ae4d2
-  data.tar.gz: 83146923f3c423858fbaddafd47f0532bfd5c6b7658e256766d6bbb697c1228eb3f57c4776526694278b0b75dc7946dda8bf4f809d280b447081d36a9793c920
+  metadata.gz: 3243021458e14158adb012befea9abc50ba39f4ef470f274535e685168a79049f99e35341105a1a1dd721bda3e1bdb02b31e035720811760f2186e1144a9fb68
+  data.tar.gz: 58dfab715e70b7f65059931b207b7faee6aa4f653ccd78d4a5dc10def861df46c29c5b284cea566c6372111a0cb60b3f6be6c2c9f14e265252a5ad58561cc696

data/ae_page_objects.gemspec

@@ -0,0 +1,23 @@
+
+# frozen_string_literal: true
+
+require_relative 'lib/ae_page_objects/version'
+
+Gem::Specification.new do |spec|
+  spec.name                  = 'ae_page_objects'
+  spec.version               = AePageObjects::VERSION
+  spec.platform              = Gem::Platform::RUBY
+  spec.author                = 'AppFolio'
+  spec.email                 = 'opensource@appfolio.com'
+  spec.description           = 'Capybara Page Objects pattern.'
+  spec.summary               = spec.description
+  spec.homepage              = 'https://github.com/appfolio/ae_page_objects'
+  spec.license               = 'MIT'
+  spec.files                 = Dir['**/*'].select { |f| f[%r{^(lib/|LICENSE.txt|.*gemspec)}] }
+  spec.require_paths         = ['lib']
+  spec.required_ruby_version = Gem::Requirement.new('>= 2.7.5')
+
+  spec.metadata['allowed_push_host'] = 'https://rubygems.org'
+
+  spec.add_dependency('capybara', ['>= 3', '< 4'])
+end

data/lib/ae_page_objects/element.rb

@@ -122,10 +122,13 @@ module AePageObjects
         locator.push(default_options)
       end
 
+      locator_copy = locator.dup
+      options = locator_copy.pop
+
       if @wait
-        node = AePageObjects.wait_until { parent.node.first(*locator) }
+        node = AePageObjects.wait_until { parent.node.first(*locator_copy, **options) }
       else
-        node = parent.node.first(*locator)
+        node = parent.node.first(*locator_copy, **options)
         raise LoadingElementFailed, 'Element Not Found' unless node
       end
       node.allow_reload!

data/lib/ae_page_objects/elements/collection.rb

@@ -52,7 +52,7 @@ module AePageObjects
       # wait time set to 0.
       #
       Capybara.using_wait_time(0) do
-        node.all(:xpath, item_xpath, options).size
+        node.all(:xpath, item_xpath, **options).size
       end
     end
 
@@ -90,7 +90,6 @@ module AePageObjects
         }
 
         if query_args[1].is_a?(XPath::Expression)
-          #
           # Use the { exact: true } setting for XPath selectors that use "XPath.is".  For example, given the XPath
           #   XPath.descendant(:div)[XPath.text.is('Example Text')]
           # the resulting path will be
@@ -98,17 +97,14 @@ module AePageObjects
           # instead of
           #   .//div[contains(./text(), 'Example Text')]
           # See https://github.com/jnicklas/capybara#exactness for more information.
-          #
           default_options[:exact] = true
         end
 
         if query_args.last.is_a?(::Hash)
-          query_args[-1] = default_options.merge(query_args.last)
-        else
-          query_args.push(default_options)
+          default_options.merge!(query_args.pop)
         end
 
-        query = Capybara::Queries::SelectorQuery.new(*query_args)
+        query = Capybara::Queries::SelectorQuery.new(*query_args, **default_options)
 
         result = query.xpath
 

data/lib/ae_page_objects/node.rb

@@ -27,7 +27,10 @@ module AePageObjects
           locator.push(default_options)
         end
 
-        node.all(*locator).any?
+        locator_copy = locator.dup
+        options = locator_copy.pop
+
+        node.all(*locator_copy, **options).any?
       end
     end
 

data/lib/ae_page_objects/rails/application_router.rb

@@ -4,9 +4,7 @@ module AePageObjects
   class ApplicationRouter < BasicRouter
 
     # This whole file is a kludge and probably belongs in an ae_page_objects-rails extension
-
     module Recognizer
-
       class Base
         def generate_path(named_route, *args)
           if routes.respond_to?("#{named_route}_path")
@@ -32,7 +30,7 @@ module AePageObjects
           false
         end
 
-      private
+        private
 
         def routes
           raise NotImplementedError, "You must implement routes"
@@ -60,9 +58,8 @@ module AePageObjects
         ResolvedRoute = Struct.new(:controller, :action)
       end
 
-      class Rails3 < Base
-
-      private
+      class Rails6Plus < Base
+        private
 
         def request_for(url, method)
           ::Rails.application.routes.request_class.new(env_for(url, method))
@@ -77,7 +74,8 @@ module AePageObjects
         end
 
         def normalize_url(url)
-          Rack::Mount::Utils.normalize_path(url) unless url =~ %r{://}
+          require 'action_dispatch/journey'
+          ActionDispatch::Journey::Router::Utils.normalize_path(url) unless url =~ %r{://}
         end
 
         def router
@@ -93,25 +91,6 @@ module AePageObjects
           end
         end
       end
-
-      class Rails32 < Rails3
-
-      private
-
-        def normalize_url(url)
-          Journey::Router::Utils.normalize_path(url) unless url =~ %r{://}
-        end
-      end
-
-      class Rails4Plus < Rails32
-
-      private
-
-        def normalize_url(url)
-          require 'action_dispatch/journey'
-          ActionDispatch::Journey::Router::Utils.normalize_path(url) unless url =~ %r{://}
-        end
-      end
     end
 
     def path_recognizes_url?(path, url)
@@ -134,15 +113,11 @@ module AePageObjects
 
     def recognizer
       @recognizer ||= case ::Rails.gem_version
-        when Gem::Requirement.new('>= 3.0', '< 3.2')
-          Recognizer::Rails3.new
-        when Gem::Requirement.new('~> 3.2')
-          Recognizer::Rails32.new
-        when Gem::Requirement.new('>= 4.0', '< 7.0')
-          Recognizer::Rails4Plus.new
+        when Gem::Requirement.new('>= 6.0', '< 8.0')
+          Recognizer::Rails6Plus.new
         else
           warn "[WARNING]: AePageObjects is not tested against Rails #{::Rails.version} and may behave in an undefined manner."
-          Recognizer::Rails4Plus.new
+          Recognizer::Rails6Plus.new
       end
     end
   end

data/lib/ae_page_objects/version.rb

@@ -1,3 +1,3 @@
 module AePageObjects
-  VERSION = '5.0.0'.freeze
+  VERSION = '6.0.0'.freeze
 end

data/test/test_apps/shared/engines/forum/forum.gemspec

@@ -0,0 +1,17 @@
+$:.push File.expand_path("../lib", __FILE__)
+
+# Maintain your gem's version:
+require "forum/version"
+
+# Describe your gem and declare its dependencies:
+Gem::Specification.new do |s|
+  s.name        = "forum"
+  s.version     = Forum::VERSION
+  s.authors     = "Appfolio"
+  s.summary     = "forum engine"
+  s.files = Dir["{app,config,db,lib}/**/*"] + ["MIT-LICENSE", "Rakefile", "README.rdoc"]
+  s.test_files = Dir["test/**/*"]
+
+  s.add_dependency "rails", "> 3"
+  s.add_development_dependency "sqlite3"
+end

metadata

@@ -1,36 +1,42 @@
 --- !ruby/object:Gem::Specification
 name: ae_page_objects
 version: !ruby/object:Gem::Version
-  version: 5.0.0
+  version: 6.0.0
 platform: ruby
 authors:
-- AppFolio Engineering
+- AppFolio
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-09-20 00:00:00.000000000 Z
+date: 2023-07-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '3'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '3'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '3.0'
-description: Capybara Page Objects pattern
-email:
-- engineering@appfolio.com
+        version: '4'
+description: Capybara Page Objects pattern.
+email: opensource@appfolio.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ae_page_objects.gemspec
 - lib/ae_page_objects.rb
 - lib/ae_page_objects/core/basic_router.rb
 - lib/ae_page_objects/core/dsl.rb
@@ -60,10 +66,12 @@ files:
 - lib/ae_page_objects/util/internal_helpers.rb
 - lib/ae_page_objects/util/wait_time_manager.rb
 - lib/ae_page_objects/version.rb
-homepage: http://github.com/appfolio/ae_page_objects
+- test/test_apps/shared/engines/forum/forum.gemspec
+homepage: https://github.com/appfolio/ae_page_objects
 licenses:
 - MIT
-metadata: {}
+metadata:
+  allowed_push_host: https://rubygems.org
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -72,15 +80,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.2.5
+      version: 2.7.5
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.3.26
 signing_key:
 specification_version: 4
-summary: Capybara Page Objects pattern
+summary: Capybara Page Objects pattern.
 test_files: []