ae_page_objects 4.1.0 → 4.3.1.tim3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: dd0afd4ed4d86badecf47afd9e5fce2fe456482e
-  data.tar.gz: f3d63d6237c9bc2c803375fcb6495e12ac5822dd
+SHA256:
+  metadata.gz: b0025f2cd90d1613fc5699f80dfe27de1e9117d3d1045d200199cadf7073b7c9
+  data.tar.gz: 6dae02265d6ab3c436fe415c09f040276d290d0c5c63e94b0b30c3dc841d4196
 SHA512:
-  metadata.gz: 0dff0c3a6baaa42c9262d26c0bd283506c70fa8663cb027ae046c03730e0e6268cca305c62ca4d9e779f721541318a719760d34159712e7d59e76763a4e8cbe2
-  data.tar.gz: b2ac6e9d0ed2bb3b8b3257653326810579b00b06806ae21d613f82153f9e2842e29f928f77865dead6d0aa9b9a48d4927fa84ac3e6d7bd1bc57c4daa00c64b01
+  metadata.gz: f9f846b4daa76ef8d3f59c96bedd65c79bc474c474744c31d5903ad355b89a5e19463793b04174633a10f580dfecf2839ec69276f18e695ea43eda83887697fa
+  data.tar.gz: ed76dbaa70c21b1a1cc62f4b0e7976064c664b4181aeb39ec0614c95dc9e097c79a4195d8f2ea015c177eddf1cee63ba8885a4203bc2a3a9a55dfead7d683f90

data/lib/ae_page_objects/element_proxy.rb

@@ -16,31 +16,21 @@ module AePageObjects
     end
 
     def visible?(options = {})
-      wait_until_visible(options[:wait])
-      true
-    rescue ElementNotVisible
-      false
+      reload_element
+      @loaded_element&.visible?
     end
 
     def hidden?(options = {})
-      wait_until_hidden(options[:wait])
-      true
-    rescue ElementNotHidden
-      false
+      !visible?
     end
 
     def present?(options = {})
-      wait_until_present(options[:wait])
-      true
-    rescue ElementNotPresent
-      false
+      reload_element
+      !@loaded_element.nil?
     end
 
     def absent?(options = {})
-      wait_until_absent(options[:wait])
-      true
-    rescue ElementNotAbsent
-      false
+      !present?
     end
 
     def presence
@@ -123,8 +113,19 @@ module AePageObjects
 
     private
 
-    def load_element
-      @element_class.new(*@args)
+    def load_element(wait: true)
+      args = @args.dup
+
+      options_or_locator = args.pop
+      options = if options_or_locator.is_a?(Hash)
+                  options_or_locator.dup.merge(wait: wait)
+                else
+                  { locator: options_or_locator, wait: wait }
+                end
+
+      args << options
+
+      @element_class.new(*args)
     end
 
     def implicit_element
@@ -132,7 +133,7 @@ module AePageObjects
     end
 
     def reload_element
-      @loaded_element = load_element
+      @loaded_element = load_element(wait: false)
     rescue LoadingElementFailed
       @loaded_element = nil
     end

data/lib/ae_page_objects/elements/collection.rb

@@ -41,7 +41,19 @@ module AePageObjects
     end
 
     def size
-      node.all(:xpath, item_xpath, options.merge(wait: false)).size
+      #
+      # In some cases when #size is called while the DOM is updating, Capybara
+      # will catch (and swallow) underlying exceptions such as
+      # `Selenium::WebDriver::Error::StaleElementReferenceError`.
+      # When this happens it will wait up to the max wait time, which can cause
+      # issues for `AePageObjects.wait_until` blocks.
+      #
+      # To prevent this issue the #all and #size calls are made with the Capybara
+      # wait time set to 0.
+      #
+      Capybara.using_wait_time(0) do
+        node.all(:xpath, item_xpath, options).size
+      end
     end
 
     def last

data/lib/ae_page_objects/rails/application_router.rb

@@ -133,12 +133,12 @@ module AePageObjects
     private
 
     def recognizer
-      @recognizer ||= case ::Rails.version
-        when /\A3\.[01]/
+      @recognizer ||= case ::Rails.gem_version
+        when Gem::Requirement.new('>= 3.0', '< 3.2')
           Recognizer::Rails3.new
-        when /\A3\.2/
+        when Gem::Requirement.new('~> 3.2')
           Recognizer::Rails32.new
-        when /\A(4\.[012]|5\.0)/
+        when Gem::Requirement.new('>= 4.0', '< 7.0')
           Recognizer::Rails4Plus.new
         else
           warn "[WARNING]: AePageObjects is not tested against Rails #{::Rails.version} and may behave in an undefined manner."

data/lib/ae_page_objects/version.rb

@@ -1,3 +1,3 @@
 module AePageObjects
-  VERSION = '4.1.0'.freeze
+  VERSION = '4.3.1.tim3'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ae_page_objects
 version: !ruby/object:Gem::Version
-  version: 4.1.0
+  version: 4.3.1.tim3
 platform: ruby
 authors:
 - AppFolio Engineering
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-05-29 00:00:00.000000000 Z
+date: 2021-03-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
@@ -64,7 +64,7 @@ homepage: http://github.com/appfolio/ae_page_objects
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -75,13 +75,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 2.2.5
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.2
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: Capybara Page Objects pattern
 test_files: []