ae_page_objects 4.0.1 → 4.4.0.pre.rc.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: db1d397fb998ff6d6fce4f99c5c23903023dd1f6
-  data.tar.gz: 8adbae2a2d9c88068b591e901e46568a872fbfa0
+SHA256:
+  metadata.gz: a81fd3e14e49322c4e0ca92ce91305800f7edde065a25f78776cadbeb1192de9
+  data.tar.gz: 3bacbc5553b90bc2e43ffec38a2d2f4de72544f0ec0c3932df0f0901852877e7
 SHA512:
-  metadata.gz: 7dce44727da3a23632fc2d796a8aca93cb560ef9d6cceff31b7b22b14bb919644d09add3d41f61c0d904605c9c26fa7d773bd213f0a9b5489946ebcd302bb14a
-  data.tar.gz: 80be52c061e4fb9e3c23e03e0b681ae65d262569ca76a19d60bab6e2e70c5f2359ad20c86ff7cbff46a7b347681cdb1459272ef87ac6870469ccb5fdc4968c07
+  metadata.gz: 8b01d530f561624b31f84d6cd50c79380c553e08df964c34cd2316ee2923b913853f3eb69f5dfbb446ef77ab81f6b515b31739dab4615fd452b60d0e735fe939
+  data.tar.gz: c6495b4e601622233ce5f9bed97612fb51cd37a0db4d9c577637c3babad5caec4418a5ab1d26f8b75c3061200d1d5a51fd181af99f66c43534d4267ec87dd488

data/lib/ae_page_objects.rb

@@ -16,7 +16,7 @@ module AePageObjects
   autoload :Checkbox,          'ae_page_objects/elements/checkbox'
 
   class << self
-    attr_accessor :default_router
+    attr_accessor :default_router, :time_keeper
 
     def browser
       @browser ||= begin
@@ -45,7 +45,7 @@ module AePageObjects
         result = call_wait_until_block(error_message, &block)
       else
         seconds_to_wait ||= default_max_wait_time
-        start_time      = Time.now
+        start_time      = AePageObjects.time_keeper.now
 
         # In an effort to avoid flakiness, Capybara waits, rescues errors, reloads nodes, and
         # retries.
@@ -71,7 +71,7 @@ module AePageObjects
           errors += [WaitTimeoutError]
           raise e unless errors.include?(e.class)
 
-          delay = seconds_to_wait - (Time.now - start_time)
+          delay = seconds_to_wait - (AePageObjects.time_keeper.now - start_time)
 
           if delay <= 0
             # Raising the WaitTimeoutError in the rescue block ensures that Ruby attaches
@@ -80,7 +80,7 @@ module AePageObjects
           end
 
           sleep(0.05)
-          raise FrozenInTime, "Time appears to be frozen" if Time.now == start_time
+          raise FrozenInTime, "Time appears to be frozen" if AePageObjects.time_keeper.now == start_time
 
           retry
         end
@@ -106,3 +106,4 @@ end
 
 require 'ae_page_objects/core/basic_router'
 AePageObjects.default_router = AePageObjects::BasicRouter.new
+AePageObjects.time_keeper = Time

data/lib/ae_page_objects/document.rb

@@ -32,7 +32,25 @@ module AePageObjects
         full_path = router.generate_path(path, *args)
         raise PathNotResolvable, "#{self.name} not visitable via #{paths.first}(#{args.inspect})" unless full_path
 
-        Capybara.current_session.visit(full_path)
+        load_retries = 0
+        begin
+          Capybara.current_session.visit(full_path)
+        rescue Net::ReadTimeout
+          # A Net::ReadTimeout can occur when the current session was already in the progress of loading
+          # a page.  This is fairly common and happens in situations like below:
+          #   1. the test performs an action that causes the page to reload
+          #   2. an assertion is made on the new page
+          #   3. the test then loads a different page
+          # Its possible for the assertion in #2 above to happen before the page is fully loaded, in which
+          # case the page load in #3 can fail with Net::ReadTimeout.
+          # In this situation the easiest thing to do is to retry
+          if load_retries < 3
+            load_retries += 1
+            retry
+          else
+            raise
+          end
+        end
 
         new
       end

data/lib/ae_page_objects/elements/collection.rb

@@ -41,7 +41,19 @@ module AePageObjects
     end
 
     def size
-      node.all(:xpath, item_xpath, options.merge(wait: false)).size
+      #
+      # In some cases when #size is called while the DOM is updating, Capybara
+      # will catch (and swallow) underlying exceptions such as
+      # `Selenium::WebDriver::Error::StaleElementReferenceError`.
+      # When this happens it will wait up to the max wait time, which can cause
+      # issues for `AePageObjects.wait_until` blocks.
+      #
+      # To prevent this issue the #all and #size calls are made with the Capybara
+      # wait time set to 0.
+      #
+      Capybara.using_wait_time(0) do
+        node.all(:xpath, item_xpath, options).size
+      end
     end
 
     def last

data/lib/ae_page_objects/rails/application_router.rb

@@ -133,12 +133,12 @@ module AePageObjects
     private
 
     def recognizer
-      @recognizer ||= case ::Rails.version
-        when /\A3\.[01]/
+      @recognizer ||= case ::Rails.gem_version
+        when Gem::Requirement.new('>= 3.0', '< 3.2')
           Recognizer::Rails3.new
-        when /\A3\.2/
+        when Gem::Requirement.new('~> 3.2')
           Recognizer::Rails32.new
-        when /\A(4\.[012]|5\.0)/
+        when Gem::Requirement.new('>= 4.0', '< 7.0')
           Recognizer::Rails4Plus.new
         else
           warn "[WARNING]: AePageObjects is not tested against Rails #{::Rails.version} and may behave in an undefined manner."

data/lib/ae_page_objects/util/wait_time_manager.rb

@@ -6,13 +6,13 @@ module AePageObjects
     end
 
     def using_wait_time
-      start_time = Time.now
+      start_time = AePageObjects.time_keeper.now
       @wait_time = [@wait_time, @max_time].min
       Capybara.using_wait_time(@wait_time) do
         yield
       end
     ensure
-      if Time.now - start_time > @wait_time
+      if AePageObjects.time_keeper.now - start_time > @wait_time
         @wait_time *= 2
       end
     end

data/lib/ae_page_objects/version.rb

@@ -1,3 +1,3 @@
 module AePageObjects
-  VERSION = '4.0.1'.freeze
+  VERSION = '4.4.0.pre.rc.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ae_page_objects
 version: !ruby/object:Gem::Version
-  version: 4.0.1
+  version: 4.4.0.pre.rc.1
 platform: ruby
 authors:
 - AppFolio Engineering
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-05-07 00:00:00.000000000 Z
+date: 2020-08-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
@@ -64,7 +64,7 @@ homepage: http://github.com/appfolio/ae_page_objects
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -75,13 +75,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 2.2.5
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.2
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: Capybara Page Objects pattern
 test_files: []