ae_page_objects 4.0.1 → 4.3.1.tim1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: db1d397fb998ff6d6fce4f99c5c23903023dd1f6
-  data.tar.gz: 8adbae2a2d9c88068b591e901e46568a872fbfa0
+SHA256:
+  metadata.gz: 7f569ecce06125424916611b6f8ebc2b78709c1b0d15e02f49e503b1aae0c845
+  data.tar.gz: 374ef8d80600c7a74951a876235776598d124512ab4a6c758e722e38c7f4d20c
 SHA512:
-  metadata.gz: 7dce44727da3a23632fc2d796a8aca93cb560ef9d6cceff31b7b22b14bb919644d09add3d41f61c0d904605c9c26fa7d773bd213f0a9b5489946ebcd302bb14a
-  data.tar.gz: 80be52c061e4fb9e3c23e03e0b681ae65d262569ca76a19d60bab6e2e70c5f2359ad20c86ff7cbff46a7b347681cdb1459272ef87ac6870469ccb5fdc4968c07
+  metadata.gz: feddd6e4fefcbe544a2e104ea7b529776907fcf5781fc30c4880778391d625b07b649cfee2ea8ef8b03cd40513661465cd935156cfc40046e44ac4211834e52d
+  data.tar.gz: 0efba04d353e4634b9cecc851bb5452545ecff929e218795813453f2a015c2e5a597a88593b26fdefbad07f55eeb4afbd6532d85f4a5baed922aa0988002a0ef

data/lib/ae_page_objects/document.rb

@@ -32,7 +32,25 @@ module AePageObjects
         full_path = router.generate_path(path, *args)
         raise PathNotResolvable, "#{self.name} not visitable via #{paths.first}(#{args.inspect})" unless full_path
 
-        Capybara.current_session.visit(full_path)
+        load_retries = 0
+        begin
+          Capybara.current_session.visit(full_path)
+        rescue Net::ReadTimeout
+          # A Net::ReadTimeout can occur when the current session was already in the progress of loading
+          # a page.  This is fairly common and happens in situations like below:
+          #   1. the test performs an action that causes the page to reload
+          #   2. an assertion is made on the new page
+          #   3. the test then loads a different page
+          # Its possible for the assertion in #2 above to happen before the page is fully loaded, in which
+          # case the page load in #3 can fail with Net::ReadTimeout.
+          # In this situation the easiest thing to do is to retry
+          if load_retries < 3
+            load_retries += 1
+            retry
+          else
+            raise
+          end
+        end
 
         new
       end

data/lib/ae_page_objects/element_proxy.rb

@@ -16,28 +16,28 @@ module AePageObjects
     end
 
     def visible?(options = {})
-      wait_until_visible(options[:wait])
+      wait_until_visible(0)
       true
     rescue ElementNotVisible
       false
     end
 
     def hidden?(options = {})
-      wait_until_hidden(options[:wait])
+      wait_until_hidden(0)
       true
     rescue ElementNotHidden
       false
     end
 
     def present?(options = {})
-      wait_until_present(options[:wait])
+      wait_until_present(0)
       true
     rescue ElementNotPresent
       false
     end
 
     def absent?(options = {})
-      wait_until_absent(options[:wait])
+      wait_until_absent(0)
       true
     rescue ElementNotAbsent
       false

data/lib/ae_page_objects/elements/collection.rb

@@ -41,7 +41,19 @@ module AePageObjects
     end
 
     def size
-      node.all(:xpath, item_xpath, options.merge(wait: false)).size
+      #
+      # In some cases when #size is called while the DOM is updating, Capybara
+      # will catch (and swallow) underlying exceptions such as
+      # `Selenium::WebDriver::Error::StaleElementReferenceError`.
+      # When this happens it will wait up to the max wait time, which can cause
+      # issues for `AePageObjects.wait_until` blocks.
+      #
+      # To prevent this issue the #all and #size calls are made with the Capybara
+      # wait time set to 0.
+      #
+      Capybara.using_wait_time(0) do
+        node.all(:xpath, item_xpath, options).size
+      end
     end
 
     def last

data/lib/ae_page_objects/rails/application_router.rb

@@ -133,12 +133,12 @@ module AePageObjects
     private
 
     def recognizer
-      @recognizer ||= case ::Rails.version
-        when /\A3\.[01]/
+      @recognizer ||= case ::Rails.gem_version
+        when Gem::Requirement.new('>= 3.0', '< 3.2')
           Recognizer::Rails3.new
-        when /\A3\.2/
+        when Gem::Requirement.new('~> 3.2')
           Recognizer::Rails32.new
-        when /\A(4\.[012]|5\.0)/
+        when Gem::Requirement.new('>= 4.0', '< 7.0')
           Recognizer::Rails4Plus.new
         else
           warn "[WARNING]: AePageObjects is not tested against Rails #{::Rails.version} and may behave in an undefined manner."

data/lib/ae_page_objects/version.rb

@@ -1,3 +1,3 @@
 module AePageObjects
-  VERSION = '4.0.1'.freeze
+  VERSION = '4.3.1.tim1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ae_page_objects
 version: !ruby/object:Gem::Version
-  version: 4.0.1
+  version: 4.3.1.tim1
 platform: ruby
 authors:
 - AppFolio Engineering
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-05-07 00:00:00.000000000 Z
+date: 2021-03-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
@@ -64,7 +64,7 @@ homepage: http://github.com/appfolio/ae_page_objects
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -75,13 +75,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 2.2.5
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.2
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: Capybara Page Objects pattern
 test_files: []