ae_page_objects 1.4.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 20c13f38ceabdcf27ecc3f89d9de3553c5787945
-  data.tar.gz: dcd428213ed6c1424727b40e0cd1583d4b6d2cc2
+  metadata.gz: 62a7c4ae245bff142532db643f26fd8d86cbeec5
+  data.tar.gz: 7f08f9ba3ee29135124a6002eee99235e19854ea
 SHA512:
-  metadata.gz: b13c1d548b49b516dc2a8d71efb0676850fc04301044fe02118bd4f0ed899ad6d81850a3021181a104f5ba79cecba6af36fdbd0aa4d84400333bccb3ac1657ce
-  data.tar.gz: 5f390f9a20b9f5d459021cfb5bceef6c96c0dd08de671ba79baa9629329253e073ce8307482b37f96e87537bea86fe7b41f89d2dc3c22450a1d33375224d4b19
+  metadata.gz: 360cc60ce2ff2ce7b5f4a4ca67ccc2c840df1a2aea9ca16fdad34629a3e9aba0d153c17514287b5be2756c12289d1f924f2f12477d7b2f4f9c6597dd8bb79213
+  data.tar.gz: 16c0429209abafbccdc3e699d41426455ae54adf340ac9398cfa885b11768c77a3223583be15e016b12ae5adba359153fae0a619aacb441dff3730c99c95c11f

data/lib/ae_page_objects/concerns/visitable.rb

@@ -22,9 +22,12 @@ module AePageObjects
 
       module VisitMethod
         def visit(*args)
-          raise ArgumentError, "Cannot pass block to visit()" if block_given?
+          args = args.dup
+          inner_options = args.last.is_a?(::Hash)? args.last : {}
 
-          full_path = site.generate_path(paths.first, *args)
+          path = inner_options.delete(:via) || paths.first
+
+          full_path = site.generate_path(path, *args)
           raise PathNotResolvable, "#{self.name} not visitable via #{paths.first}(#{args.inspect})" unless full_path
 
           Capybara.current_session.visit(full_path)

data/lib/ae_page_objects/core/dsl.rb

@@ -20,8 +20,8 @@ module AePageObjects
 
       self.element_attributes[name.to_sym] = klass
 
-      define_method name do |&block|
-        ElementProxy.new(klass, self, options, &block)
+      define_method name do
+        ElementProxy.new(klass, self, options)
       end
 
       klass

data/lib/ae_page_objects/core/rake_router.rb

@@ -4,6 +4,8 @@ module AePageObjects
     attr_reader :routes
 
     def initialize(rake_routes, mounted_prefix = '')
+      warn "[DEPRECATION WARNING]: AePageObjects::RakeRouter is deprecated and will be removed in version 2.0.0."
+
       @mounted_prefix = mounted_prefix || ""
       @routes = {}
       route_line_regex = /(\w+)(?:\s[A-Z]+)?\s+(\/.*)\(.:format\).*$/

data/lib/ae_page_objects/element_proxy.rb

@@ -31,6 +31,7 @@ module AePageObjects
     end
 
     def not_visible?
+      warn "[DEPRECATION WARNING]: AePageObjects::Element#not_visible? is deprecated and will be removed in version 2.0.0. Use AePageObjects::Element#hidden? instead."
       hidden?
     end
 
@@ -49,6 +50,7 @@ module AePageObjects
     end
 
     def not_present?
+      warn "[DEPRECATION WARNING]: AePageObjects::Element#not_present? is deprecated and will be removed in version 2.0.0. Use AePageObjects::Element#absent? instead."
       absent?
     end
 
@@ -91,6 +93,7 @@ module AePageObjects
     end
 
     def wait_for_presence(timeout = nil)
+      warn "[DEPRECATION WARNING]: AePageObjects::Element#wait_for_presence is deprecated and will be removed in version 2.0.0. Use AePageObjects::Element#wait_until_present instead."
       wait_until_present(timeout)
     end
 
@@ -105,6 +108,7 @@ module AePageObjects
     end
 
     def wait_for_absence(timeout = nil)
+      warn "[DEPRECATION WARNING]: AePageObjects::Element#wait_for_absence is deprecated and will be removed in version 2.0.0. Use AePageObjects::Element#wait_until_absent instead."
       wait_until_absent(timeout)
     end
 
@@ -117,7 +121,7 @@ module AePageObjects
     end
 
     def method_missing(name, *args, &block)
-      if name == "class"
+      if name == :class
         return @element_class
       end
 

data/lib/ae_page_objects/exceptions.rb

@@ -4,6 +4,7 @@ module AePageObjects
   class StalePageObject < Error
   end
 
+  # TODO: 2.0 - remove this base class.
   class LoadingFailed < Error
   end
 

data/lib/ae_page_objects/node.rb

@@ -51,7 +51,7 @@ module AePageObjects
       end
 
       def current_url_without_params
-        current_url.sub(/\?.*/, '')
+        current_url.sub(/(\?|\#).*/, '')
       end
     end
 

data/lib/ae_page_objects/util/waiter.rb

@@ -19,6 +19,7 @@ module AePageObjects
     end
 
     def self.wait_for(*args, &block)
+      warn "[DEPRECATION WARNING]: AePageObjects::Waiter.wait_for is deprecated and will be removed in version 2.0.0. Use AePageObjects::Waiter.wait_until instead."
       wait_until(*args, &block)
     end
 

data/lib/ae_page_objects/version.rb

@@ -1,3 +1,3 @@
 module AePageObjects
-  VERSION = '1.4.0'.freeze
+  VERSION = '1.4.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ae_page_objects
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.1
 platform: ruby
 authors:
 - Donnie Tognazzini
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-12 00:00:00.000000000 Z
+date: 2015-08-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara