ae_page_objects 1.1.0 → 1.1.1

data/lib/ae_page_objects/concerns/load_ensuring.rb

@@ -19,7 +19,7 @@ module AePageObjects
       
         self
       rescue Capybara::ElementNotFound => e
-        raise LoadingFailed, e.message 
+        raise LoadingElementFailed, e.message
       end
     end
   end

data/lib/ae_page_objects/concerns/visitable.rb

@@ -10,10 +10,14 @@ module AePageObjects
     
       def ensure_loaded!
         unless Waiter.wait_for { self.class.can_load_from_current_url? }
-          raise LoadingFailed, "#{self.class.name} cannot be loaded with url '#{current_url_without_params}'"
+          raise LoadingPageFailed, "#{self.class.name} cannot be loaded with url '#{current_url_without_params}'"
         end
 
-        super
+        begin
+          super
+        rescue LoadingElementFailed
+          raise LoadingPageFailed, e.message
+        end
       end
     
       module VisitMethod

data/lib/ae_page_objects/core/application_router.rb

@@ -55,7 +55,7 @@ module AePageObjects
       private
 
         def request_for(url, method)
-          Rails.application.routes.request_class.new(env_for(url, method))
+          ::Rails.application.routes.request_class.new(env_for(url, method))
         end
 
         def env_for(url, method)
@@ -68,7 +68,7 @@ module AePageObjects
 
         def url_and_router(url)
           url = Rack::Mount::Utils.normalize_path(url) unless url =~ %r{://}
-          router = Rails.application.routes.set
+          router = ::Rails.application.routes.set
 
           [url, router]
         end
@@ -76,7 +76,7 @@ module AePageObjects
         def routes
           @routes ||= begin
             routes_class = Class.new do
-              include Rails.application.routes.url_helpers
+              include ::Rails.application.routes.url_helpers
             end
             routes_class.new
           end
@@ -88,7 +88,7 @@ module AePageObjects
       private
         def url_and_router(url)
           url = Journey::Router::Utils.normalize_path(url) unless url =~ %r{://}
-          router = Rails.application.routes.router
+          router = ::Rails.application.routes.router
 
           [url, router]
         end
@@ -100,7 +100,7 @@ module AePageObjects
         def url_and_router(url)
           require 'action_dispatch/journey'
           url = ActionDispatch::Journey::Router::Utils.normalize_path(url) unless url =~ %r{://}
-          router = Rails.application.routes.router
+          router = ::Rails.application.routes.router
 
           [url, router]
         end
@@ -128,18 +128,17 @@ module AePageObjects
 
     def recognizer
       @recognizer ||= begin
-        if Rails.version =~ /\A2\.3/
+        if ::Rails.version =~ /\A2\.3/
           Recognizer::Rails23.new
-        elsif Rails.version =~ /\A3\.[01]/
+        elsif ::Rails.version =~ /\A3\.[01]/
           Recognizer::Rails3.new
-        elsif Rails.version =~ /\A3\.2/
+        elsif ::Rails.version =~ /\A3\.2/
           Recognizer::Rails32.new
-        elsif Rails.version =~ /\A4\.[01]/
-          warn "[WARNING]: AePageObjects works but is not thoroughly tested against Rails 4. Caveat emptor."
+        elsif ::Rails.version =~ /\A4\.[01]/
           Recognizer::Rails4.new
         else
-          warn "[WARNING]: AePageObjects is not tested against Rails #{Rails.version} and may behave in an undefined manner."
-          Recognizer::Rails32.new
+          warn "[WARNING]: AePageObjects is not tested against Rails #{::Rails.version} and may behave in an undefined manner."
+          Recognizer::Rails4.new
         end
       end
     end

data/lib/ae_page_objects/element.rb

@@ -101,6 +101,8 @@ module AePageObjects
       end
       
       parent.node
+    rescue Capybara::ElementNotFound => e
+      raise LoadingElementFailed, e.message
     end
   end
 end

data/lib/ae_page_objects/element_proxy.rb

@@ -44,7 +44,7 @@ module AePageObjects
     
     def presence
       element
-    rescue Capybara::ElementNotFound
+    rescue AePageObjects::LoadingElementFailed
       nil
     end
     

data/lib/ae_page_objects/exceptions.rb

@@ -7,9 +7,15 @@ module AePageObjects
   class LoadingFailed < Error
   end
 
+  class LoadingPageFailed < LoadingFailed
+  end
+
+  class LoadingElementFailed < LoadingFailed
+  end
+
   class PathNotResolvable < Error
   end
 
   class DocumentLoadError < Error
   end
-end
+end

data/lib/ae_page_objects/single_window/same_window_loader_strategy.rb

@@ -19,13 +19,13 @@ module AePageObjects
 
       def load_document(document_class)
         document_class.new
-      rescue AePageObjects::LoadingFailed
+      rescue AePageObjects::LoadingPageFailed
         nil
       end
 
       def condition_matches?(document, condition)
         condition.match?(document)
-      rescue Capybara::ElementNotFound
+      rescue AePageObjects::LoadingElementFailed
         false
       end
     end

data/lib/ae_page_objects/version.rb

@@ -1,3 +1,3 @@
 module AePageObjects
-  VERSION = '1.1.0'.freeze
+  VERSION = '1.1.1'.freeze
 end

metadata

@@ -1,42 +1,54 @@
---- !ruby/object:Gem::Specification
+--- !ruby/object:Gem::Specification 
 name: ae_page_objects
-version: !ruby/object:Gem::Version
-  version: 1.1.0
+version: !ruby/object:Gem::Version 
+  hash: 17
+  prerelease: 
+  segments: 
+  - 1
+  - 1
+  - 1
+  version: 1.1.1
 platform: ruby
-authors:
+authors: 
 - Donnie Tognazzini
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-06 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
-  name: capybara
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '1.1'
+
+date: 2014-09-10 00:00:00 Z
+dependencies: 
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id001 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 13
+        segments: 
+        - 1
+        - 1
+        version: "1.1"
     - - <
-      - !ruby/object:Gem::Version
-        version: '2.3'
-  type: :runtime
+      - !ruby/object:Gem::Version 
+        hash: 5
+        segments: 
+        - 2
+        - 3
+        version: "2.3"
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '1.1'
-    - - <
-      - !ruby/object:Gem::Version
-        version: '2.3'
+  requirement: *id001
+  type: :runtime
+  name: capybara
 description: Capybara Page Objects pattern
-email:
+email: 
 - engineering@appfolio.com
 executables: []
+
 extensions: []
+
 extra_rdoc_files: []
-files:
+
+files: 
 - lib/ae_page_objects.rb
 - lib/ae_page_objects/concerns/load_ensuring.rb
 - lib/ae_page_objects/concerns/staleable.rb
@@ -76,27 +88,37 @@ files:
 - lib/ae_page_objects/version.rb
 - lib/ae_page_objects/window.rb
 homepage: http://github.com/appfolio/ae_page_objects
-licenses:
+licenses: 
 - MIT
-metadata: {}
 post_install_message: 
 rdoc_options: []
-require_paths:
+
+require_paths: 
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement
-  requirements:
-  - - '>='
-    - !ruby/object:Gem::Version
-      version: '0'
-required_rubygems_version: !ruby/object:Gem::Requirement
-  requirements:
-  - - '>='
-    - !ruby/object:Gem::Version
-      version: '0'
+required_ruby_version: !ruby/object:Gem::Requirement 
+  none: false
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
+required_rubygems_version: !ruby/object:Gem::Requirement 
+  none: false
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
 requirements: []
+
 rubyforge_project: 
-rubygems_version: 2.1.11
+rubygems_version: 1.8.25
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: Capybara Page Objects pattern
 test_files: []
+

checksums.yaml

@@ -1,7 +0,0 @@
----
-SHA1:
-  metadata.gz: 5334b6a4fd2514a439fa323284a5893cb21005ca
-  data.tar.gz: 64a263fd884d0e933ebf8000ad88ed689dc3f601
-SHA512:
-  metadata.gz: 3af8bd7d6c91c8865641f2673cba8244ccc4d5db142bc95591f70dc57fdc2ecec8f924dfc71fe6fc38627b36fc5e1a1e8007d970b06a65ff17113f5b7f915fe3
-  data.tar.gz: 2b3d973eb84a26923bd6db1dcbec1bcdc18a85a923f98e3f60dfeed2b44e7ffaffa886fb88c6bc9695f565baa12fc5a0ea7a3818e311ff004a299072388b1e6f