ae_check_migrations_load_silently 0.0.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b76540091b20bf219a815f5ee7dde9272d4f8029435a36c0b3fd7294131e671f
-  data.tar.gz: db2f412966f0b86194aff16b74d7e678a1dd48194de28cc1480c1fc27a9e26c5
+  metadata.gz: 9dc4d7a9b05b8695db3c4e8b3f0c18f613118a12fa05582dbb0c1dff89930008
+  data.tar.gz: 68c46a66187aced0398e012a23c61344d886e9cf298b0645be794012d1163dde
 SHA512:
-  metadata.gz: 63ed8730d210bf7a9f6666be23071767f21de6dbe0805f5d908bec64178ba0418edea1e33d0c107c7ff7aefe83f68955bd12dee6b0c236842098b3b8ab757e46
-  data.tar.gz: b0afb5b34055d1b08ee1a19ebad5ab67214cd831037e9d57770b3611998124c1cb7b3393206002341eca3f8420c34aac86e23291954673b54f2da957d666a00c
+  metadata.gz: 6baba3f5190ebbe9dea450d9cc9059dd80166867e35ffc6e574e6616c201f1a71d77649fae5c8f8418a263f0f0ec57c12c52c1cb278942e528f92ca417146e0a
+  data.tar.gz: 26fadec1e587076366e2f01563d4f1ad348c45fc2e2a41d813de312f7aa2b57deedc200716ad5e578f315fe534055a658f1bb47573e9fa5960015ac80ba2e7ae

data/lib/ae_check_migrations_load_silently.rb

@@ -1,55 +1,54 @@
-
 require 'active_record'
-
-class AeCheckMigrationsLoadSilently
-  class << self
-
-    def run
-      before_checksums = get_database_checksums
-      load_all_migrations
-      after_checksums = get_database_checksums
-
-      tables_modified = (
-      (before_checksums - after_checksums).map(&:first) +
-        (after_checksums - before_checksums).map(&:first)
-      ).uniq
-
-      if tables_modified.present?
-        error_message = <<~MSG
-          The following tables were modified when the migration classes were
-          loaded. This is not compatable with our release process. This is likely
-          because the migration has database modifiying code on the
-          class rather than inside a method.
-
-          #{tables_modified.sort.join("\n")}
-        MSG
-
-        flunk error_message
-      end
+require 'minitest'
+
+module AeCheckMigrationsLoadSilently
+  include Minitest::Assertions
+
+  def check_all_migrations_load_silently
+    before_checksums = get_database_checksums
+    load_all_migrations
+    after_checksums = get_database_checksums
+
+    tables_modified = (
+    (before_checksums - after_checksums).map(&:first) +
+      (after_checksums - before_checksums).map(&:first)
+    ).uniq
+
+    if tables_modified.present?
+      error_message = <<~MSG
+        The following tables were modified when the migration classes were
+        loaded. This is not compatable with our release process. This is likely
+        because the migration has database modifiying code on the
+        class rather than inside a method.
+        #{tables_modified.sort.join("\n")}
+      MSG
+
+      flunk error_message
     end
+  end
 
-    private
+  private
 
-    def get_database_checksums
-      tables_sql = ActiveRecord::Base.connection.tables.sort.join(", ")
-      checksum_sql = "CHECKSUM TABLE #{tables_sql}"
-      ActiveRecord::Base.connection.execute(checksum_sql).to_a
-    end
+  def get_database_checksums
+    tables_sql = ActiveRecord::Base.connection.tables.sort.join(", ")
+    checksum_sql = "CHECKSUM TABLE #{tables_sql}"
+    ActiveRecord::Base.connection.execute(checksum_sql).to_a
+  end
 
-    def load_all_migrations
-      migrations_to_process = Dir['db/migrate/20*.rb']
-      migrations_to_process.each do |migration|
-        begin
-          load migration
-        rescue StandardError => e
-          msg = <<~MSG
-            #{self.class.name}: #{migration} failed to load. This is likely because the migration has code that is defined
-            on the top level class, instead of in a method.
-            #{e.message}
-          MSG
-          flunk msg
-        end
+  def load_all_migrations
+    migrations_to_process = Dir['db/migrate/20*.rb']
+    migrations_to_process.each do |migration|
+      begin
+        load migration
+      rescue StandardError => e
+        msg = <<~MSG
+          #{self.class.name}: #{migration} failed to load. This is likely because the migration has code that is defined
+          on the top level class, instead of in a method.
+          #{e.message}
+        MSG
+        flunk msg
       end
     end
   end
 end
+

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ae_check_migrations_load_silently
 version: !ruby/object:Gem::Version
-  version: 0.0.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Appfolio
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-06-12 00:00:00.000000000 Z
+date: 2020-08-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord