ae_bank_days 1.1.2 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 78328538c2b370e7d744ec107ee252dae174538d69352d0f1e85fa83382c449a
-  data.tar.gz: 74655b450f093f68d30cbb498356d3db45b914dfc7697991cb0b8d612ef53911
+  metadata.gz: 06f9983d00ce48e33b4a934f726e456d1eb37daec1355aad31cf605f9c5ef0bd
+  data.tar.gz: e3b17132d6696f57e38e2a1addac13d1ae4daa49fcb788dae5e553b66cec463f
 SHA512:
-  metadata.gz: dbf08e548ca896facd91a448331ab86e6687bf8f16132c88c1cb3eb08a3dd4acbed7f7f489b71f2fb4024c8587f617b135658778435029227239d5d837bcfa31
-  data.tar.gz: 6075ed1dc21f239f558e40d0ee740938b5ca3f9e8640f63a63a4cab3034fb739e6eb12be580f300a6ca6f69caff581441835af30461c9d20f94bd1a5672dba7a
+  metadata.gz: f43ac398011e018ece5207f6db467339a3b9255451627cad5cd5e970b3d08512d38c3ae9d09604ddf09d177a30febdbf98d7e5e5ba6ef8329c9122aea7424e8b
+  data.tar.gz: b0e66f75d0ea3c5ac6d39a7240e3a284af57968292e69a5b14dbfb1753273bc21a425ab9b67e0b8f5bcedffd8bc87a7d77cca0959b6944d0a3d75105087a4c00

data/Gemfile.lock

@@ -1,22 +1,23 @@
 PATH
   remote: .
   specs:
-    ae_bank_days (1.1.1)
-      holidays (~> 7.1)
+    ae_bank_days (1.2.0)
+      holidays (~> 8.3)
 
 GEM
   remote: https://rubygems.org/
   specs:
     ansi (1.5.0)
-    builder (3.2.3)
-    holidays (7.1.0)
-    minitest (5.13.0)
+    builder (3.2.4)
+    holidays (8.3.0)
+    minitest (5.11.3)
     minitest-reporters (1.3.0)
       ansi
       builder
       minitest (>= 5.0)
       ruby-progressbar
-    rake (12.3.2)
+    mocha (1.11.2)
+    rake (12.3.3)
     ruby-progressbar (1.10.1)
 
 PLATFORMS
@@ -27,7 +28,8 @@ DEPENDENCIES
   bundler (>= 1.10.4, < 3)
   minitest (>= 5.8)
   minitest-reporters (>= 1.3)
+  mocha (>= 1.1)
   rake (>= 12.0)
 
 BUNDLED WITH
-   2.0.2
+   2.1.4

data/ae_bank_days.gemspec

@@ -21,10 +21,11 @@ Gem::Specification.new do |spec|
 
   spec.metadata['allowed_push_host'] = 'https://rubygems.org'
 
-  spec.add_dependency('holidays', '~> 7.1')
+  spec.add_dependency('holidays', '~> 8.3')
 
   spec.add_development_dependency('bundler', ['>= 1.10.4', '< 3'])
   spec.add_development_dependency('minitest', '>= 5.8')
   spec.add_development_dependency('minitest-reporters', '>= 1.3')
+  spec.add_development_dependency('mocha', '>= 1.1')
   spec.add_development_dependency('rake', '>= 12.0')
 end

data/lib/ae_bank_days.rb

@@ -5,4 +5,7 @@ require 'holidays'
 
 module AeBankDays
   autoload :BankDayHelper, 'ae_bank_days/bank_day_helper'
+  autoload :DateExtensions, 'ae_bank_days/date_extensions'
 end
+
+Date.send :include, AeBankDays::DateExtensions

data/lib/ae_bank_days/bank_day_helper.rb

@@ -2,16 +2,12 @@
 
 module AeBankDays
   class BankDayHelper
-    START_DATE = Date.civil(2014, 1, 1)
-    END_DATE   = Date.today.next_year(10)
-    HOLIDAYS   = Holidays.between(START_DATE, END_DATE, :federalreserve, :observed).map do |holiday|
-      holiday[:date]
-    end
-
     class << self
+      Holidays.cache_between(Date.today.prev_year, Date.today.next_year(10), :federalreservebanks, :observed)
+
       def bank_day?(day)
         date = day.to_date
-        weekday?(date) && !HOLIDAYS.include?(date)
+        weekday?(date) && Holidays.on(date, :federalreservebanks, :observed).empty?
       end
 
       def next_banking_day(date, number_of_days: 0)

data/lib/ae_bank_days/date_extensions.rb

@@ -0,0 +1,15 @@
+module AeBankDays
+  module DateExtensions
+    def bank_day?
+      BankDayHelper.bank_day?(self)
+    end
+
+    def next_banking_day(n = 0)
+      BankDayHelper.next_banking_day(self, number_of_days: n)
+    end
+
+    def previous_banking_day(n = 0)
+      BankDayHelper.previous_banking_day(self, number_of_days: n)
+    end
+  end
+end

data/lib/ae_bank_days/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AeBankDays
-  VERSION = '1.1.2'
+  VERSION = '1.2.0'
 end

data/test/ae_bank_days/bank_day_helper_test.rb

@@ -4,85 +4,72 @@ require 'test_helper'
 
 module AeBankDays
   class BankDayHelperTest < Minitest::Test
-    def test_constants
-      assert_equal Date.civil(2014, 1, 1), BankDayHelper::START_DATE
-      assert_equal Date.today.next_year(10), BankDayHelper::END_DATE
-      assert BankDayHelper::HOLIDAYS.any?
-    end
-
     def test_bank_day__weekday
-      time = Time.parse('2017-10-03 14:30:45 -0500')
-      assert BankDayHelper.bank_day?(time.to_date)
+      assert BankDayHelper.bank_day?(Date.civil(2017, 10, 3))
     end
 
     def test_bank_day__weekend
-      time = Time.parse('2017-10-14 14:30:45 -0500')
-      refute BankDayHelper.bank_day?(time.to_date)
+      refute BankDayHelper.bank_day?(Date.civil(2017, 10, 14))
     end
 
     def test_bank_day__holiday
-      time = Time.parse('2017-10-09 14:30:45 -0500')
-      refute BankDayHelper.bank_day?(time.to_date)
+      refute BankDayHelper.bank_day?(Date.civil(2017, 10, 9))
+    end
+
+    def test_bank_day__saturday_holiday_is_not_observed_on_friday
+      # The federal bank does not observe holidays that fall on Saturday on the preceding Friday as is common.
+      # This test makes sure that these dates are not accidentally marked as holidays.
+      # July 4, 2020 fell on a Saturday. The day before was a generally observed federal holiday, but it was still
+      # a banking day due to the federal banks holiday rules.
+      assert BankDayHelper.bank_day?(Date.civil(2020, 6, 3))
     end
 
     def test_next_banking_day__weekday
-      time = Time.parse('2017-10-03 14:30:45 -0500')
-      assert_equal Date.parse('2017-10-03'), BankDayHelper.next_banking_day(time.to_date)
+      assert_equal Date.civil(2017, 10, 3), BankDayHelper.next_banking_day(Date.civil(2017, 10, 3))
     end
 
     def test_next_banking_day__weekday__extra_days
-      time = Time.parse('2017-10-03 14:30:45 -0500')
-      assert_equal Date.parse('2017-10-06'), BankDayHelper.next_banking_day(time.to_date, number_of_days: 3)
+      assert_equal Date.civil(2017, 10, 6), BankDayHelper.next_banking_day(Date.civil(2017, 10, 3), number_of_days: 3)
     end
 
     def test_next_banking_day__weekend
-      time = Time.parse('2017-10-14 14:30:45 -0500')
-      assert_equal Date.parse('2017-10-16'), BankDayHelper.next_banking_day(time.to_date)
+      assert_equal Date.civil(2017, 10, 16), BankDayHelper.next_banking_day(Date.civil(2017, 10, 14))
     end
 
     def test_next_banking_day__weekend__extra_days
-      time = Time.parse('2017-10-14 14:30:45 -0500')
-      assert_equal Date.parse('2017-10-19'), BankDayHelper.next_banking_day(time.to_date, number_of_days: 3)
+      assert_equal Date.civil(2017, 10, 19), BankDayHelper.next_banking_day(Date.civil(2017, 10, 14), number_of_days: 3)
     end
 
     def test_next_banking_day__holiday
-      time = Time.parse('2017-10-09 14:30:45 -0500')
-      assert_equal Date.parse('2017-10-10'), BankDayHelper.next_banking_day(time.to_date)
+      assert_equal Date.civil(2017, 10, 10), BankDayHelper.next_banking_day(Date.civil(2017, 10, 9))
     end
 
     def test_next_banking_day__holiday__extra_days
-      time = Time.parse('2017-10-09 14:30:45 -0500')
-      assert_equal Date.parse('2017-10-13'), BankDayHelper.next_banking_day(time.to_date, number_of_days: 3)
+      assert_equal Date.civil(2017, 10, 13), BankDayHelper.next_banking_day(Date.civil(2017, 10, 9), number_of_days: 3)
     end
 
     def test_previous_banking_day__weekday
-      time = Time.parse('2017-10-03 14:30:45 -0500')
-      assert_equal Date.parse('2017-10-03'), BankDayHelper.previous_banking_day(time.to_date)
+      assert_equal Date.civil(2017, 10, 3), BankDayHelper.previous_banking_day(Date.civil(2017, 10, 3))
     end
 
     def test_previous_banking_day__weekday__extra_days
-      time = Time.parse('2017-10-06 14:30:45 -0500')
-      assert_equal Date.parse('2017-10-03'), BankDayHelper.previous_banking_day(time.to_date, number_of_days: 3)
+      assert_equal Date.civil(2017, 10, 3), BankDayHelper.previous_banking_day(Date.civil(2017, 10, 6), number_of_days: 3)
     end
 
     def test_previous_banking_day__weekend
-      time = Time.parse('2017-10-14 14:30:45 -0500')
-      assert_equal Date.parse('2017-10-13'), BankDayHelper.previous_banking_day(time.to_date)
+      assert_equal Date.civil(2017, 10, 13), BankDayHelper.previous_banking_day(Date.civil(2017, 10, 14))
     end
 
     def test_previous_banking_day__weekend__extra_days
-      time = Time.parse('2017-10-14 14:30:45 -0500')
-      assert_equal Date.parse('2017-10-10'), BankDayHelper.previous_banking_day(time.to_date, number_of_days: 3)
+      assert_equal Date.civil(2017, 10, 10), BankDayHelper.previous_banking_day(Date.civil(2017, 10, 14), number_of_days: 3)
     end
 
     def test_previous_banking_day__holiday
-      time = Time.parse('2017-10-09 14:30:45 -0500')
-      assert_equal Date.parse('2017-10-06'), BankDayHelper.previous_banking_day(time.to_date)
+      assert_equal Date.civil(2017, 10, 6), BankDayHelper.previous_banking_day(Date.civil(2017, 10, 9))
     end
 
     def test_previous_banking_day__holiday__extra_days
-      time = Time.parse('2017-10-09 14:30:45 -0500')
-      assert_equal Date.parse('2017-10-03'), BankDayHelper.previous_banking_day(time.to_date, number_of_days: 3)
+      assert_equal Date.civil(2017, 10, 3), BankDayHelper.previous_banking_day(Date.civil(2017, 10, 9), number_of_days: 3)
     end
   end
 end

data/test/ae_bank_days/date_extensions_test.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+module AeBankDays
+  class DateExtensionsTest < Minitest::Test
+    def test_bank_day
+      date = Date.today
+      BankDayHelper.expects(:bank_day?).with(date).returns(true)
+
+      assert date.bank_day?
+    end
+
+    def test_next_banking_day
+      date = Date.today
+      new_date = date + 2
+      BankDayHelper.expects(:next_banking_day).with(date, number_of_days: 2).returns(new_date)
+
+      assert_equal new_date, date.next_banking_day(2)
+    end
+
+    def test_next_banking_day__default
+      date = Date.today
+      new_date = date + 2
+      BankDayHelper.expects(:next_banking_day).with(date, number_of_days: 0).returns(new_date)
+
+      assert_equal new_date, date.next_banking_day
+    end
+
+    def test_previous_banking_day
+      date = Date.today
+      new_date = date + 2
+      BankDayHelper.expects(:previous_banking_day).with(date, number_of_days: 2).returns(new_date)
+
+      assert_equal new_date, date.previous_banking_day(2)
+    end
+
+    def test_previous_banking_day__default
+      date = Date.today
+      new_date = date + 2
+      BankDayHelper.expects(:previous_banking_day).with(date, number_of_days: 0).returns(new_date)
+
+      assert_equal new_date, date.previous_banking_day
+    end
+  end
+end

data/test/test_helper.rb

@@ -14,6 +14,7 @@ end
 require 'ae_bank_days'
 require 'minitest/autorun'
 require 'minitest/reporters'
+require 'mocha/setup'
 require 'time'
 
 MiniTest::Reporters.use!

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ae_bank_days
 version: !ruby/object:Gem::Version
-  version: 1.1.2
+  version: 1.2.0
 platform: ruby
 authors:
 - AppFolio
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-12-31 00:00:00.000000000 Z
+date: 2020-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: holidays
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '8.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '8.3'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -72,6 +72,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: mocha
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.1'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -101,8 +115,10 @@ files:
 - ae_bank_days.gemspec
 - lib/ae_bank_days.rb
 - lib/ae_bank_days/bank_day_helper.rb
+- lib/ae_bank_days/date_extensions.rb
 - lib/ae_bank_days/version.rb
 - test/ae_bank_days/bank_day_helper_test.rb
+- test/ae_bank_days/date_extensions_test.rb
 - test/ae_bank_days_test.rb
 - test/test_helper.rb
 homepage: http://github.com/appfolio/ae_bank_days
@@ -110,7 +126,7 @@ licenses:
 - MIT
 metadata:
   allowed_push_host: https://rubygems.org
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -128,11 +144,12 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.4
-signing_key: 
+rubygems_version: 3.0.3
+signing_key:
 specification_version: 4
 summary: Gem for finding the next banking date
 test_files:
 - test/ae_bank_days/bank_day_helper_test.rb
+- test/ae_bank_days/date_extensions_test.rb
 - test/ae_bank_days_test.rb
 - test/test_helper.rb