ae_bank_days 1.1.1 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ebc81dee02883d380c6bfad586411db0aa39c41de3200b8524e93bfcea58aeb4
-  data.tar.gz: df7239995df00da14fc96a1b440707bf42aed6fa3f59690d7e1ee03a10e7afb7
+  metadata.gz: 78328538c2b370e7d744ec107ee252dae174538d69352d0f1e85fa83382c449a
+  data.tar.gz: 74655b450f093f68d30cbb498356d3db45b914dfc7697991cb0b8d612ef53911
 SHA512:
-  metadata.gz: b4c817ddb3f0c29ab2f0ba863faf0b25346d2392228a9367eb99c3088f138706787e0a8e689edf21ca9357db2061bd1e73218bc000af392b4410df23076d87b1
-  data.tar.gz: d5f176b045c3848737f3a65b6b5debd048fc194c3ac9432256f7499345732726bed114323e37d47d3d1e53e91fed25eaa29fed3f8f6825573d2e9508ead7c761
+  metadata.gz: dbf08e548ca896facd91a448331ab86e6687bf8f16132c88c1cb3eb08a3dd4acbed7f7f489b71f2fb4024c8587f617b135658778435029227239d5d837bcfa31
+  data.tar.gz: 6075ed1dc21f239f558e40d0ee740938b5ca3f9e8640f63a63a4cab3034fb739e6eb12be580f300a6ca6f69caff581441835af30461c9d20f94bd1a5672dba7a

data/Gemfile.lock

@@ -2,26 +2,22 @@ PATH
   remote: .
   specs:
     ae_bank_days (1.1.1)
-      activesupport (>= 5.2, < 7)
       holidays (~> 7.1)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (5.2.3)
-      concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 0.7, < 2)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-    concurrent-ruby (1.1.5)
+    ansi (1.5.0)
+    builder (3.2.3)
     holidays (7.1.0)
-    i18n (1.7.0)
-      concurrent-ruby (~> 1.0)
     minitest (5.13.0)
+    minitest-reporters (1.3.0)
+      ansi
+      builder
+      minitest (>= 5.0)
+      ruby-progressbar
     rake (12.3.2)
-    thread_safe (0.3.6)
-    tzinfo (1.2.5)
-      thread_safe (~> 0.1)
+    ruby-progressbar (1.10.1)
 
 PLATFORMS
   ruby
@@ -29,6 +25,8 @@ PLATFORMS
 DEPENDENCIES
   ae_bank_days!
   bundler (>= 1.10.4, < 3)
+  minitest (>= 5.8)
+  minitest-reporters (>= 1.3)
   rake (>= 12.0)
 
 BUNDLED WITH

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2019 AppFolio inc
+Copyright (c) 2019-2020 AppFolio inc
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.rdoc

@@ -9,9 +9,9 @@ Simple utility to find the next banking day
 * Fork the project.
 * Start a feature/bugfix branch.
 * Commit and push until you are happy with your contribution.
-* Make sure to add tests for it. This is important so I don't break it in a future version unintentionally.
-* Please try not to mess with the Rakefile, version, or history. If you want to have your own version, or is otherwise necessary, that is fine, but please isolate to its own commit so I can cherry-pick around it.
+* Make sure to add tests for it. This is important so it doesn't break in a future version unintentionally.
+* Please try not to mess with the Rakefile, version, or history. If you want to have your own version, or is otherwise necessary, that is fine, but please isolate to its own commit so it can be cherry-picked around.
 
 == Copyright
 
-Copyright © 2019 AppFolio.
+Copyright © 2019-2020 AppFolio.

data/Rakefile

@@ -2,13 +2,15 @@
 
 require 'rubygems'
 require 'bundler'
+
 begin
   Bundler.setup(:default, :development)
 rescue Bundler::BundlerError => e
-  $stderr.puts e.message
-  $stderr.puts 'Run `bundle install` to install missing gems'
+  warn e.message
+  warn 'Run `bundle install` to install missing gems'
   exit e.status_code
 end
+
 require 'rake/testtask'
 
 Rake::TestTask.new(:test) do |test|

data/ae_bank_days.gemspec

@@ -5,23 +5,26 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'ae_bank_days/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = 'ae_bank_days'
-  spec.version       = AeBankDays::VERSION
-  spec.authors       = ['AppFolio']
-  spec.email         = ['dev@appfolio.com']
-  spec.summary       = 'Gem for finding the next banking date'
-  spec.description   = ''
-  spec.homepage      = 'http://github.com/appfolio/ae_bank_days'
+  spec.name                  = 'ae_bank_days'
+  spec.version               = AeBankDays::VERSION
+  spec.platform              = Gem::Platform::RUBY
+  spec.authors               = ['AppFolio']
+  spec.email                 = ['dev@appfolio.com']
+  spec.summary               = 'Gem for finding the next banking date'
+  spec.description           = spec.summary
+  spec.homepage              = 'http://github.com/appfolio/ae_bank_days'
   spec.required_ruby_version = ['>= 2.3.3', '< 2.7']
-  spec.licenses      = ['MIT']
+  spec.licenses              = ['MIT']
+  spec.files                 = Dir['**/*'].reject { |f| f[%r{^log/}] || f[%r{^pkg/}] }
+  spec.test_files            = spec.files.grep(%r{^(test)/})
+  spec.require_paths         = ['lib']
+
   spec.metadata['allowed_push_host'] = 'https://rubygems.org'
 
-  spec.files         = Dir['**/*'].reject { |f| f[%r{^log/}] || f[%r{^pkg/}] }
-  spec.test_files    = spec.files.grep(%r{^(test)/})
-  spec.require_paths = ['lib']
+  spec.add_dependency('holidays', '~> 7.1')
 
-  spec.add_dependency 'activesupport', ['>= 5.2', '< 7']
-  spec.add_dependency 'holidays', '~> 7.1'
-  spec.add_development_dependency 'rake', '>= 12.0'
-  spec.add_development_dependency 'bundler', ['>= 1.10.4', '< 3']
+  spec.add_development_dependency('bundler', ['>= 1.10.4', '< 3'])
+  spec.add_development_dependency('minitest', '>= 5.8')
+  spec.add_development_dependency('minitest-reporters', '>= 1.3')
+  spec.add_development_dependency('rake', '>= 12.0')
 end

data/lib/ae_bank_days.rb

@@ -1,49 +1,8 @@
 # frozen_string_literal: true
 
-require 'ae_bank_days/version'
+require 'date'
 require 'holidays'
-require 'active_support'
-require 'active_support/core_ext/time'
-require 'active_support/core_ext/integer/time'
 
 module AeBankDays
-  class BankDayHelper
-    ten_years_from_now = Time.now + 10.years
-    HOLIDAYS = Holidays.between(Date.civil(2014, 1, 1), ten_years_from_now, :federalreserve, :observed).map do |holiday|
-      holiday[:date]
-    end
-
-    class << self
-      def bank_day?(day)
-        date = day.to_date
-        weekday?(date) && !HOLIDAYS.include?(date)
-      end
-
-      def next_banking_day(date, number_of_days: 0)
-        banking_day = date
-        number_of_days.times do
-          banking_day += 1 until bank_day?(banking_day)
-          banking_day += 1
-        end
-        banking_day += 1 until bank_day?(banking_day)
-        banking_day
-      end
-
-      def previous_banking_day(date, number_of_days: 0)
-        banking_day = date
-        number_of_days.times do
-          banking_day -= 1 until bank_day?(banking_day)
-          banking_day -= 1
-        end
-        banking_day -= 1 until bank_day?(banking_day)
-        banking_day
-      end
-
-      private
-
-      def weekday?(day)
-        [1, 2, 3, 4, 5].include? day.wday
-      end
-    end
-  end
+  autoload :BankDayHelper, 'ae_bank_days/bank_day_helper'
 end

data/lib/ae_bank_days/bank_day_helper.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+module AeBankDays
+  class BankDayHelper
+    START_DATE = Date.civil(2014, 1, 1)
+    END_DATE   = Date.today.next_year(10)
+    HOLIDAYS   = Holidays.between(START_DATE, END_DATE, :federalreserve, :observed).map do |holiday|
+      holiday[:date]
+    end
+
+    class << self
+      def bank_day?(day)
+        date = day.to_date
+        weekday?(date) && !HOLIDAYS.include?(date)
+      end
+
+      def next_banking_day(date, number_of_days: 0)
+        banking_day = date
+        number_of_days.times do
+          banking_day += 1 until bank_day?(banking_day)
+          banking_day += 1
+        end
+        banking_day += 1 until bank_day?(banking_day)
+        banking_day
+      end
+
+      def previous_banking_day(date, number_of_days: 0)
+        banking_day = date
+        number_of_days.times do
+          banking_day -= 1 until bank_day?(banking_day)
+          banking_day -= 1
+        end
+        banking_day -= 1 until bank_day?(banking_day)
+        banking_day
+      end
+
+      private
+
+      def weekday?(day)
+        (1..5).include?(day.wday)
+      end
+    end
+  end
+end

data/lib/ae_bank_days/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AeBankDays
-  VERSION = '1.1.1'
+  VERSION = '1.1.2'
 end

data/test/ae_bank_days/bank_day_helper_test.rb

@@ -0,0 +1,88 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+module AeBankDays
+  class BankDayHelperTest < Minitest::Test
+    def test_constants
+      assert_equal Date.civil(2014, 1, 1), BankDayHelper::START_DATE
+      assert_equal Date.today.next_year(10), BankDayHelper::END_DATE
+      assert BankDayHelper::HOLIDAYS.any?
+    end
+
+    def test_bank_day__weekday
+      time = Time.parse('2017-10-03 14:30:45 -0500')
+      assert BankDayHelper.bank_day?(time.to_date)
+    end
+
+    def test_bank_day__weekend
+      time = Time.parse('2017-10-14 14:30:45 -0500')
+      refute BankDayHelper.bank_day?(time.to_date)
+    end
+
+    def test_bank_day__holiday
+      time = Time.parse('2017-10-09 14:30:45 -0500')
+      refute BankDayHelper.bank_day?(time.to_date)
+    end
+
+    def test_next_banking_day__weekday
+      time = Time.parse('2017-10-03 14:30:45 -0500')
+      assert_equal Date.parse('2017-10-03'), BankDayHelper.next_banking_day(time.to_date)
+    end
+
+    def test_next_banking_day__weekday__extra_days
+      time = Time.parse('2017-10-03 14:30:45 -0500')
+      assert_equal Date.parse('2017-10-06'), BankDayHelper.next_banking_day(time.to_date, number_of_days: 3)
+    end
+
+    def test_next_banking_day__weekend
+      time = Time.parse('2017-10-14 14:30:45 -0500')
+      assert_equal Date.parse('2017-10-16'), BankDayHelper.next_banking_day(time.to_date)
+    end
+
+    def test_next_banking_day__weekend__extra_days
+      time = Time.parse('2017-10-14 14:30:45 -0500')
+      assert_equal Date.parse('2017-10-19'), BankDayHelper.next_banking_day(time.to_date, number_of_days: 3)
+    end
+
+    def test_next_banking_day__holiday
+      time = Time.parse('2017-10-09 14:30:45 -0500')
+      assert_equal Date.parse('2017-10-10'), BankDayHelper.next_banking_day(time.to_date)
+    end
+
+    def test_next_banking_day__holiday__extra_days
+      time = Time.parse('2017-10-09 14:30:45 -0500')
+      assert_equal Date.parse('2017-10-13'), BankDayHelper.next_banking_day(time.to_date, number_of_days: 3)
+    end
+
+    def test_previous_banking_day__weekday
+      time = Time.parse('2017-10-03 14:30:45 -0500')
+      assert_equal Date.parse('2017-10-03'), BankDayHelper.previous_banking_day(time.to_date)
+    end
+
+    def test_previous_banking_day__weekday__extra_days
+      time = Time.parse('2017-10-06 14:30:45 -0500')
+      assert_equal Date.parse('2017-10-03'), BankDayHelper.previous_banking_day(time.to_date, number_of_days: 3)
+    end
+
+    def test_previous_banking_day__weekend
+      time = Time.parse('2017-10-14 14:30:45 -0500')
+      assert_equal Date.parse('2017-10-13'), BankDayHelper.previous_banking_day(time.to_date)
+    end
+
+    def test_previous_banking_day__weekend__extra_days
+      time = Time.parse('2017-10-14 14:30:45 -0500')
+      assert_equal Date.parse('2017-10-10'), BankDayHelper.previous_banking_day(time.to_date, number_of_days: 3)
+    end
+
+    def test_previous_banking_day__holiday
+      time = Time.parse('2017-10-09 14:30:45 -0500')
+      assert_equal Date.parse('2017-10-06'), BankDayHelper.previous_banking_day(time.to_date)
+    end
+
+    def test_previous_banking_day__holiday__extra_days
+      time = Time.parse('2017-10-09 14:30:45 -0500')
+      assert_equal Date.parse('2017-10-03'), BankDayHelper.previous_banking_day(time.to_date, number_of_days: 3)
+    end
+  end
+end

data/test/ae_bank_days_test.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+class AeBankDaysTest < Minitest::Test
+  def test_that_it_has_a_version_number
+    refute_nil ::AeBankDays::VERSION
+  end
+end

data/test/test_helper.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+require 'rubygems'
+require 'bundler'
+
+begin
+  Bundler.setup(:default, :development)
+rescue Bundler::BundlerError => e
+  warn e.message
+  warn 'Run `bundle install` to install missing gems'
+  exit e.status_code
+end
+
+require 'ae_bank_days'
+require 'minitest/autorun'
+require 'minitest/reporters'
+require 'time'
+
+MiniTest::Reporters.use!

metadata

@@ -1,84 +1,92 @@
 --- !ruby/object:Gem::Specification
 name: ae_bank_days
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - AppFolio
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-12-27 00:00:00.000000000 Z
+date: 2019-12-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: activesupport
+  name: holidays
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '7.1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '7.1'
+- !ruby/object:Gem::Dependency
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: 1.10.4
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7'
-  type: :runtime
+        version: '3'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: 1.10.4
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '3'
 - !ruby/object:Gem::Dependency
-  name: holidays
+  name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '7.1'
-  type: :runtime
+        version: '5.8'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '5.8'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: minitest-reporters
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: '1.3'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.10.4
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '3'
+        version: '12.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.10.4
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '3'
-description: ''
+        version: '12.0'
+description: Gem for finding the next banking date
 email:
 - dev@appfolio.com
 executables: []
@@ -92,8 +100,11 @@ files:
 - Rakefile
 - ae_bank_days.gemspec
 - lib/ae_bank_days.rb
+- lib/ae_bank_days/bank_day_helper.rb
 - lib/ae_bank_days/version.rb
-- test/bank_day_helper_test.rb
+- test/ae_bank_days/bank_day_helper_test.rb
+- test/ae_bank_days_test.rb
+- test/test_helper.rb
 homepage: http://github.com/appfolio/ae_bank_days
 licenses:
 - MIT
@@ -122,4 +133,6 @@ signing_key:
 specification_version: 4
 summary: Gem for finding the next banking date
 test_files:
-- test/bank_day_helper_test.rb
+- test/ae_bank_days/bank_day_helper_test.rb
+- test/ae_bank_days_test.rb
+- test/test_helper.rb

data/test/bank_day_helper_test.rb

@@ -1,87 +0,0 @@
-# frozen_string_literal: true
-
-require 'minitest/autorun'
-require 'ae_bank_days'
-
-module AeBankDays
-  class BankDayHelperTest < ActiveSupport::TestCase
-    def test_constant
-      refute AeBankDays::BankDayHelper::HOLIDAYS.empty?
-    end
-
-    def test_bank_day__weekday
-      time = Time.parse('2017-10-03 14:30:45 -0500')
-      assert AeBankDays::BankDayHelper.bank_day?(time.to_date)
-    end
-
-    def test_bank_day__weekend
-      time = Time.parse('2017-10-14 14:30:45 -0500')
-      refute AeBankDays::BankDayHelper.bank_day?(time.to_date)
-    end
-
-    def test_bank_day__holiday
-      time = Time.parse('2017-10-09 14:30:45 -0500')
-      refute AeBankDays::BankDayHelper.bank_day?(time.to_date)
-    end
-
-    def test_next_banking_day__weekday
-      time = Time.parse('2017-10-03 14:30:45 -0500')
-      assert_equal Date.parse('2017-10-03'), AeBankDays::BankDayHelper.next_banking_day(time.to_date)
-    end
-
-    def test_next_banking_day__weekday__extra_days
-      time = Time.parse('2017-10-03 14:30:45 -0500')
-      assert_equal Date.parse('2017-10-06'), AeBankDays::BankDayHelper.next_banking_day(time.to_date, number_of_days: 3)
-    end
-
-    def test_next_banking_day__weekend
-      time = Time.parse('2017-10-14 14:30:45 -0500')
-      assert_equal Date.parse('2017-10-16'), AeBankDays::BankDayHelper.next_banking_day(time.to_date)
-    end
-
-    def test_next_banking_day__weekend__extra_days
-      time = Time.parse('2017-10-14 14:30:45 -0500')
-      assert_equal Date.parse('2017-10-19'), AeBankDays::BankDayHelper.next_banking_day(time.to_date, number_of_days: 3)
-    end
-
-    def test_next_banking_day__holiday
-      time = Time.parse('2017-10-09 14:30:45 -0500')
-      assert_equal Date.parse('2017-10-10'), AeBankDays::BankDayHelper.next_banking_day(time.to_date)
-    end
-
-    def test_next_banking_day__holiday__extra_days
-      time = Time.parse('2017-10-09 14:30:45 -0500')
-      assert_equal Date.parse('2017-10-13'), AeBankDays::BankDayHelper.next_banking_day(time.to_date, number_of_days: 3)
-    end
-
-    def test_previous_banking_day__weekday
-      time = Time.parse('2017-10-03 14:30:45 -0500')
-      assert_equal Date.parse('2017-10-03'), AeBankDays::BankDayHelper.previous_banking_day(time.to_date)
-    end
-
-    def test_previous_banking_day__weekday__extra_days
-      time = Time.parse('2017-10-06 14:30:45 -0500')
-      assert_equal Date.parse('2017-10-03'), AeBankDays::BankDayHelper.previous_banking_day(time.to_date, number_of_days: 3)
-    end
-
-    def test_previous_banking_day__weekend
-      time = Time.parse('2017-10-14 14:30:45 -0500')
-      assert_equal Date.parse('2017-10-13'), AeBankDays::BankDayHelper.previous_banking_day(time.to_date)
-    end
-
-    def test_previous_banking_day__weekend__extra_days
-      time = Time.parse('2017-10-14 14:30:45 -0500')
-      assert_equal Date.parse('2017-10-10'), AeBankDays::BankDayHelper.previous_banking_day(time.to_date, number_of_days: 3)
-    end
-
-    def test_previous_banking_day__holiday
-      time = Time.parse('2017-10-09 14:30:45 -0500')
-      assert_equal Date.parse('2017-10-06'), AeBankDays::BankDayHelper.previous_banking_day(time.to_date)
-    end
-
-    def test_previous_banking_day__holiday__extra_days
-      time = Time.parse('2017-10-09 14:30:45 -0500')
-      assert_equal Date.parse('2017-10-03'), AeBankDays::BankDayHelper.previous_banking_day(time.to_date, number_of_days: 3)
-    end
-  end
-end