adzerk 0.9 → 0.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 6ba4b853cea1aba9150e437e7360604d3791bcc7
-  data.tar.gz: 3f3ca3a7026b66061257b2958411f6e1cc7184a6
+SHA256:
+  metadata.gz: dfcb33e06a66b4728d0a27e69c41a240a3d3f73ce3af93056fdbb794e6b1361c
+  data.tar.gz: d6b9c3113f6120d074a517643a56fb4cb1fc2b98b98abe016cb31cbebcadad32
 SHA512:
-  metadata.gz: 144f5a632d83d075c45f9f05e103fce634531a1b4a8c806bc1a25d30a73763fdde47133023401ae9ac74dab1a3432beb5996984fd4174fef1505b733f94020f9
-  data.tar.gz: adcb50f27f01290bbd7c0a6e3401a8b9d58491af62fa3aaf29584924518c6eb32b9f291ac6e11a27af135424a0fb1d74c41323716b12dca61a744e924d2dfb5d
+  metadata.gz: f549e8160c19e563cdb4aa4c54b085a833b62b6588227c2540f7e58471805ed88f79680f3d3a32c125639e98a7502b55fe9dee2b4736c560322a10ef5aa5aa61
+  data.tar.gz: 2be8a73fb39675f73bd02e13ddd6165f2402005b561b03ab94cf546fd4702c8fcf5105b1240cd7b0a8b71dcb214064764e6d7ce249bee12f2e87d7947533ceaa

data/lib/adzerk/client.rb

@@ -63,16 +63,17 @@ module Adzerk
     def create_creative(data={}, image_path='')
       response = RestClient.post(@config[:host] + 'creative',
                                  {:creative => camelize_data(data).to_json},
-                                 :X_Adzerk_ApiKey => @api_key,
-                                 :content_type => :json,
-                                 :accept => :json)
+                                  :X_Adzerk_ApiKey => @api_key,
+                                  :accept => :json)
       response = upload_creative(JSON.parse(response)["Id"], image_path) unless image_path.empty?
       response
     end
 
-    def upload_creative(id, image_path)
+    def upload_creative(id, image_path, size_override: false)
       image = File.new(image_path, 'rb')
-      RestClient.post(@config[:host] + 'creative/' + id.to_s + '/upload',
+      url = @config[:host] + 'creative/' + id.to_s + '/upload'
+      url += '?sizeOverride=true' if size_override
+      RestClient.post(url,
       {:image => image},
       "X-Adzerk-ApiKey" => @api_key,
       :accept => :mime)
@@ -82,9 +83,10 @@ module Adzerk
       http = Net::HTTP.new(uri.host, uri.port)
       http.use_ssl = uri.scheme == 'https'
       response = http.request(request)
-      if response.kind_of? Net::HTTPClientError
+      if response.kind_of? Net::HTTPClientError or response.kind_of? Net::HTTPServerError
         error_response = JSON.parse(response.body)
-        raise Adzerk::ApiError.new(error_response["message"])
+        msg = error_response["message"] || error_response["Error"]
+        raise Adzerk::ApiError.new(msg)
       end
       response
     end

data/lib/adzerk/version.rb

@@ -1,3 +1,3 @@
 module Adzerk
-  VERSION = "0.9"
+  VERSION = "0.14"
 end

data/test/campaign_api_spec.rb

@@ -73,7 +73,8 @@ describe "Campaign API" do
       :name => "Test",
       :priority_id => $priority_id,
       :impressions => 10000,
-      :is_deleted => false
+      :is_deleted => false,
+      :goal_type => 1
     }]
     new1_campaign = {
       :name => $campaign_name,
@@ -88,8 +89,6 @@ describe "Campaign API" do
     campaign = @campaigns.create(new1_campaign)
     $campaign_id_1 = campaign[:id].to_s
     expect($campaign_name).to eq(campaign[:name])
-    # JSON.parse(response.body)["StartDate"].should == "/Date(1293858000000-0500)/"
-    # JSON.parse(response.body)["EndDate"].should == "/Date(1325307600000-0500)/"
     expect($campaign_is_active).to eq(campaign[:is_active])
     expect(campaign[:is_deleted]).to eq(false)
     expect($campaign_price.to_f).to eq(campaign[:price])
@@ -154,7 +153,9 @@ describe "Campaign API" do
     }
 
     expect{ @campaigns.create(new_campaign) }.to raise_error("This advertiser is not part of your network")
+  end
 
+  it "should not update a campaign with a new advertiserId" do
     updated_campaign = {
       :id => $campaign_id,
       :name => 'Test campaign ' + rand(1000000).to_s,
@@ -167,7 +168,7 @@ describe "Campaign API" do
       :is_deleted => false
     }
 
-    expect{ @campaigns.update(updated_campaign) }.to raise_error("This advertiser is not part of your network")
+    expect{ @campaigns.update(updated_campaign) }.to raise_error("This campaign belongs to advertiser #{$advertiserId}; a different advertiser cannot be specified.")
   end
 
   it "should not retrieve a campaign with a advertiserId that doesn't belong to it" do

data/test/category_api_spec.rb

@@ -46,7 +46,6 @@ describe "Category API" do
       :name => 'Test flight ' + rand(1000000).to_s,
       :start_date => "1/1/2011",
       :end_date => "12/31/2011",
-      :no_end_date => false,
       :price => '15.00',
       :option_type => 1,
       :impressions => 10000,

data/test/creative_map_api_spec.rb

@@ -332,7 +332,7 @@ describe "Creative Flight API" do
   end
 
   it "should not get a map in a different network" do
-    expect{ @creative_maps.get(123, @flight_id) }.to raise_error "This PassCreativeMap does not belong to your network."
+    expect{ @creative_maps.get(123, @flight_id) }.to raise_error Adzerk::ApiError
   end
 
   it "should get a map that's been deleted" do
@@ -382,37 +382,6 @@ describe "Creative Flight API" do
     }.to raise_error "This creative map has been deleted"
   end
 
-  it "should fail when creating a map for a campaign in a different network" do
-    expect {
-      creative_map = @creative_maps.create(
-        :campaign_id => 123,
-        :flight_id => @flight_id,
-        :size_override => false,
-        :iframe => false,
-        :impressions => 100000,
-        :percentage => 50,
-        :siteId => @site_id,
-        :zoneId => @zone_id,
-        :distributionType => 1,
-        :isActive => true,
-        :isDeleted => false,
-        :creative => {
-          :title => "Creative Title",
-          :url => "http://www.adzerk.com",
-          :body => "Test Body",
-          :advertiser_id => @advertiser_id,
-          :ad_type_id => 18,
-          'IsHTMLJS' => true,
-          :script_body => "<html></html>",
-          :is_active => true,
-          :alt => "alt text",
-          :is_deleted => false,
-          :is_sync => false
-        }
-      )
-    }.to raise_error "This campaign is not part of your network"
-  end
-
   it "should fail when creating a map for a site in a different network" do
     expect {
       creative_map = @creative_maps.create(

data/test/flight_api_spec.rb

@@ -66,7 +66,6 @@ describe "Flight API" do
     $flight_GoalType = 1
 
     new_flight = {
-      :no_end_date => false,
       :priority_id => $priority_id,
       :name => $flight_Name,
       :start_date => $flight_StartDate,
@@ -110,7 +109,6 @@ describe "Flight API" do
 
   it "should fail to create a flight without a goal type" do
     flight_without_goal_type = {
-      :no_end_date => false,
       :priority_id => $priority_id,
       :name => $flight_Name,
       :start_date => $flight_StartDate,
@@ -161,7 +159,8 @@ describe "Flight API" do
                              :start_date => $flight_StartDate,
                              :goal_type => $flight_GoalType,
                              :impressions => $flight_Impressions,
-                             :is_companion => false)
+                             :is_companion => false,
+                             :end_date => $flight_EndDate)
     expect(flight[:name]).to eq("New Flight Name")
     expect(flight[:is_companion]).to be false
   end
@@ -184,7 +183,6 @@ describe "Flight API" do
     }]
 
     new_flight = {
-      'NoEndDate' => false,
       'PriorityId' => $priority_id,
       'Name' => $flight_Name,
       'StartDate' => $flight_StartDate,
@@ -232,7 +230,6 @@ describe "Flight API" do
   it "should not create a flight for a campaign in a different network" do
     expect {
       @flights.create(
-        :no_end_date => false,
         :priority_id => $priority_id,
         :name => $flight_Name,
         :start_date => $flight_StartDate,

data/test/geo_targeting_api_spec.rb

@@ -38,7 +38,6 @@ describe "GeoTargeting API" do
     $campaign_id = campaign[:id]
 
     new_flight = {
-      :no_end_date => false,
       :priority_id => $priority_id,
       :name => 'Test flight ' + rand(1000000).to_s,
       :start_date => "1/1/2011",

data/test/login_api_spec.rb

@@ -1,5 +1,9 @@
 require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 
+def random_email
+  "test@email-#{rand(1000000)}.com"
+end
+
 describe "Login_API" do
 
   before do
@@ -7,13 +11,14 @@ describe "Login_API" do
   end
 
   it "should create a new login" do
-    email = "test@email_#{rand(1000000)}.com"
+    email = random_email()
     login = @logins.create(:email => email,
                            :password => '1234567',
                            :name => "John Doe")
     $login_id = login[:id]
     expect(login[:email]).to eq(email)
-    expect(login[:password]).to eq("1234567")
+    # Password is redacted in the response.
+    expect(login[:password]).to eq("")
     expect(login[:name]).to eq("John Doe")
   end
 
@@ -28,9 +33,12 @@ describe "Login_API" do
   end
 
   it "should update a login" do
+    new_email = random_email()
     login = @logins.update(:id => $login_id,
-                           :name => "New Name")
+                           :name => "New Name",
+                           :email => new_email)
     expect(login[:name]).to eq("New Name")
+    expect(login[:email]).to eq(new_email)
   end
 
 end

data/test/priority_api_spec.rb

@@ -63,7 +63,7 @@ describe "Priority API" do
   end
 
   it "should not allow selection algorithm to be updated" do
-    expect { @priorities.update(selection_algorithm: 1) }.to raise_error
+    expect { @priorities.update(selection_algorithm: 1) }.to raise_error JSON::ParserError
   end
 
   it "should list all priorities" do

data/test/report_api_spec.rb

@@ -6,7 +6,7 @@ describe "Report API" do
     @reports = Adzerk::Client.new(API_KEY).reports
 
     $new_report = {
-      :start_date => "1/15/2011",
+      :start_date => "01/15/2011",
       :end_date => "12/31/2011",
       :group_by => ['month'],
       'Top30countries' => false,
@@ -16,8 +16,8 @@ describe "Report API" do
     }
   end
 
-  it "should create a report within 20 seconds" do
-    report = @reports.create_report($new_report, 20000)
+  it "should create a report within 60 seconds" do
+    report = @reports.create_report($new_report, 60000)
     expect(report.has_key? :report_id).to be true
     expect(report[:is_total]).to be true
     # expect(report[:grouping]).to eq ["month"]
@@ -36,7 +36,7 @@ describe "Report API" do
   end
 
   it "should return a status of 1 if the report isn't ready yet" do
-    bigger_report = $new_report.update(start_date: "1/1/2014", end_date: "10/1/2018")
+    bigger_report = $new_report.update(start_date: "01/01/2014", end_date: "10/01/2018")
     report_id = @reports.create_queued_report(bigger_report)[:id]
     # immediately poll for the result
     response = @reports.retrieve_queued_report(report_id)

data/test/site_zone_targeting_api_spec.rb

@@ -41,7 +41,6 @@ describe "SiteZoneTargeting API" do
     $campaign_id = campaign[:id]
 
     new_flight = {
-      :no_end_date => false,
       :priority_id => $priority_id,
       :name => 'Test flight ' + rand(1000000).to_s,
       :start_date => "1/1/2011",

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: adzerk
 version: !ruby/object:Gem::Version
-  version: '0.9'
+  version: '0.14'
 platform: ruby
 authors:
 - Kacy Fortner
@@ -17,7 +17,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-08 00:00:00.000000000 Z
+date: 2020-07-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -25,56 +25,70 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.11.0
+        version: 3.5.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.11.0
+        version: 3.5.0
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 12.3.3
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 12.3.3
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.7.7
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.7.7
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rest-client
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.6.9
+        version: 2.0.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.6.9
+        version: 2.0.1
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.2.8
+        version: '5.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.2.8
+        version: '5.1'
 description: Ruby library for the Adzerk API
 email: engineering@adzerk.com
 executables: []
@@ -122,7 +136,8 @@ files:
 - test/util_spec.rb
 - test/zone_api_spec.rb
 homepage: http://adzerk.com
-licenses: []
+licenses:
+- Apache-2.0
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -130,17 +145,16 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Adzerk API