adzerk 0.6 → 0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2321c22990edc573c0f196b4bd595cfe062e868c
-  data.tar.gz: 3587892f9b11c5247d9e12fadbcd13e8a6af1597
+  metadata.gz: 4f9eeda38a1912464c7c167aed5d8062aa963435
+  data.tar.gz: e9bca2b96e673c63b0a04102240c00b344db1c88
 SHA512:
-  metadata.gz: 945e89da810227bef4377774ea0381192b745ce63bc63f2faf8604e6c61262a15264f3afe83baa6f95c6f4738b6b07d9d31a94b8f1f62af8a3238545a41dbb6e
-  data.tar.gz: ce30494b990b2bf3f1c0bdb80b2c67d81f5d31c67ba70812ab427a63c97441ac3ae49ddff83f3dbb41822e2a8cdc2a4a3f5c9bf2900f4f0ce75f4b58f0a7d7b0
+  metadata.gz: 1daf84e4c11e7de52c1af713dd37f2d1e7516bdaa17eb7266ae71f0d4809fe449d165e15f8281d1facd4ac3961a5a8923dc5950d639a144eab18eb3756b68beb
+  data.tar.gz: 1608cdcb6d58afbf4a957d23747d276aa4709aee2bbd7f9c67f11c9a2dbefc0ed4f54e02f1831b9b946df3dacd80fd0e4763a9e540c01bfa7d16f1b90259a011

data/lib/adzerk/client.rb

@@ -9,7 +9,7 @@ module Adzerk
                 :logins, :geotargetings, :sitezonetargetings, :categories
 
     DEFAULTS = {
-      :host => ENV["ADZERK_API_HOST"] || 'http://api.adzerk.net/v1/',
+      :host => ENV["ADZERK_API_HOST"] || 'https://api.adzerk.net/v1/',
       :header => 'X-Adzerk-ApiKey'
     }
 
@@ -60,11 +60,11 @@ module Adzerk
       send_request(request, uri)
     end
 
-    def create_creative(data={}, image_path='')      
+    def create_creative(data={}, image_path='')
       response = RestClient.post(@config[:host] + 'creative',
                                  {:creative => camelize_data(data).to_json},
                                  :X_Adzerk_ApiKey => @api_key,
-                                 :content_type => :json, 
+                                 :content_type => :json,
                                  :accept => :json)
       response = upload_creative(JSON.parse(response)["Id"], image_path) unless image_path.empty?
       response
@@ -80,6 +80,7 @@ module Adzerk
 
     def send_request(request, uri)
       http = Net::HTTP.new(uri.host, uri.port)
+      http.use_ssl = uri.scheme == 'https'
       response = http.request(request)
       if response.kind_of? Net::HTTPClientError
         error_response = JSON.parse(response.body)

data/lib/adzerk/version.rb

@@ -1,3 +1,3 @@
 module Adzerk
-  VERSION = "0.6"
+  VERSION = "0.7"
 end

data/test/adtype_api_spec.rb

@@ -49,6 +49,7 @@ describe "Ad Type API" do
   end
 
   it "should delete ad type for channel" do
+    $ad_type_channel_id = @client.channels.list[:items].last[:id].to_s
     @client.ad_types.delete($ad_type_channel_id, $channel_id)
   end
 end

data/test/advertiser_api_spec.rb

@@ -62,8 +62,9 @@ describe "Advertiser API" do
     end
   end
 
-  it "should not get individual deleted advertiser" do
-    expect { @advertisers.get $advertiser_id }.to raise_error("This advertiser is deleted.")
+  it "should get individual deleted advertiser" do
+    advertiser = @advertisers.get $advertiser_id
+    expect(advertiser[:is_deleted]).to eq(true)
   end
 
   it "should not update a deleted advertiser" do

data/test/category_api_spec.rb

@@ -86,8 +86,8 @@ describe "Category API" do
   end
 
   it "should list categories for the current network" do
-    cat = @category.listAll()[:items].last
-    expect(cat[:name]).to eq($category_name)
+    cats = @category.listAll()[:items].select { |x| x[:name] == $category_name }
+    expect(cats.count).to eq(1)
   end
 
   it "should delete a category from a flight" do

data/test/channel_api_spec.rb

@@ -82,8 +82,9 @@ describe "Channel API" do
     expect(response.body).to eq('"Successfully deleted"')
   end
 
-  it "should not get individual deleted channel" do
-    expect{ @channels.get($channel_id) }.to raise_error 'This channel has been deleted'
+  it "should get individual deleted channel" do
+    channel = @channels.get $channel_id
+    expect(channel[:is_deleted]).to eq(true)
   end
 
   it "should not update deleted channels" do

data/test/creative_map_api_spec.rb

@@ -327,8 +327,9 @@ describe "Creative Flight API" do
     expect{ @creative_maps.get(123, @flight_id) }.to raise_error "This flight is not part of your network"
   end
 
-  it "should not get a map that's been deleted" do
-    expect{ @creative_maps.get($map_id, @flight_id) }.to raise_error "This creative map has been deleted"
+  it "should get a map that's been deleted" do
+    map = @creative_maps.get($map_id, @flight_id)
+    expect(map[:is_deleted]).to eq(true)
   end
 
   it "should not update a map that's in a different network" do

data/test/flight_api_spec.rb

@@ -154,6 +154,7 @@ describe "Flight API" do
                              :priority_id => $priority_id,
                              :start_date => $flight_StartDate,
                              :goal_type => $flight_GoalType,
+                             :impressions => $flight_Impressions,
                              :is_companion => false)
     expect(flight[:name]).to eq("New Flight Name")
     expect(flight[:is_companion]).to be false

data/test/report_api_spec.rb

@@ -36,7 +36,7 @@ describe "Report API" do
   end
 
   it "should return a status of 1 if the report isn't ready yet" do
-    bigger_report = $new_report.update(start_date: "1/1/2010", end_date: "10/1/2014")
+    bigger_report = $new_report.update(start_date: "1/1/2014", end_date: "10/1/2018")
     report_id = @reports.create_queued_report(bigger_report)[:id]
     # immediately poll for the result
     response = @reports.retrieve_queued_report(report_id)

data/test/security_api_spec.rb

@@ -6,6 +6,7 @@ describe "Channel API security" do
   it "should reject unauthenticated GET requests" do
     uri = URI.parse(API_HOST + 'channel/')
     http = Net::HTTP.new(uri.host, uri.port)
+    http.use_ssl = uri.scheme == 'https'
     request = Net::HTTP::Get.new(uri.request_uri)
     expect(http.request(request).response.code).not_to eq(200)
   end
@@ -13,6 +14,7 @@ describe "Channel API security" do
   it "should reject GET requests with null API keys" do
     uri = URI.parse(API_HOST + 'channel/')
     http = Net::HTTP.new(uri.host, uri.port)
+    http.use_ssl = uri.scheme == 'https'
     request = Net::HTTP::Get.new(uri.request_uri)
     request.add_field "X-Adzerk-ApiKey", ""
     expect(http.request(request).response.code).not_to eq(200)

data/test/spec_helper.rb

@@ -7,7 +7,7 @@ require "adzerk"
 API_KEY = ENV['ADZERK_API_KEY']
 raise "The ADZERK_API_KEY environment variable must be set." unless API_KEY
 
-API_HOST = ENV['ADZERK_API_HOST'] || 'http://api.adzerk.net/v1/'
+API_HOST = ENV['ADZERK_API_HOST'] || 'https://api.adzerk.net/v1/'
 # $adzerk = Adzerk.new(API_KEY)
 
 RSpec.configure do |config|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: adzerk
 version: !ruby/object:Gem::Version
-  version: '0.6'
+  version: '0.7'
 platform: ruby
 authors:
 - Kacy Fortner
@@ -17,7 +17,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-22 00:00:00.000000000 Z
+date: 2016-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -82,45 +82,45 @@ extensions: []
 extra_rdoc_files: []
 files:
 - lib/adzerk.rb
-- lib/adzerk/version.rb
-- lib/adzerk/site_zone_targeting.rb
-- lib/adzerk/creative.rb
-- lib/adzerk/geo_targeting.rb
 - lib/adzerk/advertiser.rb
-- lib/adzerk/invitation.rb
-- lib/adzerk/client.rb
-- lib/adzerk/flight.rb
-- lib/adzerk/util.rb
-- lib/adzerk/category.rb
 - lib/adzerk/api_endpoint.rb
+- lib/adzerk/category.rb
 - lib/adzerk/channel_site_map.rb
+- lib/adzerk/client.rb
+- lib/adzerk/creative.rb
 - lib/adzerk/creative_map.rb
-- lib/adzerk/reporting.rb
-- lib/adzerk/publisher.rb
 - lib/adzerk/errors.rb
+- lib/adzerk/flight.rb
+- lib/adzerk/geo_targeting.rb
+- lib/adzerk/invitation.rb
 - lib/adzerk/priority.rb
-- test/site_zone_targeting_api_spec.rb
-- test/spec_helper.rb
-- test/zone_api_spec.rb
-- test/channel_site_map_api_spec.rb
-- test/creative_api_spec.rb
-- test/advertiser_api_spec.rb
+- lib/adzerk/publisher.rb
+- lib/adzerk/reporting.rb
+- lib/adzerk/site_zone_targeting.rb
+- lib/adzerk/util.rb
+- lib/adzerk/version.rb
 - test/adtype_api_spec.rb
+- test/advertiser_api_spec.rb
 - test/campaign_api_spec.rb
 - test/category_api_spec.rb
-- test/security_api_spec.rb
-- test/login_api_spec.rb
-- test/creative_map_api_spec.rb
 - test/channel_api_spec.rb
-- test/rakefile.rb
+- test/channel_site_map_api_spec.rb
+- test/creative_api_spec.rb
+- test/creative_map_api_spec.rb
 - test/flight_api_spec.rb
-- test/site_api_spec.rb
-- test/priority_api_spec.rb
+- test/geo_targeting_api_spec.rb
 - test/invitation_api_spec.rb
+- test/login_api_spec.rb
+- test/priority_api_spec.rb
+- test/publisher_api_spec.rb
+- test/rakefile.rb
 - test/report_api_spec.rb
+- test/security_api_spec.rb
+- test/site_api_spec.rb
+- test/site_zone_targeting_api_spec.rb
+- test/spec_helper.rb
 - test/util_spec.rb
-- test/geo_targeting_api_spec.rb
-- test/publisher_api_spec.rb
+- test/zone_api_spec.rb
 homepage: http://adzerk.com
 licenses: []
 metadata: {}
@@ -140,7 +140,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: Adzerk API