adzerk 0.4 → 0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c665786700652cfe78709f0f64edb8e33a18bdc0
-  data.tar.gz: 25d623fe18b1754b64ead8d06067ed9707fc5daf
+  metadata.gz: b9b0de334492f30ebc133781cae4adbd34ba6879
+  data.tar.gz: 7b60133c1cb10c5adafad6cd6ce32a5f8f20b77f
 SHA512:
-  metadata.gz: 398edffd5fd4cf6e1e16bac11a7acfe9cb5958aa2c734a02bfe6dd429a431bcb48000d09821dd40a7778d8ea12c6fa99f29dfd6c2bb84733b1769394310e92ee
-  data.tar.gz: 22e1343320f3228ac3002cb96cd54630b1f714f1bafc35007d4631364ef75ace5c59c08d8ff81c604dc5c209fe6ca24895f6b97d601848973095de3d318724d0
+  metadata.gz: cffc3e1988161f9a52c78e88da13c2cc0991db3ae794533bd8acbaaaf7e0d1607a7dd6f64272ea51d7d7be6b456a20fc7a016381edfaa790503c42dfc740422f
+  data.tar.gz: 1e10384ba550636c69fcd08c65744053bf1e5ea86e98c5d2ac11ca3574ff2f5626616e24c0ede2bb3662c2ff729e2c135cab9f0047d8da1575369353ee24414d

data/lib/adzerk.rb

@@ -17,3 +17,4 @@ require "adzerk/geo_targeting"
 require "adzerk/site_zone_targeting"
 require "adzerk/category"
 require "adzerk/client"
+require "adzerk/priority"

data/lib/adzerk/client.rb

@@ -22,7 +22,7 @@ module Adzerk
       @zones = Adzerk::ApiEndpoint.new(:client => self, :endpoint => 'zone')
       @campaigns = Adzerk::ApiEndpoint.new(:client => self, :endpoint => 'campaign')
       @channels = Adzerk::ApiEndpoint.new(:client => self, :endpoint => 'channel')
-      @priorities = Adzerk::ApiEndpoint.new(:client => self, :endpoint => 'priority')
+      @priorities = Adzerk::Priority.new(:client => self, :endpoint => 'priority')
       @advertisers = Adzerk::Advertiser.new(:client => self, :endpoint => 'advertiser')
       @publishers = Adzerk::Publisher.new(:client => self, :endpoint => 'publisher')
       @creatives = Adzerk::Creative.new(:client => self, :endpoint => 'creative')

data/lib/adzerk/priority.rb

@@ -0,0 +1,8 @@
+module Adzerk
+  class Priority < ApiEndpoint
+    def create(opts={})
+      opts[:selection_algorithm] ||= 0 # SelectionAlgorithm defaults to 0 (Lottery)
+      super opts
+    end
+  end
+end

data/lib/adzerk/version.rb

@@ -1,3 +1,3 @@
 module Adzerk
-  VERSION = "0.4"
+  VERSION = "0.5"
 end

data/test/creative_map_api_spec.rb

@@ -85,6 +85,7 @@ describe "Creative Flight API" do
     $DistributionType = 1
     $IsMapActive = true
     $IsMapDeleted = false
+    $CustomTargeting = '$keywords contains "bjork"'
     
     $Title = 'Test creative ' + rand(1000000).to_s
     $Url = "http://adzerk.com"
@@ -111,6 +112,7 @@ describe "Creative Flight API" do
       :distributionType => $DistributionType,
       :isActive => $IsMapActive,
       :isDeleted => $IsMapDeleted,
+      :custom_targeting => $CustomTargeting,
       :creative => {
         :title => $Title,
         :url => $Url,
@@ -139,6 +141,7 @@ describe "Creative Flight API" do
     expect(creative_map[:distribution_type]).to eq($DistributionType)
     expect(creative_map[:is_active]).to eq($IsMapActive)
     expect(creative_map[:is_deleted]).to eq($IsMapDeleted)
+    expect(creative_map[:custom_targeting]).to eq($CustomTargeting)
 
     expect(creative_map[:creative][:title]).to eq($Title)
     expect(creative_map[:creative][:url]).to eq($Url)
@@ -169,6 +172,7 @@ describe "Creative Flight API" do
     expect(creative_map[:distribution_type]).to eq($DistributionType)
     expect(creative_map[:is_active]).to eq($IsMapActive)
     expect(creative_map[:is_deleted]).to eq($IsMapDeleted)
+    expect(creative_map[:custom_targeting]).to eq($CustomTargeting)
 
     expect(creative_map[:creative][:title]).to eq($Title)
     expect(creative_map[:creative][:url]).to eq($Url)
@@ -195,6 +199,7 @@ describe "Creative Flight API" do
     expect(creative_map[:distribution_type]).to eq($DistributionType)
     expect(creative_map[:is_active]).to eq($IsMapActive)
     expect(creative_map[:is_deleted]).to eq($IsMapDeleted)
+    expect(creative_map[:custom_targeting]).to eq($CustomTargeting)
 
     expect(creative_map[:creative][:title]).to eq($Title)
     expect(creative_map[:creative][:url]).to eq($Url)

data/test/flight_api_spec.rb

@@ -2,7 +2,6 @@ require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 
 describe "Flight API" do
 
-
   before(:all) do
     new_advertiser = {
       'Title' => "Test"
@@ -80,11 +79,12 @@ describe "Flight API" do
       :campaign_id => $flight_CampaignId,
       :is_active => $flight_IsActive,
       :is_deleted => $flight_IsDeleted,
-      :goal_type => $flight_GoalType
+      :goal_type => $flight_GoalType,
+      :is_companion => true
     }
     flight = @flights.create(new_flight)
     $flight_id = flight[:id].to_s
-    expect(flight[:no_end_date]).to eq(false)
+    expect(flight[:no_end_date]).to be false
     expect(flight[:priority_id]).to eq($priority_id.to_i)
     expect(flight[:name]).to eq($flight_Name)
     # JSON.parse(response.body)["StartDate"].should == "/Date(1293840000000+0000)/"
@@ -101,6 +101,31 @@ describe "Flight API" do
     expect(flight[:is_active]).to eq($flight_IsActive)
     expect(flight[:is_deleted]).to eq($flight_IsDeleted)
     expect(flight[:goal_type]).to eq($flight_GoalType)
+    expect(flight[:is_companion]).to be true
+  end
+
+  it "should fail to create a flight without a goal type" do
+    flight_without_goal_type = {
+      :no_end_date => false,
+      :priority_id => $priority_id,
+      :name => $flight_Name,
+      :start_date => $flight_StartDate,
+      :end_date => $flight_EndDate,
+      :no_end_date => $flight_NoEndDate,
+      :price => $flight_Price,
+      :option_type => $flight_OptionType,
+      :impressions => $flight_Impressions,
+      :is_unlimited => $flight_IsUnlimited,
+      :is_full_speed => $flight_IsFullSpeed,
+      :keywords => $flight_Keywords,
+      :user_agent_keywords => $flight_UserAgentKeywords,
+      :weight_override => $flight_WeightOverride,
+      :campaign_id => $flight_CampaignId,
+      :is_active => $flight_IsActive,
+      :is_deleted => $flight_IsDeleted
+    }
+
+    expect { @flights.create flight_without_goal_type }.to raise_error
   end
 
   it "should list a specific flight" do
@@ -119,6 +144,7 @@ describe "Flight API" do
     expect(flight[:is_active]).to eq($flight_IsActive)
     expect(flight[:is_deleted]).to eq($flight_IsDeleted)
     expect(flight[:goal_type]).to eq($flight_GoalType)
+    expect(flight[:is_companion]).to be true
   end
 
   it "should update a flight" do
@@ -127,8 +153,10 @@ describe "Flight API" do
                              :name => "New Flight Name",
                              :priority_id => $priority_id,
                              :start_date => $flight_StartDate,
-                             :goal_type => $flight_GoalType)
+                             :goal_type => $flight_GoalType,
+                             :is_companion => false)
     expect(flight[:name]).to eq("New Flight Name")
+    expect(flight[:is_companion]).to be false
   end
 
   it "should list all flights" do

data/test/login_api_spec.rb

@@ -1,9 +1,7 @@
 require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 
 describe "Login_API" do
-
-  puts ENV['ADZERK_API_KEY']
-
+  
   before do
     @logins = Adzerk::Client.new(API_KEY).logins
   end

data/test/priority_api_spec.rb

@@ -31,6 +31,7 @@ describe "Priority API" do
     expect($priority_channel_id.to_f).to eq(priority[:channel_id])
     expect($priority_weight).to eq(priority[:weight])
     expect($priority_is_deleted).to eq(priority[:is_deleted])
+    expect(priority[:selection_algorithm]).to eq(0) # default (Lottery)
   end
 
   it "should list a specific priority" do
@@ -39,7 +40,7 @@ describe "Priority API" do
     expect($priority_channel_id.to_f).to eq(priority[:channel_id])
     expect($priority_weight).to eq(priority[:weight])
     expect($priority_is_deleted).to eq(priority[:is_deleted])
-    priority = @priorities.get($priority_id)
+    expect(priority[:selection_algorithm]).to eq(0)
   end
 
   it "should update a priority" do
@@ -54,6 +55,11 @@ describe "Priority API" do
     expect($priority_channel_id.to_f).to eq(priority[:channel_id])
     expect(priority[:weight]).to eq(2)
     expect($priority_is_deleted).to eq(priority[:is_deleted])
+    expect(priority[:selection_algorithm]).to eq(0)
+  end
+
+  it "should not allow selection algorithm to be updated" do
+    expect { @priorities.update(selection_algorithm: 1) }.to raise_error
   end
 
   it "should list all priorities" do
@@ -65,6 +71,7 @@ describe "Priority API" do
     expect($priority_channel_id.to_f).to eq(priority[:channel_id])
     expect(priority[:weight]).to eq(2)
     expect($priority_is_deleted).to eq(priority[:is_deleted])
+    expect(priority[:selection_algorithm]).to eq(0)
   end
 
   it "should delete a new priority" do

data/test/spec_helper.rb

@@ -4,8 +4,10 @@ require "net/http"
 $:.push File.expand_path("../lib", __FILE__)
 require "adzerk"
 
-API_KEY = ENV['ADZERK_API_KEY'] || 'your_api_key'
-API_HOST = ENV["ADZERK_API_HOST"] || 'http://api.adzerk.net/v1/'
+API_KEY = ENV['ADZERK_API_KEY']
+raise "The ADZERK_API_KEY environment variable must be set." unless API_KEY
+
+API_HOST = ENV['ADZERK_API_HOST'] || 'http://api.adzerk.net/v1/'
 # $adzerk = Adzerk.new(API_KEY)
 
 RSpec.configure do |config|

metadata

@@ -1,14 +1,22 @@
 --- !ruby/object:Gem::Specification
 name: adzerk
 version: !ruby/object:Gem::Version
-  version: '0.4'
+  version: '0.5'
 platform: ruby
 authors:
 - Kacy Fortner
+- James Jeffers
+- James Avery
+- Nate Kohari
+- Rafael Chacon
+- Sean Chaney
+- Brec Carson
+- Sam Lehman
+- Dave Yarwood
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-19 00:00:00.000000000 Z
+date: 2015-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -67,7 +75,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 3.2.8
 description: Ruby library for the Adzerk API
-email: kacy@adzerk.com
+email: engineering@adzerk.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -84,6 +92,7 @@ files:
 - lib/adzerk/flight.rb
 - lib/adzerk/geo_targeting.rb
 - lib/adzerk/invitation.rb
+- lib/adzerk/priority.rb
 - lib/adzerk/publisher.rb
 - lib/adzerk/reporting.rb
 - lib/adzerk/site_zone_targeting.rb
@@ -130,7 +139,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: Adzerk API