adzerk 0.1.4 → 0.2

data/test/creative_map_api_spec.rb

@@ -1,97 +1,79 @@
-require './spec_helper'
+require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 
 describe "Creative Flight API" do
-  
-  $creative_url = 'http://www.adzerk.com'
-  @@map = $adzerk::CreativeMap.new
-  @@creative = $adzerk::Creative.new
-  @@advertiser = $adzerk::Advertiser.new
-  @@channel = $adzerk::Channel.new
-  @@campaign = $adzerk::Campaign.new
-  @@site = $adzerk::Site.new
-  @@flight = $adzerk::Flight.new
-  @@priority = $adzerk::Priority.new
-  @@zone = $adzerk::Zone.new
-  
+
+
   before(:all) do
-    new_advertiser = {
-      'Title' => "Test"
-    }
-    response = @@advertiser.create(new_advertiser)
-    $advertiserId = JSON.parse(response.body)["Id"]
-    
-    new_channel = {
-      'Title' => 'Test Channel ' + rand(1000000).to_s,
-      'Commission' => '0',
-      'Engine' => 'CPM',
-      'Keywords' => 'test',
-      'CPM' => '10.00',
-      'AdTypes' => [1,2,3,4]
-    }  
-    response = @@channel.create(new_channel)
-    $channelId = JSON.parse(response.body)["Id"]
+    client = Adzerk::Client.new(API_KEY)
+    @creative_maps = client.creative_maps
+    @advertisers = client.advertisers
+    @channels =  client.channels
+    @campaigns = client.campaigns
+    @sites = client.sites
+    @flights  = client.flights
+    @priorities = client.priorities
+    @zones = client.zones
 
-    new_priority = {
-      'Name' => "High Priority Test",
-      'ChannelId' => $channelId,
-      'Weight' => 1,
-      'IsDeleted' => false
-    }
-    response = @@priority.create(new_priority)
-    $priority_id = JSON.parse(response.body)["Id"].to_s
-    
-    new_campaign = {
-      'Name' => 'Test campaign ' + rand(1000000).to_s,
-      'StartDate' => "1/1/2011",
-      'EndDate' => "12/31/2011",
-      'IsActive' => false,
-      'Price' => '10.00',
-      'AdvertiserId' => $advertiserId,
-      'Flights' => [],
-      'IsDeleted' => false
-    }  
-    response = @@campaign.create(new_campaign)
-    $campaignId = JSON.parse(response.body)["Id"]
-    
-    new_flight = {
-      'NoEndDate' => false,
-      'PriorityId' => $priority_id,
-      'Name' => 'Test flight ' + rand(1000000).to_s,
-      'StartDate' => "1/1/2011",
-      'EndDate' => "12/31/2011",
-      'NoEndDate' => false,
-      'Price' => '15.00',
-      'OptionType' => 1,
-      'Impressions' => 10000,
-      'IsUnlimited' => false,
-      'IsFullSpeed' => false,
-      'Keywords' => "test, test2",
-      'UserAgentKeywords' => nil,
-      'WeightOverride' => nil,
-      'CampaignId' => $campaignId,
-      'IsActive' => true,
-      'IsDeleted' => false
-    }
-    response = @@flight.create(new_flight)
-    $flightId = JSON.parse(response.body)["Id"]
-    
-    new_site = {
-     'Title' => 'Test Site ' + rand(1000000).to_s,
-     'Url' => 'http://www.adzerk.com'
-    }
-    response = @@site.create(new_site)
-    $siteId = JSON.parse(response.body)["Id"]
-    
-    new_zone = {
-      'Name' => 'Test Zone ' + rand(10000000).to_s,
-      'SiteId' => $siteId,
+    advertiser = @advertisers.create(:title => "test")
+    @advertiser_id = advertiser[:id].to_s
+
+    channel = @channels.create(:title => 'Test Channel ' + rand(1000000).to_s,
+                               :commission => '0.0',
+                               :engine => 'CPM',
+                               :keywords => 'test',
+                               'CPM' => '10.00',
+                               :ad_types =>  [1,2,3,4])
+    @channel_id = channel[:id].to_s
+
+    priority = @priorities.create(:name => "High Priority Test",
+                                  :channel_id => @channel_id,
+                                  :weight => 1,
+                                  :is_deleted => false)
+    @priority_id = priority[:id].to_s
+
+    campaign = @campaigns.
+      create(:name => 'Test campaign ' + rand(1000000).to_s,
+             :start_date => "1/1/2011",
+             :end_date => "12/31/2011",
+             :is_active => false,
+             :price => '10.00',
+             :advertiser_id => @advertiser_id,
+             :flights => [],
+             :is_deleted => false)
+    @campaign_id = campaign[:id]
+
+     new_flight = {
+      :no_end_date => false,
+      :priority_id => @priority_id,
+      :name => 'Test flight ' + rand(1000000).to_s,
+      :start_date => "1/1/2011",
+      :endDate => "12/31/2011",
+      :noEndDate => false,
+      :price => '15.00',
+      :option_type => 1,
+      :impressions => 10000,
+      :is_unlimited => false,
+      :is_full_speed => false,
+      :keywords => "test, test2",
+      :user_agent_keywords => nil,
+      :weight_override => nil,
+      :campaign_id => @campaign_id,
+      :is_active => true,
+      :is_deleted => false
     }
-    response = @@zone.create(new_zone)
-    $zoneId = JSON.parse(response.body)["Id"]
+    flight = @flights.create(new_flight)
+    @flight_id = flight[:id]
 
+    site = @sites.create(:title => 'Test Site ' + rand(1000000).to_s,
+                        :url => 'http://www.adzerk.com')
+    @site_id = site[:id]
+
+    zone = @zones.create(:name => 'Test Zone ' + rand(10000000).to_s,
+                         :site_id => @site_id)
+    @zone_id = zone[:id]
   end
-  
-  it "should create a creative" do
+
+  it "should create a creative map" do
     $Title = 'Test creative ' + rand(1000000).to_s
     $ImageName = "test.jpg"
     $Url = "http://adzerk.com"
@@ -106,332 +88,266 @@ describe "Creative Flight API" do
     $SizeOverride = false
     $Iframe = false
     $PublisherAccountId = 372
-    $ScriptBody = '<html>' 
+    $ScriptBody = '<html>'
     $Impressions = 100000
     $Percentage = 50
-    $DistributionType = 1 
+    $DistributionType = 1
     $IsHTMLJS = true
     $IsActive = true
     $Alt = "test alt"
     $IsDeleted = false
     $IsSync = false
-    
+
     new_creative = {
-      'CampaignId' => $CampaignId,
-      'FlightId' => $FlightId,
-      'SizeOverride' => $SizeOverride,
-      'Iframe' => $Iframe,
-      'PublisherAccountId' => $PublisherAccountId,
-      'Impressions' => $Impressions,
-      'Percentage' => $Percentage,
-      'SiteId' => $SiteId,
-      'ZoneId' => $ZoneId,
-      'DistributionType' => $DistributionType,
-      'IsActive' => $IsActive,
-      'IsDeleted' => $IsDeleted,
-      'Creative' => {
-        'Title' => $Title,
-        'Url' => $Url,
-        'Body' => $Body,
-        'AdvertiserId' => $AdvertiserId,
-        'AdTypeId' => $AdTypeId,
-        'IsHTMLJS' => $IsHTMLJS,
-        'ScriptBody' => $ScriptBody,
-        'IsActive' => $IsActive,
-        'Alt' => $Alt,
-        'IsDeleted' => $IsDeleted,
-        'IsSync' => $IsSync
+      :campaign_id => @campaign_id,
+      :flight_id => @flight_id,
+      :size_override => false,
+      :iframe => false,
+      :impressions => 100000,
+      :percentage => 50,
+      :siteId => @site_id,
+      :zoneId => @zone_id,
+      :distributionType => 1,
+      :isActive => true,
+      :isDeleted => false,
+      :creative => {
+        :title => "Creative Title",
+        :url => "http://www.adzerk.com",
+        :body => "Test Body",
+        :advertiser_id => @advertiser_id,
+        :ad_type_id => 18,
+        'IsHTMLJS' => true,
+        :script_body => "<html></html>",
+        :is_active => true,
+        :alt => "alt text",
+        :is_deleted => false,
+        :is_sync => false
       }
     }
-    response = @@map.create(new_creative)
-    Adzerk.uploadCreative(JSON.parse(response.body)["Creative"]["Id"].to_s, "250x250.gif") 
-    $map_id= JSON.parse(response.body)["Id"].to_s
-    JSON.parse(response.body)["Creative"]["Title"].should == $Title
-    JSON.parse(response.body)["Creative"]["Url"].should == $Url
-    JSON.parse(response.body)["Creative"]["Body"].should == $Body
-    JSON.parse(response.body)["Creative"]["AdvertiserId"].should == $AdvertiserId
-    JSON.parse(response.body)["CampaignId"].should == $CampaignId
-    JSON.parse(response.body)["FlightId"].should == $FlightId
-    JSON.parse(response.body)["Creative"]["AdTypeId"].should == $AdTypeId
-    JSON.parse(response.body)["ZoneId"].should == $zoneId
-    JSON.parse(response.body)["SiteId"].should == $siteId
-    JSON.parse(response.body)["SizeOverride"].should == $SizeOverride
-    JSON.parse(response.body)["PublisherAccountId"].should == $PublisherAccountId
-    JSON.parse(response.body)["Impressions"].should == $Impressions
-    JSON.parse(response.body)["Percentage"].should == $Percentage
-    JSON.parse(response.body)["DistributionType"].should == $DistributionType
-    JSON.parse(response.body)["Creative"]["IsHTMLJS"].should == $IsHTMLJS
-    JSON.parse(response.body)["Creative"]["ScriptBody"].should == $ScriptBody
-    JSON.parse(response.body)["Creative"]["IsActive"].should == $IsActive
-    JSON.parse(response.body)["Creative"]["Alt"].should == $Alt
-    JSON.parse(response.body)["IsDeleted"].should == $IsDeleted
-    JSON.parse(response.body)["Creative"]["IsSync"].should == $IsSync
-    $creative_id_id = JSON.parse(response.body)["Creative"]["Id"]
-  end
-  
-  it "should list all creatives for a flight" do
-    response = @@map.list($FlightId)
-    entry = response["Items"].last.to_json
-    $map_id = JSON.parse(entry)["Id"]
-    JSON.parse(entry)["Creative"]["Title"].should == $Title
-    JSON.parse(entry)["Creative"]["Url"].should == $Url
-    JSON.parse(entry)["Creative"]["Body"].should == $Body
-    JSON.parse(entry)["Creative"]["AdvertiserId"].should == $AdvertiserId
-    JSON.parse(entry)["CampaignId"].should == $CampaignId
-    JSON.parse(entry)["FlightId"].should == $FlightId
-    JSON.parse(entry)["Creative"]["AdTypeId"].should == $AdTypeId
-    JSON.parse(entry)["ZoneId"].should == $ZoneId
-    JSON.parse(entry)["SiteId"].should == $SiteId
-    #JSON.parse(entry)["SizeOverride"].should == $SizeOverride
-    #JSON.parse(entry)["PublisherAccountId"].should == $PublisherAccountId
-    #JSON.parse(entry)["Impressions"].should == $Impressions
-    JSON.parse(entry)["Percentage"].should == $Percentage
-    JSON.parse(entry)["DistributionType"].should == $DistributionType
-    JSON.parse(entry)["Creative"]["IsHTMLJS"].should == $IsHTMLJS
-    JSON.parse(entry)["Creative"]["ScriptBody"].should == $ScriptBody
-    JSON.parse(entry)["Creative"]["IsActive"].should == $IsActive
-    JSON.parse(entry)["Creative"]["Alt"].should == $Alt
-    JSON.parse(entry)["IsDeleted"].should == $IsDeleted
-    JSON.parse(entry)["Creative"]["IsSync"].should == $IsSync
+    creative_map = @creative_maps.create(new_creative)
+    creative_map[:creative][:title].should eq("Creative Title")
+    creative_map[:creative][:url].should eq("http://www.adzerk.com")
+    creative_map[:campaign_id].should eq(@campaign_id)
+    creative_map[:flight_id].should eq(@flight_id)
+    creative_map[:zone_id].should eq(@zone_id)
+    creative_map[:site_id].should eq(@site_id)
+    creative_map[:creative][:is_htmljs]
+    creative_map[:creative][:script_body].should eq("<html></html>")
+    $creative_id_id = creative_map[:creative][:id]
   end
-  
-  it "should get a specific creative" do
-    response = @@map.get($map_id, $flightId)
-    JSON.parse(response.body)["Id"].should == $map_id
-    JSON.parse(response.body)["Creative"]["Title"].should == $Title
-    JSON.parse(response.body)["Creative"]["Url"].should == $Url
-    JSON.parse(response.body)["Creative"]["Body"].should == $Body
-    JSON.parse(response.body)["Creative"]["AdvertiserId"].should == $AdvertiserId
-    JSON.parse(response.body)["CampaignId"].should == $CampaignId
-    JSON.parse(response.body)["FlightId"].should == $FlightId
-    JSON.parse(response.body)["Creative"]["AdTypeId"].should == $AdTypeId
-    JSON.parse(response.body)["ZoneId"].should == $ZoneId
-    JSON.parse(response.body)["SiteId"].should == $SiteId
-    #JSON.parse(response.body)["SizeOverride"].should == $SizeOverride
-    #JSON.parse(response.body)["PublisherAccountId"].should == $PublisherAccountId
-    #JSON.parse(response.body)["Impressions"].should == $Impressions
-    JSON.parse(response.body)["Creative"]["IsHTMLJS"].should == $IsHTMLJS
-    JSON.parse(response.body)["Creative"]["ScriptBody"].should == $ScriptBody
-    JSON.parse(response.body)["Percentage"].should == $Percentage
-    JSON.parse(response.body)["DistributionType"].should == $DistributionType
-    JSON.parse(response.body)["Creative"]["IsActive"].should == $IsActive
-    JSON.parse(response.body)["Creative"]["Alt"].should == $Alt
-    JSON.parse(response.body)["IsDeleted"].should == $IsDeleted
-    JSON.parse(response.body)["Creative"]["IsSync"].should == $IsSync
-    @@creativeId = JSON.parse(response.body)["Creative"]["Id"]
+
+  it "should list all creatives maps for a flight" do
+    creative_maps = @creative_maps.list(@flight_id)
+    creative_map = creative_maps[:items].last
+    $map_id= creative_map[:id]
+    creative_map[:creative][:title].should eq("Creative Title")
+    creative_map[:creative][:url].should eq("http://www.adzerk.com")
+    creative_map[:campaign_id].should eq(@campaign_id)
+    creative_map[:flight_id].should eq(@flight_id)
+    creative_map[:zone_id].should eq(@zone_id)
+    creative_map[:site_id].should eq(@site_id)
+    creative_map[:creative][:is_htmljs]
+    creative_map[:creative][:script_body].should eq("<html></html>")
   end
-  
+
+  it "should get a specific creative map" do
+    creative_map = @creative_maps.get($map_id, @flight_id)
+    creative_map[:creative][:title].should eq("Creative Title")
+    creative_map[:creative][:url].should eq("http://www.adzerk.com")
+    creative_map[:campaign_id].should eq(@campaign_id)
+    creative_map[:flight_id].should eq(@flight_id)
+    creative_map[:zone_id].should eq(@zone_id)
+    creative_map[:site_id].should eq(@site_id)
+    creative_map[:creative][:is_htmljs]
+    creative_map[:creative][:script_body].should eq("<html></html>")
+ end
+
   it "should update a specific creative" do
    updated_creative = {
-      'Id' => $map_id,
-      'CampaignId' => $CampaignId,
-      'FlightId' => $FlightId,
-      'SizeOverride' => $SizeOverride,
-      'Iframe' => $Iframe,
-      'PublisherAccountId' => $PublisherAccountId,
-      'Impressions' => $Impressions + 100,
-      'Percentage' => $Percentage,
-      'SiteId' => $SiteId,
-      'ZoneId' => $zoneId,
-      'IsActive' => $IsActive,
-      'IsDeleted' => $IsDeleted,
-      'Creative' => {
-        'Id' => @@creativeId
+      :id => $map_id,
+      :campaign_id => @campaign_id,
+      :flight_id => @flight_id,
+      :size_override => false,
+      :iframe => false,
+      :impressions => 200000,
+      :percentage => 50,
+      :site_id => @site_id,
+      :zone_id => @zone_id,
+      :is_active => true,
+      :is_deleted => false,
+      :creative => {
+        :id => $creative_id_id
       }
     }
-    response = @@map.create(updated_creative)
-    Adzerk.uploadCreative(JSON.parse(response.body)["Creative"]["Id"].to_s, "250x250.gif") 
-    JSON.parse(response.body)["Creative"]["Title"].should == $Title
-    JSON.parse(response.body)["Creative"]["Url"].should == $Url
-    JSON.parse(response.body)["Creative"]["Body"].should == $Body
-    JSON.parse(response.body)["Creative"]["AdvertiserId"].should == $AdvertiserId
-    JSON.parse(response.body)["CampaignId"].should == $CampaignId
-    JSON.parse(response.body)["FlightId"].should == $FlightId
-    JSON.parse(response.body)["Creative"]["AdTypeId"].should == $AdTypeId
-    JSON.parse(response.body)["ZoneId"].should == $zoneId
-    JSON.parse(response.body)["SiteId"].should == $SiteId
-    JSON.parse(response.body)["SizeOverride"].should == $SizeOverride
-    JSON.parse(response.body)["PublisherAccountId"].should == $PublisherAccountId
-    JSON.parse(response.body)["Impressions"].should == $Impressions + 100
-    JSON.parse(response.body)["Percentage"].should == $Percentage
-    JSON.parse(response.body)["Creative"]["IsActive"].should == $IsActive
-    JSON.parse(response.body)["Creative"]["Alt"].should == $Alt
-    JSON.parse(response.body)["IsDeleted"].should == $IsDeleted
-    JSON.parse(response.body)["Creative"]["IsSync"].should == $IsSync
+    creative_map = @creative_maps.update(updated_creative)
+    creative_map[:impressions].should eq(200000)
   end
 
   it "should update the scriptBody tag on a nested creative" do
     updated_creative = {
-      'Id' => $map_id,
-      'CampaignId' => $CampaignId,
-      'FlightId' => $FlightId,
-      'ZoneId' => $ZoneId,
-      'SizeOverride' => $SizeOverride,
-      'Iframe' => $Iframe,
-      'PublisherAccountId' => $PublisherAccountId,
-      'Impressions' => $Impressions,
-      'Percentage' => $Percentage,
-      'SiteId' => $SiteId,
-      'IsActive' => $IsActive,
-      'IsDeleted' => nil,
-      'Creative' => {
-        'Id' => @@creativeId,
-        'IsHTMLJS' => true,
-        'ScriptBody' => '<html></html>',
-        'Title' => 'test'
+      :id => $map_id,
+      :campaign_id => @campaign_id,
+      :flight_id => @flight_id,
+      :size_override => false,
+      :iframe => false,
+      :impressions => 200000,
+      :percentage => 50,
+      :site_id => @site_id,
+      :zone_id => @zone_id,
+      :is_active => true,
+      :is_deleted => false,
+      :creative => {
+        :id => $creative_id_id,
+        :script_body => '<html>New Body</html>',
       }
     }
-    response = @@map.update(updated_creative)
-    response.body.scan(/Exception/).should == []
+    creative_map = @creative_maps.update(updated_creative)
+    creative_map[:creative][:script_body].should eq('<html>New Body</html>')
   end
-  
+
   it "should delete the creatives after creating it" do
-    response = @@map.delete($map_id, $FlightId)
-    response.body.should == "OK"
+    response = @creative_maps.delete($map_id, @flight_id)
+    response.body.should == "\"This creative map has been deleted\""
   end
-  
-  it "should not create a map when campaignId is forbidden" do
-    map = {
-      'CampaignId' => '123',
-      'FlightId' => $FlightId,
-      'SizeOverride' => $SizeOverride,
-      'Iframe' => $Iframe,
-      'PublisherAccountId' => $PublisherAccountId,
-      'Impressions' => $Impressions,
-      'SiteId' => $SiteId,
-      'Percentage' => $Percentage,
-      'IsActive' => $IsActive,
-      'IsDeleted' => $IsDeleted
-    }
-    response = @@map.create(map)
-    response.body.scan(/This campaign is not part/).should_not == []
+
+  it "should not get a map in a different network" do
+    creative_map = @creative_maps.get(123, @flight_id)
+    creative_map[:message].should == "This flight is not part of your network"
   end
-  
-  it "should not create a map when flightId is forbidden" do
-    map = {
-      'CampaignId' => $CampaignId,
-      'FlightId' => '123',
-      'SizeOverride' => $SizeOverride,
-      'Iframe' => $Iframe,
-      'PublisherAccountId' => $PublisherAccountId,
-      'Impressions' => $Impressions,
-      'SiteId' => $SiteId,
-      'Percentage' => $Percentage,
-      'IsActive' => $IsActive,
-      'IsDeleted' => $IsDeleted
-    }
-    response = @@map.create(map)
-    response.body.scan(/This flight is not part/).should_not == []
+
+  it "should not get a map that's been deleted" do
+    creative_map = @creative_maps.get($map_id, @flight_id)
+    creative_map[:message].should == "This creative map has been deleted"
   end
-    
-  it "should create a map when there is no creative object, just id" do
-    map = {
-      'CampaignId' => $CampaignId,
-      'FlightId' => $FlightId,
-      'SizeOverride' => $SizeOverride,
-      'Iframe' => $Iframe,
-      'PublisherAccountId' => $PublisherAccountId,
-      'Impressions' => $Impressions,
-      'SiteId' => $SiteId,
-      'Percentage' => $Percentage,
-      'IsActive' => $IsActive,
-      'IsDeleted' => $IsDeleted,
-      'Creative' => {
-        'Id' => @@creativeId
+
+  it "should not update a map that's in a different network" do
+    creative_map = @creative_maps.update(
+      :id => $map_id,
+      :campaign_id => @campaign_id,
+      :flight_id => 123,
+      :size_override => false,
+      :iframe => false,
+      :impressions => 200000,
+      :percentage => 50,
+      :site_id => @site_id,
+      :zone_id => @zone_id,
+      :is_active => true,
+      :is_deleted => false,
+      :creative => {
+        :id => $creative_id_id
       }
-    }
-    response = @@map.create(map)
-    response.body.scan(/Exception/).should == []
+    )
+    creative_map[:message].should == "This flight is not part of your network"
   end
 
-  it "should not create a map when there is no creative object, just id that belongs to a different advertiser" do
-    map = {
-      'CampaignId' => $CampaignId,
-      'FlightId' => $FlightId,
-      'SizeOverride' => $SizeOverride,
-      'Iframe' => $Iframe,
-      'PublisherAccountId' => $PublisherAccountId,
-      'Impressions' => $Impressions,
-      'SiteId' => $SiteId,
-      'Percentage' => $Percentage,
-      'IsActive' => $IsActive,
-      'IsDeleted' => $IsDeleted,
-      'Creative' => {
-        'Id' => 1234
+  it "should not update a map that's been deleted" do
+    creative_map = @creative_maps.update(
+      :id => $map_id,
+      :campaign_id => @campaign_id,
+      :flight_id => @flight_id,
+      :size_override => false,
+      :iframe => false,
+      :impressions => 200000,
+      :percentage => 50,
+      :site_id => @site_id,
+      :zone_id => @zone_id,
+      :is_active => true,
+      :is_deleted => false,
+      :creative => {
+        :id => $creative_id_id
       }
-    }
-    response = @@map.create(map)
-    response.body.scan(/That creative belongs to an advertiser/).should_not == []
+    )
+    creative_map[:message].should == "This creative map has been deleted"
   end
 
-  it "should create a map with and invalid siteId" do
-    new_creative = {
-      'CampaignId' => $CampaignId,
-      'FlightId' => $FlightId,
-      'ZoneId' => $ZoneId,
-      'SizeOverride' => $SizeOverride,
-      'Iframe' => $Iframe,
-      'PublisherAccountId' => $PublisherAccountId,
-      'Impressions' => $Impressions,
-      'Percentage' => $Percentage,
-      'SiteId' => 0,
-      'IsActive' => $IsActive,
-      'IsDeleted' => $IsDeleted,
-      'Creative' => {
-        'Title' => $Title,
-        'Url' => $Url,
-        'Body' => $Body,
-        'AdvertiserId' => $AdvertiserId,
-        'AdTypeId' => $AdTypeId,
-        'IsActive' => $IsActive,
-        'Alt' => $Alt,
-        'IsDeleted' => $IsDeleted,
-        'IsSync' => $IsSync
+  it "should fail when creating a map for a campaign in a different network" do
+    creative_map = @creative_maps.create(
+      :campaign_id => 123,
+      :flight_id => @flight_id,
+      :size_override => false,
+      :iframe => false,
+      :impressions => 100000,
+      :percentage => 50,
+      :siteId => @site_id,
+      :zoneId => @zone_id,
+      :distributionType => 1,
+      :isActive => true,
+      :isDeleted => false,
+      :creative => {
+        :title => "Creative Title",
+        :url => "http://www.adzerk.com",
+        :body => "Test Body",
+        :advertiser_id => @advertiser_id,
+        :ad_type_id => 18,
+        'IsHTMLJS' => true,
+        :script_body => "<html></html>",
+        :is_active => true,
+        :alt => "alt text",
+        :is_deleted => false,
+        :is_sync => false
       }
-    }
-    response = @@map.create(new_creative)
-    response.body.scan(/This site does not belong to your network/).should_not == []
+    )
+    creative_map[:message].should == "This campaign is not part of your network"
   end
 
-  it "should test if IsHTMLJS is getting written over" do
-    creative = {
-      'Title' => 'Test Creative ' + rand(1000).to_s,
-      'Url' => 'http://adzerk.com/',
-      'Body' => 'test',
-      'AdvertiserId' => $advertiserId,
-      'AdTypeId' => 18,
-      'IsHTMLJS' => true,
-      'ScriptBody' => '<html>test</html>',
-      'IsActive' => true,
-      'Alt' => 'test',
-      'IsDeleted' => false,
-      'IsSync' => false
-    }
-    response = @@creative.create(creative, '250x250.gif')
-    creativeId = JSON.parse(response.body)["Id"]
-    JSON.parse(response.body)["IsHTMLJS"].should == true
-    JSON.parse(response.body)["ScriptBody"].should == '<html>test</html>'
-
-    map = {
-      'CampaignId' => $campaignId,
-      'FlightId' => $flightId,
-      'ZoneId' => $zoneId,
-      'SizeOverride' => $SizeOverride,
-      'Iframe' => $Iframe,
-      'PublisherAccountId' => $PublisherAccountId,
-      'Impressions' => $Impressions,
-      'Percentage' => $Percentage,
-      'SiteId' => $siteId,
-      'IsActive' => $IsActive,
-      'IsDeleted' => $IsDeleted,
-      'Creative' => {
-        'Id' => creativeId
+  it "should fail when creating a map for a site in a different network" do
+    creative_map = @creative_maps.create(
+      :campaign_id => @campaign_id,
+      :flight_id => @flight_id,
+      :size_override => false,
+      :iframe => false,
+      :impressions => 100000,
+      :percentage => 50,
+      :siteId => 123,
+      :zoneId => @zone_id,
+      :distributionType => 1,
+      :isActive => true,
+      :isDeleted => false,
+      :creative => {
+        :title => "Creative Title",
+        :url => "http://www.adzerk.com",
+        :body => "Test Body",
+        :advertiser_id => @advertiser_id,
+        :ad_type_id => 18,
+        'IsHTMLJS' => true,
+        :script_body => "<html></html>",
+        :is_active => true,
+        :alt => "alt text",
+        :is_deleted => false,
+        :is_sync => false
       }
-    }
-    map_response = @@map.create(map)
+    )
+    creative_map[:message].should == "This site does not belong to your network"
+  end
 
-    JSON.parse(map_response.body)["Creative"]["IsHTMLJS"].should == true
-    JSON.parse(map_response.body)["Creative"]["ScriptBody"].should == '<html>test</html>'
+  it "should fail when creating a map for a zone in a different network" do
+    creative_map = @creative_maps.create(
+      :campaign_id => @campaign_id,
+      :flight_id => @flight_id,
+      :size_override => false,
+      :iframe => false,
+      :impressions => 100000,
+      :percentage => 50,
+      :siteId => @site_id,
+      :zoneId => 11,
+      :distributionType => 1,
+      :isActive => true,
+      :isDeleted => false,
+      :creative => {
+        :title => "Creative Title",
+        :url => "http://www.adzerk.com",
+        :body => "Test Body",
+        :advertiser_id => @advertiser_id,
+        :ad_type_id => 18,
+        'IsHTMLJS' => true,
+        :script_body => "<html></html>",
+        :is_active => true,
+        :alt => "alt text",
+        :is_deleted => false,
+        :is_sync => false
+      }
+    )
+    creative_map[:message].should == "The site associated with that zone does not belong to your network"
   end
 
 end