adyen_jpiqueras 2.3.0 → 2.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8c9637788e33f4b5ea6358b481dd6b84fa21c893
-  data.tar.gz: 0373397b8eea85370cff403d086d87f199075a4b
+  metadata.gz: 05bd483db66cada29259292de71f385a2c54345a
+  data.tar.gz: ac777c6f970f2b311ce3bd4d3798eace00b0d357
 SHA512:
-  metadata.gz: d7c29df5296cfca388f24baf77d5bd5d9ef7445912de358b4fadbbea2aabfdd3c86f8e1755ae57e14e55fb684e7d86cfe51c91e23f13a605eeaa25a680792ae3
-  data.tar.gz: e50f8976df8452af922a403fec63ffbc833d7a79c9fc6ea4531930da1760966b94e1abe12c8a80f2989f722dac02470d1340703b51002cb787837449ce8a1370
+  metadata.gz: c118178acf9a176f816c06fb831ba622656d0f99f611a62ada157422a76fcac23e2e16c6a6d5b78ebf0c0ebc737b450a4cf46076d2b1aa45903c1f055ce44b21
+  data.tar.gz: 5131df70714f73087622423e4cc206412e5ab49abc53e5f61f060b1df9462ea796c84d60c72a0d3d15282889c52c0bf9b5a8ac90e0cde522b4cf31214fe1b811

data/.gitignore

@@ -4,7 +4,7 @@
 /tmp
 /pkg
 /doc
-adyen-*.gem
+adyen_jpiqueras*.gem
 .yardoc
 *.swp
 *.swo

data/README.md

@@ -1,31 +1,7 @@
-# Adyen [![Build Status](https://travis-ci.org/wvanbergen/adyen.svg?branch=master)](https://travis-ci.org/wvanbergen/adyen)
+# Adyen_jpiqueras
 
-Package to simplify including Adyen payments services into a Ruby on Rails application.
+### This is a temporal fork of the [adyen gem](https://github.com/wvanbergen/adyen)
 
-Adyen integration relies on three modes of communication between Adyen, your server and your client/customer:
+The main difference is that implements the payout support by [AlexGaspar](https://github.com/AlexGaspar)
 
-- Client-to-Adyen communication using Hosted Payment Pages (HPP).
-- Server-to-Adyen communication using their REST webservice.
-- Adyen-to-server communications using notifications.
-
-This library aims to ease the implementation of all these modes into your Rack application. Moreover, it provides matchers, assertions and mocks to make it easier to implement an automated test suite to assert the integration is working correctly.
-
-### Usage
-
-- See the [project wiki](https://github.com/wvanbergen/adyen/wiki) to get started.
-- Check out [the example server](https://github.com/wvanbergen/adyen/blob/master/test/helpers/example_server.rb) for an example implementation of the HPP payment flow, and an implementation of self-hosted a payment flow that uses the REST webservice. To start the example server, run `bundle exec rackup` in the root of this project.
-- Complete RDoc documentation can be found on [rubydoc.info](http://www.rubydoc.info/gems/adyen).
-- For more information about Adyen, see http://www.adyen.com
-- For more information about integrating Adyen, see [their manuals](https://www.adyen.com/home/support/manuals.html). Of primary interest are the HPP integration manual for `Adyen::Form`, and the API integration manual for `Adyen::REST`.
-
-The library doesn't have any dependencies, but making Nokogiri available in your environment will greatly improve the speed of any XML and HTML processing.
-
-### About
-
-This package is written by Michel Barbosa and Willem van Bergen for Floorplanner.com, and
-made public under the MIT license (see LICENSE). It is currently maintained by Willem van
-Bergen, with help from several contributors. We are not affiliated with Adyen B.V. The software
-comes without warranty of any kind, so use at your own risk.
-
-- `CHANGELOG.md` documents the changes between releases.
-- Check out `CONTRIBUTING.md` if you want to help out with this project.
+I also modified the ResponseError class to implement the new response error format (https://docs.adyen.com/developers/api-manual)

data/lib/adyen/rest/client.rb

@@ -104,7 +104,7 @@ module Adyen
         case response = http.request(http_request)
         when Net::HTTPOK
           return response
-        when Net::HTTPInternalServerError
+        when Net::HTTPUnprocessableEntity, Net::HTTPInternalServerError
           raise Adyen::REST::ResponseError.new(response.body)
         when Net::HTTPUnauthorized
           raise Adyen::REST::Error.new("Webservice credentials are incorrect")

data/lib/adyen/rest/errors.rb

@@ -11,23 +11,38 @@ module Adyen
 
     # Exception class for error responses from the Adyen API.
     #
-    # @!attribute category
+    # @!attribute status
     #    @return [String, nil]
-    # @!attribute code
+    # @!attribute error_code
     #    @return [Integer, nil]
-    # @!attribute description
+    # @!attribute message
+    #    @return [String, nil]
+    # @!attribute error_type
+    #    @return [String, nil]
+    # @!attribute psp_reference
     #    @return [String, nil]
     class ResponseError < Adyen::REST::Error
-      attr_accessor :category, :code, :description
+      attr_reader :status, :error_code, :message, :error_type, :psp_reference
 
       def initialize(response_body)
-        if match = /\A(\w+)\s(\d+)\s(.*)\z/.match(response_body)
-          @category, @code, @description = match[1], match[2].to_i, match[3]
-          super("API request error: #{description} (code: #{code}/#{category})")
+        parse_params(response_body)
+        if error_code && message && error_type
+          super("API request error: #{message} (code: #{error_type}/#{error_code})")
         else
           super("API request error: #{response_body}")
         end
       end
+
+      private
+
+      def parse_params(response_body)
+        params = Hash[CGI.parse(response_body).map {|key,values| [key.to_sym, values[0] || true]}]
+        @status = params[:status]
+        @error_code = params[:errorCode]
+        @message = params[:message]
+        @error_type = params[:errorType]
+        @psp_reference = params[:pspReference] if params[:pspReference]
+      end
     end
   end
 end

data/lib/adyen/version.rb

@@ -1,5 +1,5 @@
 module Adyen
   # Version constant for the Adyen plugin.
   # Set it & commit the change before running rake release.
-  VERSION = "2.3.0"
+  VERSION = "2.4.0"
 end

data/test/rest_response_error_test.rb

@@ -0,0 +1,26 @@
+require 'test_helper'
+require 'adyen/rest/errors'
+
+class RESTResponseErrorTest < Minitest::Test
+
+  def test_parsing_attributes
+    response_body = 'errorType=validation&errorCode=800&message=Contract+not+found&pspReference=1234512345&status=422'
+    response_error = Adyen::REST::ResponseError.new(response_body)
+    common_checks(response_error)
+    assert_equal '1234512345', response_error.psp_reference
+  end
+
+  def test_parsing_attributes_without_psp_reference
+    response_body = 'errorType=validation&errorCode=800&message=Contract+not+found&status=422'
+    response_error = Adyen::REST::ResponseError.new(response_body)
+    common_checks(response_error)
+    assert_nil response_error.psp_reference
+  end
+
+  def common_checks(response_error)
+    assert_equal '422', response_error.status
+    assert_equal 'validation', response_error.error_type
+    assert_equal '800', response_error.error_code
+    assert_equal 'Contract not found', response_error.message
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: adyen_jpiqueras
 version: !ruby/object:Gem::Version
-  version: 2.3.0
+  version: 2.4.0
 platform: ruby
 authors:
 - Willem van Bergen
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-29 00:00:00.000000000 Z
+date: 2016-09-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -231,6 +231,7 @@ files:
 - test/rest/signature_test.rb
 - test/rest_list_recurring_details_response_test.rb
 - test/rest_request_test.rb
+- test/rest_response_error_test.rb
 - test/rest_response_test.rb
 - test/signature_test.rb
 - test/test_helper.rb
@@ -302,6 +303,7 @@ test_files:
 - test/rest/signature_test.rb
 - test/rest_list_recurring_details_response_test.rb
 - test/rest_request_test.rb
+- test/rest_response_error_test.rb
 - test/rest_response_test.rb
 - test/signature_test.rb
 - test/test_helper.rb