adyen 2.2.0 → 2.3.0

data/{spec/api/test_helpers_spec.rb → test/unit/api/test_helpers_test.rb}

@@ -1,6 +1,6 @@
 # encoding: UTF-8
 
-require 'api/spec_helper'
+require 'unit/api/test_helper'
 require 'adyen/api/test_helpers'
 
 describe "Test helpers" do
@@ -42,29 +42,29 @@ describe "Test helpers" do
     it "returns an `authorized' response" do
       stub_net_http(AUTHORISATION_DECLINED_RESPONSE)
       Adyen::API::PaymentService.stub_success!
-      @payment.authorise_payment.should be_authorized
+      @payment.authorise_payment.must_be :authorized?
 
-      @payment.authorise_payment.should_not be_authorized
+      @payment.authorise_payment.wont_be :authorized?
     end
 
     it "returns a `refused' response" do
       stub_net_http(AUTHORISE_RESPONSE)
       Adyen::API::PaymentService.stub_refused!
       response = @payment.authorise_payment
-      response.should_not be_authorized
-      response.should_not be_invalid_request
+      response.wont_be :authorized?
+      response.wont_be :invalid_request?
 
-      @payment.authorise_payment.should be_authorized
+      @payment.authorise_payment.must_be :authorized?
     end
 
     it "returns a `invalid request' response" do
       stub_net_http(AUTHORISE_RESPONSE)
       Adyen::API::PaymentService.stub_invalid!
       response = @payment.authorise_payment
-      response.should_not be_authorized
-      response.should be_invalid_request
+      response.wont_be :authorized?
+      response.must_be :invalid_request?
 
-      @payment.authorise_payment.should be_authorized
+      @payment.authorise_payment.must_be :authorized?
     end
   end
 
@@ -77,8 +77,8 @@ describe "Test helpers" do
     it "returns a `disabled' response" do
       stub_net_http(DISABLE_RESPONSE % 'nope')
       Adyen::API::RecurringService.stub_disabled!
-      @recurring.disable.should be_disabled
-      @recurring.disable.should_not be_disabled
+      @recurring.disable.must_be :disabled?
+      @recurring.disable.wont_be :disabled?
     end
   end
 end

data/test/unit/hpp/request_test.rb

@@ -0,0 +1,68 @@
+require 'test_helper'
+require 'adyen/hpp/request'
+
+class HPPRequestTest < Minitest::Test
+  def setup
+    Adyen.configuration.default_form_params[:merchant_account] = 'TestMerchant'
+    Adyen.configuration.default_skin = :skin1
+
+    # Use autodetection for the environment unless otherwise specified
+    Adyen.configuration.environment = nil
+    Adyen.configuration.payment_flow = :select
+    Adyen.configuration.payment_flow_domain = nil
+    Adyen.configuration.default_skin = :skin1
+
+    @raw_params = {
+      :merchant_account => 'TestMerchant',
+      :currency_code => 'EUR',
+      :payment_amount => '199',
+      :session_validity => '2015-06-25T10:31:06Z',
+      :ship_before_date => '2015-07-01',
+      :shopper_locale => 'en_GB',
+      :merchant_reference => 'SKINTEST-1435226439255',
+      :skin_code => 'X7hsNDWp',
+    }
+  end
+
+  def test_formatted_parameters
+    expected_parameters = {
+      merchant_account: "TestMerchant",
+      currency_code: "EUR",
+      payment_amount: "199",
+      session_validity: "2015-06-25T10:31:06Z",
+      ship_before_date: "2015-07-01",
+      shopper_locale: "en_GB",
+      merchant_reference: "SKINTEST-1435226439255",
+      skin_code: "X7hsNDWp"}
+
+    parameters = Adyen::HPP::Request.new(@raw_params).formatted_parameters
+    assert_equal parameters, expected_parameters
+  end
+
+  def test_formatted_parameters_without_parameters
+    request = Adyen::HPP::Request.new('String')
+
+    exception = assert_raises(ArgumentError) { request.formatted_parameters }
+    assert_equal("Cannot generate request: parameters should be a hash!", exception.message)
+  end
+
+  def test_formatted_parameters_without_currency_code
+    @raw_params.delete(:currency_code)
+    request = Adyen::HPP::Request.new(@raw_params)
+
+    exception = assert_raises(ArgumentError) { request.formatted_parameters }
+    assert_equal("Cannot generate request: :currency_code attribute not found!", exception.message)
+  end
+
+  def test_formatted_parameters_missing_parameters
+    Adyen.configuration.default_form_params[:merchant_account] = nil
+    Adyen.configuration.default_skin = 'unknown_skin'
+    %i(currency_code payment_amount merchant_account skin_code ship_before_date session_validity).each do |parameter|
+      params = @raw_params.reject { |param| param == parameter }
+      request = Adyen::HPP::Request.new(params)
+
+      exception = assert_raises(ArgumentError) { request.formatted_parameters }
+      assert_equal("Cannot generate request: :#{parameter} attribute not found!", exception.message)
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: adyen
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 2.3.0
 platform: ruby
 authors:
 - Willem van Bergen
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-23 00:00:00.000000000 Z
+date: 2017-09-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -27,34 +27,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '2.14'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '2.14'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '5'
+        version: '5.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '5'
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
@@ -98,12 +84,15 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rails
+  name: railties
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '3.2'
+    - - <
+      - !ruby/object:Gem::Version
+        version: '5.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -111,20 +100,23 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '3.2'
+    - - <
+      - !ruby/object:Gem::Version
+        version: '5.2'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: 1.6.1
+        version: 1.6.8
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: 1.6.1
+        version: 1.6.8
 description: |2
       Package to simplify including the Adyen payments services into a Ruby on Rails application.
       The package provides functionality to create payment forms, handling and storing notifications
@@ -187,18 +179,9 @@ files:
 - lib/adyen/templates/notification_model.rb
 - lib/adyen/util.rb
 - lib/adyen/version.rb
-- spec/api/api_spec.rb
-- spec/api/payment_service_spec.rb
-- spec/api/recurring_service_spec.rb
-- spec/api/response_spec.rb
-- spec/api/simple_soap_client_spec.rb
-- spec/api/spec_helper.rb
-- spec/api/test_helpers_spec.rb
-- spec/functional/api_spec.rb
-- spec/functional/initializer.rb.ci
-- spec/functional/initializer.rb.sample
-- spec/spec_helper.rb
-- test/form_test.rb
+- test/functional/api_test.rb
+- test/functional/initializer.rb.ci
+- test/functional/initializer.rb.sample
 - test/functional/payment_authorisation_api_test.rb
 - test/functional/payment_modification_api_test.rb
 - test/helpers/capybara.rb
@@ -212,18 +195,27 @@ files:
 - test/helpers/views/index.erb
 - test/helpers/views/pay.erb
 - test/helpers/views/redirect_shopper.erb
-- test/hpp/signature_test.rb
-- test/hpp_test.rb
 - test/integration/hpp_integration_test.rb
 - test/integration/payment_using_3d_secure_integration_test.rb
 - test/integration/payment_with_client_side_encryption_integration_test.rb
-- test/rest/signature_test.rb
-- test/rest_list_recurring_details_response_test.rb
-- test/rest_request_test.rb
-- test/rest_response_test.rb
-- test/signature_test.rb
 - test/test_helper.rb
-- test/util_test.rb
+- test/unit/api/api_test.rb
+- test/unit/api/payment_service_test.rb
+- test/unit/api/recurring_service_test.rb
+- test/unit/api/response_test.rb
+- test/unit/api/simple_soap_client_test.rb
+- test/unit/api/test_helper.rb
+- test/unit/api/test_helpers_test.rb
+- test/unit/form_test.rb
+- test/unit/hpp/request_test.rb
+- test/unit/hpp/signature_test.rb
+- test/unit/hpp_test.rb
+- test/unit/rest/signature_test.rb
+- test/unit/rest_list_recurring_details_response_test.rb
+- test/unit/rest_request_test.rb
+- test/unit/rest_response_test.rb
+- test/unit/signature_test.rb
+- test/unit/util_test.rb
 - yard_extensions.rb
 homepage: http://github.com/wvanbergen/adyen/wiki
 licenses:
@@ -257,18 +249,9 @@ signing_key:
 specification_version: 4
 summary: Integrate Adyen payment services in your Ruby on Rails application.
 test_files:
-- spec/api/api_spec.rb
-- spec/api/payment_service_spec.rb
-- spec/api/recurring_service_spec.rb
-- spec/api/response_spec.rb
-- spec/api/simple_soap_client_spec.rb
-- spec/api/spec_helper.rb
-- spec/api/test_helpers_spec.rb
-- spec/functional/api_spec.rb
-- spec/functional/initializer.rb.ci
-- spec/functional/initializer.rb.sample
-- spec/spec_helper.rb
-- test/form_test.rb
+- test/functional/api_test.rb
+- test/functional/initializer.rb.ci
+- test/functional/initializer.rb.sample
 - test/functional/payment_authorisation_api_test.rb
 - test/functional/payment_modification_api_test.rb
 - test/helpers/capybara.rb
@@ -282,15 +265,24 @@ test_files:
 - test/helpers/views/index.erb
 - test/helpers/views/pay.erb
 - test/helpers/views/redirect_shopper.erb
-- test/hpp/signature_test.rb
-- test/hpp_test.rb
 - test/integration/hpp_integration_test.rb
 - test/integration/payment_using_3d_secure_integration_test.rb
 - test/integration/payment_with_client_side_encryption_integration_test.rb
-- test/rest/signature_test.rb
-- test/rest_list_recurring_details_response_test.rb
-- test/rest_request_test.rb
-- test/rest_response_test.rb
-- test/signature_test.rb
 - test/test_helper.rb
-- test/util_test.rb
+- test/unit/api/api_test.rb
+- test/unit/api/payment_service_test.rb
+- test/unit/api/recurring_service_test.rb
+- test/unit/api/response_test.rb
+- test/unit/api/simple_soap_client_test.rb
+- test/unit/api/test_helper.rb
+- test/unit/api/test_helpers_test.rb
+- test/unit/form_test.rb
+- test/unit/hpp/request_test.rb
+- test/unit/hpp/signature_test.rb
+- test/unit/hpp_test.rb
+- test/unit/rest/signature_test.rb
+- test/unit/rest_list_recurring_details_response_test.rb
+- test/unit/rest_request_test.rb
+- test/unit/rest_response_test.rb
+- test/unit/signature_test.rb
+- test/unit/util_test.rb

data/spec/spec_helper.rb

@@ -1,8 +0,0 @@
-# encoding: UTF-8
-
-require 'rspec'
-require 'adyen/matchers'
-
-RSpec.configure do |config|
-  config.include Adyen::Matchers
-end