adyen 1.5.0 → 1.6.0

data/test/test_helper.rb

@@ -0,0 +1,24 @@
+# encoding: UTF-8
+require 'minitest/autorun'
+require 'minitest/pride'
+require 'mocha/setup'
+
+require 'adyen'
+require 'adyen/matchers'
+
+module Adyen::Test
+  module EachXMLBackend
+    XML_BACKENDS = [Adyen::API::XMLQuerier::NokogiriBackend, Adyen::API::XMLQuerier::REXMLBackend]
+
+    def for_each_xml_backend(&block)
+      XML_BACKENDS.each do |xml_backend|
+        begin
+          Adyen::API::XMLQuerier.stubs(:default_backend).returns(xml_backend.new)
+          block.call(xml_backend)
+        ensure
+          Adyen::API::XMLQuerier.unstub(:default_backend)
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: adyen
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.6.0
 platform: ruby
 authors:
 - Willem van Bergen
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-14 00:00:00.000000000 Z
+date: 2014-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -41,6 +41,34 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '2.14'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '5'
+- !ruby/object:Gem::Dependency
+  name: mocha
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
@@ -85,13 +113,11 @@ extra_rdoc_files:
 - README.rdoc
 files:
 - .gitignore
-- .kick
 - .travis.yml
 - Gemfile
 - LICENSE
 - README.rdoc
 - Rakefile
-- TODO
 - adyen.gemspec
 - lib/adyen.rb
 - lib/adyen/api.rb
@@ -114,7 +140,6 @@ files:
 - lib/adyen/templates/notification_migration.rb
 - lib/adyen/templates/notification_model.rb
 - lib/adyen/version.rb
-- spec/adyen_spec.rb
 - spec/api/api_spec.rb
 - spec/api/payment_service_spec.rb
 - spec/api/recurring_service_spec.rb
@@ -122,11 +147,13 @@ files:
 - spec/api/simple_soap_client_spec.rb
 - spec/api/spec_helper.rb
 - spec/api/test_helpers_spec.rb
-- spec/form_spec.rb
 - spec/functional/api_spec.rb
 - spec/functional/initializer.rb.ci
 - spec/functional/initializer.rb.sample
 - spec/spec_helper.rb
+- test/adyen_test.rb
+- test/form_test.rb
+- test/test_helper.rb
 - yard_extensions.rb
 homepage: http://github.com/wvanbergen/adyen/wiki
 licenses:
@@ -160,7 +187,6 @@ signing_key:
 specification_version: 4
 summary: Integrate Adyen payment services in your Ruby on Rails application.
 test_files:
-- spec/adyen_spec.rb
 - spec/api/api_spec.rb
 - spec/api/payment_service_spec.rb
 - spec/api/recurring_service_spec.rb
@@ -168,8 +194,10 @@ test_files:
 - spec/api/simple_soap_client_spec.rb
 - spec/api/spec_helper.rb
 - spec/api/test_helpers_spec.rb
-- spec/form_spec.rb
 - spec/functional/api_spec.rb
 - spec/functional/initializer.rb.ci
 - spec/functional/initializer.rb.sample
 - spec/spec_helper.rb
+- test/adyen_test.rb
+- test/form_test.rb
+- test/test_helper.rb

data/.kick

@@ -1,35 +0,0 @@
-options.on('--doc', 'Also generate docs.') do
-  process do |files|
-    if files.any? { |f| f =~ /lib\/.+\.rb$/ }
-      execute "yardoc --no-private"
-      execute(%{osascript -e 'tell application "Safari"
-        do JavaScript "window.location.reload()" in first document
-      end tell'})
-    end
-  end
-end
-
-recipe :ruby
-
-process do |files|
-  specs = files.take_and_map do |file|
-    case file
-    when "spec/spec_helper.rb"
-      Dir.glob("spec/**/*_spec.rb")
-    when "spec/api/spec_helper.rb"
-      Dir.glob("spec/api/*_spec.rb")
-    when "lib/adyen/api.rb"
-      "spec/api/api_spec.rb"
-    when "lib/adyen/api/xml_querier.rb"
-      ["spec/api/payment_service_spec.rb", "spec/api/recurring_service_spec.rb"]
-    when "lib/adyen/api/simple_soap_client.rb"
-      ["spec/api/simple_soap_client_spec.rb", "spec/api/payment_service_spec.rb", "spec/api/recurring_service_spec.rb"]
-    when "lib/adyen/api/response.rb"
-      ["spec/api/response_spec.rb", "spec/api/payment_service_spec.rb", "spec/api/recurring_service_spec.rb"]
-    when %r{lib/adyen/api/templates/(.+)\.rb$}, %r{lib/adyen/api/(.+)\.rb$}
-      "spec/api/#{$1}_spec.rb"
-    end
-  end
-  Ruby.run_tests(specs)
-end
-

data/TODO

@@ -1,16 +0,0 @@
-* Add a capture! method to an authorisation response from the PaymentService.
-
-* Add iDEAL API. To get started, see the `iDEAL' topic-branch which contains `ideal-scratchpad.rb' and a stub for a functional spec.
-
-* Add the DirectDebit API.
-
-* Add ActiveMerchant integration
-
-* Split up gem to have more explicit dependency requirements, e.g.:
-  * adyen-soap
-  * adyen-railtie
-  * adyen-activemerchant
-
-* Add mocks for notification requests in order to test your app
-
-* Add more mock SOAP responses for testing your app.

data/spec/adyen_spec.rb

@@ -1,44 +0,0 @@
-# encoding: UTF-8
-
-require 'spec_helper'
-
-describe Adyen do
-
-  describe Adyen::Encoding do
-    it "should a hmac_base64 correcly" do
-      encoded_str = Adyen::Encoding.hmac_base64('bla', 'bla')
-      encoded_str.should == '6nItEkVpIYF+i1RwrEyQ7RHmrfU='
-    end
-
-    it "should gzip_base64 correcly" do
-      encoded_str = Adyen::Encoding.gzip_base64('bla')
-      encoded_str.length.should == 32
-    end
-  end
-
-  describe Adyen::Formatter::DateTime do
-    it "should accept dates" do
-      Adyen::Formatter::DateTime.fmt_date(Date.today).should match(/^\d{4}-\d{2}-\d{2}$/)
-    end
-
-    it "should accept times" do
-      Adyen::Formatter::DateTime.fmt_time(Time.now).should match(/^\d{4}-\d{2}-\d{2}T\d{2}\:\d{2}\:\d{2}Z$/)
-    end
-
-    it "should accept valid time strings" do
-      Adyen::Formatter::DateTime.fmt_time('2009-01-01T11:11:11Z').should match(/^\d{4}-\d{2}-\d{2}T\d{2}\:\d{2}\:\d{2}Z$/)
-    end
-
-    it "should accept valid time strings" do
-      Adyen::Formatter::DateTime.fmt_date('2009-01-01').should match(/^\d{4}-\d{2}-\d{2}$/)
-    end
-
-    it "should raise on an invalid time string" do
-      lambda { Adyen::Formatter::DateTime.fmt_time('2009-01-01 11:11:11') }.should raise_error
-    end
-
-    it "should raise on an invalid date string" do
-      lambda { Adyen::Formatter::DateTime.fmt_date('2009-1-1') }.should raise_error
-    end
-  end
-end

data/spec/form_spec.rb

@@ -1,318 +0,0 @@
-# encoding: UTF-8
-
-require 'date'
-require 'spec_helper'
-require 'adyen/form'
-
-describe Adyen::Form do
-
-  before(:each) do
-    Adyen.configuration.register_form_skin(:testing, '4aD37dJA', 'Kah942*$7sdp0)')
-    Adyen.configuration.default_form_params[:merchant_account] = 'TestMerchant'
-  end
-
-  describe 'Action URLs' do
-
-    before(:each) do
-      # Use autodetection for the environment unless otherwise specified
-      Adyen.configuration.environment = nil
-    end
-
-    it "should generate correct testing url" do
-      Adyen::Form.url.should == 'https://test.adyen.com/hpp/select.shtml'
-    end
-
-    it "should generate a live url if the environment is set to live" do
-      Adyen.configuration.environment = :live
-      Adyen::Form.url.should == 'https://live.adyen.com/hpp/select.shtml'
-    end
-
-    it "should generate correct live url in a production environment" do
-      Adyen.configuration.stub(:autodetect_environment).and_return('live')
-      Adyen::Form.url.should. == 'https://live.adyen.com/hpp/select.shtml'
-    end
-
-    it "should generate correct live url if explicitely asked for" do
-      Adyen::Form.url(:live).should == 'https://live.adyen.com/hpp/select.shtml'
-    end
-
-    it "should generate correct testing url if the payment flow selection is set to select" do
-      Adyen.configuration.payment_flow = :select
-      Adyen::Form.url.should == 'https://test.adyen.com/hpp/select.shtml'
-    end
-
-    it "should generate correct testing url if the payment flow selection is set to pay" do
-      Adyen.configuration.payment_flow = :pay
-      Adyen::Form.url.should == 'https://test.adyen.com/hpp/pay.shtml'
-    end
-
-    it "should generate correct testing url if the payment flow selection is set to details" do
-      Adyen.configuration.payment_flow = :details
-      Adyen::Form.url.should == 'https://test.adyen.com/hpp/details.shtml'
-    end
-
-    context "with custom domain" do
-      before(:each) do
-        Adyen.configuration.payment_flow = :select
-        Adyen.configuration.payment_flow_domain = "checkout.mydomain.com"
-      end
-
-      it "should generate correct testing url" do
-        Adyen::Form.url.should == 'https://checkout.mydomain.com/hpp/select.shtml'
-      end
-    end
-  end
-
-  describe 'redirect signature check' do
-    before(:each) do
-      # Example taken from integration manual
-
-      # Example get params sent back with redirect
-      @params = { :authResult => 'AUTHORISED', :pspReference => '1211992213193029',
-        :merchantReference => 'Internet Order 12345', :skinCode => '4aD37dJA',
-        :merchantSig => 'ytt3QxWoEhAskUzUne0P5VA9lPw='}
-    end
-
-    it "should calculate the signature string correctly" do
-      Adyen::Form.redirect_signature_string(@params).should == 'AUTHORISED1211992213193029Internet Order 123454aD37dJA'
-      params = @params.merge(:merchantReturnData => 'testing1234')
-      Adyen::Form.redirect_signature_string(params).should == 'AUTHORISED1211992213193029Internet Order 123454aD37dJAtesting1234'
-    end
-
-    it "should calculate the signature correctly" do
-      Adyen::Form.redirect_signature(@params).should == @params[:merchantSig]
-    end
-
-    it "should check the signature correctly with explicit shared signature" do
-      Adyen::Form.redirect_signature_check(@params, 'Kah942*$7sdp0)').should be_true
-    end
-
-    it "should check the signature correctly using the stored shared secret" do
-      Adyen::Form.redirect_signature_check(@params).should be_true
-    end
-
-    it "should raise ArgumentError on missing skinCode" do
-      expect do
-        @params.delete(:skinCode)
-        Adyen::Form.redirect_signature_check(@params).should be_false
-      end.to raise_error ArgumentError
-    end
-
-    it "should raise ArgumentError on empty input" do
-      expect do
-        Adyen::Form.redirect_signature_check({}).should be_false
-      end.to raise_error ArgumentError
-    end
-
-    it "should detect a tampered field" do
-      Adyen::Form.redirect_signature_check(@params.merge(:pspReference => 'tampered')).should be_false
-    end
-
-    it "should detect a tampered signature" do
-      Adyen::Form.redirect_signature_check(@params.merge(:merchantSig => 'tampered')).should be_false
-    end
-
-  end
-
-  describe 'redirect URL generation' do
-    before(:each) do
-      @attributes = { :currency_code => 'GBP', :payment_amount => 10000, :ship_before_date => Date.today,
-        :merchant_reference => 'Internet Order 12345', :skin => :testing,
-        :session_validity => Time.now + 3600 }
-
-      @redirect_url = Adyen::Form.redirect_url(@attributes)
-    end
-
-    it "should return an URL pointing to the adyen server" do
-      @redirect_url.should =~ %r[^#{Adyen::Form.url}]
-    end
-
-    it "should include all provided attributes" do
-      params = @redirect_url.split('?', 2).last.split('&').map { |param| param.split('=', 2).first }
-      params.should include(*(@attributes.keys.map { |k| Adyen::Form.camelize(k) }))
-    end
-
-    it "should include the merchant signature" do
-      params = @redirect_url.split('?', 2).last.split('&').map { |param| param.split('=', 2).first }
-      params.should include('merchantSig')
-    end
-  end
-
-  describe 'payment methods available URL' do
-    let(:payment_methods_url) do
-      @attributes = { :currency_code => 'GBP', :payment_amount => 10000, :ship_before_date => Date.today,
-        :merchant_reference => 'Internet Order 12345', :skin => :testing,
-        :session_validity => Time.now + 3600 }
-
-      Adyen::Form.payment_methods_url(@attributes)
-    end
-
-    it "should return an directory URL" do
-      payment_methods_url.should =~ %r[^#{Adyen::Form.url(nil, :directory)}]
-    end
-
-    it "should include all provided attributes" do
-      params = payment_methods_url.split('?', 2).last.split('&').map { |param| param.split('=', 2).first }
-      params.should include(*(@attributes.keys.map { |k| Adyen::Form.camelize(k) }))
-    end
-
-    it "should include the merchant signature" do
-      params = payment_methods_url.split('?', 2).last.split('&').map { |param| param.split('=', 2).first }
-      params.should include('merchantSig')
-    end
-  end
-
-  describe 'hidden fields generation' do
-    include APISpecHelper
-    subject { %Q'<form action="#{CGI.escapeHTML(Adyen::Form.url)}" method="post">#{Adyen::Form.hidden_fields(@attributes)}</form>' }
-
-    before(:each) do
-      @attributes = { :currency_code => 'GBP', :payment_amount => 10000, :ship_before_date => Date.today,
-        :merchant_reference => 'Internet Order 12345', :skin => :testing,
-        :session_validity => Time.now + 3600 }
-    end
-
-    for_each_xml_backend do
-      it { should have_adyen_payment_form }
-    end
-
-    it { should include('<input type="hidden" name="merchantAccount" value="TestMerchant" />') }
-
-    context "width default_form_params" do
-      before(:each) do
-        Adyen.configuration.register_form_skin(:testing, '4aD37dJA', 'Kah942*$7sdp0)', {
-          :merchant_account => 'OtherMerchant',
-        })
-      end
-
-      it { should include('<input type="hidden" name="merchantAccount" value="OtherMerchant" />') }
-      it { should_not include('<input type="hidden" name="merchantAccount" value="TestMerchant" />') }
-    end
-  end
-
-  describe 'signature calculation' do
-
-    # This example is taken from the Adyen integration manual
-
-    before(:each) do
-
-      @parameters = { :currency_code => 'GBP', :payment_amount => 10000,
-        :ship_before_date => '2007-10-20', :merchant_reference => 'Internet Order 12345',
-        :skin => :testing, :session_validity => '2007-10-11T11:00:00Z',
-        :billing_address => {
-            :street               => 'Alexanderplatz',
-            :house_number_or_name => '0815',
-            :city                 => 'Berlin',
-            :postal_code          => '10119',
-            :state_or_province    => 'Berlin',
-            :country              => 'Germany',
-          },
-        :shopper => {
-            :telephone_number       => '1234512345',
-            :first_name             => 'John',
-            :last_name              => 'Doe',
-            :social_security_number => '123-45-1234'
-          }
-        }
-
-      Adyen::Form.do_parameter_transformations!(@parameters)
-    end
-
-    it "should construct the signature base string correctly" do
-      signature_string = Adyen::Form.calculate_signature_string(@parameters)
-      signature_string.should == "10000GBP2007-10-20Internet Order 123454aD37dJATestMerchant2007-10-11T11:00:00Z"
-
-      signature_string = Adyen::Form.calculate_signature_string(@parameters.merge(:merchant_return_data => 'testing123'))
-      signature_string.should == "10000GBP2007-10-20Internet Order 123454aD37dJATestMerchant2007-10-11T11:00:00Ztesting123"
-    end
-
-    it "should calculate the signature correctly" do
-      signature = Adyen::Form.calculate_signature(@parameters)
-      signature.should == 'x58ZcRVL1H6y+XSeBGrySJ9ACVo='
-    end
-
-    it "should raise ArgumentError on empty shared_secret" do
-      expect do
-        @parameters.delete(:shared_secret)
-        signature = Adyen::Form.calculate_signature(@parameters)
-      end.to raise_error ArgumentError
-    end
-
-    it "should calculate the signature base string correctly for a recurring payment" do
-      # Add the required recurrent payment attributes
-      @parameters.merge!(:recurring_contract => 'DEFAULT', :shopper_reference => 'grasshopper52', :shopper_email => 'gras.shopper@somewhere.org')
-
-      signature_string = Adyen::Form.calculate_signature_string(@parameters)
-      signature_string.should == "10000GBP2007-10-20Internet Order 123454aD37dJATestMerchant2007-10-11T11:00:00Zgras.shopper@somewhere.orggrasshopper52DEFAULT"
-    end
-
-    it "should calculate the signature correctly for a recurring payment" do
-      # Add the required recurrent payment attributes
-      @parameters.merge!(:recurring_contract => 'DEFAULT', :shopper_reference => 'grasshopper52', :shopper_email => 'gras.shopper@somewhere.org')
-
-      signature = Adyen::Form.calculate_signature(@parameters)
-      signature.should == 'F2BQEYbE+EUhiRGuPtcD16Gm7JY='
-    end
-
-    context 'billing address' do
-
-      it "should construct the signature base string correctly" do
-        signature_string = Adyen::Form.calculate_billing_address_signature_string(@parameters[:billing_address])
-        signature_string.should == "Alexanderplatz0815Berlin10119BerlinGermany"
-      end
-
-      it "should calculate the signature correctly" do
-        signature = Adyen::Form.calculate_billing_address_signature(@parameters)
-        signature.should == '5KQb7VJq4cz75cqp11JDajntCY4='
-      end
-
-      it "should raise ArgumentError on empty shared_secret" do
-        expect do
-          @parameters.delete(:shared_secret)
-          signature = Adyen::Form.calculate_billing_address_signature(@parameters)
-        end.to raise_error ArgumentError
-      end
-
-    end
-
-    context 'shopper' do
-
-      it "should construct the signature base string correctly" do
-        signature_string = Adyen::Form.calculate_shopper_signature_string(@parameters[:shopper])
-        signature_string.should == "JohnDoe1234512345"
-      end
-
-      it "should calculate the signature correctly" do
-        signature = Adyen::Form.calculate_shopper_signature(@parameters)
-        signature.should == 'rb2GEs1kGKuLh255a3QRPBYXmsQ='
-      end
-
-      it "should raise ArgumentError on empty shared_secret" do
-        expect do
-          @parameters.delete(:shared_secret)
-          signature = Adyen::Form.calculate_shopper_signature(@parameters)
-        end.to raise_error ArgumentError
-      end
-
-    end
-
-  end
-
-  describe "flatten" do
-   let(:parameters) do
-      {
-        :billing_address => { :street => 'My Street'}
-      }
-    end
-
-    it "returns empty hash for nil input" do
-      Adyen::Form.flatten(nil).should == {}
-    end
-
-    it "flattens hash and prefixes keys" do
-      Adyen::Form.flatten(parameters).should == {
-        'billingAddress.street' =>  'My Street'
-      }
-    end
-  end
-end