adyen-ruby-api-library 2.0.0 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 75219812a204d42ae5bfb963e9cc7dda45f13c7b0193836f6334ab65307b2b55
-  data.tar.gz: '0869e11b8beebd712e22166ef4f309bf30f35c0346e848d4beabe7213813eac8'
+SHA1:
+  metadata.gz: 231b46c2247176df71d2d893aff31a84e8db8e30
+  data.tar.gz: 097565c20054e485ed2765a6dec518067517608a
 SHA512:
-  metadata.gz: 752b39ed6e1a26cb6c66dfca461cecb478f33bbd680c3aa65545e3a27bf9b6d05664888d30bb38c060fd622b203c345499a0b90f0ebcd397cb7d08355601e291
-  data.tar.gz: 771ffa63e29d3a68fba69c47807163c6f08486169279eaaa17e4cdb5084476fff1a8e972e79682190daf3ddb170a7db3d156122314baba2d693c233eee2d4dc0
+  metadata.gz: 357904495d8ec8afab0a4aef8151cf8d976572a4827c62070fb6737a9dda6f041892974688c6cd2412af6d1b9339adaaafb6799af9ffab93487be9903c6b16bc
+  data.tar.gz: 8132cc3af9c35ac41c4e5431ca783ba4c7f1fe05be5f9e30b62f65b85203c827617f8a460162dd071ef153fbb5f97c1ccd89f86886205c86bb75dd4106a2f596

data/README.md

@@ -64,6 +64,11 @@ response = adyen.checkout.payments({
 })
 ```
 
+### Change API Version
+```ruby
+adyen.checkout.version = 49
+```
+
 ## List of supported methods
 
 **checkout:**

data/bin/console

@@ -1,6 +1,6 @@
 #!/usr/bin/env ruby
 
-require_relative "../lib/adyen.rb"
+require_relative "../lib/adyen-ruby-api-library.rb"
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.

data/docs/payout.html

@@ -88,7 +88,7 @@ adyen.ws_passord = "super_secure_password123"</code></pre></p>
     "shopperReference" : "&lt;ShopperReference&gt;",
     "dateOfBirth" : "1990-01-01",
     "entityType" : "Company",
-    "nationality" : "NL",
+    "nationality" : "NL"
 }')</code></pre>
 
         <h3 id="submitapayout">Submit a payout</h3>

data/lib/adyen/client.rb

@@ -102,12 +102,13 @@ module Adyen
         end
       end
 
-      # if json string convert to hash needed to add applicationInfo
+      # if json string convert to hash
+      # needed to add applicationInfo
       if request_data.is_a?(String)
         request_data = JSON.parse(request_data)
       end
 
-      # add apllication only on checkout service
+      # add application only on checkout service
       if service == 'Checkout' || service == 'CheckoutUtility'
         add_application_info(request_data)
       end
@@ -127,14 +128,15 @@ module Adyen
       # check for API errors
       case response.status
       when 401
-        raise Adyen::AuthenticationError.new("Invalid webservice username / password", request_data)
+        raise Adyen::AuthenticationError.new("Invalid API authentication; https://docs.adyen.com/user-management/how-to-get-the-api-key", request_data)
       when 403
-        raise Adyen::PermissionError.new("Invalid Checkout API key", request_data)
+        raise Adyen::PermissionError.new("Missing user permissions; https://docs.adyen.com/user-management/user-roles", request_data)
       end
 
       response
     end
 
+    # add application_info for analytics
     def add_application_info(request_data)
       external_platform = {
         :adyenLibrary => {

data/lib/adyen/errors.rb

@@ -1,8 +1,16 @@
 module Adyen
   class AdyenError < StandardError
-    attr_reader :code, :response, :request
+    attr_reader :code, :response, :request, :msg
 
     def initialize(request = nil, response = nil, msg = nil, code = nil)
+      attributes = {
+        code: code,
+        request: request,
+        response: response,
+        msg: msg
+      }.select { |_k, v| v }.map { |k, v| "#{k}:#{v}" }.join(', ')
+      message = "#{self.class.name} #{attributes}"
+      super(message)
       @code = code
       @response = response
       @request = request
@@ -12,65 +20,44 @@ module Adyen
 
   class AuthenticationError < AdyenError
     def initialize(msg, request)
-      @code = 401
-      @response = nil
-      @request = request
-      @msg = msg
+      super(request, nil, msg, 401)
     end
   end
 
   class PermissionError < AdyenError
     def initialize(msg, request)
-      @code = 403
-      @response = nil
-      @request = request
-      @msg = msg
+      super(request, nil, msg, 403)
     end
   end
 
   class FormatError < AdyenError
     def initialize(msg, request, response)
-      @code = 422
-      @response = response
-      @request = request
-      @msg = msg
+      super(request, response, msg, 422)
     end
   end
 
   class ServerError < AdyenError
     def initialize(msg, request, response)
-      @code = 500
-      @response = response
-      @request = request
-      @msg = msg
+      super(request, response, msg, 500)
     end
   end
 
   class ConfigurationError < AdyenError
     def initialize(msg, request)
-      @code = 905
-      @response = nil
-      @request = request
-      @msg = msg
+      super(request, nil, msg, 905)
     end
   end
 
   class ValidationError < AdyenError
     def initialize(msg, request)
-      @code = nil
-      @response = nil
-      @request = request
-      @msg = msg
+      super(request, nil, msg, nil)
     end
   end
 
   # catchall for errors which don't have more specific classes
   class APIError < AdyenError
     def initialize(msg, request, response, code)
-      @code = code
-      @response = response
-      @request = request
-      @msg = msg
+      super(request, response, msg, code)
     end
   end
 end

data/lib/adyen/services/checkout.rb

@@ -2,7 +2,7 @@ require_relative 'service'
 
 module Adyen
   class Checkout < Service
-    DEFAULT_VERSION = 41
+    DEFAULT_VERSION = 49
 
     def initialize(client, version = DEFAULT_VERSION)
       service = 'Checkout'

data/lib/adyen/services/marketpay.rb

@@ -72,7 +72,7 @@ module Adyen
 
     class Notification < Service
       attr_accessor :version
-      DEFAULT_VERSION = 1
+      DEFAULT_VERSION = 5
 
       def initialize(client, version = DEFAULT_VERSION)
         service = 'Notification'

data/lib/adyen/services/payments.rb

@@ -3,13 +3,14 @@ require_relative 'service'
 module Adyen
   class Payments < Service
     attr_accessor :version
-    DEFAULT_VERSION = 40
+    DEFAULT_VERSION = 49
 
     def initialize(client, version = DEFAULT_VERSION)
       service = 'Payment'
       method_names = [
         :authorise,
         :authorise3d,
+        :authorise3ds2,
         :capture,
         :cancel,
         :refund,

data/lib/adyen/services/recurring.rb

@@ -3,7 +3,7 @@ require_relative 'service'
 module Adyen
   class Recurring < Service
     attr_accessor :version
-    DEFAULT_VERSION = 25
+    DEFAULT_VERSION = 30
 
     def initialize(client, version = DEFAULT_VERSION)
       service = 'Recurring'

data/lib/adyen/version.rb

@@ -1,4 +1,4 @@
 module Adyen
   NAME = "adyen-ruby-api-library"
-  VERSION = "2.0.0".freeze
+  VERSION = "3.0.0".freeze
 end

data/spec/errors_spec.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Adyen::AdyenError do
+  describe '#to_s' do
+    it 'describes using the error properties' do
+      expect(Adyen::AdyenError.new('request', 'response', 'message', 'code').to_s).to eq('Adyen::AdyenError code:code, request:request, response:response, msg:message')
+    end
+    it 'skips the null properties' do
+      expect(Adyen::AdyenError.new('request', nil, nil, 'code').to_s).to eq('Adyen::AdyenError code:code, request:request')
+    end
+    it 'uses the proper error class name' do
+      expect(Adyen::PermissionError.new('a message', 'a request').to_s).to eq('Adyen::PermissionError code:403, request:a request, msg:a message')
+    end
+  end
+end

data/spec/mocks/requests/Payment/authorise3ds2.json

@@ -0,0 +1,7 @@
+{
+   "merchantAccount":"TestMerchant",
+   "threeDS2RequestData":{
+      "threeDSCompInd":"Y"
+   },
+   "threeDS2Token":"BQABAQBPCQZ98WKh3v7qGnBlUMGClVzDolIjs8w/8L64WIAqaOGZipbZod7n+E="
+}

data/spec/mocks/responses/Payment/authorise3ds2.json

@@ -0,0 +1,17 @@
+{
+   "additionalData":{
+      "threeds2.threeDS2ResponseData.dsReferenceNumber":"ADYEN-DS-SIMULATOR",
+      "threeds2.threeDS2ResponseData.transStatus":"C",
+      "threeds2.threeDS2ResponseData.acsChallengeMandated":"Y",
+      "threeds2.threeDS2ResponseData.acsURL":"http:\/\/localhost:8080\/threeds2simulator\/services\/ThreeDS2Simulator\/v1\/handle\/eb9c6eb3-57b3-400d-bf2f-4e72bd69dcec",
+      "threeds2.threeDS2ResponseData.threeDSServerTransID":"c9200190-5ffe-11e8-954f-2677777ae710",
+      "threeds2.threeDS2ResponseData.authenticationType":"01",
+      "threeds2.threeDS2ResponseData.dsTransID":"73aab3ce-eb39-49e8-8e9b-46fb77a472f1",
+      "threeds2.threeDS2ResponseData.messageVersion":"2.1.0",
+      "threeds2.threeDS2Token":"BQABAQBPCQZ98WKh3v7qGnBlUMGClVzDolIjs8w/8L64WIAqaOGZipbZod7n+E=...",
+      "threeds2.threeDS2ResponseData.acsTransID":"eb9c6eb3-57b3-400d-bf2f-4e72b779dcec",
+      "threeds2.threeDS2ResponseData.acsReferenceNumber":"ADYEN-ACS-SIMULATOR"
+   },
+   "pspReference":"9935272408577755",
+   "resultCode":"ChallengeShopper"
+}

data/spec/payments_spec.rb

@@ -10,6 +10,7 @@ RSpec.describe Adyen::Payments, service: "payments service" do
     ["authorise", "resultCode", "Authorised"],
     ["adjust_authorisation", "response", "[adjustAuthorisation-received]"],
     ["authorise3d", "resultCode", "Authorised"],
+    ["authorise3ds2", "resultCode", "ChallengeShopper"],
     ["cancel", "response", "[cancel-received]"],
     ["cancel_or_refund", "response", "[cancelOrRefund-received]"],
     ["capture", "response", "[capture-received]"],

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: adyen-ruby-api-library
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 3.0.0
 platform: ruby
 authors:
 - Adyen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-26 00:00:00.000000000 Z
+date: 2019-08-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -114,6 +114,7 @@ files:
 - spec/checkout_spec.rb
 - spec/checkout_utility_spec.rb
 - spec/client_spec.rb
+- spec/errors_spec.rb
 - spec/fund_spec.rb
 - spec/mocks/requests/Account/close_account.json
 - spec/mocks/requests/Account/close_account_holder.json
@@ -151,6 +152,7 @@ files:
 - spec/mocks/requests/Payment/adjust_authorisation.json
 - spec/mocks/requests/Payment/authorise.json
 - spec/mocks/requests/Payment/authorise3d.json
+- spec/mocks/requests/Payment/authorise3ds2.json
 - spec/mocks/requests/Payment/cancel.json
 - spec/mocks/requests/Payment/cancel_or_refund.json
 - spec/mocks/requests/Payment/capture.json
@@ -199,6 +201,7 @@ files:
 - spec/mocks/responses/Payment/adjust_authorisation.json
 - spec/mocks/responses/Payment/authorise.json
 - spec/mocks/responses/Payment/authorise3d.json
+- spec/mocks/responses/Payment/authorise3ds2.json
 - spec/mocks/responses/Payment/cancel.json
 - spec/mocks/responses/Payment/cancel_or_refund.json
 - spec/mocks/responses/Payment/capture.json
@@ -239,7 +242,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.8
+rubygems_version: 2.2.0
 signing_key: 
 specification_version: 4
 summary: Official Adyen  Ruby API Library