adyen-admin 0.0.11 → 0.0.12

data/CHANGES.md

@@ -6,11 +6,12 @@
   * add CLI binaries (to compile + upload) -> read from .adyenrc file
   * make compatible with Live system
 
-## v0.0.11 - 23-04-2012
+## v0.0.12 - 23-04-2012
   * renamed `compile` to `compress`
   * added `compile` which splits any given input to the inc/* file according to given pattern
   * parse metafile
   * log out on AuthError
+  * cache all skins, only load remote when authorized
 
 ## v0.0.7
   * fix download issue

data/VERSION

@@ -1 +1 @@
-0.0.11
+0.0.12

data/lib/adyen-admin/skin.rb

@@ -21,7 +21,7 @@ module Adyen
           send("#{key}=", value)
         end
 
-        self.path ||= File.join(Skin.default_path, [name,code].compact.join("-"))
+        self.path ||= File.expand_path File.join(Skin.default_path, [name,code].compact.join("-"))
 
         raise ArgumentError, "No Code given" unless code
       end
@@ -36,12 +36,14 @@ module Adyen
 
       # union remote and local skins. Local skins are frozen to
       # indicate no availble remote counter part which avoid update
-      def self.all(path = Skin.default_path)
-        {}.tap do |hash|
-          self.all_remote.each do |skin|
-            hash[skin.code] = skin unless hash[skin.code]
+      def self.all
+        @all ||= {}.tap do |hash|
+          if Adyen::Admin.authenticated?
+            self.all_remote.each do |skin|
+              hash[skin.code] = skin unless hash[skin.code]
+            end
           end
-          self.all_local(path).each do |skin|
+          self.all_local.each do |skin|
             hash[skin.code] = skin unless hash[skin.code]
           end
         end.values
@@ -49,20 +51,18 @@ module Adyen
 
       # fetch all remote skins
       def self.all_remote
-        @skins_remote ||= begin
-          page = Adyen::Admin.get(SKINS)
-          page.search(".data tbody tr").map do |node|
-            Skin.new({
-              :code => node.search("a")[0].content.strip,
-              :name => node.search("td")[1].content.strip,
-            })
-          end
+        page = Adyen::Admin.get(SKINS)
+        page.search(".data tbody tr").map do |node|
+          Skin.new({
+            :code => node.search("a")[0].content.strip,
+            :name => node.search("td")[1].content.strip,
+          })
         end
       end
 
       # fetch all local skins
-      def self.all_local(path = Skin.default_path)
-        Dir[File.join(path.to_s, "*")].map do |path|
+      def self.all_local
+        Dir[File.join(default_path.to_s, "*")].map do |path|
           Skin.new(:path => path).freeze rescue nil
         end.compact
       end
@@ -75,7 +75,7 @@ module Adyen
       end
 
       def self.purge_cache
-        @skins_remote = nil
+        @all = nil
       end
 
       ##################################

data/spec/adyen-admin/client_spec.rb

@@ -31,9 +31,11 @@ describe Adyen::Admin::Client, :vcr  do
     end
 
     it 'sets authenticated to false on error' do
+      Adyen::Admin.instance_variable_set(:@authenticated, true)
+
       expect do
         Adyen::Admin.get(Adyen::Admin::Skin::SKINS) rescue nil
-      end.to change { Adyen::Admin.authenticated? }.from(nil).to(false)
+      end.to change { Adyen::Admin.authenticated? }.from(true).to(false)
     end
   end
 end

data/spec/adyen-admin/skin_spec.rb

@@ -5,10 +5,16 @@ require "adyen-admin/skin"
 
 module Adyen::Admin
   describe Skin, :vcr  do
-    let(:skin_fixtures) { 'spec/fixtures/skins' }
+    let(:skin_fixtures) { File.expand_path 'spec/fixtures/skins' }
     let(:skin_code) { "7hFAQnmt" }
     let(:skin) { Skin.new(:code => skin_code, :name => "example") }
 
+    describe ".all" do
+      it 'returns all local skins' do
+        Skin.all.should == Skin.all_local
+      end
+    end
+
     context "authenticated" do
       before(:all) do
         VCR.use_cassette("login") do
@@ -38,7 +44,7 @@ module Adyen::Admin
 
       describe ".all_local" do
         it 'returns the skins' do
-          Skin.all_local(skin_fixtures).should == [
+          Skin.all_local.should == [
             Skin.new(:code => "base"),
             Skin.new(:code => "DV3tf95f"),
             skin,
@@ -49,7 +55,7 @@ module Adyen::Admin
 
       describe ".all" do
         it 'returns the skins' do
-          Skin.all(skin_fixtures).should == [
+          Skin.all.should == [
             skin,
             Skin.new(:code => "Kx9axnRf", :name => "demo"),
             Skin.new(:code => "vQW0fEo8", :name => "test"),
@@ -60,11 +66,10 @@ module Adyen::Admin
         end
 
         it 'freezes local skins' do
-          Skin.all(skin_fixtures).last.should be_frozen
+          Skin.all.last.should be_frozen
         end
       end
 
-
       describe ".find" do
         it 'returns the skin' do
           Skin.find(skin_code).should == skin

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: adyen-admin
 version: !ruby/object:Gem::Version
-  version: 0.0.11
+  version: 0.0.12
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2012-04-23 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mechanize
-  requirement: &70115439116500 !ruby/object:Gem::Requirement
+  requirement: &70207780752880 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70115439116500
+  version_requirements: *70207780752880
 - !ruby/object:Gem::Dependency
   name: rubyzip
-  requirement: &70115439116020 !ruby/object:Gem::Requirement
+  requirement: &70207780752400 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70115439116020
+  version_requirements: *70207780752400
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70115439115440 !ruby/object:Gem::Requirement
+  requirement: &70207780751820 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70115439115440
+  version_requirements: *70207780751820
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70115439114980 !ruby/object:Gem::Requirement
+  requirement: &70207780751360 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70115439114980
+  version_requirements: *70207780751360
 - !ruby/object:Gem::Dependency
   name: vcr
-  requirement: &70115439114520 !ruby/object:Gem::Requirement
+  requirement: &70207780750900 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70115439114520
+  version_requirements: *70207780750900
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &70115439114060 !ruby/object:Gem::Requirement
+  requirement: &70207780750440 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70115439114060
+  version_requirements: *70207780750440
 - !ruby/object:Gem::Dependency
   name: debugger
-  requirement: &70115439113600 !ruby/object:Gem::Requirement
+  requirement: &70207780749980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,7 +87,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70115439113600
+  version_requirements: *70207780749980
 description: A little Gem to make your life easier when dealing with Adyen skins
 email:
 - tobi@soundcloud.com