advisor 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 13e94ad0f3346d7f61789c7edee4c7542dcd6860
-  data.tar.gz: 2da167661ff60ca690c1445b45ec5d0f93f274c9
+  metadata.gz: 6bd705ca8a6e531d27ba1f7477118d039fd8e93e
+  data.tar.gz: f0372ed273abef5b744b0509c35d25887220081b
 SHA512:
-  metadata.gz: 69ff533ed9a2137bad41e8bf944d84775bf750d5c91aeacaf0480e2affb1a5a7006d2c4d7e30f08bbb64ca577c400e5f25758a18efccef9f402c95c2bd63b0f8
-  data.tar.gz: c302301750115b752db21647db6799ecbe0c28b0bc2dfdc663178ba8813484d85d2996a9bb3d3316b33de96ddd3a738c70ee32b77c70aaead458edea590d3b50
+  metadata.gz: d662f5d5c8270323bd8023c3f9f27b13fbe2fc7b6b0081a37d2975cf743d889b71336f2f61cc9859a7630ed489bbdfbd9f1db87711b5d6b9ef4b72dc354364f9
+  data.tar.gz: 8d38aa47bcdad42014e600e9492dcde1c1c789f76c15fd357d793e10216f740a0935534d245bbdccfb397dbac5b54c04f6ecfca57a9dc7550f7545de8a64f828

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    advisor (0.5.0)
+    advisor (0.5.1)
       metriks
 
 GEM
@@ -74,4 +74,4 @@ DEPENDENCIES
   rubocop
 
 BUNDLED WITH
-   1.10.5
+   1.10.6

data/lib/advisor/advices/call_logger.rb

@@ -4,21 +4,23 @@ module Advisor
   module Advices
     class CallLogger
       class << self
+        attr_accessor :backtrace_cleaner
         attr_accessor :default_logger
         attr_accessor :catch_exception
       end
       self.default_logger = Logger.new(STDOUT)
-      self.catch_exception = false
 
       def initialize(object, method, call_args, **opts)
         @object = object
         @method = method
         @call_args = call_args
+
+        @cleaner = opts[:backtrace_cleaner] || CallLogger.backtrace_cleaner
         @logger = opts[:logger] || CallLogger.default_logger
-        @tag_proc = opts[:with] || ->{}
+        @tag_proc = opts[:with] || -> {}
       end
 
-      attr_reader :object, :method, :call_args, :logger, :tag_proc
+      attr_reader :object, :method, :call_args, :logger, :tag_proc, :cleaner
 
       def self.applier_method
         :log_calls_to
@@ -28,7 +30,7 @@ module Advisor
         logger.info(success_message)
         yield
       rescue exception_class => e
-        logger.warn(failure_message(e))
+        logger.error(failure_message(e))
         raise
       end
 
@@ -40,6 +42,7 @@ module Advisor
 
       def failure_message(ex)
         backtrace = ["\n", ex.to_s] + ex.backtrace
+        backtrace = cleaner.clean(backtrace) if cleaner
         call_message('Failed: ', backtrace.join("\n"))
       end
 

data/lib/advisor/version.rb

@@ -1,3 +1,3 @@
 module Advisor
-  VERSION = '0.5.0'
+  VERSION = '0.5.1'
 end

data/spec/advisor/advices/call_logger_spec.rb

@@ -46,12 +46,10 @@ Called: OpenStruct#the_meaning_of_life(\"the universe\", \"and everything\")"
  everything\"\).*/
           end
 
-          let(:error_message) { /deu ruim!/ }
-
           let(:catch_exception) { false }
 
           before do
-            allow(logger).to receive(:warn)
+            allow(logger).to receive(:error)
             allow(CallLogger).to receive(:catch_exception)
               .and_return(catch_exception)
           end
@@ -59,22 +57,20 @@ Called: OpenStruct#the_meaning_of_life(\"the universe\", \"and everything\")"
           it { expect { call }.to raise_error(StandardError, 'deu ruim!') }
 
           it do
-            expect(logger).to receive(:warn).with(log_message)
+            expect(logger).to receive(:error).with(log_message)
             expect { call }.to raise_error
           end
 
           it do
-            expect(logger).to receive(:warn).with(error_message)
+            expect(logger).to receive(:error).with(log_message)
             expect { call }.to raise_error
           end
 
           context 'when the error is not a StandardError' do
             let(:block) { -> { fail Exception, 'deu muito ruim!' } }
 
-            let(:error_message) { /deu muito ruim!/ }
-
             it do
-              expect(logger).not_to receive(:warn).with(log_message)
+              expect(logger).not_to receive(:error).with(log_message)
               expect { call }.to raise_error(Exception, 'deu muito ruim!')
             end
 
@@ -82,12 +78,12 @@ Called: OpenStruct#the_meaning_of_life(\"the universe\", \"and everything\")"
               let(:catch_exception) { true }
 
               it do
-                expect(logger).to receive(:warn).with(log_message)
+                expect(logger).to receive(:error).with(log_message)
                 expect { call }.to raise_error(Exception, 'deu muito ruim!')
               end
 
               it do
-                expect(logger).to receive(:warn).with(error_message)
+                expect(logger).to receive(:error).with(log_message)
                 expect { call }.to raise_error(Exception, 'deu muito ruim!')
               end
             end
@@ -96,7 +92,7 @@ Called: OpenStruct#the_meaning_of_life(\"the universe\", \"and everything\")"
 
         context 'when no custom tag is provided' do
           let(:tag) {}
-          let(:log_without_custom_tag) { log_message.gsub("[x=y]", "") }
+          let(:log_without_custom_tag) { log_message.gsub('[x=y]', '') }
 
           it do
             expect(logger).to receive(:info).with(log_without_custom_tag)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: advisor
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Renan Ranelli
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-14 00:00:00.000000000 Z
+date: 2015-08-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: metriks