advisor 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e483f74eff0de6b04eed5051b4d289b44dfb7a80
-  data.tar.gz: 8a852c9df0b89d7afaaf16ee53c407cfa13b8a52
+  metadata.gz: bd0bff4c56325afe9169e9a9e6846f39a5b5050d
+  data.tar.gz: 7ed6cd9a3a9e940ae3c62b216da94c333b7910be
 SHA512:
-  metadata.gz: 144f536d6c89850f100ff1025802f1be321868d9721a4849756b309a2e60a41aee9b4b63447a818a5d4e7d0cb884240676ba6c0161a107611dc2134be7d4dc13
-  data.tar.gz: fa95e30ccb7eb56b3138420203334d094e8dc9b5db7fbe134f9ea3b2e8147542e8d42673e1b42ff7d03985229c9b0c01d6de0f6a299f56a849b3ab7ae6585d2d
+  metadata.gz: d2d760a6c6ee40363b916cb8233b488a0bfae01a021836695a6801e736751fcfd34106b93f49afdcc5f1dfc8e06fcb2402372a15f0182cb3b5e397c44a2e92dd
+  data.tar.gz: 1d33b22f3299bc1176a536771bcdcec3f756c4b389cc7bbdba6513c8519daeab17fb28758de33c861d9816b69305251d376cedb5ca91a210ada34e99e55b2e86

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    advisor (0.2.0)
+    advisor (0.2.1)
       metriks
 
 GEM
@@ -13,7 +13,13 @@ GEM
     atomic (1.1.99)
     avl_tree (1.2.1)
       atomic (~> 1.1)
+    byebug (3.5.1)
+      columnize (~> 0.8)
+      debugger-linecache (~> 1.2)
+      slop (~> 3.6)
     coderay (1.1.0)
+    columnize (0.9.0)
+    debugger-linecache (1.2.0)
     diff-lcs (1.2.5)
     hitimes (1.2.2)
     method_source (0.8.2)
@@ -28,6 +34,9 @@ GEM
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
       slop (~> 3.4)
+    pry-byebug (3.0.0)
+      byebug (~> 3.4)
+      pry (~> 0.10)
     rainbow (2.0.0)
     rake (10.4.2)
     rspec (3.2.0)
@@ -59,6 +68,7 @@ DEPENDENCIES
   advisor!
   bundler (~> 1.7)
   pry
+  pry-byebug
   rake (~> 10.0)
   rspec (~> 3.0)
   rubocop

data/advisor.gemspec

@@ -25,4 +25,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rubocop'
   spec.add_development_dependency 'pry'
+  spec.add_development_dependency 'pry-byebug'
 end

data/lib/advisor/advices/metriks.rb

@@ -31,8 +31,8 @@ module Advisor
       end
 
       def call
-        (timed? ? timed_call { yield } : yield)
-          .tap { |result| instruments.each(&measure(result)) }
+        result = timed? ? timer.time { yield } : yield
+        result.tap { instruments.each(&measure(result)) }
       rescue => e
         logger.warn(e)
         raise
@@ -40,13 +40,6 @@ module Advisor
 
       private
 
-      def timed_call
-        timer.time
-        yield.tap do
-          timer.stop
-        end
-      end
-
       def measure(result)
         # How I wish I had currying...
         lambda do |instrument|

data/lib/advisor/version.rb

@@ -1,3 +1,3 @@
 module Advisor
-  VERSION = '0.2.0'
+  VERSION = '0.2.1'
 end

data/spec/advisor/advices/metriks_spec.rb

@@ -138,14 +138,11 @@ module Advisor
         context 'when using a timer' do
           let(:instruments) { %i(counter result_meter call_meter gauge timer) }
 
-          let(:timer) { instance_double(::Metriks::Timer) }
+          let(:timer) { ::Metriks.timer('a-timer') }
 
           before do
             allow(::Metriks).to receive(:timer)
               .and_return(timer)
-
-            allow(timer).to receive(:time)
-            allow(timer).to receive(:stop)
           end
 
           it_behaves_like 'instruments && measuring'
@@ -153,13 +150,14 @@ module Advisor
           it 'finds the right timer metric' do
             expect(::Metriks).to receive(:timer)
               .with('OpenStruct#the_force_awakens_timer')
+              .and_call_original
 
             call
           end
 
           it 'times the method call' do
             expect(timer).to receive(:time)
-            expect(timer).to receive(:stop)
+              .and_call_original
 
             call
           end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: advisor
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Renan Ranelli
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-01 00:00:00.000000000 Z
+date: 2015-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: metriks
@@ -94,6 +94,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry-byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 
 email:
 - renanranelli@gmail.com
@@ -148,3 +162,4 @@ signing_key:
 specification_version: 4
 summary: AOP with anonymous modules
 test_files: []
+has_rdoc: